Commit Graph

785 Commits

Author SHA1 Message Date
Rahul Garg f1746197c7 Fix hipMemcpy3D (#1798)
Fixes #1790 and #1791. hipMemcpy3D still requires further refactoring for different input and output combinations.

[ROCm/hip commit: 8c5e5e435b]
2020-02-17 19:35:35 +05:30
Maneesh Gupta 5d7f0b1798 [dtests] Fix random timeout failures in hipModuleLoadDataMultThreaded (#1877)
Limit the max threads that are launched to 16.

[ROCm/hip commit: 854afef281]
2020-02-17 11:16:20 +05:30
vsytch cf57b45f3c Add missing __hip_pinned_shadow__ attributes to the texture global vars. (#1866)
[ROCm/hip commit: 56b8b0d80e]
2020-02-15 09:52:25 +05:30
Maneesh Gupta e72b5a0187 Use deque instead of vector for code readers so that the iterators and references will be stable (#1851)
* Use deque instead of vector for code readers so that the iterators and references will be stable

* Fix compile error

* Assign the iterator

* Add multithreaded test

* Make threads a multiple of hardware concurrency

* Output on failure

* Add setDevice to try and initialize the context on cuda

* Create context for cuda

* Set context on each thread

* Reduce threads on cuda

* Skip test on cuda

* Try to initialize the primary context on cuda

* Push ctx to the stack as current

* Revert "Push ctx to the stack as current"

This reverts commit 0fb72d9e7f.

* Revert "Try to initialize the primary context on cuda"

This reverts commit 44e3908680.

* updated test for nvidia path

* Add c++11 option for nvcc

Co-authored-by: satyanveshd <53337087+satyanveshd@users.noreply.github.com>


[ROCm/hip commit: e7120dd876]
2020-02-15 09:51:24 +05:30
Nick Curtis 6d661ba6ca Implement long / long long shuffles (#1829)
Implement additional data-types for shuffles (long and long long).
Based upon the double implementation.


[ROCm/hip commit: 797a929a65]
2020-02-15 09:51:09 +05:30
Satyanvesh Dittakavi 8cfced9bfd Add c++11 option for nvcc
[ROCm/hip commit: 3fb4135946]
2020-02-13 19:48:26 +05:30
Satyanvesh Dittakavi 802aa5f44e updated test for nvidia path
[ROCm/hip commit: ead254cdd5]
2020-02-13 16:34:05 +05:30
Paul ca0eb390a9 Revert "Try to initialize the primary context on cuda"
This reverts commit 44e3908680.


[ROCm/hip commit: 26bb6a97a7]
2020-02-11 12:34:11 -06:00
Paul f86740ff94 Revert "Push ctx to the stack as current"
This reverts commit 0fb72d9e7f.


[ROCm/hip commit: e82e3c2339]
2020-02-11 12:34:10 -06:00
Paul 0fb72d9e7f Push ctx to the stack as current
[ROCm/hip commit: bff8cbe950]
2020-02-11 11:46:29 -06:00
Paul 44e3908680 Try to initialize the primary context on cuda
[ROCm/hip commit: fd98514113]
2020-02-11 11:26:24 -06:00
Paul 746c36ed8e Skip test on cuda
[ROCm/hip commit: b9f97ec3fe]
2020-02-10 17:23:58 -06:00
Paul 92ff502b92 Reduce threads on cuda
[ROCm/hip commit: 30e8dfdd86]
2020-02-10 16:37:34 -06:00
Paul 039171f6fd Set context on each thread
[ROCm/hip commit: 2d9a2d866c]
2020-02-10 16:01:53 -06:00
Paul a3e2660669 Create context for cuda
[ROCm/hip commit: e5d077f70e]
2020-02-10 15:52:34 -06:00
Paul b6e01adc72 Add setDevice to try and initialize the context on cuda
[ROCm/hip commit: 29a257d79b]
2020-02-10 13:37:45 -06:00
Maneesh Gupta 7753b3e827 Revert "Match Occupancy APIs syntax with CUDA (#1625)" (#1857)
Reverting this for now till we figure out how to avoid the build
breakage.

This reverts commit e38db9fb6f.

[ROCm/hip commit: f8e1c01900]
2020-02-10 10:45:28 +05:30
Paul 3fa3e99a9a Make threads a multiple of hardware concurrency
[ROCm/hip commit: 8e494cfce8]
2020-02-06 16:23:29 -06:00
Paul 5cfa3c626a Add multithreaded test
[ROCm/hip commit: 5361424702]
2020-02-06 16:21:40 -06:00
vsytch e5243c1834 Device texture functions should not normalize the sampled pixel (#1826)
* Device texture functions should not normalize the sampled pixel. This is already done by HW.
* Add support to use h/w capability for normalized float data convertion for driver API's

Co-authored-by: ansurya <50609411+ansurya@users.noreply.github.com>


[ROCm/hip commit: ef514eef71]
2020-02-05 20:56:17 +05:30
lthakur e340a8e921 [dtest] Update hipLaunchCoopMultiKernel.cpp (#1844)
used reinterpret_cast<uint32_t*> for numBlocks, as expected by hipOccupancyMaxActiveBlocksPerMultiprocessor() api.

[ROCm/hip commit: 4d472b777f]
2020-02-04 19:37:38 +05:30
Siu Chi Chan ec45ec16e3 Fix C-style hipLaunchKernel (#1835)
* Fix bug in LaunchKernel test
Instead of passing the address of the gpu buffer, pass the address
of the pointer that holds the address of the gpu buffer

* Fix hipLaunchKernel's kernarg buffer construction.
The hipLaunchKernel implementation should rely on ihipModuleLaunchKernel
to construct the kernarg buffer correctly based on kernel metadata.

* Fix a bug in get_functions where the Kernel_descriptor wasn't constructed with the correct kernarg layout information.

* Fix a bug in kernarg layout parsing dealing with kernel without any arg

* teach ihipModuleLaunchKernel to handle kernel without any arg

* Add a more interesting test

[ROCm/hip commit: bff8e15e13]
2020-02-04 19:37:16 +05:30
gandryey 42bc78d148 [dtest] RCCL multi device launch test (#1731)
Simple test for hipLaunchCooperativeKernelMultiDevice API.


[ROCm/hip commit: 48d1f766d5]
2020-02-04 08:53:43 +05:30
jujiang-del 61156d3b2d [dtest] Avoid resViewDesc for non-array resource in texture creation (#1823)
[ROCm/hip commit: 3684ef813d]
2020-01-30 14:04:41 -08:00
satyanveshd e38db9fb6f Match Occupancy APIs syntax with CUDA (#1625)
* Match Occupancy APIs syntax with CUDA and fix tests using these APIs


[ROCm/hip commit: fa98798b63]
2020-01-29 13:05:53 -08:00
Siu Chi Chan af3e8f633a Fix associate code object symbols with host allocation bug (#1799)
The current implementation skips this procedure for a given device
object when a global symbol is found in the cache.  This is incorrect:

 - There could be other undefined globals that have not been previously
encountered further down the list
 - If a symbol is found in the cache, it doesn't need to be pinned again
but it still need to be defined for the current executable

Added special case for the printf buffer symbol (already pinned by HCC)

The bug was exposed by running printf on different GPUs.

[ROCm/hip commit: 6613a37b3b]
2020-01-24 16:22:49 +05:30
Yaxun (Sam) Liu 5d17d5b029 Fix test hip_bitextract.cpp (#1784)
The randomly generated offset+width may exceeds 32, which causes
a left shift operation with 32-offset-width. As an unsigned number
that is greater than 32 and causes undefined behavior. When the
test is compiled without -mavx it is still OK. However when
the test is compiled with -mavx, the undefined behavior causes
wrong results and test failure.

This patch adjusts width so that offset+width<=32 always.

[ROCm/hip commit: 02848e0b80]
2020-01-10 13:46:57 +05:30
Rahul Garg 327a45b18b Add hipBindTexture2D on NVCC path (#1773)
[ROCm/hip commit: a5d7e7d8d3]
2020-01-06 12:33:50 +05:30
Evgeny Mankov 6ac4d18753 Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/hip commit: 0dadb23327]
2019-12-30 19:21:09 +03:00
Sarbojit2019 6d2ec032fe Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.

[ROCm/hip commit: aa4aea0754]
2019-12-30 12:44:24 +05:30
Evgeny Mankov abef353b5b [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/hip commit: 4921678b6c]
2019-12-23 17:01:35 +03:00
Alex Voicu 1f5ecc0f6a Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/hip commit: 75a11330aa]
2019-12-23 19:11:24 +05:30
Vladislav Sytchenko 6015efe6f5 Add comments explaining choice on the cap for system memory on Windows.
[ROCm/hip commit: bf3df9d7c0]
2019-12-13 21:38:27 -05:00
Vladislav Sytchenko 29ca9f7d53 Add explicit cast when computing the available amount of system memory.
[ROCm/hip commit: 12634879e2]
2019-12-13 21:37:30 -05:00
Vladislav Sytchenko 9dade23425 Reduce the amount of free host memory to 40% of what is reported on Windows, otherwise we can run into OOM situations.
[ROCm/hip commit: b12c53cceb]
2019-12-11 20:21:12 -05:00
Rahul Garg ebdd811632 Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.

[ROCm/hip commit: e53fc316f1]
2019-12-06 09:51:53 +05:30
Rahul Garg fa87abd58a Fix hipMemcpyWithStream (#1707)
* Fix hipMemcpyWithStream
* Add a dtest for the same.


[ROCm/hip commit: 892d2a562e]
2019-12-04 11:56:23 +05:30
Maneesh Gupta 4e564f783e Revert changes for atomic FADD support when address is in LDS (#1701)
This reverts PR #1591 and follow-on PR #1695

[ROCm/hip commit: 32442c6506]
2019-11-29 11:58:12 +05:30
Alex Voicu fd08d068c7 Use native support for atomic FADD when address is in LDS (#1591)
[ROCm/hip commit: d597e7ca20]
2019-11-22 07:53:48 +05:30
Paul Fultz II 27112bbdf0 Fix helper header when using c++17 (#1666)
This will fix issue #1621. It also adds tests for is_callable with c++11, c++14, and c++17.

The fallback implementation was completely broken so I rewrote it so it pass the tests as well. This should be used instead of PR #1631.

[ROCm/hip commit: 8519a1411c]
2019-11-20 21:33:42 +05:30
Alex Voicu 4ec70a7e03 Extend vector type capabilities and add tests to reflect it. (#1656)
[ROCm/hip commit: b5b3d1bbaa]
2019-11-20 21:32:32 +05:30
Sarbojit2019 6679cd3998 Revert [HIP] Fixed hipStreamAddCallback (#1674)
This reverts commit fa1e44aa0e.
Addresses SWDEV#212675.

[ROCm/hip commit: 153a959280]
2019-11-20 11:55:46 +05:30
Rahul Garg f55b1cd6a4 [dtest] Rename hipExtLaunchMultiKernelMultiDevice dtest (#1671)
[ROCm/hip commit: 188752b2cb]
2019-11-19 09:41:13 -08:00
Sameer Sahasrabuddhe cfaf04a467 hostcall: add tests that are only used by the VDI build (#1664)
[ROCm/hip commit: 363caf29c6]
2019-11-18 19:52:40 -08:00
Rahul Garg ecdba45d29 Fix gcc build on NVCC path (#1661)
* Fix gcc build on NVCC path

* Fix CI build errors

* [dtest] Fix texture and surface obj2D tests


[ROCm/hip commit: e39d7497ec]
2019-11-18 12:19:22 +05:30
jiabaxie cd3bf4e205 Updated hipEnvVarDriver to work with Windows (#1614)
* Updated hipEnvVarDriver to work with Windows

* Cleaned up a bit of code

* Fixed a part where putenv was used for both win and linux

* Defines moved to test_common.h and cleaned up code

* Cleaned up some macro defines and used const char instead

* Got rid of some excess commenting

* directory paths are unconditional

* Cleaned some duplicate code, and variables are now declared and defined together


[ROCm/hip commit: e73927caee]
2019-11-18 12:18:29 +05:30
kjayapra-amd fac2e14dab [dtests] Fixing compilation error in saxpy.cpp (#1608)
[ROCm/hip commit: 0a68be8b5b]
2019-11-18 12:18:11 +05:30
Alex Voicu 3ea404a8ba Add support for extended launch syntax. (#1530)
* Add support for extended launch syntax.

* Add unit test.

* Fix typo

* hipExtLaunchKernelGGL lives in hip_ext.h

Change-Id: Ice32dab0d43475fda65c6a910c11416871a8f2ff

* [dtest] remove redundant include from hipModuleGetGlobal dtest


[ROCm/hip commit: 69e74c3e96]
2019-11-16 22:24:07 -08:00
Maneesh Gupta 5536940e12 [ci] Fix failures on nvcc path (#1654)
Change-Id: I97f6b51314e14965618ab510bf57a2b034183e78

[ROCm/hip commit: f9fec8fdca]
2019-11-15 07:58:40 +05:30
Sarbojit2019 fa1e44aa0e [HIP] Fixed hipStreamAddCallback [SWDEV#165185] (#1425)
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior


[ROCm/hip commit: 45613311d7]
2019-11-07 13:18:12 +05:30