Commit Graph

1455 Commits

Author SHA1 Message Date
Mark Searles 81c93d94be Add keyword 'explicit' to avoid ambiguity
Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:

In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
                    const double __y = -std::abs(__n) * __param._M_sm - 1;
                                        ^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)


[ROCm/clr commit: 37cc117bd5]
2018-08-31 10:36:05 -07:00
Aaron Enye Shi 6ce7e12be9 __forceinline__ needs inline and always_inline
Related to SWDEV-163084


[ROCm/clr commit: decf9beec9]
2018-08-29 18:33:35 +00:00
Yaxun Sam Liu 137880f369 Add clock() and clock64()
[ROCm/clr commit: 0f4546deca]
2018-08-29 10:51:00 -04:00
Aaron Enye Shi 3a7ad8a604 Add bitinsert64 to device functions
[ROCm/clr commit: 031c0204d8]
2018-08-28 20:01:14 +00:00
Aaron Enye Shi 06a68d3eb6 Clean up and add meaningful variables to bit funcs
[ROCm/clr commit: 24429eabb0]
2018-08-28 18:19:48 +00:00
Aaron Enye Shi 13f4ace668 Add bitextract and bitinsert functions
[ROCm/clr commit: fb1da42d0e]
2018-08-20 16:46:12 +00:00
Maneesh Gupta 3cb8b82de3 Merge pull request #623 from ROCm-Developer-Tools/tf18
Fix declaration conflict when hip/math_functions.h is included first

[ROCm/clr commit: 546378292d]
2018-08-10 09:36:27 +05:30
Maneesh Gupta a3e7b7c18e Merge pull request #613 from ROCm-Developer-Tools/hcc-compat
Add HCC compatibility mode for hip-clang

[ROCm/clr commit: a5f9ae90d2]
2018-08-10 09:32:31 +05:30
Yaxun Sam Liu d3295e61e2 Fix __HIP_ARCH_* not defined after including math_functions.h
hcc_detail/math_functions.h used to include hcc_detail/hip_runtime.h.

Removing it has caused regression in TensorFlow 1.8.

Put it back for backward compatibiliity.


[ROCm/clr commit: 87de95975a]
2018-08-08 08:55:28 -04:00
Yaxun Sam Liu 6e153a743f Fix __HIP_DEVICE_COMPILE__ not defined when hip/math_functions.h is included
This fixes build failure in TensorFlow 1.8 for HCC


[ROCm/clr commit: 058eb7535b]
2018-08-07 17:14:39 -04:00
Yaxun Sam Liu 6df5aef807 Fix declaration conflict when hip/math_functions.h is included first
This fixes build failure in TensorFlow 1.8 for HCC


[ROCm/clr commit: 69bbf45b44]
2018-08-07 15:44:59 -04:00
Wen-Heng (Jack) Chung d7b2bab183 Revert "HIP program state re-initialization logic"
This reverts commit 865fe01b37.


[ROCm/clr commit: 1fe7f1be91]
2018-08-03 17:03:04 -05:00
Maneesh Gupta 0f033ca572 Merge pull request #603 from b-sumner/master
Drop use of NVCC_COMPAT since it is always set

[ROCm/clr commit: b485957858]
2018-08-03 08:45:18 +05:30
Maneesh Gupta 1039c7952c Merge pull request #610 from aaronenyeshi/enable-hcc-module-launch
Enable hipHccModuleLaunchKernel on HIP-Clang

[ROCm/clr commit: 0354367a07]
2018-08-02 08:08:46 +05:30
Yaxun Sam Liu b587661200 Add hc_get_workitem_absolute_id for hip-clang HCC compatibility mode
[ROCm/clr commit: 9c28758fa0]
2018-08-01 15:14:38 -04:00
Yaxun Sam Liu 2d74df6f34 Add HCC compatibility mode
[ROCm/clr commit: b91691966f]
2018-08-01 15:14:38 -04:00
Aaron Enye Shi 83d293a2a4 Enable hipHccModuleLaunchKernel on HIP-Clang
[ROCm/clr commit: 0ad36dfa58]
2018-07-31 20:38:20 +00:00
Aaron Enye Shi 9512246b5c Protect macro TYPEDEF_VECTOR_VALUE_TYPE and prefix __hip_ for vector_value_types
[ROCm/clr commit: e42af991d1]
2018-07-30 20:41:24 +00:00
Aaron Enye Shi ad6066eebd Ensure correct vector value type used in texture
Implement the vector value types in terms of SCALAR_TYPE##SIZE_vector_value_type for float, int, uint and sizes 2, 3, 4, 8, and 16.


[ROCm/clr commit: ff1e49d191]
2018-07-30 19:43:12 +00:00
Yaxun Sam Liu ea77788a5f Fix thread index calculation in __hip_malloc
[ROCm/clr commit: f08f26942c]
2018-07-27 16:24:51 -04:00
Yaxun Sam Liu 9a4744566f Support malloc/free for hip-clang
[ROCm/clr commit: d17dc21c9c]
2018-07-27 16:24:51 -04:00
Brian Sumner beb7f13068 Drop use of NVCC_COMPAT since it is always set
[ROCm/clr commit: 8d80abb30f]
2018-07-27 09:29:29 -07:00
Aaron Enye Shi 65a1df76dc Enable HIP texture functions with HIP vector types
Include texture_functions.h on HIP-Clang path. Use HIP vector types instead of hc::short_vectors for texture_functions, and remove HCC headers.


[ROCm/clr commit: bf6fdca1e8]
2018-07-25 19:52:19 +00:00
Maneesh Gupta 9f23f7fc99 Merge pull request #584 from ROCm-Developer-Tools/fix-vector-explicit-cast
Fix explicit cast required

[ROCm/clr commit: 123af1a9c6]
2018-07-23 10:13:05 +05:30
Aaron Enye Shi 1282ef2e0c Fix explicit cast required
This is required for PyTorch which runs into an issue with narrowing types. Requires an explicit cast.

[ROCm/clr commit: 032ebd41ea]
2018-07-20 16:34:15 -04:00
Aaron Enye Shi 5e2395deeb [HIPClang] Switch ordering on math functions
Header math_functions.h should be included after including __clang_cuda_math_forward_declares.h to avoid warning: attribute declaration must precede definition.

[ROCm/clr commit: 98fca64220]
2018-07-20 13:25:04 -04:00
Maneesh Gupta 746e56a61b Merge pull request #543 from ROCm-Developer-Tools/add-std-complex
Support std::complex for hip-clang

[ROCm/clr commit: 5632faf928]
2018-07-19 07:14:45 +05:30
Yaxun (Sam) Liu dc1257a16c Support std::complex for hip-clang
[ROCm/clr commit: a8dc1257df]
2018-07-18 00:08:04 -04:00
Alex Voicu 8b6a48d0d1 Update hip_vector_types.h
[ROCm/clr commit: 252776d4aa]
2018-07-17 17:28:48 +01:00
Alex Voicu 766211b400 Not yet.
[ROCm/clr commit: 14281c0a40]
2018-07-17 17:21:10 +01:00
Alex Voicu 2c568a5541 Constrain variadic constructor to ranks > 1 and add missing __device__s
[ROCm/clr commit: 1734eaead8]
2018-07-17 17:17:48 +01:00
Maneesh Gupta c96a617b78 Merge branch 'master' into move-memcpy
[ROCm/clr commit: 1fc3ef3cd4]
2018-07-17 10:51:42 +05:30
Maneesh Gupta 112c945016 Merge branch 'master' into feature_native_vector_types
Change-Id: I943b94ee230871a960d8f9c321ad5e096183b415


[ROCm/clr commit: 9e142ea66a]
2018-07-17 09:51:22 +05:30
Maneesh Gupta 8eeb225c04 Merge pull request #515 from ROCm-Developer-Tools/hipclang-add-amdgcn-funcs
Add hipclang amdgcn functions

[ROCm/clr commit: 7d8c1ae761]
2018-07-17 09:25:09 +05:30
Alex Voicu 438a2c1fb9 Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into feature_native_vector_types
[ROCm/clr commit: a2b6508912]
2018-07-15 11:44:48 +01:00
Evgeny Mankov 3a45d7016c [HIPIFY] Support of cudaComputeMode / CUcomputemode
+ update docs
+ fix typo in hip_runtime_api.h


[ROCm/clr commit: 4e0d07f07a]
2018-07-14 16:08:19 +03:00
Maneesh Gupta 6e7579dbd7 Merge pull request #563 from gargrahul/add_gettexrefoffset_nvcc
Add hipGetTextureAlignmentOffset and hipGetChanDesc on NVCC path

[ROCm/clr commit: 56984d04b0]
2018-07-11 15:01:20 +05:30
Maneesh Gupta c25b0f61e9 Merge branch 'master' into add_bindtextoarrayref_overload_api
[ROCm/clr commit: afe1396b35]
2018-07-11 12:55:49 +05:30
Maneesh Gupta 8001ecea35 Merge pull request #549 from gargrahul/correct_bindtex_syntax_nvcc
Corrected enum type for TextureReadMode 

[ROCm/clr commit: 8820eee3a2]
2018-07-11 12:52:50 +05:30
Rahul Garg f25e75ee6b Added hipGetChanDesc for NVCC path
[ROCm/clr commit: bab48b86a6]
2018-07-11 12:37:07 +05:30
Rahul Garg 4fdb1a8ee5 Add hipGetTextureAlignmentOffset on NVCC path
[ROCm/clr commit: 5b53e278a5]
2018-07-11 12:17:33 +05:30
Yaxun (Sam) Liu 6666bf623d Include stddef.h in device_functions.h and remove use of uint8_t
[ROCm/clr commit: 2531815dfe]
2018-07-10 18:12:41 -04:00
Yaxun (Sam) Liu 007a005cf3 Move __hip_hc_memcpy and __hip_hc_memset from device_utils.cpp to device_functions.h as inline functions
[ROCm/clr commit: 903dfa94eb]
2018-07-10 18:12:41 -04:00
Aaron Enye Shi 0e111de9f4 Fix min/max, icmp asm and add comment for conversion functions
[ROCm/clr commit: 9f3404cfea]
2018-07-10 18:56:48 +00:00
Aaron Enye Shi 8d0936bbe4 Add func attributes to match ocml and ockl
[ROCm/clr commit: bc8bc8cac4]
2018-07-10 18:27:32 +00:00
Aaron Enye Shi 327b0fb0e4 Remove activelanemask asm using ockl and llvm instrinsics
Replace implementation of __any and __all functions using OCKL functions and replaced __ballot implementation to use llvm intrinsic llvm.amdgcn.icmp.i32 instead of calls to __activelanemask_v4_b64_b1 which is not convergent.


[ROCm/clr commit: f8746ecc64]
2018-07-10 17:56:57 +00:00
Yaxun (Sam) Liu d1dbc3dbc5 Add workaround __local_to_generic
[ROCm/clr commit: 9aaa792286]
2018-07-09 17:56:33 +00:00
Yaxun (Sam) Liu 2d5e831c7f Add declare of __get_dynamicgroupbaseptr for host compilation
[ROCm/clr commit: 1f34993ac1]
2018-07-09 17:56:25 +00:00
Aaron Enye Shi 0e5ef747e6 Enable surface functions on HIP clang path
Fix surface test on HIP clang path.


[ROCm/clr commit: 5862ae4b6a]
2018-07-05 20:49:47 +00:00
Aaron Enye Shi eab9cacef2 Implement hip_ldg Functions into HIP header
Move all the function definitions for hip_ldg.cpp into hip_ldg.h header and enable for HIP clang path.


[ROCm/clr commit: d39508b4fd]
2018-07-05 20:38:46 +00:00