3fefd31b07
Update license file for 2025 ( #1480 )
2025-01-07 14:47:55 -05:00
4ee2ed6e23
Merge pull request #1479 from JhaShweta1/patch-1
...
Update CODEOWNERS: Add a new name
2025-01-07 10:45:21 -06:00
f2ee8d9132
Check nvlink_node instead of xgmi_node in xml.cc ( #1407 )
...
It seems like here wants to check xgmi_node instead. If checks node for "nvlink", it will verify the link_info everytime.
If checks node for "xgmi", when get yes answer, it won't need check vsmi topo interface.
2025-01-06 17:09:27 -08:00
c6c7b6db98
Define wc_store_fence for riscv ( #1475 )
2025-01-06 16:59:14 -08:00
e77c3c2975
Bump jinja2 from 3.1.4 to 3.1.5 in /docs/sphinx ( #1473 )
...
Bumps [jinja2](https://github.com/pallets/jinja ) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/pallets/jinja/releases )
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst )
- [Commits](https://github.com/pallets/jinja/compare/3.1.4...3.1.5 )
---
updated-dependencies:
- dependency-name: jinja2
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-01-06 17:09:32 -07:00
c158d3a9b4
[SWDEV-497665] Blocked cudaMemcpyAsync race condition by synchronizing ( #1447 )
...
* Switched calls to `cudaMemcpyAsync` to be `cudaMemcpy` in `ncclTransportP2pSetup` to avoid race condition with `cudaIpcOpenMemHandle` inside p2p `connect`. See `ncclP2pImportShareableBuffer`.
* Moved synchronize outside of the loop, as it isn't necessary to sync between every iteration of the loop.
2025-01-03 13:06:47 -07:00
f60fac76e6
Update CODEOWNERS
...
Added a new user: Shweta Jha
2025-01-03 11:47:22 -06:00
a9d6e7661c
Add macro for channel mask offset ( #1467 )
2025-01-03 08:41:41 -05:00
39483c55f8
Initializing all ranks to the same value to avoid failure of UT AllR… ( #1459 )
...
* Initializing all ranks to the same value to avoid failure of UT AllReduce for FP8 type
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
2025-01-02 11:39:02 -06:00
fd03b5b6a5
[BUILD] Fix ASAN build if GPU targets has xnack+ ( #1474 )
...
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
2024-12-26 12:13:36 -06:00
648a58dd27
Bump rocm-docs-core from 1.9.2 to 1.12.0 in /docs/sphinx ( #1466 )
...
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core ) from 1.9.2 to 1.12.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.9.2...v1.12.0 )
---
updated-dependencies:
- dependency-name: rocm-docs-core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-18 10:04:07 -07:00
2934bf6fc6
Change kernel reference to use new terminology ( #1462 )
2024-12-16 13:34:18 -05:00
e6b179d627
Remove unneeded highestTransportType ( #1461 )
2024-12-16 13:28:47 -05:00
83c5eb7378
Fix MSCCL algorithm loading order ( #1460 )
2024-12-16 07:41:17 -08:00
45c1c1a781
changed the CMake option from AMDGPU_TARGETS to GPU_TARGETS ( #1440 )
2024-12-12 12:09:30 -07:00
7386fac64a
Improve the handling of CMake deduplication ( #1450 )
...
Certain CMake functions deduplicates arguments by default. For example, if we
have two `target_link_options` with both `-Xoffload-linker -opt-A` and then
`-Xoffload-linker -opt-B`, the final link command would be `-Xoffload-linker
-opt-A -opt-B`, which is not what we want.
2024-12-11 13:48:18 -08:00
8e9fcf111a
Check -parallel-jobs before use ( #1451 )
...
`-parallel-jobs` is not always available, such as upstream LLVM.
2024-12-11 11:40:49 -06:00
ad4c36dc34
increase p2p channels for Intel platform ( #1448 )
...
Co-authored-by: hujingbo <hujingbo@kuaishou.com >
2024-12-10 07:33:37 -08:00
9aa5b9f02e
Refactor how to docs and formatting fixes ( #1444 )
2024-12-10 08:47:24 -05:00
6d34fb7632
Add RCCL debugging guide ( #1420 )
...
* Add RCCL debugging guide
* Changes from external review
* More edits from internal review
* Additional edits
* Minor correction
* More changes after external review
* Integrate index and ToC changes with incoming merge changes
* Integrate feedback from management review
* Minor edits from the internal review
2024-12-06 13:25:58 -05:00
42b6831a39
ext-src: tune TP=8 case on MI308 CPX mode ( #1446 )
...
Tune the number of blocks for hierarchical mscclpp allreduce.
2024-12-06 08:16:39 -06:00
a05329bd0d
Add Topologies for 16-GPU gfx942 SuperNode ( #1417 )
...
* Add Topologies for 16-GPU gfx942 SuperNode
- Add GigaIO topologies to tools/topo_expl for dev and testing
- Add GigaIO Columba 16 GPU romeModel and adjust topology
matching algorithm in rome_models for 16 GPU system
- Fix bug which failed to match Rome Model when using subsets
of system resources (i.e. ROCR_VISIBLE_DEVICES is set)
- Fixes for topo_expl
* Fix bug w/ 1H16P
2024-12-03 13:12:03 -08:00
28594b26b3
Modify cmake instruction in build from source ( #1445 )
2024-12-03 11:26:02 -05:00
1f789d6836
Bump rocm-docs-core from 1.8.3 to 1.9.2 in /docs/sphinx ( #1441 )
...
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core ) from 1.8.3 to 1.9.2.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases )
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.8.3...v1.9.2 )
---
updated-dependencies:
- dependency-name: rocm-docs-core
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-29 15:21:43 -07:00
bf7c130631
Refactor RCCL install guide into several pages ( #1427 )
...
* Refactor RCCL install guide into several pages
* Changes from code review and new docker guide
* Add missing entries to ToC
* Minor fixes
* Fix help strings
* Edits after review and remove extra white space
2024-11-27 15:34:26 -05:00
e42f10a361
Update rccl changelog for 6.3.1 ( #1433 )
...
* Update rccl changelog for 6.3.1
* Fix version number
* Correct RCCL release version
* Added details to 6.3.0 changelog
---------
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
2024-11-26 08:46:37 -05:00
000575867c
Adding RCCL_MODEL_REVERSAL_DISABLE env var to disable model reversal ( #1431 )
...
* Adding RCCL_MODEL_REVERSAL_DISABLE env var to disable model reversal
2024-11-25 11:24:54 -07:00
dfe4a3ed81
Fix typo in ncclGetKernelIndex macro ( #1424 )
2024-11-18 10:40:05 -05:00
4336a0f3a3
Added latest users to CODEOWNERS. ( #1422 )
2024-11-14 16:55:18 -07:00
cb175fb0b3
Template generic kernel for unroll factor ( #1419 )
...
* Template generic kernel for unroll factor
2024-11-12 18:27:29 -05:00
2d07f18696
Refactor landing page and move some info to What is RCCL ( #1415 )
2024-11-12 13:15:27 -05:00
2284101624
removing unused gfx targets ( #1411 )
2024-11-06 08:50:08 -07:00
52d5f4cde2
Merge pull request #1406 from ROCm/darren-amd-remove-computeColl-declaration
...
remove undefined computeColl declaration
2024-11-06 10:43:35 -05:00
cb1027de97
Updating RCCL Replayer README ( #1408 )
2024-11-05 08:06:11 -07:00
ebf0417e90
remove undefined computeColl declaration
2024-11-04 13:42:01 -05:00
69b2b712ab
GPU allocation for CPX Unit Tests using PCI bus id ( #1403 )
...
* mapping devices wrt pci
* Gpu allocation by using pci mapping
* Passing gpuPriorityOrder in as an argument rather than making the functions non-static.
* Removing redundant testBed instance calling
2024-11-04 10:51:00 -06:00
1c45962273
Hide or fix all build warnings ( #1331 )
...
* Changing C-strings to be const.
* Changed variable-length arrays to std::vector to avoid warnings. VLA is a compiler extension.
* Changed `#define` inside functions into `constexpr int` to preserve scoping and avoid macro redefinition warnings.
* Disabled warnings for modifying `CMAKE_CXX_FLAGS` caused by `check_symbol_exists`, which temporarily modifies the flag to do a compile check.
* Fixed VLA in rccl UT.
2024-11-04 09:46:42 -07:00
6178556853
GDR enablement logic fix for kernel 6.4.0+ ( #1378 )
2024-11-03 01:20:07 -05:00
984f1e4343
Increase MAX_STACK_SIZE for UT ( #1398 )
2024-11-01 13:07:45 -04:00
6db2644766
Set minimum ROCm version for MSCCLPP to 6.2 ( #1401 )
...
* Added ROCm version check around setting `ENABLE_MSCCLPP` flag.
2024-10-30 16:48:54 -06:00
d6006f0425
Memory leak fixes in hostside functions ( #1388 )
...
memory leak fixes for parseRome4P2H and ncclTopoAddGPU
2024-10-30 14:25:56 -05:00
fd9924cfe7
Adjustment for UT Sendrecv ( #1400 )
...
Enabled UT sendrecv to same rank and refactor UBR call
2024-10-30 15:13:53 -04:00
0fb3b5eba9
ext-src: Improved allreduce performance in cpx mode for MI308 ( #1393 )
...
To get the improved performance for TP=4, the user needs to use
RCCL_MSCCL_FORCE_ENABLE=1 and MSCCLPP_READ_ALLRED=1. For TP=8, the
user should use MSCCLPP_HIERARCHICAL_ALLRED=1.
2024-10-30 08:30:15 -05:00
ea20af698e
Remove MSCCL switch case fall-through by adding break statement. ( #1342 )
2024-10-29 15:47:59 -06:00
8ac63e7e70
6.2 final documentation fixes updated for 6.3 ( #1252 ) ( #1399 )
...
* Update CHANGELOG.md
* Update NOTICES.txt
* [DOCS] Note on using less than 8 MI300 GPUs
* Update README.md
---------
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
Co-authored-by: nileshnegi <Nilesh.Negi@amd.com >
2024-10-29 15:23:45 -06:00
0cbce2a757
Adding support for odd nodes for model_87 ( #1309 )
2024-10-24 08:38:12 -06:00
6ed513e1b9
Update CHANGELOG to match release branches 6.2 and 6.3 ( #1391 )
...
* [CHANGELOG] Add Known issues for ROCm 6.2.1
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
* Updated 6.2.1 known issues to match the content in develop.
* Updated CHANGELOG for ROCm 6.3 release. (#1380 )
* Updated CHANGELOG for ROCm 6.3 release.
* Update CHANGELOG to new format.
Co-authored-by: Jeffrey Novotny <jnovotny@amd.com >
---------
Co-authored-by: Jeffrey Novotny <jnovotny@amd.com >
---------
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
Co-authored-by: nileshnegi <Nilesh.Negi@amd.com >
Co-authored-by: Jeffrey Novotny <jnovotny@amd.com >
2024-10-23 13:49:40 -06:00
29f87c7191
Increased maximum number of XML nodes to support CPX mode. ( #1386 )
2024-10-23 11:15:11 -05:00
e0780ba4d4
Fix topology discovery in container with subset of GPUs ( #1384 )
...
* Fix topology discovery in container with subset of GPUs
* Move links counting out of loop
2024-10-22 13:50:23 -07:00
cfecce790f
[Replayer] Add validation ( #1387 )
...
* Add validation to rccl_replayer
2024-10-22 10:41:08 -04:00
Jeffrey Novotny
JhaShweta1
qiwei_ji
Xeonacid
dependabot[bot]
corey-derochie-amd
Mustafa Abduljabbar
mberenjk
Nilesh M Negi
Ziyue Yang
akolliasAMD
Shilei Tian
Hujingbo
Nusrat Islam
Benjamin Kitor
gilbertlee-amd
Bertan Dogancay
darren-amd
saurabhAMD
Abhishek Kulkarni
Avinash
Tim
Arm Patinyasakdikul
Wenkai Du