Commit Graph

937 Commitit

Tekijä SHA1 Viesti Päivämäärä
Tao Sang eb5fed63c1 Temporarily comment out Hcc-specific APIs for CLang compiler
Temporarily comment out Hcc-specific template functions
hipExtLaunchKernelGGL and hipOccupancyMaxPotentialBlockSize for CLang
compiler so that all test cases under hip/samples can be built
successfully for Clang + Hip/Hcc runtime.

Change-Id: Iafc761257be4a7b34eafa6759a01f369570cd6ce


[ROCm/hip commit: b3f445c0f5]
2020-02-16 22:26:47 -05:00
Tao Sang adadf90ff5 Support defaultDriver test with Clang+Hcc Runtime
Fix the following issues:
1.Ignore hidden arguments of kernel functions.
2.Look up both origial function name and function name with .kd postfix
when argments are retrived from module.
3.Addition, fix compiling issue of LaunchKernel test app.

Change-Id: I9400943f2f02433cb4409b19c0cac3626c2bc454


[ROCm/hip commit: 9a005eacf3]
2020-02-15 19:29:13 -05:00
Payam d2e10a632e removing oocupancy tests from hip-vdi for now
Change-Id: I06e966d07021af87fa2c195e4bbaf6bcc336658d


[ROCm/hip commit: fabe62e31f]
2020-02-13 21:40:06 -05:00
Laurent Morichetti 471b697a05 Merge branch 'master' into amd-master-next
Change-Id: Ibb7775e7acd263d2ece40a241517bbd15976fdd4


[ROCm/hip commit: 2cf3257795]
2020-02-12 00:14:07 -08:00
Maneesh Gupta 7753b3e827 Revert "Match Occupancy APIs syntax with CUDA (#1625)" (#1857)
Reverting this for now till we figure out how to avoid the build
breakage.

This reverts commit e38db9fb6f.

[ROCm/hip commit: f8e1c01900]
2020-02-10 10:45:28 +05:30
Payam 5cf8d742cb Excluding vdi platform for now from the following tests so we can build
Change-Id: I651255c2515a62c8bdfdd17a3ac85c3d66a5761b


[ROCm/hip commit: e4e8c4b74b]
2020-02-07 02:16:05 -05:00
Laurent Morichetti 8b18768a1c Merge branch 'master' into amd-master-next
Change-Id: Ib7e7824073f4dfc391fb3833fc90e11b327d3c22


[ROCm/hip commit: 258adce78e]
2020-02-05 14:56:08 -08:00
vsytch e5243c1834 Device texture functions should not normalize the sampled pixel (#1826)
* Device texture functions should not normalize the sampled pixel. This is already done by HW.
* Add support to use h/w capability for normalized float data convertion for driver API's

Co-authored-by: ansurya <50609411+ansurya@users.noreply.github.com>


[ROCm/hip commit: ef514eef71]
2020-02-05 20:56:17 +05:30
lthakur e340a8e921 [dtest] Update hipLaunchCoopMultiKernel.cpp (#1844)
used reinterpret_cast<uint32_t*> for numBlocks, as expected by hipOccupancyMaxActiveBlocksPerMultiprocessor() api.

[ROCm/hip commit: 4d472b777f]
2020-02-04 19:37:38 +05:30
Siu Chi Chan ec45ec16e3 Fix C-style hipLaunchKernel (#1835)
* Fix bug in LaunchKernel test
Instead of passing the address of the gpu buffer, pass the address
of the pointer that holds the address of the gpu buffer

* Fix hipLaunchKernel's kernarg buffer construction.
The hipLaunchKernel implementation should rely on ihipModuleLaunchKernel
to construct the kernarg buffer correctly based on kernel metadata.

* Fix a bug in get_functions where the Kernel_descriptor wasn't constructed with the correct kernarg layout information.

* Fix a bug in kernarg layout parsing dealing with kernel without any arg

* teach ihipModuleLaunchKernel to handle kernel without any arg

* Add a more interesting test

[ROCm/hip commit: bff8e15e13]
2020-02-04 19:37:16 +05:30
ansurya a63cce96da [hit] Syntax support for EXCLUDE_HIP_RUNTIME and EXCLUDE_HIP_COMPILER (#1800)
* Added support to disable test based on HIP Runtime(HCC/VDI) and Compiler(hcc/clang)
* Updated README.md, HIT.cmake for new options EXCLUDE_HIP_RUNTIME and EXCLUDE_HIP_COMPILER


[ROCm/hip commit: 1d88a230cc]
2020-02-04 08:56:02 +05:30
gandryey 42bc78d148 [dtest] RCCL multi device launch test (#1731)
Simple test for hipLaunchCooperativeKernelMultiDevice API.


[ROCm/hip commit: 48d1f766d5]
2020-02-04 08:53:43 +05:30
Laurent Morichetti bc78a8529d Merge branch 'origin/pghafari/hip-vdi' into lmoriche/amd-master-next
Change-Id: I22c145d39f430ca571a981687bcb034ea6e3b8a2


[ROCm/hip commit: a8b81e96b4]
2020-01-31 07:33:12 -08:00
jujiang-del 61156d3b2d [dtest] Avoid resViewDesc for non-array resource in texture creation (#1823)
[ROCm/hip commit: 3684ef813d]
2020-01-30 14:04:41 -08:00
satyanveshd e38db9fb6f Match Occupancy APIs syntax with CUDA (#1625)
* Match Occupancy APIs syntax with CUDA and fix tests using these APIs


[ROCm/hip commit: fa98798b63]
2020-01-29 13:05:53 -08:00
Siu Chi Chan af3e8f633a Fix associate code object symbols with host allocation bug (#1799)
The current implementation skips this procedure for a given device
object when a global symbol is found in the cache.  This is incorrect:

 - There could be other undefined globals that have not been previously
encountered further down the list
 - If a symbol is found in the cache, it doesn't need to be pinned again
but it still need to be defined for the current executable

Added special case for the printf buffer symbol (already pinned by HCC)

The bug was exposed by running printf on different GPUs.

[ROCm/hip commit: 6613a37b3b]
2020-01-24 16:22:49 +05:30
Yaxun (Sam) Liu 5d17d5b029 Fix test hip_bitextract.cpp (#1784)
The randomly generated offset+width may exceeds 32, which causes
a left shift operation with 32-offset-width. As an unsigned number
that is greater than 32 and causes undefined behavior. When the
test is compiled without -mavx it is still OK. However when
the test is compiled with -mavx, the undefined behavior causes
wrong results and test failure.

This patch adjusts width so that offset+width<=32 always.

[ROCm/hip commit: 02848e0b80]
2020-01-10 13:46:57 +05:30
Rahul Garg 327a45b18b Add hipBindTexture2D on NVCC path (#1773)
[ROCm/hip commit: a5d7e7d8d3]
2020-01-06 12:33:50 +05:30
Evgeny Mankov 6ac4d18753 Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/hip commit: 0dadb23327]
2019-12-30 19:21:09 +03:00
Sarbojit2019 6d2ec032fe Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.

[ROCm/hip commit: aa4aea0754]
2019-12-30 12:44:24 +05:30
Evgeny Mankov abef353b5b [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/hip commit: 4921678b6c]
2019-12-23 17:01:35 +03:00
Alex Voicu 1f5ecc0f6a Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/hip commit: 75a11330aa]
2019-12-23 19:11:24 +05:30
Evgeny Mankov 30ae3942dc [HIP] Unify hipError_t (Step 2)
Step 2. Make a few hipError codes deprecated
Update hipify-clang, hipify-perl, docs and samples accordingly


[ROCm/hip commit: dbad4d9b7f]
2019-12-22 02:05:31 +03:00
Vladislav Sytchenko 6015efe6f5 Add comments explaining choice on the cap for system memory on Windows.
[ROCm/hip commit: bf3df9d7c0]
2019-12-13 21:38:27 -05:00
Vladislav Sytchenko 29ca9f7d53 Add explicit cast when computing the available amount of system memory.
[ROCm/hip commit: 12634879e2]
2019-12-13 21:37:30 -05:00
Vladislav Sytchenko 9dade23425 Reduce the amount of free host memory to 40% of what is reported on Windows, otherwise we can run into OOM situations.
[ROCm/hip commit: b12c53cceb]
2019-12-11 20:21:12 -05:00
Rahul Garg ebdd811632 Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.

[ROCm/hip commit: e53fc316f1]
2019-12-06 09:51:53 +05:30
Rahul Garg fa87abd58a Fix hipMemcpyWithStream (#1707)
* Fix hipMemcpyWithStream
* Add a dtest for the same.


[ROCm/hip commit: 892d2a562e]
2019-12-04 11:56:23 +05:30
Maneesh Gupta 4e564f783e Revert changes for atomic FADD support when address is in LDS (#1701)
This reverts PR #1591 and follow-on PR #1695

[ROCm/hip commit: 32442c6506]
2019-11-29 11:58:12 +05:30
Alex Voicu fd08d068c7 Use native support for atomic FADD when address is in LDS (#1591)
[ROCm/hip commit: d597e7ca20]
2019-11-22 07:53:48 +05:30
Paul Fultz II 27112bbdf0 Fix helper header when using c++17 (#1666)
This will fix issue #1621. It also adds tests for is_callable with c++11, c++14, and c++17.

The fallback implementation was completely broken so I rewrote it so it pass the tests as well. This should be used instead of PR #1631.

[ROCm/hip commit: 8519a1411c]
2019-11-20 21:33:42 +05:30
Alex Voicu 4ec70a7e03 Extend vector type capabilities and add tests to reflect it. (#1656)
[ROCm/hip commit: b5b3d1bbaa]
2019-11-20 21:32:32 +05:30
Sarbojit2019 6679cd3998 Revert [HIP] Fixed hipStreamAddCallback (#1674)
This reverts commit fa1e44aa0e.
Addresses SWDEV#212675.

[ROCm/hip commit: 153a959280]
2019-11-20 11:55:46 +05:30
Rahul Garg f55b1cd6a4 [dtest] Rename hipExtLaunchMultiKernelMultiDevice dtest (#1671)
[ROCm/hip commit: 188752b2cb]
2019-11-19 09:41:13 -08:00
Sameer Sahasrabuddhe cfaf04a467 hostcall: add tests that are only used by the VDI build (#1664)
[ROCm/hip commit: 363caf29c6]
2019-11-18 19:52:40 -08:00
Rahul Garg ecdba45d29 Fix gcc build on NVCC path (#1661)
* Fix gcc build on NVCC path

* Fix CI build errors

* [dtest] Fix texture and surface obj2D tests


[ROCm/hip commit: e39d7497ec]
2019-11-18 12:19:22 +05:30
jiabaxie cd3bf4e205 Updated hipEnvVarDriver to work with Windows (#1614)
* Updated hipEnvVarDriver to work with Windows

* Cleaned up a bit of code

* Fixed a part where putenv was used for both win and linux

* Defines moved to test_common.h and cleaned up code

* Cleaned up some macro defines and used const char instead

* Got rid of some excess commenting

* directory paths are unconditional

* Cleaned some duplicate code, and variables are now declared and defined together


[ROCm/hip commit: e73927caee]
2019-11-18 12:18:29 +05:30
kjayapra-amd fac2e14dab [dtests] Fixing compilation error in saxpy.cpp (#1608)
[ROCm/hip commit: 0a68be8b5b]
2019-11-18 12:18:11 +05:30
Alex Voicu 3ea404a8ba Add support for extended launch syntax. (#1530)
* Add support for extended launch syntax.

* Add unit test.

* Fix typo

* hipExtLaunchKernelGGL lives in hip_ext.h

Change-Id: Ice32dab0d43475fda65c6a910c11416871a8f2ff

* [dtest] remove redundant include from hipModuleGetGlobal dtest


[ROCm/hip commit: 69e74c3e96]
2019-11-16 22:24:07 -08:00
Maneesh Gupta 5536940e12 [ci] Fix failures on nvcc path (#1654)
Change-Id: I97f6b51314e14965618ab510bf57a2b034183e78

[ROCm/hip commit: f9fec8fdca]
2019-11-15 07:58:40 +05:30
Sarbojit2019 fa1e44aa0e [HIP] Fixed hipStreamAddCallback [SWDEV#165185] (#1425)
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior


[ROCm/hip commit: 45613311d7]
2019-11-07 13:18:12 +05:30
ansurya 92dcba11ac Fixed texture 2D mapping for pitched arrays & 3D Texture read (#1415)
Texture 2D image mapping for pitched arrays:
github issue: Texture Object's Buffer seems to be Misaligned #886
JIRA ticket: SWDEV-199313

SWDEV-151670 : Fixed issue with 3D texture with 4 components
SWDEV-151671 : Issue with 2D layered texture with 4 components

[ROCm/hip commit: e07926ce0f]
2019-11-07 13:17:46 +05:30
Rahul Garg 6968362d99 Rename hip/hip_hcc.h to hip/hip_ext.h (#1341)
* Rename hip/hip_hcc.h to hip/hip_ext.h

* Deprecate hip_hcc.h


[ROCm/hip commit: 579a4f36fa]
2019-11-07 13:17:10 +05:30
Evgeny Mankov b4a30a0c7a Merge pull request #1624 from emankov/hipify
[HIPIFY][#1409] Fix for kernel launch macro expansion

[ROCm/hip commit: a601670cb7]
2019-11-05 14:04:51 +03:00
Evgeny Mankov 5a9c8168c1 [HIPIFY][#1409] Fix for kernel launch macro expansion
+ Add a corresponding test kernel_launch_01.cu
+ Add isBefore() check to avoid crash on Replacement with negative length

TODO:
+ Compatibility with former LLVM versions
+ More complicated kernel launch tests


[ROCm/hip commit: 976f8e8bf6]
2019-11-05 14:00:13 +03:00
Aryan Salmanpour 2ad99a6326 [hip][tests] Add two more workgroup sizes for testing hipLaunchCooperativeKernel (#1613)
[ROCm/hip commit: cf92fae9e6]
2019-11-05 12:32:46 +05:30
Rahul Garg 25a5ca94de Merge pull request #1582 from amd-lthakur/hipExtMLK
Adding a directed test case for hipExtModuleLaunchKernel() api.

[ROCm/hip commit: 4739e68bbe]
2019-10-31 17:13:26 -07:00
Rahul Garg b68c8d2f60 Formatting changes
[ROCm/hip commit: 55f2a38120]
2019-10-30 18:12:51 -07:00
Rahul Garg 8429e15052 Formatting changes ,variable name and check update
[ROCm/hip commit: 4ab71216b4]
2019-10-30 18:09:21 -07:00
Rahul Garg 7e742b1216 Merge pull request #1515 from ansurya/tex_unbind_issue_fix
Fix undefined ref to hipUnbindTexture for texture types

[ROCm/hip commit: ba8105e0cd]
2019-10-30 17:54:15 -07:00