Commit Graph

726 Commits

Author SHA1 Message Date
Xie,AlexBin 4d6ec86edf SWDEV-378367 - Observed performance drop for Geekbench5
Change-Id: I0beabc6e3bec095574c8168fcf52af1e94105792


[ROCm/clr commit: 97243ff755]
2023-02-21 17:18:16 -05:00
Todd tiantuo Li 77a647b170 SWDEV-382501 - support new ASIC Revision for Phoenix2
Change-Id: I0225511960c9fbc50ec541511599ef87e509b567


[ROCm/clr commit: 189ce1ad05]
2023-02-21 02:54:35 -08:00
Anusha GodavarthySurya 06ffd15060 SWDEV-366636 - Fix performance drop in TF-RCCL models
Change-Id: Idc845bb0dab858b94b9d2720cae8308cac2e7328


[ROCm/clr commit: f98dcf9d7f]
2023-02-17 00:48:13 -05:00
kjayapra-amd 53073c4657 SWDEV-376697 - Use PCIE fine grain memory pool when hipDeviceMallocUncached flag is used.
Change-Id: I7234d456ef2df42b0b9b9e0d2647ee9bded565f9


[ROCm/clr commit: 6b873b8a86]
2023-02-16 14:05:50 -05:00
Maneesh Gupta d7fdd9fcb8 SWDEV-368235 - Revert "Remove obsolete env variables"
This reverts commit dfa7790030.

Reason for revert: Deferred to a future release.

Change-Id: Ia66c37f0ab9734dee73c930d10d7469d5fd57254


[ROCm/clr commit: 5dc104b3ea]
2023-02-15 07:25:00 +00:00
Anusha GodavarthySurya 24eec94928 SWDEV-380035 - Check for agent and ptr match for hsa LOCKED ptr
Change-Id: I2503aa05512aebc3535963e188ca8d1dbfab08f0


[ROCm/clr commit: fa35239b4b]
2023-02-15 00:12:42 -05:00
Saleel Kudchadker a314419f7a SWDEV-301667 - Refactor code
Change-Id: I8f20d994d88acb14f392eaa9d5cd14620667d7f6


[ROCm/clr commit: 695f169ed0]
2023-02-13 14:58:17 -08:00
David Yat Sin b8226e4292 SWDEV-365908 - Do not align mem size for IPC
Remove alignment to granularity for IPC handles as ROCr has a patch that
will internally validate pointer sizes against requested size during
allocation instead of size aligned to page size. This patch is needed
together with this patch from ROCr:
f8a42a3a:Use user requested size for memory fragments

Change-Id: I28b25558ea03c836b44fafdb34b7330cf6887424


[ROCm/clr commit: fa1b7925cf]
2023-02-13 17:32:02 -05:00
Jeremy Newton 2103c97868 SWDEV-1 - device: Add missing include
Newer GCC's seem to require this.

Change-Id: I85926d4fa552b772f2eb9f8ede7863a546c47f54
Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>


[ROCm/clr commit: 70bdb7a597]
2023-02-09 14:57:14 -05:00
Jacob Lambert c013a1c39b SWDEV-376413 - Revert "SWDEV-376413 - Replace deprecated Comgr device-lib action"
This reverts commit 8da846db0a.

Reason for revert: Test failures with Luxmark, blender, and Indigobench. Need to investigate before re-applying

Change-Id: I6b08273a8f9c8bcaa4e7a06cd42d15048e52ca2a


[ROCm/clr commit: 5168485d23]
2023-02-09 10:02:47 -05:00
German Andryeyev b180effdb6 SWDEV-381633 - Use blit manager on app's queue
Heap initialization used device queue, but it shoudl be used for
cooperative launches only. Heap initialization must use the same queue
as the current dispatch.

Change-Id: I856621bf82bbdeb1c2d0fbc4970e90d09af805cb


[ROCm/clr commit: 67af16bdf3]
2023-02-09 09:43:13 -05:00
Saleel Kudchadker 95e07af803 SWDEV-381633 - Better log
Change-Id: Ie151d73aa4b1dae7d0d9acd0457e7dbdf35f21ee


[ROCm/clr commit: 7619b53e9b]
2023-02-08 17:54:11 -05:00
jatang 43e9497462 SWDEV-380792 - Fix floating point exception when maxEngineClockFrequency_ is 0
Change-Id: Ic443ceae586c4c84995ed2abef9bd7f32f8b60f9


[ROCm/clr commit: b798c85272]
2023-02-07 11:43:10 -05:00
kjayapra-amd 4cdfa88971 SWDEV-378648 - Adding checks in runtime to abort when bad/invalid payload is sent.
Change-Id: Ibaa7927bacef1ba067ded5ccbf3f1111f31200a2


[ROCm/clr commit: 297223a763]
2023-02-06 10:37:29 -05:00
German dfa7790030 SWDEV-368235 - Remove obsolete env variables
Change-Id: I7e14d53297e79e2f68b3a6cc40251ad7db9eb5ab


[ROCm/clr commit: 7b50c935f8]
2023-02-03 13:44:24 -05:00
Ranjith Ramakrishnan 87f7e9ff0a SWDEV-366831 - Correct the include path for new directory layout
Change-Id: I7c826ed9c2f2d839d350e5150f578830655616f0


[ROCm/clr commit: 689425433f]
2023-02-02 03:19:47 -05:00
German f1acdf6db3 SWDEV-352197 - Use static VM ID for capture
Use static VM ID if available for capture.
Add a delay in RGP trace finish to help RGP server to complete
file operations.

Change-Id: Id0dab2fe4398ac2df79f25608fdd06b1f84e7fe0


[ROCm/clr commit: 7b4de0df0f]
2023-02-01 11:46:10 -05:00
David Yat Sin 904d3fd3ba SWDEV-380258 - Fix invalid iterator after erase
Fix rare segfault due to invalid iterator after erase

Change-Id: Id5b54d6cf10075deff0d613fec12af249c6c55a3


[ROCm/clr commit: 08d72c4f98]
2023-01-31 17:46:15 +00:00
German f857dcc48d SWDEV-352197 - Destroy virtual device in thread destructor
Windows kills threads on exit without any notification. However,
runtime can still destroy VirtualGPU object from the host thread with
HostQueue destruction.
This change also forces RGP trace transfer on the last capture without
any delays.

Change-Id: I768e87e99e1d23a021e63c12f36e450817743759


[ROCm/clr commit: ad33a021cb]
2023-01-31 10:53:48 -05:00
Sourabh Betigeri ceca882cf3 SWDEV-340649 - Removes calls to commitMemory in hmm path
Change-Id: I8d381b4c3f5cf95628487e0d10ae643443c9709d


[ROCm/clr commit: 2388f61705]
2023-01-27 13:15:23 -05:00
Jiabao Xie 7b13a338ac SWDEV-366886 - Revert "SWDEV-366886 - force svm alloc for rocm"
This reverts commit 7a5c07bf4e.

Reason for revert: performance drop in Quicksilver app

Change-Id: I2bdf42ad0a235a74e2bb4d38f86471e9affbd7a6


[ROCm/clr commit: 3e88081961]
2023-01-25 15:54:53 -05:00
German Andryeyev 45ed09d0cb SWDEV-372790 - Copy AQL packet from runtime setup
Scheduler in device queue requires relaunching itself. Make sure
scheduler uses exactly the same AQL packet as the host launch.

Change-Id: I4eb03c4c91bf2408a6d4607731f081a2e2c2c8ae


[ROCm/clr commit: b23c759746]
2023-01-24 10:25:45 -05:00
Jaydeep Patel 1884cc401c SWDEV-378157 - Correct log message
Change-Id: I6297693f67ae78a8874b976ac03353a81b728b1d


[ROCm/clr commit: 1e4a4162ff]
2023-01-23 12:06:18 -05:00
German 6eec7a361e SWDEV-377991 - Remove liquidflash support
Remove amdgpu-pro interface for persistent memory,
used in Liquidflash

Change-Id: I7d1720ad0875a62ebb2d7f96cba39601d560a5df


[ROCm/clr commit: 6dad2fc306]
2023-01-23 10:40:57 -05:00
kjayapra-amd b4ffe0e810 SWDEV-378006 - Adding a new guarantee macro to support printing args.
Change-Id: I9c838644e31a84d96a44b2bd10525a08d805a047


[ROCm/clr commit: b968394b4e]
2023-01-21 06:26:50 -05:00
Jacob Lambert 8da846db0a SWDEV-376413 - Replace deprecated Comgr device-lib action
The Comgr ADD_DEVICE_LIBRARIES action has been deprecated. In place
of the previous two-action approach:

    AMD_COMGR_COMPILE_SOURCE_TO_BC
    AMD_COMGR_ADD_DEVICE_LIBRARIES

We can now use a single combined action:

    AMD_COMGR_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC

This new action more closely alings with how device library
management is done by the clang driver.

Change-Id: Id844e9031a1896dedeacec453440b9babc4b111a


[ROCm/clr commit: 0969056f66]
2023-01-20 15:52:00 -05:00
German b5b078e036 SWDEV-377991 - Remove liquidflash support
Change-Id: Iba6455e5c0210c3223a06fec332404cd9f489154


[ROCm/clr commit: 53a10c9039]
2023-01-20 09:57:06 -05:00
Anusha GodavarthySurya f14b3d669b SWDEV-371123 - Fix seg fault when running hashcat app
Change-Id: I0c66d881b8dfae322f58a644860ecce4fb18debd


[ROCm/clr commit: 89e9f9db58]
2023-01-19 15:50:03 -05:00
Xie,AlexBin 2483d3a0d8 SWDEV-365305 - Same time is observed for CU Med-Priority tests
OCL runtime uses WGP mode and total CU count reported in WGP.
Realtime values are still in CUs. That can mislead in the test results.
Report realtime in WGP values and convert to CUs for KMD.

Change-Id: I90b82615640734dd655be2b613ccac3cb8483239


[ROCm/clr commit: 0703b8380b]
2023-01-19 11:36:34 -05:00
jiabaxie 7a5c07bf4e SWDEV-366886 - force svm alloc for rocm
Change-Id: If85a6aaeb5861ff1550a0bc3f0a25073ff8145e7


[ROCm/clr commit: 8278e86918]
2023-01-18 16:26:34 -05:00
German 2143e64c23 SWDEV-377991 - Remove Liquidflash extension
Initial check-in to untie dependencies with HIP and OCL repos

Change-Id: I363b63954c3f118f40a6ed893545d6a4ac44144c


[ROCm/clr commit: c8927cd84e]
2023-01-18 13:16:20 -05:00
Alex Xie ebefe9c576 SWDEV-374668 - Observed one subtest failure in ocltst32
Don't force sysmem allocation

Change-Id: I792f0da231c6e8058f1bfb81ba1f88ecb59b7c8e


[ROCm/clr commit: 60d413a5b9]
2023-01-18 12:02:27 -05:00
Anusha GodavarthySurya 6ae2298d06 SWDEV-373173 - Correct max VGPRs and VGPR Granularity in Occupancy calculation for different asics
Change-Id: I6f595428ed31733cdc04e65e7c3e383f454ab72b


[ROCm/clr commit: 2b50636809]
2023-01-18 00:22:02 -05:00
Tao Sang 339bb6a7de SWDEV-377423 - Fix kernel attribute missing
Fix missing issue of kernel attributes including vec_type_hint,
work_group_size_hint and reqd_work_group_size.
Make WorkGroupInfo's meta attributes initialized before other parameters
are initialized.
This way workGroupInfo_'s compileSizeHint_, compileSize_ and
compileVecTypeHint_ will be valid when they are used to create kernel
signature in Kernel::createSignature().
Fix a typo of ".workgorup_size_hint".

Change-Id: I4a1ede2210a25596ad7a935cd4debb896e0147f8


[ROCm/clr commit: cb30ce4e06]
2023-01-17 14:50:35 -05:00
Jiabao Xie b6d1602da0 SWDEV-366886 - force alloc from svm
Change-Id: I6a89aa46d944832e59491bb96ba3669e5031b636


[ROCm/clr commit: 6c44353107]
2023-01-17 12:12:27 -05:00
Anusha GodavarthySurya 5b79a926e3 SWDEV-373173 - Add kernel metadata for WGP mode
Change-Id: Ic270e90c46938b975513ff2bc19b7bb6b9485f9d


[ROCm/clr commit: 0bd0c29b7d]
2023-01-17 10:51:22 -05:00
German Andryeyev 8ad3120e25 SWDEV-355281 - Add offset calculation
Calculate memory location offset for requested memory

Change-Id: I7919523df1790d9eaad5827ee5bd98e4263a7554


[ROCm/clr commit: 5d83345c20]
2023-01-16 14:19:40 -05:00
Saleel Kudchadker 772def2cd1 SWDEV-345213 - Fix staged line-by-line copy path
- Address an old bug in offset calculation that was causing out of bound
access.
- Improve logging

Change-Id: Iebdf34dddaa5e987cc72184a2152918adc6a96e0


[ROCm/clr commit: 033d4c0463]
2023-01-16 11:04:30 -05:00
Juan Manuel MARTINEZ CAAMAÑO 16a5bfd654 SWDEV-287018 - Remove requiredDump argument from Program::linkLLVMBitcode
Weirdly, the `requiredDump` argument to linkLLVMBitcode was used to enable/disable
the keeping temporary bytecode files (those generated by -save-temps=all) after linking.

This patch removes this argument as there is no obvious benefit from keepeing it
(the user would only rely on -save-temps=all to control this).

Change-Id: I0c00486f95eb1d4e296b5247c488407c47f0b2d9


[ROCm/clr commit: 8ab3fd58cf]
2023-01-16 03:34:21 -05:00
Anusha GodavarthySurya e8c8fd8c3f SWDEV-374778 - Select SDMA path when HSA_XNACK is enabled
Change-Id: I052675186238eb24b910a0a558d6b8ede36d1413


[ROCm/clr commit: 710749c291]
2023-01-12 23:34:21 -05:00
Ioannis Assiouras ab81da6544 SWDEV-374401 - Surface the ammount of used constant memory by kernel
Change-Id: I6de0e46482f27b9068582fdaee0e562f9f71f9f0


[ROCm/clr commit: 4d49204fb9]
2023-01-12 05:22:37 -05:00
Saleel Kudchadker f903a6c2c9 SWDEV-371123 - Fix barrier value packet header
- Use correct header for vendor packet
- Pass one dependent signal when submitting a marker if there is one

Change-Id: I4efc70dd5204b559de26f899d0637f50421c8834


[ROCm/clr commit: 77ceb7e9ad]
2023-01-12 04:06:03 -05:00
jatang 1f5f1c8708 SWDEV-287018 - Only generate _optimized.bc when both requiredDump and DUMP_BC_LINKED are true
The current code generates a _optimized.bc regardlessly, so put back the original logic.

Change-Id: I3f84d10934b3e983f5f828af8d0943449a6e1d94


[ROCm/clr commit: 6647882773]
2023-01-11 17:51:35 -05:00
Anusha GodavarthySurya 379781ea65 SWDEV-364576 - initialize device malloc heap state using blit kernel
Change-Id: I5d0172aff7d2c04b322a4d828b8a2b438158b80f


[ROCm/clr commit: 274f2de391]
2023-01-07 06:53:53 +00:00
Saleel Kudchadker 4a92208bb7 SWDEV-371123 - Fix typo for log print
Change-Id: I18297a032d6fc9a030863eac7c525e86e9fdcd29


[ROCm/clr commit: 6651aab28d]
2023-01-05 17:46:22 -05:00
jatang fca7b357b8 SWDEV-372791 - Default UniformWorkGroupSize to true for CL1.x
Change-Id: If03396b5a7a3a69e05fdb4c43791a0d84d9f4127


[ROCm/clr commit: 05a8eaaf0f]
2022-12-28 12:59:08 -05:00
Jaydeep Patel f1eae835e3 SWDEV-374370 - Propogate element size to blit kernel.
Change-Id: I06d1ae6feebd238e9a63c617eb4c4dcf485d9ee0


[ROCm/clr commit: 070ae4e6d4]
2022-12-26 09:33:50 +00:00
Jaydeep Patel 7df45ffc38 SWDEV-366087 - Pass pitch and slice pitch to blit kernel from rect struct.
Change-Id: I1ffe54929db59a40e2a1ae19c125f8d8e81b07ec


[ROCm/clr commit: 9076d9a518]
2022-12-20 16:43:49 +00:00
Saleel Kudchadker ed4c04b150 SWDEV-373334 - Use copyMetadata for blit decisions
- Check isAsync flag for small host copies on large bar as it synchronizes
- Use CopyEngine Preference hint if HMM is enabled.

Change-Id: I1ffc4b2604ed03cf5979cdc454178648c5ae5cba


[ROCm/clr commit: e0384f9f6b]
2022-12-15 17:09:02 -05:00
Jacob Lambert 87e6e1357b SWDEV-356171 - Adding new Comgr mangled name fetching APIs
amd::Comgr::populate_mangled_names()
  amd::Comgr::get_mangled_name()

Change-Id: Ie6ebf3aae76632f7e7cfef3c90642b2e3cd10b48


[ROCm/clr commit: 50d77d17fd]
2022-12-14 12:40:18 -05:00