Commit Graph

37726 Commits

Author SHA1 Message Date
ywang103-amd bb0c417871 fix broken test with --cols options (#750) 2025-06-12 19:45:24 -04:00
Arif, Maisam 9002bcc5a8 Revert "SWDEV-534264 - Add liboam.a to static package"
This reverts commit ae9bcb11e1.


[ROCm/rocm_smi_lib commit: 5cc6c1ca1c]
2025-06-12 16:26:19 -05:00
Arif, Maisam 5cc6c1ca1c Revert "SWDEV-534264 - Add liboam.a to static package"
This reverts commit ff7561607e.
2025-06-12 16:26:19 -05:00
jamessiddeley-amd 05aba003c9 Fix: Add explicit includes for assert.h and thread in sample files (#751)
* Fix: Add explicit includes for assert.h and thread in sample/vcopy.cpp

The HIP/CLR change e3cb5399c removed transitive inclusion  
of standard headers like assert.h from hip_runtime.h.  
This caused build failures in rocprof-compute samples.  

This commit explicitly includes <assert.h> and <thread>  
in vcopy.cpp to resolve potential missing definitions.  


Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vsequential_access.cpp

Added assert and thread imports

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vrandom_access.cpp

Added assert import

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vsequential_access.cpp

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

[ROCm/rocprofiler-compute commit: 667128e3c7]
2025-06-12 17:03:48 -04:00
jamessiddeley-amd 667128e3c7 Fix: Add explicit includes for assert.h and thread in sample files (#751)
* Fix: Add explicit includes for assert.h and thread in sample/vcopy.cpp

The HIP/CLR change e3cb5399c removed transitive inclusion  
of standard headers like assert.h from hip_runtime.h.  
This caused build failures in rocprof-compute samples.  

This commit explicitly includes <assert.h> and <thread>  
in vcopy.cpp to resolve potential missing definitions.  


Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vsequential_access.cpp

Added assert and thread imports

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vrandom_access.cpp

Added assert import

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* Update vsequential_access.cpp

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
2025-06-12 17:03:48 -04:00
Jason Bonnell fe985ec077 add pull_request_template.md (#237)
* add pull_request_template.md

* Update .github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* fix markdown linting errors

* Update .github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* moved pull_request_template.md to base /.github/ directory

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: da326048b9]
2025-06-12 16:13:48 -04:00
Jason Bonnell da326048b9 add pull_request_template.md (#237)
* add pull_request_template.md

* Update .github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* fix markdown linting errors

* Update .github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

* moved pull_request_template.md to base /.github/ directory

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-06-12 16:13:48 -04:00
Vignesh Edithal 696c1407af Bugfix for PR #744
[ROCm/rocprofiler-compute commit: 6054b3b7fd]
2025-06-12 16:09:15 -04:00
Vignesh Edithal 6054b3b7fd Bugfix for PR #744 2025-06-12 16:09:15 -04:00
vedithal-amd 89bc1fc812 Change default rocprof to rocprofv3 (#748)
* Revert of https://github.com/ROCm/rocprofiler-compute/pull/738

* Change default rocprof backend interface to rocprofv3

* Add MI 350 support in documentation

* Added known issue that MI 100 profiling will not work unless rocprofv1
  is explicitly opted in

* Remove MI 50 soc gfx python class since MI 50 is not supported

[ROCm/rocprofiler-compute commit: d27ee69b52]
2025-06-12 15:45:11 -04:00
vedithal-amd d27ee69b52 Change default rocprof to rocprofv3 (#748)
* Revert of https://github.com/ROCm/rocprofiler-compute/pull/738

* Change default rocprof backend interface to rocprofv3

* Add MI 350 support in documentation

* Added known issue that MI 100 profiling will not work unless rocprofv1
  is explicitly opted in

* Remove MI 50 soc gfx python class since MI 50 is not supported
2025-06-12 15:45:11 -04:00
David Yat Sin 3c0af843e3 rocr: Remove scratch_backing_memory_byte_size
scratch_backing_memory_byte_size was originally removed, and then put
back in 02b38d0614. This was because it
was used by rocgdb. rocgdb code has been updated to not use this field.
Bumped _amdgpu_r_debug for the ABI change.
2025-06-12 15:33:47 -04:00
vedithal-amd 9e743cdff2 Remove rocscope related code and add deprecation warning for mongo db usecase (#744)
* Remove rocscope related code

* Add deprecation warning for database update mode which is used for grafana and mongodb functionality

[ROCm/rocprofiler-compute commit: cdd41dee40]
2025-06-12 14:21:24 -04:00
vedithal-amd cdd41dee40 Remove rocscope related code and add deprecation warning for mongo db usecase (#744)
* Remove rocscope related code

* Add deprecation warning for database update mode which is used for grafana and mongodb functionality
2025-06-12 14:21:24 -04:00
Verma, Saurabh bb4cec5816 Readme update for open-sourcing (#84)
* Initial commit

Change-Id: I24703941cda0d009f1eb4dac8846195fac9ebb24

* Updated "Supported Architectures and Counter Blocks"

Change-Id: Ia7cdc46d4623d7a6664550ee4e0ab9425a3ac52f

* Added HSA links

Change-Id: Id506362f6d913dc94943a6ee047e25c00cf85f53

* addressing review comments

Change-Id: Iec35efc55e49f5b9c57c2de455fbef2afed80a77

* Minor change

Change-Id: I0bfdc774dcc42aa01b2f3dfc24d97cf301e364d7

* minor update

Change-Id: I970d5fa416a1c3e4c3fc37dde5269a37f02a4c60

[ROCm/aqlprofile commit: d046917427]
2025-06-12 22:07:03 +05:30
Verma, Saurabh d046917427 Readme update for open-sourcing (#84)
* Initial commit

Change-Id: I24703941cda0d009f1eb4dac8846195fac9ebb24

* Updated "Supported Architectures and Counter Blocks"

Change-Id: Ia7cdc46d4623d7a6664550ee4e0ab9425a3ac52f

* Added HSA links

Change-Id: Id506362f6d913dc94943a6ee047e25c00cf85f53

* addressing review comments

Change-Id: Iec35efc55e49f5b9c57c2de455fbef2afed80a77

* Minor change

Change-Id: I0bfdc774dcc42aa01b2f3dfc24d97cf301e364d7

* minor update

Change-Id: I970d5fa416a1c3e4c3fc37dde5269a37f02a4c60
2025-06-12 22:07:03 +05:30
David Galiffi a153c96c7b Copyright Header Compliance (#745)
- for SWDEV-537492

[ROCm/rocprofiler-compute commit: 1cd989a110]
2025-06-12 12:02:58 -04:00
David Galiffi 1cd989a110 Copyright Header Compliance (#745)
- for SWDEV-537492
2025-06-12 12:02:58 -04:00
Trowbridge, Ian 4f7d6d7f1c Removed roc_video_dec files due to reoccurring errors (#439)
* Removed roc_video_dec files due to reoccurring errors

* Added back rocDecCreateVideoParser

* Fix remaining errors with rocdecode.cpp

[ROCm/rocprofiler-sdk commit: 72b97a8b7e]
2025-06-12 10:49:08 -05:00
Trowbridge, Ian 72b97a8b7e Removed roc_video_dec files due to reoccurring errors (#439)
* Removed roc_video_dec files due to reoccurring errors

* Added back rocDecCreateVideoParser

* Fix remaining errors with rocdecode.cpp
2025-06-12 10:49:08 -05:00
Elwazir, Ammar bc2aad6cca Changing the Github Runner Sets (#446)
* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

[ROCm/rocprofiler-sdk commit: 5c6b03801d]
2025-06-12 10:32:01 -05:00
Elwazir, Ammar 5c6b03801d Changing the Github Runner Sets (#446)
* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml
2025-06-12 10:32:01 -05:00
David Yat Sin 17b8f9b24d cmake: Remove unused file 2025-06-12 10:38:58 -04:00
David Yat Sin 24ce840732 rocr: Remove support for Kaveri GPUs
Kaveri GPUs are EoL
2025-06-12 10:38:58 -04:00
David Yat Sin 96d0f07b15 rocr: Fix compile warning when using clang 2025-06-12 10:38:58 -04:00
jamessiddeley-amd 218d77b88f fixed long kernel names cut off in --kernel-names option (#728)
* reformatted kernel roofline PDF to use table

* restored kernel symbol icons

* enhance code readability

* restored cell text wrap

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

[ROCm/rocprofiler-compute commit: f004aeebe9]
2025-06-12 10:23:40 -04:00
jamessiddeley-amd f004aeebe9 fixed long kernel names cut off in --kernel-names option (#728)
* reformatted kernel roofline PDF to use table

* restored kernel symbol icons

* enhance code readability

* restored cell text wrap

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
2025-06-12 10:23:40 -04:00
jamessiddeley-amd 2b60d10e49 increased utils.py code coverage to ~84% (#742)
* code coverage file cover: utils.py

* added code coverage 82% for utils.py

* reverted unused_code rebase

[ROCm/rocprofiler-compute commit: 97dad3f7f1]
2025-06-12 10:21:40 -04:00
jamessiddeley-amd 97dad3f7f1 increased utils.py code coverage to ~84% (#742)
* code coverage file cover: utils.py

* added code coverage 82% for utils.py

* reverted unused_code rebase
2025-06-12 10:21:40 -04:00
David Galiffi 8a241f46e1 Updated Dockerfile.ubuntu (#245)
Using miniforge instead of miniconda

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 877fa671cc]
2025-06-12 10:19:01 -04:00
David Galiffi 877fa671cc Updated Dockerfile.ubuntu (#245)
Using miniforge instead of miniconda

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-12 10:19:01 -04:00
David Galiffi 45605cf645 SWDEV-525474 - Fixed CMake 4 configuration error (#244)
Update Timemory / GOTCHA modules

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: d9381c3e0a]
2025-06-12 10:14:55 -04:00
David Galiffi d9381c3e0a SWDEV-525474 - Fixed CMake 4 configuration error (#244)
Update Timemory / GOTCHA modules

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-12 10:14:55 -04:00
Bhardwaj, Gopesh 4117f4de75 Adding tests for code coverage (#82)
* Adding tests for code coverage

* integration tests

* Fixing gtest dependencies

* Removing gmock linkage

* build fixes

* Fixing Analyze job

* CMake updates

* Fixing PSDB

* Addressing feedback

* Adding licenses

* Addressing feedback

* updating dashboard

* more API tests

* Addressing feedback

* correcting Macro

* preloading libintercept

[ROCm/aqlprofile commit: eca6739e13]
2025-06-12 19:13:44 +05:30
Bhardwaj, Gopesh eca6739e13 Adding tests for code coverage (#82)
* Adding tests for code coverage

* integration tests

* Fixing gtest dependencies

* Removing gmock linkage

* build fixes

* Fixing Analyze job

* CMake updates

* Fixing PSDB

* Addressing feedback

* Adding licenses

* Addressing feedback

* updating dashboard

* more API tests

* Addressing feedback

* correcting Macro

* preloading libintercept
2025-06-12 19:13:44 +05:30
David Yat Sin 26ddb37bd1 Remove unnecessary dependency on hsakmt
[ROCm/aqlprofile commit: ed7a2104ef]
2025-06-12 09:36:19 -04:00
David Yat Sin ed7a2104ef Remove unnecessary dependency on hsakmt 2025-06-12 09:36:19 -04:00
Hernandez, Gerardo 0877d257e6 SWDEV-510589 - fix libgcc1 dependency on Debian 10 (#252)
* fix libgcc1 should added to HIP_RUNTIME_DEB_STDPKG_DEPENDENCIES and not HIP_RUNTIME_RPM_STDPKG_DEPENDENCIES
* add libgcc1 and not libgcc_s1 also to HIP_RUNTIME_RPM_STDPKG_DEPENDENCIES as it seems rpms are also generated when compiling on Debian
2025-06-12 14:22:28 +05:30
Sang, Tao 67f6409eb1 SWDEV-519446 - Part 1: update normal atomic function file header (#345)
Remove the scope of __has_builtin(__hip_atomic_compare_exchange_strong) == false
2025-06-12 09:16:51 +05:30
Pranjal Swarup 8a2ac0ae71 Change docker scripts to use miniforge instead of miniconda (#242)
[ROCm/rocprofiler-systems commit: c00070ddbf]
2025-06-11 23:43:34 -04:00
Pranjal Swarup c00070ddbf Change docker scripts to use miniforge instead of miniconda (#242) 2025-06-11 23:43:34 -04:00
Alysa Liu 77b86ca908 rocr: Prevent int overflow in arithmetic operation
Cast range->x and range->y to uint64_t before performing multiplication

Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>
2025-06-11 19:36:36 -04:00
David Yat Sin df5d66eae5 rocr: document pseudo-code for scratch reclaim
Document CP FW and ROCr pseudo-code for asynchronous reclaim.
No code change.
2025-06-11 16:19:59 -04:00
David Galiffi db21150ab0 Fix OpenMP-Target ctest (#241)
Test is missing from rocm-7.0 stack because of a HIP version check.
In these builds, hip_version.h is still reporting 6.5.0.
This check was originally put in to skip the test on older versions
of ROCm, which should no longer be required

- For SWDEV-537718

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 28bee27253]
2025-06-11 16:00:48 -04:00
David Galiffi 28bee27253 Fix OpenMP-Target ctest (#241)
Test is missing from rocm-7.0 stack because of a HIP version check.
In these builds, hip_version.h is still reporting 6.5.0.
This check was originally put in to skip the test on older versions
of ROCm, which should no longer be required

- For SWDEV-537718

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-11 16:00:48 -04:00
cfallows-amd 56f38e3b60 Add roofline cli_generate_plot method (#737)
Add option to print out roofline plot in terminal using plotext.
Takes in one datatype and returns the str from plot.build() which contains the visual plot of roofline analysis for said datatype.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 0415bb9740]
2025-06-11 15:38:21 -04:00
cfallows-amd 0415bb9740 Add roofline cli_generate_plot method (#737)
Add option to print out roofline plot in terminal using plotext.
Takes in one datatype and returns the str from plot.build() which contains the visual plot of roofline analysis for said datatype.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-06-11 15:38:21 -04:00
Ranjith Ramakrishnan ae9bcb11e1 SWDEV-534264 - Add liboam.a to static package
liboam.a was missing in static package. The library is gettting created but not packaged.
Fixed the same


[ROCm/rocm_smi_lib commit: ff7561607e]
2025-06-11 13:45:21 -05:00
Ranjith Ramakrishnan ff7561607e SWDEV-534264 - Add liboam.a to static package
liboam.a was missing in static package. The library is gettting created but not packaged.
Fixed the same
2025-06-11 13:45:21 -05:00
Sang, Tao ec8ff45a1d SWDEV-514141 - Fix zero clock rate issues (#4)
1.Remove clock functions from some tests that don't need them.
2.In some memory pool tests and coherency tests, timer-based kernel
delay isn't reliable, use pinned host based notification instead.
3.Add CHECK_PCIE_ATOMICS_SUPPORT before some tests.
4.catch/unit/memory/hipMemoryAllocateCoherent.cc is removed
as it is useless and originally excluded in building.
5.Some tests can still pass even if clock rate =0, thus they
  will be kept as is.
6.Some logic and format improvement in some tests.

Change-Id: I6b3c6bf54c61cffd45cd6f17c75998f751b75725
2025-06-11 21:11:25 +05:30