Commit Graph

37726 Commits

Author SHA1 Message Date
jamesxu2 6f22b2d2e5 Change Perfetto Source to Github (#373)
- Current Perfetto source repo is from android.googlesource
        which is censored in China and causes an infinite
        hang when building Omnitrace
- This commit changes the Perfetto source repo to Github which acts
        as a read-only mirror to the googlesource perfetto
        repo.

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2024-09-13 15:59:27 -04:00
Ranjith Ramakrishnan 4d0b815d06 SWDEV-437189 - Provide option to enable/disable CPACK_SET_DESTDIR
The variable is already set as cache, so that user can override.
But the hard coded setting is preventing override. Removed the same

Change-Id: I2aecc18ce4f1d1b523ba267ef1c8ef4ea1168d9c
2024-09-13 15:49:53 -04:00
Rahul Manocha eb1089593e SWDEV-480536 - Disable cpu wait in device synchronize
1) currently cpu wait is set to true, which makes the host wait for last
command in queue to finish even if the kernel execution has already
finished causing delay in device sync call.
2) device sync only needs to await completion when hw event
is not ready.


Change-Id: I91e3e89d39a1193ae06abac822cea8ae651493a5
2024-09-13 15:31:32 -04:00
Marko Arandjelovic a34ae6c8fc SWDEV-461791 - Enable Unit_hipPointerSetAttribute_Positive_SyncMemops
Change-Id: I9be8fb4622d60d9f05d3601eeccc5f6e0687a3e3
2024-09-13 14:49:36 -04:00
venkat1361 b9d2b3f495 SWDEV-476852 - Check added for agent architecture counters support. (#1022)
* check added for agent arch support

* formatting issue

[ROCm/rocprofiler-sdk commit: bc82eccf4f]
2024-09-13 11:28:00 -07:00
venkat1361 bc82eccf4f SWDEV-476852 - Check added for agent architecture counters support. (#1022)
* check added for agent arch support

* formatting issue
2024-09-13 11:28:00 -07:00
Ajay c9955a1cea SWDEV-465215 - hipFuncSetAttribute hipFuncGetAttributes fixes
Change-Id: I2151e4470d63918ff6b809a8fdeaae5bea5cc899
2024-09-13 14:05:25 -04:00
ajanicijamd 218f8bcbea Update Perfetto and fix tests (#378)
Fix for "SWDEV-479652" - Perfetto-based tests are failing.

Updated version of perfetto submodule to v46.0.
Modified Omnitrace code that uses Perfetto, so it can compile.
Modified the testing code, so it can run the version of trace_processor_shell provided (v46.0).

---------

Signed-off-by: Aleksandar Janicijevic <Aleksandar.Janicijevic@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 96d7b8f0ab]
2024-09-13 13:43:26 -04:00
ajanicijamd 96d7b8f0ab Update Perfetto and fix tests (#378)
Fix for "SWDEV-479652" - Perfetto-based tests are failing.

Updated version of perfetto submodule to v46.0.
Modified Omnitrace code that uses Perfetto, so it can compile.
Modified the testing code, so it can run the version of trace_processor_shell provided (v46.0).

---------

Signed-off-by: Aleksandar Janicijevic <Aleksandar.Janicijevic@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2024-09-13 13:43:26 -04:00
Galantsev, Dmitrii 660c5afaf4 Disable RVS as the error scares people
Change-Id: I572fdb65dd8882ab4fdc1474cb39fc0e493b1eab
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-09-13 10:42:59 -05:00
Galantsev, Dmitrii f3450f61bf Disable RVS as the error scares people
Change-Id: I572fdb65dd8882ab4fdc1474cb39fc0e493b1eab
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rdc commit: 660c5afaf4]
2024-09-13 10:42:59 -05:00
Branislav Brzak 3e945b10f1 SWDEV-441279 - Add hipMemsetD8Async test
Change-Id: Ibcdb2098c45db440c79151b4d7dad6734b16222a
2024-09-13 17:30:26 +02:00
Marko Arandjelovic ad5b55a2c4 SWDEV-465204 - Fix Unit_hipModuleLaunchKernel_Negative_Parameters
Change-Id: I754d1835366f131f44d56da05ac24bc152cbfa47
2024-09-13 10:56:33 -04:00
Marko Arandjelovic 27be56f329 SWDEV-454659 - Correct test setup, Unit_hipGraphExecMemcpyNodeSetParams_Negative_Parameters
Pitch cannot be lower then width

Change-Id: Ib42f036f1158b500ce8892643178469a2ec7dc88
2024-09-13 10:48:14 -04:00
Zhang Ava 9316bae9d8 Merge amd-staging into amd-master 20240911
Signed-off-by: Zhang Ava <niandong.zhang@amd.com>
Change-Id: Iaa1be5b9c6eb4c205ced9d610feada93ad28aa50


[ROCm/rocm_smi_lib commit: 743bd50aa5]
2024-09-13 18:31:57 +08:00
Zhang Ava 743bd50aa5 Merge amd-staging into amd-master 20240911
Signed-off-by: Zhang Ava <niandong.zhang@amd.com>
Change-Id: Iaa1be5b9c6eb4c205ced9d610feada93ad28aa50
2024-09-13 18:31:57 +08:00
Marko Arandjelovic 850511cc28 SWDEV-465196 - Fix coalesced_group tests
Change-Id: I4537e2351273d0c71ff62d34b5002fcb2ecd15e6
2024-09-13 04:29:02 -04:00
Jonathan R. Madsen 5db64b5425 Fix OTF2 build dependency (#1080)
- systems with many cores (e.g. 128) had a race condition between compiling generateOTF2.cpp and the otf2-build make install step

[ROCm/rocprofiler-sdk commit: 92c0c9d252]
2024-09-13 03:16:06 -05:00
Jonathan R. Madsen 92c0c9d252 Fix OTF2 build dependency (#1080)
- systems with many cores (e.g. 128) had a race condition between compiling generateOTF2.cpp and the otf2-build make install step
2024-09-13 03:16:06 -05:00
itrowbri 6099e623a4 SWDEV-483130: Replace calls to deprecated functions hipHostMalloc/hipHostFree (#1070)
* SWDEV-483130: Replace calls to deprecated functions hipHostMalloc/hipHostFree

* SWDEV-483130: Replace calls to deprecated functions hipHostMalloc/hipHostFree. Moved definitions from lib/commons/defines.hpp to samples/common/defines.hpp and tests/common/defines.hpp

* Updated comment for clarity

* Update tests/rocprofv3/aborted-app/validate.py

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Formatting

* Formatting

* Updated CHANGELOG

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: 8d7be2e4b4]
2024-09-12 18:31:00 -05:00
itrowbri 8d7be2e4b4 SWDEV-483130: Replace calls to deprecated functions hipHostMalloc/hipHostFree (#1070)
* SWDEV-483130: Replace calls to deprecated functions hipHostMalloc/hipHostFree

* SWDEV-483130: Replace calls to deprecated functions hipHostMalloc/hipHostFree. Moved definitions from lib/commons/defines.hpp to samples/common/defines.hpp and tests/common/defines.hpp

* Updated comment for clarity

* Update tests/rocprofv3/aborted-app/validate.py

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Formatting

* Formatting

* Updated CHANGELOG

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-09-12 18:31:00 -05:00
Mythreya d008463d50 Enable queue interception with scratch reporting (#1069)
* Enable queue interception with scratch reporting

Scratch reporting reports agent ID in buffer and callback records, but
HSA runtime provides only queue ID in the scratch callback.

This change enables queue interception when scratch reporting is requested

* Validation test for rocprofv3 + scratch-memory-trace

* Simplify checks for whether context is tracing a domain

* Update changelog

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: efbe4ea0a2]
2024-09-12 18:26:34 -05:00
Mythreya efbe4ea0a2 Enable queue interception with scratch reporting (#1069)
* Enable queue interception with scratch reporting

Scratch reporting reports agent ID in buffer and callback records, but
HSA runtime provides only queue ID in the scratch callback.

This change enables queue interception when scratch reporting is requested

* Validation test for rocprofv3 + scratch-memory-trace

* Simplify checks for whether context is tracing a domain

* Update changelog

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2024-09-12 18:26:34 -05:00
Jonathan R. Madsen db0f26f562 Prevent misaligned read from common::container::ring_buffer (#1076)
- causes undefined behavior

[ROCm/rocprofiler-sdk commit: 6098d52335]
2024-09-12 18:25:05 -05:00
Jonathan R. Madsen 6098d52335 Prevent misaligned read from common::container::ring_buffer (#1076)
- causes undefined behavior
2024-09-12 18:25:05 -05:00
Jonathan R. Madsen fcd6cc45bd Package RCCL headers to support adding RCCL support w/o installed headers (#1075)
- in ROCm CI, rocprofiler-sdk gets built before RCCL is installed, this is a workaround for this issue

[ROCm/rocprofiler-sdk commit: 8c1382fceb]
2024-09-12 18:24:50 -05:00
Jonathan R. Madsen 8c1382fceb Package RCCL headers to support adding RCCL support w/o installed headers (#1075)
- in ROCm CI, rocprofiler-sdk gets built before RCCL is installed, this is a workaround for this issue
2024-09-12 18:24:50 -05:00
itrowbri 348c547039 Updated README and CHANGELOG to contain information about --no-serialization flag option
Change-Id: I5a4ea5cba34a33ed27a784bcea07db0e212839d9
2024-09-12 10:18:46 -05:00
itrowbri 887e107fb1 Updated README and CHANGELOG to contain information about --no-serialization flag option
Change-Id: I5a4ea5cba34a33ed27a784bcea07db0e212839d9


[ROCm/rocprofiler commit: 348c547039]
2024-09-12 10:18:46 -05:00
Rahul Manocha 5dc048b559 SWDEV-475482 - Disable Texture Object Tests to merge clr change
Change-Id: I821120cd3c9eba8abd1beeeee5e61246272243e6
2024-09-12 11:05:12 -04:00
gobhardw c2701e4da4 SWDEV-484201 removing extra licenses
Change-Id: I1a1fb1e9487f1a3e63e9551278bd62b8f930792a
2024-09-12 19:58:45 +05:30
gobhardw 10e9800220 SWDEV-484201 removing extra licenses
Change-Id: I1a1fb1e9487f1a3e63e9551278bd62b8f930792a


[ROCm/rocprofiler commit: c2701e4da4]
2024-09-12 19:58:45 +05:30
Jonathan R. Madsen 3a5154c5ff rocprofv3 Kokkos-Tools Support (#1058)
[ROCm/rocprofiler-sdk commit: d5bcb63263]
2024-09-12 00:46:07 -05:00
Jonathan R. Madsen d5bcb63263 rocprofv3 Kokkos-Tools Support (#1058) 2024-09-12 00:46:07 -05:00
Mythreya c47a128941 Add support for RCCL tracing (#1047)
* [Draft]: Add support for RCCL tracing

Address comments

* [Draft]: Add support for RCCL tracing

Address PR comments, changes from RCCL upstream

* Add RCCL library table registration

Working on adding support to rocprofiler-register

* Support compilation w/o <rccl/amd_detail/api_trace.h>

- dummy api_trace.h header
- return ROCPROFILER_STATUS_ERROR_NOT_IMPLEMENTED when RCCL does not have api_trace.h header

* RCCL API tracing tool support

- add to rocprofv3
- add to json-tool

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 2a146259c7]
2024-09-12 00:42:58 -05:00
Mythreya 2a146259c7 Add support for RCCL tracing (#1047)
* [Draft]: Add support for RCCL tracing

Address comments

* [Draft]: Add support for RCCL tracing

Address PR comments, changes from RCCL upstream

* Add RCCL library table registration

Working on adding support to rocprofiler-register

* Support compilation w/o <rccl/amd_detail/api_trace.h>

- dummy api_trace.h header
- return ROCPROFILER_STATUS_ERROR_NOT_IMPLEMENTED when RCCL does not have api_trace.h header

* RCCL API tracing tool support

- add to rocprofv3
- add to json-tool

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2024-09-12 00:42:58 -05:00
Mythreya 13c0bf8e2b Add rccl API support (#66)
* [Draft]: Add rccl API support

* Partial tests

Need to add tests to the cmake file

[ROCm/rocprofiler-register commit: b71f9cabe6]
2024-09-11 17:57:51 -05:00
Mythreya b71f9cabe6 Add rccl API support (#66)
* [Draft]: Add rccl API support

* Partial tests

Need to add tests to the cmake file
2024-09-11 17:57:51 -05:00
Jonathan R. Madsen 4d01508d0b LD_PRELOAD librocprofiler-sdk-roctx.so when marker-trace enabled (#1057)
* LD_PRELOAD librocprofiler-sdk-roctx.so when marker-trace enabled

- this enables apps to link against old ROCTx (libroctx64.so) but get marker tracing in rocprofv3

* Update CHANGELOG

* Validation test for app linked to old (roctracer) ROCTx library

* Tweak scope of tool_counter_info

- causing "signal-unsafe call inside of a signal" error for ThreadSanitizer on mi200

* Fix handling of missing transpose-roctracer-roctx

* Disable rocprofv3 aborted-app test (ThreadSanitizer)

- ThreadSanitizer + mi200/mi300 + aborted-app results in a signal-unsafe call inside a signal that cannot be specifically suppressed as usual via rocprofv3_error_signal_handler for some unknown reason

* Add UndefinedBehaviorSanitizer job

[ROCm/rocprofiler-sdk commit: 72cbcedc9e]
2024-09-11 15:27:35 -05:00
Jonathan R. Madsen 72cbcedc9e LD_PRELOAD librocprofiler-sdk-roctx.so when marker-trace enabled (#1057)
* LD_PRELOAD librocprofiler-sdk-roctx.so when marker-trace enabled

- this enables apps to link against old ROCTx (libroctx64.so) but get marker tracing in rocprofv3

* Update CHANGELOG

* Validation test for app linked to old (roctracer) ROCTx library

* Tweak scope of tool_counter_info

- causing "signal-unsafe call inside of a signal" error for ThreadSanitizer on mi200

* Fix handling of missing transpose-roctracer-roctx

* Disable rocprofv3 aborted-app test (ThreadSanitizer)

- ThreadSanitizer + mi200/mi300 + aborted-app results in a signal-unsafe call inside a signal that cannot be specifically suppressed as usual via rocprofv3_error_signal_handler for some unknown reason

* Add UndefinedBehaviorSanitizer job
2024-09-11 15:27:35 -05:00
Saleel Kudchadker 9de6d4d46c SWDEV-478624 - Use readback workaround to ensure kernel arg coherence
Use env var DEBUG_CLR_KERNARG_HDP_FLUSH_WA=1 to fall back to HDP flush
workaround. The default is 0

Change-Id: I7bdb9be61da60c30d15ac9991b7cd27351e1831c
2024-09-11 14:53:15 -04:00
David Galiffi 61905d0dbb Update CODEOWNERS (#382)
[ROCm/rocprofiler-systems commit: 1413ab612d]
2024-09-11 14:44:28 -04:00
David Galiffi 1413ab612d Update CODEOWNERS (#382) 2024-09-11 14:44:28 -04:00
Ajay 5a810f789a SWDEV-471863 - avoid copy of invisibleHeap
Change-Id: Ieb0aa22ac6d0d01cb9ca7fbf1305df03a1ab3cdf
2024-09-11 13:24:31 -04:00
Gopesh Bhardwaj d0047fd969 SWDEV-48112 Counter header and OTF2 updates (#1042)
[ROCm/rocprofiler-sdk commit: df939cbe96]
2024-09-11 08:15:03 -05:00
Gopesh Bhardwaj df939cbe96 SWDEV-48112 Counter header and OTF2 updates (#1042) 2024-09-11 08:15:03 -05:00
Giovanni Lenzi Baraldi a91eab65f8 Removing unecessary barrier packet (#1017)
[ROCm/rocprofiler-sdk commit: 474b72b4fc]
2024-09-11 16:29:57 +05:30
Giovanni Lenzi Baraldi 474b72b4fc Removing unecessary barrier packet (#1017) 2024-09-11 16:29:57 +05:30
Gopesh Bhardwaj cfc9df73ae Update git clone URL + few documentation fixes (#1066)
[ROCm/rocprofiler-sdk commit: 0e7f9444e8]
2024-09-11 15:09:21 +05:30
Gopesh Bhardwaj 0e7f9444e8 Update git clone URL + few documentation fixes (#1066) 2024-09-11 15:09:21 +05:30