Commit Graph

37726 Commits

Author SHA1 Message Date
Jonathan Kim 509e8d863a rocr: Reverse host-device copy engines on GFX94x
GFX 9.4.x has better performance for CPU-GPU copies when using
engines in reverse order from other devices.

Change-Id: I1eaebf0e837bb7f44712f40d5115df618f6a73d7
2024-09-06 19:02:59 -04:00
Jonathan Kim 24b25003b0 rocr: Fix backwards compatible host-device copies on target engines
If the KFD doesn't support targeting SDMA engines, ensure that ROCr
selects the correct downstream queue type by using an invalid engine.

Change-Id: Ia6848126f67f3d35ab37248633e8e0e6e2d77fff
2024-09-06 19:02:51 -04:00
Sourabh Betigeri aaec37314f SWDEV-462007 - Fixes and strenghtens multi grid sync on mgpus
- Replaces logic relying on clock64() instead to
  use an atomic counter that the last wg in grid
  and multi-grid groups wait on while the the
  non-last work groups increment the counter
  to "done"
- Implements a new logic to verify the multi-grid
  sync()

Change-Id: I7780d8124e5f144b124e5d191d0f412483a3b565
2024-09-06 11:58:20 -07:00
kjayapra-amd 6211037f63 SWDEV-439234 - Access check before memcpy and kernel operations.
Change-Id: I7057125c03460db205409e19980145298c190fe2
2024-09-06 14:30:00 -04:00
Vladimir Indic 56e33c7543 More comprehensive IOCTL PC sampling checks (mi200 and mi300) (#1045)
* More comprehensive IOCTL PC sampling checks (mi200 and mi300)

* PC sampling tests: formatting

[ROCm/rocprofiler-sdk commit: 8bf2ce622c]
2024-09-06 09:45:05 -05:00
Vladimir Indic 8bf2ce622c More comprehensive IOCTL PC sampling checks (mi200 and mi300) (#1045)
* More comprehensive IOCTL PC sampling checks (mi200 and mi300)

* PC sampling tests: formatting
2024-09-06 09:45:05 -05:00
Kent Russell 3da42a0847 libhsakmt: Prefix global symbols with hsakmt
To support fully-static library ROCm builds, ensure that all global
symbols are prefixed with something meaningful to avoid collisions with
other libraries

A script was made using" objdump -C -t" to get a list of symbols,
then checking if the global symbols have a meaningful prefix (for thunk:
hsakmt or kmt in various cases)

Change-Id: Ifd353f64a3344eb60d1f6c4e041aa20967b38a59
Signed-off-by: Kent Russell <kent.russell@amd.com>
2024-09-06 09:56:07 -04:00
Chris Freehill a676d8639c Support for not building ROCr
Add cmake variable BUILD_ROCR so that user can elect to not
build ROCr.

Change-Id: I73bd28cde9430ba86aed50fb88ec2e42b3443dbb
2024-09-05 23:27:54 -04:00
Saleel Kudchadker 3baaa6e9c0 rocr: Allocate AQL queue on device memory
- Use HSA_ALLOCATE_QUEUE_DEV_MEM=1 to create AQL queue in device
memory.
- Before writing AQL packet header to the queue use an SFENCE to ensure
that there is no reodering of the writes over PCIE

Change-Id: I5eacdc35108c4a1e245c75ae349b7495451aa60d
2024-09-05 17:48:02 -04:00
David Galiffi 5df521badd Fixing CMake Format
Signed-off-by: David Galiffi <David.Galiffi@amd.com>


[ROCm/rocprofiler-systems commit: a9face692f]
2024-09-05 17:41:53 -04:00
David Galiffi a9face692f Fixing CMake Format
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-09-05 17:41:53 -04:00
David Yat Sin fe8d8c15f1 kfdtest: Fix ISA buffers not executable
Fix for some places where the ISA buffers are not declared as
executable. Previous code in Thunk was blindly setting exec bit on all
memory allocations so this issue was masked.

Change-Id: Ic7a1169c69fb85ff9e8ea7bcc49a1845b37c08ff
2024-09-05 16:57:34 -04:00
David Galiffi efdf4ed656 Install the LICENSE file to ${CMAKE_INSTALL_DOCDIR} (#377)
* Install the LICENSE file to ${CMAKE_INSTALL_DOCDIR}

ie., {INSTALL_PREFIX}/share/doc/omnitrace/LICENSE
Internal ticket: SWDEV-466385

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Add CPACK_RPM_PACKAGE_LICENSE = "MIT"

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 702da3a679]
2024-09-05 15:47:16 -04:00
David Galiffi 702da3a679 Install the LICENSE file to ${CMAKE_INSTALL_DOCDIR} (#377)
* Install the LICENSE file to ${CMAKE_INSTALL_DOCDIR}

ie., {INSTALL_PREFIX}/share/doc/omnitrace/LICENSE
Internal ticket: SWDEV-466385

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* Add CPACK_RPM_PACKAGE_LICENSE = "MIT"

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-09-05 15:47:16 -04:00
Julia Jiang bb03ef11a3 SWDEV481762 - Updated definition of 'DEPRECATED' in header file
Change-Id: I88986b8e1815f3d816595f3eb2da8a6c1c1c2993
Jenifer helped make a combined PSDB build, together with the change in hip repos
https://gerrit-git.amd.com/c/compute/ec/hip/+/1114046
Combined PSDB verification passed.
http://rocm-ci.amd.com/job/compute-psdb-staging-hip/17293/
2024-09-05 15:41:04 -04:00
victzhan 8be00b6602 SWDEV-477218 - Implement hipDeviceGetTexture1DLinearMaxWidth
Change-Id: I8103f710abeb869f5f84be61c57a30b24356def6
2024-09-05 15:09:38 -04:00
Vladimir Indic 3ed3489670 PC sampling: online partial PC sampling decoding (#1004)
* PC sampling: online partial PC sampling decoding

PC sampling service decodes a PC sample partially
by replacing the PC with an id of the loaded code object instance
containing PC and the offset of the PC within that code object instance.

* PC sampling: marker records removed

* PC sampling parser: minor doc update in mock

* PC sampling: introducing rocprofiler_pc_t

* NULL value of the code object id introduced.

* Clarifying documenation related to PC offset.

* PC offset documentation improvement

* PC sampling parser benchmark: Reducing the number of samples to recreate half of performance.

[ROCm/rocprofiler-sdk commit: 93e82663d9]
2024-09-05 11:35:46 -05:00
Vladimir Indic 93e82663d9 PC sampling: online partial PC sampling decoding (#1004)
* PC sampling: online partial PC sampling decoding

PC sampling service decodes a PC sample partially
by replacing the PC with an id of the loaded code object instance
containing PC and the offset of the PC within that code object instance.

* PC sampling: marker records removed

* PC sampling parser: minor doc update in mock

* PC sampling: introducing rocprofiler_pc_t

* NULL value of the code object id introduced.

* Clarifying documenation related to PC offset.

* PC offset documentation improvement

* PC sampling parser benchmark: Reducing the number of samples to recreate half of performance.
2024-09-05 11:35:46 -05:00
Ammar ELWazir a6c31edfc3 SWDEV-482307: Fixing Perfetto Plugin
Change-Id: Iec128a03b8b57c76861e9cd8ddfd647965076ca8
2024-09-05 12:15:22 -04:00
Ammar ELWazir 0e9e3f0ab6 SWDEV-482307: Fixing Perfetto Plugin
Change-Id: Iec128a03b8b57c76861e9cd8ddfd647965076ca8


[ROCm/rocprofiler commit: a6c31edfc3]
2024-09-05 12:15:22 -04:00
Kent Russell 545467be04 kfdtest: Check for NULL at MCABackend creation
The function can return NULL if it fails to create the backend, so check
for NULL before using it.

Change-Id: I4d6501bffd6dd0fc0d0f2224720f7d6dca1646f3
Signed-off-by: Kent Russell <kent.russell@amd.com>
2024-09-05 12:07:11 -04:00
Julia Jiang 529a78c3ff SWDEV481762 - Updated definition of 'DEPRECATED' in HIP header
Change-Id: I76c1d925f35594a042cde4f26fab75492db96633

Jenifer helped make a combined PSDB build, together with
https://gerrit-git.amd.com/c/compute/ec/clr/+/1114054
. Combined build verification passed.
http://rocm-ci.amd.com/job/compute-psdb-staging-hip/17293/
Change-Id: I76c1d925f35594a042cde4f26fab75492db96633
2024-09-05 11:48:54 -04:00
David Yat Sin 9537420254 Add queries for xnack_enabled and vmm support
Change-Id: I7200fdc4c3086e92d60fbf785be89fb5d441409c
2024-09-05 10:32:27 -04:00
Chris Freehill 7e13b9e62f hsakmt: Fix ROCr static lib build in new layout
Change-Id: Idc71524924b96a44d63be9b1d0fccbe0e328d96e
2024-09-05 10:26:06 -04:00
Kent Russell 4dc9d49aa6 hsakmt: Free alloc'd memory
trace is calloc'd but never freed. Free it.

Change-Id: I5795cbe5738f25a9621d24be86abb35c263fa8b7
Signed-off-by: Kent Russell <kent.russell@amd.com>
2024-09-05 10:20:09 -04:00
victzhan 7a01db98e9 Revert "SWDEV-458943 - make new AMD_MONITOR on"
This reverts commit f8598dabb0.

Change-Id: I2a7ddb2d4340224f43749a2ea91a894a8a95b83b
2024-09-05 10:10:50 -04:00
Ioannis Assiouras 90b441a804 SWDEV-477039 - Disabled samples that directly invoke hipcc for static builds
This commit disables samples that directly call hipcc when
building in a static environment. In its current state, hipcc
requires all static libraries to be explicitly provided
in order to succesfully link the sample binary.

Change-Id: I74c94a57867bc1fe0e6134ddd633b465bd6c0f83
2024-09-05 05:42:27 -04:00
Shane Xiao 821f6e58f9 Revert "gfx11 is able to perform atomic ops even PCI reports no atomic support."
This reverts commit 9f0f7741de.
For APU, the PCIe atomic is supported by default. However, the PCIe
atomic feature needs to checked for dGPU. The kfd driver has already
set PCIe atomic support for APUs, so this patch can be reverted.

Change-Id: I131d5b8e095c1104e1695e7cf8b1ed178bccddde
Signed-off-by: Shane Xiao <shane.xiao@amd.com>
2024-09-05 01:44:16 -04:00
dependabot[bot] 05a1376c82 Bump cryptography from 42.0.8 to 43.0.1 in /docs/sphinx (#376)
Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.8 to 43.0.1.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pyca/cryptography/compare/42.0.8...43.0.1)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-systems commit: b00d1b35de]
2024-09-04 17:09:38 -04:00
dependabot[bot] b00d1b35de Bump cryptography from 42.0.8 to 43.0.1 in /docs/sphinx (#376)
Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.8 to 43.0.1.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](https://github.com/pyca/cryptography/compare/42.0.8...43.0.1)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-09-04 17:09:38 -04:00
Nirmal Unnikrishnan 2cc55b27ac SWDEV-467155 : Add llvm to RPATH search path
Change-Id: I3598d7938bd63b06fd9cf14906c4ed3e7cc52a82
2024-09-04 13:52:49 -05:00
AravindanC be3728bd33 CheryPick SWDEV-442738 - Static package generation for rocm-core
Change-Id: I8e55f4cc3e476a9b4f3d73c02bab51c70b936bcc

SWDEV-442738 - ROCM-CORE Static Package Pre/Post Script

Change-Id: Ie55ffc98dfc60d9cb01b7a6df7a5fe1a890bc771
2024-09-04 13:52:49 -05:00
Ranjith Ramakrishnan a5a437e48a SWDEV-449560 - Backward compatibility support for deprected package rocm-clang-ocl
rocm-clang-ocl has been deprected from ROCm 6.1 onwards. Uprading ROCm from 6.0 to latest release will result in stale files of rocm-clang-ocl.
rocm-core will replaces/obsoletes rocm-clang-ocl package. This will ensure clean removal of the deprecated package

Change-Id: Id5c16492273d8a0dcbbd5ac797daaef96c058f5b
2024-09-04 13:52:49 -05:00
Vladana Stojiljkovic 1a12bbf19c SWDEV-475987 - Add mapping for missing CUDA error codes
Change-Id: I4cc5cb786fa4c7cc67cc037b00edad63d811ca73
2024-09-04 12:26:09 -04:00
Vladana Stojiljkovic bee0ba867d SWDEV-478472 - Disable tests to merge SWDEV-475987 on hipother
Change-Id: I58715144518a35954e29d89878465cfd41ccfe86
2024-09-04 12:25:04 -04:00
Rahul Manocha dbf00966b9 SWDEV-479575 - Graph clone root size check
Change-Id: I34dd43ea36ce1e2623198e6ce1179318b9f7e277
2024-09-04 11:54:15 -04:00
Jeremy Newton c574c81835 kfdtest: Drop sp3 licensing comments
This is obsolete and can be dropped.

Change-Id: I4ed7d22567043f9cca39879a82e5ea945c27efc1
Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
2024-09-04 11:20:38 -04:00
Xuanteng Huang 7a52a45824 hsakmt: fix spelling error
This was pulled in from:
https://github.com/ROCm/ROCT-Thunk-Interface/pull/107

Change-Id: Ic30e4552a94a212a9cd138f9311b1c85b0c13867
2024-09-04 10:46:39 -04:00
Jaydeep Patel b89a7c6201 SWDEV-481860 - Match malloc/hipMalloc calls with free/hipFree calls in all samples.
Change-Id: Ib44551b3f60cd90fa7158e4ed016ef5549a34ef7
2024-09-04 10:32:58 -04:00
Tom Rix b9c6144f23 kfdtest: Improve finding rocm-smi
On Fedora, rocm-smi is a standard package and is installed to /usr/bin
So when run_kfdtest.sh is run this error is produced

find: ‘/opt/rocm*’: No such file or directory

First redirect stderr to dev/null on the original search.
Then fall back to either looking for rocm-smi in BIN_DIR or
look for it in the PATH.

Change-Id: I389ed0b9a4a4507263c9eb19894b25326c9a4222
Signed-off-by: Tom Rix <Tom.Rix@amd.com>
Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
2024-09-04 09:20:32 -04:00
Marko Arandjelovic 224334e1d2 SWDEV-478206 - Fix hipTexRefSetArray
Change-Id: I6bd6ce60163d4f79001fce75e40ef46f1fcb7c3f
2024-09-04 03:41:25 -04:00
Jimbo Xie 3bdbc1eaf3 SWDEV-403363 - add gfx1152 runtime support
Change-Id: I2f59ddb38a98d9f8edec5d1548232d4d826b7d04
(cherry picked from commit 5e94656f744e315ee7ae1285d3e6dd515f9d66a8)
2024-09-03 17:12:24 -04:00
Joseph Greathouse 75143555fa hsakmt: Only set exec flag when requested
Previous code would blindly set executable bit on all allocations.

Change-Id: Id1154f08f6ba21c633905fd46b06053994d6f3cc
2024-09-03 15:13:56 -04:00
Julia Jiang ef55ef332b SWDEV-478511 - Fix return format in API doxygen
Change-Id: I64bdbd77ad664b3aa489c0e0e34647bb72095978
2024-09-03 14:36:55 -04:00
Jeremy Newton 8fd1b14a42 Fix permissions on kfdtest
Using "PROGRAMS" and "FILES" without specifying permissions will
automatically select the right permissions.

PROGRAMS is used for executables, FILES is used for data files

Change-Id: I0fb6eff257a8f936848bd648cf877da6dc0b6906
2024-09-03 14:11:01 -04:00
David Yat Sin 4ba4867fa5 rocrtst: Fix segfault on p2p copies
Fix segfault on p2p copies when 2 agents cannot access each other's
memory (usually because the PCI BAR's are out of range). The
AcquireAsyncCopyAccess function should return NULL in that case, so that
the test can be skipped.

Change-Id: If018f3609dd21a01c56eaec94de3bca52c385c4d
2024-09-03 14:06:48 -04:00
Giovanni LB 3b0c6bd165 Fixing --help for counter collection
Change-Id: I76e02e0593966f2b9c1db4bffa8566b987efcf53
2024-09-03 13:40:21 -03:00
Giovanni LB caf9bc23a8 Fixing --help for counter collection
Change-Id: I76e02e0593966f2b9c1db4bffa8566b987efcf53


[ROCm/rocprofiler commit: 3b0c6bd165]
2024-09-03 13:40:21 -03:00
Rahul Manocha 1f333f64c4 SWDEV-468039 - Define formatting for fp8 ocp data type
Change-Id: Ie3c8bc71b4cefaa20e9e5d80636c2d26a05e91a7
2024-09-03 11:35:48 -04:00
Rahul Manocha ddbd7039b0 SWDEV-478921 - Destroy Queue created by Coop Launch
Change-Id: I7f31ce05421479ff1de138cae26aafa071e956e2
2024-09-02 02:35:08 -04:00