Commit Graph

1167 Commits

Author SHA1 Message Date
coleramos425 23cbe3f595 Create dedicated subdirectory in perfmon configs for archs supporting roofline
Separate subdirs allows us to target different roofline counters for different archs (i.e. MI300 vs MI200)

Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 49371cacec]
2024-05-31 16:09:58 -05:00
Karl W. Schulz dd374ea0ef remove use of distutils package entirely to avoid future deprecation
issues

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 7a01f499d7]
2024-05-28 15:34:00 -05:00
Karl W. Schulz 7288bf34f4 updated approach for runtime dependency check that does use "pkg_resources"
which will reportedly be deprecated at some point in the future.

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: aca084f41c]
2024-05-28 15:34:00 -05:00
coleramos425 782ea3099b Wrap text displayed in 'Top Dispatch' table for neatness
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: c6cfa9cc26]
2024-05-28 15:34:00 -05:00
Nicholas Curtis 8bd72673e8 Add fix for case where we pass a single 'nan' value to to_avg
This is triggered by doing e.g., analyze -p <whatever> -k <kernel> -n per_kernel -b 17 18
Manifests as e.g.:

```
  ERROR [analysis] 'float' object has no attribute 'empty'
```

because of:

https://github.com/ROCm/omniperf/blob/f3a0360a5640e4539fac534f73876f51ddd268d0/src/utils/parser.py#L135

Instead, we first check whether numpy thinks the whole array is nan's, and bail early if so

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: 047d7771f3]
2024-05-28 15:34:00 -05:00
Nicholas Curtis f7da503e6f handle unspecified case
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: 1f584c1612]
2024-05-28 15:34:00 -05:00
Nick Curtis 562e36a5c3 fix formatting
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com>


[ROCm/rocprofiler-compute commit: 5579beeed5]
2024-05-28 15:34:00 -05:00
Nick Curtis fbb384bd2f Add ability to overide arch when name missing in rocminfo
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com>


[ROCm/rocprofiler-compute commit: 989dd3b7ae]
2024-05-28 15:34:00 -05:00
Cole Ramos 6ce7c00461 Update packaging.yml checkout library
Signed-off-by: Cole Ramos <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 57c4f2047e]
2024-05-17 15:00:18 -05:00
Cole Ramos 28c2797792 Update AUTHORS
Signed-off-by: Cole Ramos <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 5f0978c278]
2024-05-17 13:42:36 -05:00
coleramos425 c2e549c883 Update CHANGES
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 4c70cb919d]
2024-05-17 18:36:11 +00:00
coleramos425 219914fa9e Format CMake and Python
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 1f370c9fe7]
2024-05-10 09:07:40 -06:00
coleramos425 e6b2b03f32 Add support for --quiet flag to roofline
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: dba868973b]
2024-05-10 09:07:40 -06:00
coleramos425 d7d0e5bb70 Include Grafana assets in CMake build
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 1767c31db9]
2024-05-10 09:07:40 -06:00
coleramos425 b110c2e20b Executable permissions to docker entrypoint
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: e274f7ee88]
2024-05-10 09:07:40 -06:00
coleramos425 1517617004 Add docs for --quiet mode and update README
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 3ab51735b5]
2024-05-10 09:07:40 -06:00
coleramos425 156305f391 Update docs for new Grafana reorg
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 8bca70a6ef]
2024-05-10 09:07:40 -06:00
coleramos425 68ef26a9cf Move all Grafana assets into subdir. Update plugin dependencies
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 1f44b4faa5]
2024-05-10 09:07:40 -06:00
coleramos425 5fd6022d9a Update from https://github.com/ROCm/mibench/commit/b704bd3ec439f8cbece6713852fcafc855c5b07e
[ROCm/rocprofiler-compute commit: 519bcb9b3e]
2024-05-10 09:07:40 -06:00
Karl W. Schulz f3a0360a56 Adding a top-level runtime python dependency checker. Goal is to
provide a kinder error message in the case where python dependencies
are not available locally. This is motivated for future execution by
users who are running from rocm-based binary packaging instead of using
normal cmake build system which would have verified the dependencies.

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: d1ee2ec870]
2024-05-03 15:26:27 -05:00
coleramos425 ecd516a660 Remove deprecated workflow. No longer applicable
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 80c93aa452]
2024-05-03 15:26:27 -05:00
Cole Ramos edf579d992 Optimizing Dockerfiles and buildscripts (#359)
* Optimizing Dockerfiles and buildscripts

Signed-off-by: coleramos425 <colramos@amd.com>

* Give docker scripts exe permission

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: bf9176c1ae]
2024-05-03 15:26:27 -05:00
Karl W Schulz f997ef063c update badges to reflect latest CI settings on (production) main branch
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: d5c637e6c8]
2024-05-02 14:25:14 -05:00
David Galiffi ee3139de7e Update CMakeLists
- Add CPACK_RPM_PACKAGE_RELEASE_DIST to set RPM distro.
- Indent packaging logs for easier reading.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>


[ROCm/rocprofiler-compute commit: 450370a767]
2024-04-29 14:58:52 -05:00
David Galiffi e75e632f3d Update project packaging
Signed-off-by: David Galiffi <David.Galiffi@amd.com>


[ROCm/rocprofiler-compute commit: 539ec0c65e]
2024-04-29 14:58:42 -05:00
coleramos425 3ac6cd4b53 Fix outstanding roofline test that was missed in previous commit
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 3f150409f1]
2024-04-26 10:53:57 -05:00
coleramos425 9a0d5f0663 Replace deprecated roofline warning with logging helper function
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 7d34e80567]
2024-04-25 18:43:20 +00:00
coleramos425 efcf9001d7 Add TCC_TOO_MANY_EA_WRREQS_STALL to gfx940 input configs (#349)
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 0fc620ce79]
2024-04-25 18:22:00 +00:00
coleramos425 3237f685e6 Update names of roofline csv expectation in testing
Co-authored-by: Jose Santos <josantos@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 46aa20e014]
2024-04-25 18:10:21 +00:00
David Galiffi e9df02bb5b Add ".venv" to gitignore file
Signed-off-by: David Galiffi <David.Galiffi@amd.com>


[ROCm/rocprofiler-compute commit: c24baf3610]
2024-04-24 17:02:52 -05:00
Karl W Schulz 2653dc850b additional mod needed to support roofline binaries potentially
executing from two different locations

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: b5011ff0ae]
2024-04-22 09:00:18 -05:00
Karl W Schulz 6d277e5443 allow override of CPACK_GENERATOR
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 144843f710]
2024-04-21 14:53:14 -05:00
Karl W Schulz 4dd0801633 use concurrency instead of cancel-workflow-action
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: c5cb6ba44f]
2024-04-21 14:53:14 -05:00
Karl W Schulz 6591b6e2d3 fix module load path
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: f0ec149497]
2024-04-21 14:53:14 -05:00
Karl W Schulz 8033e4f20f include additional omniperf in modulefile install path
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 7d24465ee6]
2024-04-21 14:53:14 -05:00
Karl W Schulz 2eb3255a7d wip
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: bd9cf81f17]
2024-04-21 14:53:14 -05:00
Karl W Schulz 479784fb97 wip
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 92f6367f18]
2024-04-21 14:53:14 -05:00
Karl W Schulz b696085fad wip
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 9415f5e54b]
2024-04-21 14:53:14 -05:00
Karl W Schulz 8a69115187 include omniperf subdir
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: ab95711c14]
2024-04-21 14:53:14 -05:00
Karl W Schulz 4bbe584251 update tarball packaging test based on new install paths
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 53beac102a]
2024-04-21 14:53:14 -05:00
Karl W Schulz 71dfdef23e remove duplicate cpack include
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 985d8bac84]
2024-04-21 14:53:14 -05:00
Karl W Schulz 6c1252ee03 restore tarball generation that was inadvertently removed during
packaging updates

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 624aeacf31]
2024-04-21 14:53:14 -05:00
Karl W Schulz f81f76162f update cmake config to user cpack components; allows test collateral
to be housed in a separate package

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 6fdd6190bf]
2024-04-21 14:53:14 -05:00
Karl W Schulz 16f41ba182 wrap python depdenency check with a CHECK_PYTHON_DEPS option
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 3fca4bf511]
2024-04-21 14:53:14 -05:00
Karl W Schulz 9d5dd68ea7 remove commented out tests
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 4f408e9fc3]
2024-04-21 14:53:14 -05:00
Karl W Schulz 69787cb124 remove commented out tarball packaging
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 7bb4f9430a]
2024-04-21 14:53:14 -05:00
Karl W Schulz 820a790fc2 enable optional tests component install
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: eedb78139c]
2024-04-21 14:53:14 -05:00
Karl W Schulz 12b8352f3f update modulefile install path and remove crusher-specific mods
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 8777593466]
2024-04-21 14:53:14 -05:00
Karl W Schulz ab7db47eb6 update logic to detect roofline binaries in two alternate paths
depending on whether user is running within local clone or from form
install.

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 093a4511ee]
2024-04-21 14:53:14 -05:00
Karl W Schulz 0e2ea80e12 refactor cmake config to accommodate rocm-style packaging
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 2a18c0fead]
2024-04-21 14:53:14 -05:00