Commit Graph

542 Commits

Author SHA1 Message Date
Ranjith Ramakrishnan 75fadc28dd Populate roctracer.h wrapper file with orginal file contents as dead code
Backward comaptibility for components that search for  contents in roctracer.h
Improvements: Removed redundant code for setting and unsetting variables
Added header template file in source code instead of generating it on build time

Change-Id: I96aeb7f2a6d53d45eb5aeb5300024cd22dad1324


[ROCm/roctracer commit: 8ca752ce2c]
2022-04-26 03:09:35 -07:00
Ammar ELWazir 9dd5a58e3e SWDEV-295522: Fixing Performance Issue
Removing DEBUG_TRACES and the unnecessary use of roctracer_op_string, made the MS app reporting 78 to 81 stable samples per second, depending on the type of the trace, while the main app without rocprof reports 100 to 106. More detailed numbers will be posted in the ticket.

Change-Id: Ifbc529278cea54dd23e6086aa9b9ea2df952d5dd


[ROCm/roctracer commit: e4569c41fe]
2022-04-22 18:51:49 -04:00
Laurent Morichetti 0fd8cd7895 Allow MemoryPool::Write while Flushing
Before this change, when a producer was blocked by a flush operation,
no other producer could write to the memory pool.  This change allows
other producer threads to continue to write by releasing the producer
lock before waiting on the consumer condition variable.

Change-Id: Idc1c07173d2edb18fbe1a61961f10c02e7ca8c20


[ROCm/roctracer commit: dc8717a6b5]
2022-04-22 11:22:23 -07:00
Laurent Morichetti 1aaed4c508 Remove HCC_EXC_RAISING and HIP_EXC_RAISING
HCC_EXC_RAISING and HIP_EXC_RAISING don't add much value, so to
simplify, only keep EXC_RAISING and EXC_ABORT.

Change-Id: Ifdc54981bb682fe68b418cdc95ecebe668e3dcf6


[ROCm/roctracer commit: 121a84b449]
2022-04-22 11:22:23 -07:00
Laurent Morichetti 14f1d48482 Move the HccLoader activities into the HipLoader
The HCC runtime is no longer used, so move all the remaining
activities in the HipApi loader and remove the HccLoader.

Change-Id: I845c04ca275a474526840315bae0ad1a4ce02257


[ROCm/roctracer commit: 85552ea3a0]
2022-04-22 11:22:07 -07:00
Laurent Morichetti 33d8437801 Use ACTIVITY_DOMAIN_HIP_OPS instead of ACTIVITY_DOMAIN_HCC_OPS
Change-Id: I43fbac3d02011f74bf7b597519148ed0bd68ff98


[ROCm/roctracer commit: abf1b90017]
2022-04-20 22:00:59 -07:00
Laurent Morichetti 83cf22a698 Remove roctracer_hcc.h
roctracer_hip.h now contains the definitions for the HCC_OPS domain.

Change-Id: I132c993110254050aaa68828f3ca80f368ad24bc


[ROCm/roctracer commit: d3b166cf01]
2022-04-20 22:00:59 -07:00
Laurent Morichetti 57304225d9 Remove hip_act_cb_tracker.h
It only defines one class (hip_act_cb_tracker_t) that is only used
by roctracer.cpp.

Change-Id: I375a25bd363770d70a7b3b713223484a498cc3d1


[ROCm/roctracer commit: c009df3327]
2022-04-20 19:48:24 -07:00
Laurent Morichetti f8cc0d58a8 Close the default pool on exit
Change-Id: I388ea4d4f06c1818312a72185ef55b615c730509


[ROCm/roctracer commit: a0fd1e7c4b]
2022-04-20 19:48:24 -07:00
Laurent Morichetti 3c18fb9f01 Simplify memory_pool.h
Use the standard concurrent support library (std::thread, std::mutex,
st::condition_variable) instead of pthread.

Fix a mismatched memory allocation/deallocation when a custom allocator
is provided. The MemoryPool destructor was always using the default
allocator (using malloc/realloc/free) even if the pool memory was
allocated with the custom allocator.

Fix various thread safety issues and inefficiencies (spin loops).

Change-Id: I97592caa947f63463041bf43e00af9ebb5ff5886


[ROCm/roctracer commit: 9d728f74a1]
2022-04-20 19:48:24 -07:00
Laurent Morichetti 45deedf43a Make roctracer_cb_table.h a private header
Move roctracer_cb_table.h to the src/core directory, as it should not
be exposed as a public header, and rename it callback_table.h

Change-Id: Ib448cbd32a275df0268d53bd8d1da0bdc9201470


[ROCm/roctracer commit: cd62d841fa]
2022-04-20 19:47:43 -07:00
Laurent Morichetti 2a2852048f Address review comments from previous commit
Change-Id: I6629dd911de0d7fd08d7a863c172ec73f35fa3d1


[ROCm/roctracer commit: dc22139977]
2022-04-20 22:46:15 -04:00
Laurent Morichetti 23528f51e0 Run clang-format on all source files
Change-Id: Ifb52ca306286b6b2d473821bed9db28e9f616d50


[ROCm/roctracer commit: 15ab5d9cda]
2022-04-20 22:45:54 -04:00
Laurent Morichetti b9bbce0017 Simplify journal.h
Simplify implementation of journal.h.

Change-Id: I9e2e93fd3cd3391fdf182249f5c4c5ef3debae03


[ROCm/roctracer commit: 89f6880371]
2022-04-20 19:43:16 -07:00
Laurent Morichetti 80c01a27c0 Fix copyright headers
Change-Id: I380d867fa5fb04e68b5b332e9abf33fbeb1e9418


[ROCm/roctracer commit: 06a3da7c63]
2022-04-19 09:30:45 -07:00
Laurent Morichetti ebf0985173 Switch roctracer to C++17
Change-Id: Ic8dee7dddaac2e7cca6e055f3c5f717f162f1eed


[ROCm/roctracer commit: 31365f3076]
2022-04-18 15:02:49 -07:00
Tony Tye 713a0c30c9 Update README.md
Improve formating and correct build directions.

Change-Id: I06b97e206e014c29c0c9f3b34dedd683448728f2


[ROCm/roctracer commit: b30b5b84e7]
2022-04-15 20:34:21 +00:00
Ammar Elwazir d69070a133 Revert "SWDEV-295522: Fixing Performance Issue"
This reverts commit 35ea06abd0.

Reason for revert: Merged by mistake

Change-Id: I8c39c823d92cc20a238ca6120dde4b2fa9121e85


[ROCm/roctracer commit: 57add1a6fa]
2022-04-07 06:55:34 -04:00
Ammar ELWazir 35ea06abd0 SWDEV-295522: Fixing Performance Issue
Removing DEBUG_TRACES and the unnecessary use of roctracer_op_string, made the MS app reporting 78 to 81 stable samples per second, depending on the type of the trace, while the main app without rocprof reports 100 to 106. More detailed numbers will be posted in the ticket.

Change-Id: Ida25d3bfc72047afaa27326d697be76d97564334


[ROCm/roctracer commit: e7327aaac7]
2022-04-07 00:07:24 +00:00
Ammar ELWazir f1de3ae0e5 SWDEV-307394: Fixing Download HSA-Class Issue
Exchanging the git clone of the hsa-class to a local downloaded version pushed to the roctracer repo

Change-Id: Id45a38b2d355102c2e0dee1e4bfde50398369047


[ROCm/roctracer commit: 7ee4f87b73]
2022-03-29 22:27:25 +00:00
Saravanan Solaiyappan 127ab7646d roctracer: Consider apt upgrade operation check in package scripts.
Include the upgrade operation check in the prerm script
in package.

Signed-off-by: Saravanan Solaiyappan <saravanan.solaiyappan@amd.com>
Change-Id: I1504ce96a27d21d9c3d9bafc0dea8055398adc99


[ROCm/roctracer commit: bfea525ff3]
2022-03-21 23:43:19 -04:00
Saurabh Verma 553d8a0da3 Merge "SWDEV-295871: [MSRCHA-130] Unable to filter API using .txt or .xml -Part-2 of MSRCHA-128. Made xml input more robust to accept both spaces and commas in xml array." into amd-staging
[ROCm/roctracer commit: 43657de4d2]
2022-03-18 10:13:31 -04:00
Ammar ELWazir 1029cc418e SWDEV-328300: supporting centos-9 for roctracer
Changing pthread_yield() to sched_yield() as pthread_yield() is deprecated in CentOS 9

Change-Id: I2961b61374e36995d0835f0e65b26c35f5eb8715


[ROCm/roctracer commit: 43a36f8dd5]
2022-03-18 01:26:39 +00:00
Saurabh Verma e1f9f82198 SWDEV-295871: [MSRCHA-130] Unable to filter API using .txt or .xml -Part-2 of MSRCHA-128. Made xml input more robust to accept both spaces and commas in xml array.
Change-Id: I3900fdf91cd0b893fadd9dfc958030effc5663db


[ROCm/roctracer commit: 37ed31087a]
2022-03-17 17:16:17 -05:00
Saurabh Verma daa23130ad SWDEV-295871 : [MSRCHA-130] Unable to filter API using .txt or .xml - Part-2 of MSRCHA-128. Fixed constructor ordering issue of global variables hip_api_vec and hsa_api_vec by wrapping themin static getter functions
Change-Id: I2dae5e196118fcab696b2365b24281f05d9d0f88


[ROCm/roctracer commit: aee8102fa6]
2022-03-14 16:07:58 -04:00
Ammar ELWazir 5daf0bcd13 SWDEV-296010: Fixing RPATH & CMAKE files
Removing the RPATH skip & Removing the install path that was defined CMakelist

Change-Id: Icf374b9548fc7b24e99a1b5ab9720ce6d775abf8


[ROCm/roctracer commit: 8098ec6acf]
2022-03-09 19:16:08 -06:00
Ranjith Ramakrishnan 472330b728 File reorganization with backward compatibility
Package installed /opt/rocm
Soft links and wrapper header files installed /opt/rocm/roctracer for backward compatibility
tracer_tool library renamed to roctracer_tool and installed in /opt/rocm/lib/roctracer

Change-Id: Ica7518c5ef2e591715121cbc942b69dff29233d3


[ROCm/roctracer commit: bc19ae71eb]
2022-03-04 04:03:51 -08:00
Ranjith Ramakrishnan 9b1793bd39 Merge "SWDEV-291455: Prefer rocm include path to hip include path" into amd-staging
[ROCm/roctracer commit: c037ccb95e]
2022-02-15 14:43:32 -05:00
Ranjith Ramakrishnan a3c738ff30 SWDEV-291455: Prefer rocm include path to hip include path
Change-Id: I1fa96e72169fac689a3a2ed38e988d7f5d18bf04


[ROCm/roctracer commit: ebda880c4a]
2022-02-14 14:21:32 -08:00
Kiumars Sabeti 55299c1d75 SWDEV-322312 [ASAN] [roctracer] RPM packages are generated while building roctracer for UBUNTU
To fix the issue we modified CMakeLists.txt as described in Sparry Icarus comment

Change-Id: Ie9ca16cfcfb7b7a9a858f0fb1f5071923c787313


[ROCm/roctracer commit: 554011e767]
2022-02-11 19:21:17 +00:00
Kiumars Sabeti fa57056629 SWDEV-322312: RPM packages are generated while build roctracer for UBUNTU
replaced -DCPACK_GENERATOR=DEB

Change-Id: I9f6d4d652e7cad510343731948675f0cd4398ef4


[ROCm/roctracer commit: cec4cb2538]
2022-02-11 08:33:17 +00:00
kiumars f7c3908e62 replace the set of CMAKE_SHARED_LINKER_FLAGS with add_link_options.
Change-Id: I2696ccd53b234e700e1464b0b3852aac1e3fc3b3


[ROCm/roctracer commit: e56146ff7c]
2022-02-03 12:55:15 -05:00
Ammar ELWazir 4cca362f20 SWDEV-318551: Adding License file for tracer
Making the new License file, Adding support in the CMakeLists.txt

Change-Id: I43862b8b7f3025ae6200aeb442ea70c7993a7349


[ROCm/roctracer commit: b721e3209e]
2022-01-26 13:39:31 -05:00
Icarus Sparry 7e622b9075 Forcibly disable parallelism
The manually written Makefiles in the test directory are not safe to
use by more than one job. For example we see things like
	all: clean $(EXECUTABLE)
which says that the 'all' target depends on the 'clean' and
'$(EXECUTABLE)' targets. If make is invoked with -j2 then the clean
and '${EXECUTABLE}' can be built in parallel, so the clean can delete
things whilst they are being built!

Change-Id: I9c56db4c629081b8d812dad45dfd4afde10e481f
Signed-off-by: Icarus Sparry <icarus.sparry@amd.com>


[ROCm/roctracer commit: 8ea268b3f4]
2021-10-31 15:19:36 -07:00
Ammar ELWazir 023cb806f9 SWDEV-275232: Replaced the use of on_exit()
on_exit() registered exit_handler function, but in the case of OpenMP applications the registered exit func exit_handler was called after the dlclose of the library. So we removed exit_handler from roctracer as it is already handled in both rocprofiler and rocprof script.

Change-Id: I7c3d42e6ccc282e713b48b4a7faec4935e7a2600


[ROCm/roctracer commit: aa41554130]
2021-10-09 17:36:36 -04:00
Ammar ELWazir 606d3dd8e8 SWDEV-298155: Fixing HSA-CLASS REV
Adding the latest commit to pull from the hsa-class git repo that includes the fix for SWDEV-298155
"Fixing the typo in evt_stats.h" https://github.com/ROCmSoftwarePlatform/hsa-class/commit/e6456a6d93cc6d8bcc59bd6ea24f27146f86ff4c

Change-Id: I9984de8ec9204a6cf47a25ce4ac42852473c56c9


[ROCm/roctracer commit: 99e2f37c81]
2021-09-29 12:27:15 -04:00
Saurabh Verma 3b16547bf6 SWDEV-295878 Fix for seg fault when using --trace-start off
Change-Id: Ic76d814b3591f72db18319d78f34596dae1ddfee


[ROCm/roctracer commit: a7cd80b716]
2021-08-31 16:46:59 -05:00
Ammar Elwazir a40f9816e5 Merge "SWDEV-294319 & SWDEV-294321 Added support for missing functions" into amd-staging
[ROCm/roctracer commit: 02d27d06e5]
2021-08-12 03:15:40 -04:00
Ammar ELWazir fe9f4c9d87 SWDEV-294248 (Fixing Race Conditions):
Fixing race conditions that happened when enabling trace-period feature on the following code:
#include <hip/hip_runtime.h>
__global__ void
kernel ()
{
}
int
main (int argc, char **argv)
{
  for (size_t i = 0; i < 10000; ++i) {
    hipLaunchKernelGGL (kernel, 1, 1, 0, 0);
    hipDeviceSynchronize ();
  }
  return 0;
}

Change-Id: I4eb88a4a71efbad0f6483e7fb6e8e0c6a662860b


[ROCm/roctracer commit: 513460bd41]
2021-08-11 22:48:55 -04:00
Ammar Elwazir 8b48f6ad7e Merge "Fixing correlation_id_map" into amd-staging
[ROCm/roctracer commit: 53fa06ad66]
2021-08-11 21:44:59 -04:00
Ammar Elwazir e52fc25af9 Merge "Cosmetic change" into amd-staging
[ROCm/roctracer commit: 682ebba1c2]
2021-08-11 20:47:53 -04:00
Ammar ELWazir bf410d1747 SWDEV-294319 & SWDEV-294321 Added support for missing functions
Added Support for launch kernel functions to fill_api_db

Change-Id: Ie8749806214d6e283c3d408d8019f178f42018bf


[ROCm/roctracer commit: 8396836c25]
2021-08-11 11:42:21 -04:00
Ammar ELWazir 77ef6e38dc Cosmetic change
Fixing variable names and removing un-needed references

Change-Id: I3ed2cee89e7dc599caf1726fe1eab1a913e5a93d


[ROCm/roctracer commit: b02586c587]
2021-08-09 14:13:57 -04:00
Ammar ELWazir fec4a850bb Fixing correlation_id_map
Changing correlation_id_map to static instance instead of being a pointer and fixing the corresponding references

Change-Id: Id8a481a90b46831f91985a7e0523fd2869991aeb


[ROCm/roctracer commit: 1e3ed06a9a]
2021-08-09 14:05:52 -04:00
Christophe Paquot a9f6522a41 SWDEV-295205 - Remove KFD domain from roctracer
Change-Id: I2771cf43aa115bb466531bf887f7cc75e187f2ef


[ROCm/roctracer commit: e5e1258ef8]
2021-07-22 10:12:45 -07:00
Christophe Paquot ae9c760305 SWDEV-281658 - Preserve the callback IDs enum ordering
Use HIP_API_ID_NONE to detect unsupported API instead of
HIP_API_ID_NUMBER which can grow with a new version of the API.
This HIP_API_ID_NONE enum has a fixed value of 0 so the
HIP_API_IDs really start at FIRST.

Change-Id: I760aa50ddf6fa6d46bf20555ad7d429335a53f97


[ROCm/roctracer commit: b04dfd5fdf]
2021-06-30 09:52:20 -04:00
Freddy Paul 1c6c8def17 roctracer:All libraries need to be installed with LIBRARY TAG
Cmake will do the post processing required for RPATH or any other
needed for the libraries only if installed as libraries not as
regular files

FIX: SWDEV-287893
Change-Id: I9cf478fcd23b9f2e8b3bdd81aa566cad3ec2a5e3


[ROCm/roctracer commit: 1cc934204f]
2021-05-26 12:15:25 -04:00
Rachida Kebichi 99ae6ad86a SWDEV-284863 Fixed several issues preventing memcpy info dump in csv
Change-Id: I4c6323311ce8314296e81a9b9b5d8adb485e0aa8


[ROCm/roctracer commit: e5dd1e9b85]
2021-05-25 11:10:52 -04:00
Laurent Morichetti 77c83db3ef Fix random bugs discovered while reading the code
In HsaTimer::correlated_pair_ns, the time ID should be used to
select the clock ID passed to clock_gettime.

In MemoryPool::allocator_default, pass the correct value to realloc.

Change-Id: I5d10c0994c07fdeadd99c81deba4e71a4f579523


[ROCm/roctracer commit: 297b613604]
2021-05-20 21:22:16 -04:00
Laurent Morichetti 61e044e67c Make HIP_VDI the default
As this snippet shows, HCC is no longer supported by roctracer:

#if HIP_VDI
...
#else
#error HCC support dropped
#endif

Removed HIP_VDI from the CMakeLists.txt, and the source code.

Change-Id: Ib273da2a5af6d67fa1b021a7eca3ff785c8b9c73


[ROCm/roctracer commit: 8fb3cdb30b]
2021-05-20 21:20:27 -04:00