Enabling anything beyond -Wall like -Wextra or -pedantic seems impossible as our code base explodes in thousands of warnings.
-Wno-unused-{variable/function} is not present in the p4 build, but with gcc7.4.0 we get hundreds of instances of this warning being triggered in the code base.
With this change only two warnings show up during the build - -Wsequence-point and -Wunused-but-set-variable. The fix for the first is alredy in review.
Change-Id: I2ff37981377487b0e07fd9490498e38a60792c0c
[ROCm/clr commit: 947dbe82fb]
Similar to http://gerrit-git.amd.com/c/compute/ec/vdi/+/375385, except no -Wno-strict-aliasing.
With this change only one warning shows up during the build - -Wdeprecated-declarations in cltrace.
Change-Id: Ie335eb9c45287ee1006e6bd65d54d67b41f79604
[ROCm/clr commit: ac3848a8e6]
exposing the following hip APIs which have been previously implemented:
hipMemcpy2DFromArray
hipMemcpy2DFromArrayAsync
hipMemcpyAtoH
hipMemcpyHtoA
hipMemcpyParam2DAsync
Change-Id: I3f8635bd4265d2bf5aa2084f4eabb51f74fb18ba
[ROCm/clr commit: 02c62165b8]
Rocr won't return real hops so that we have to deduce hops from
numa distance as a workaround. This will be subject to change
as driver team will provide a long term solution in rocm3.7
Change-Id: Ifb939ed848db190c3d544bb7f30a5821161921e6
[ROCm/clr commit: b14d9e0a36]
- Expose ROCclr interfaces for HIP usage
- ROCr interfaces aren't available in staging, thus control the
build with AMD_HMM_SUPPORT define
Change-Id: Iadc2bcc230e78d3b0dc22b235189c8cc80843446
[ROCm/clr commit: c5afd5d412]
Currently std::complex and some other std functions require uses to
include hip_runtime.h before any other headers to work, which is not
reliable.
changes are made in clang to fix this issue:
https://reviews.llvm.org/D81176
which requires hipcc and HIP headers to make corresponding changes.
This patch will make sure the clang change will not break
HIP/ROCclr during this transition.
After the transition is done, we can remove explicitly setting
include path for HIP-Clang and HIP header in hipcc and hip config
cmake files and rely on clang driver to set it automatically.
Change-Id: I5d226861c2560ffa6c5ab17343a43cc378048061
[ROCm/clr commit: 0a513d8a02]
Make sure runtime waits for the current queue before
synching with device queue
Change-Id: I753b6fc0bb15a3a3d4bf03fef1152842550850c0
[ROCm/clr commit: 86e0f337fc]
Use the cmake method, and consolidate setting the language standard in
one place.
Change-Id: I96826c31955b1553ed1beb94203c99933075bb0a
[ROCm/clr commit: dd5f255c7e]
1.Added hipModuleLaunchKernel multithreaded multi GPU scenario.
2.removed hipCtxCreate API from earlier test as it is deprecated.
SWDEV-238517 for enhancing hip unit tests
Change-Id: Id102d80887b6ff61a59938dbeb9fa2a26a3275b2
[ROCm/clr commit: 0920bac577]
this change follows CUDA convention where lower number is greater priority
Change-Id: I72596a36449e818cbd8c175bf8519c51f46b1610
[ROCm/clr commit: 83b8e1fbac]
Vlad Sytchenko
Aryan Salmanpour
German Andryeyev
Chauncey Hui
Tao Sang
Jason Tang
kjayapra-amd
Rahul Garg
Saleel Kudchadker
Siu Chi Chan
jujiang
Dittakavi Satyanvesh
Christophe Paquot
Yaxun (Sam) Liu
Matt Arsenault
rohit pathania
Lakhan Singh Thakur