Commit Graph

12867 Commits

Author SHA1 Message Date
German Andryeyev 3d2182f8ba Revert "Avoid lock for last queued command"
This reverts commit 88c3f77bed.

Reason for revert: <INSERT REASONING HERE>

Change-Id: Ie10442c9447f010bb90c679b6cffca5b48b8d054


[ROCm/clr commit: 44bc0cb35d]
2020-06-04 18:08:17 -04:00
Saleel Kudchadker 2a42d5838d Set hidden mem witholding to 0 by default
TF doesn't reserve all available memory now. If any
client wants to reserve they can explicitly set
HIP_HIDDEN_FREE_MEM env var
Change-Id: Ied3a948b79f49aa7327f6a820e9789e39cec143b


[ROCm/clr commit: d8ca3c632c]
2020-06-04 14:37:40 -04:00
Payam 8bdf07bb9c Observed softhang while running hipStreamAddCallbackCatch SWDEV-236746
Workaround hipStream deadlock issue as the same lock was used twice SWDEV-236746

Change-Id: Icc60104ce6edf4cfd2a3a889bab78a6caadd50b7


[ROCm/clr commit: f3ee29cdb2]
2020-06-04 14:11:22 -04:00
Saleel Kudchadker 0bdb497c1a Fix a potential mem leak
If a offset of the pointer is passed to free it may release
the mem object but may not release from MemObjMap. Erase the map
by getting the parent pointer.
Change-Id: I06b92548de2d49b4029efe6b511329225007cc55


[ROCm/clr commit: 2b6fea4348]
2020-06-04 14:05:11 -04:00
Aaron En Ye Shi 4d51dbf4f1 Add gfx908 to hip-config.cmake
Support gfx908 as part of the default AMDGPU_TARGETS. MIGraphX requires this change.

Change-Id: I692f87f27829778e04f59c9ca655c6e8cbc00abc


[ROCm/clr commit: 29c7c9b1c2]
2020-06-04 11:00:09 -04:00
Chauncey Hui 5f9321b8a0 SWDEV-2 - Change OpenCL version number from 3154 to 3155
[ROCm/clr commit: f9fd4bb186]
2020-06-04 03:00:03 -04:00
Siu Chi Chan 1f7c745330 add constexpr constructor for vector types
Change-Id: I45bb0537d6a24ee50b548c2fd8b4f20518764813


[ROCm/clr commit: 4b56aaefd6]
2020-06-04 01:57:03 -04:00
Evgeny ecdca97a00 adding hipGetStreamDeviceId() profiling API
Change-Id: I5ccf88ddac123260d7c17defefcf20ff3b2504e2


[ROCm/clr commit: 0c0a8fc108]
2020-06-03 18:57:49 -04:00
Vlad Sytchenko 20c5916b32 Handle the option USE_COMGR_LIBRARY correctly
This is a follow up to http://gerrit-git.amd.com/c/compute/ec/vdi/+/359563. The setting is now either ON or OFF, never "yes".

Change-Id: I031d013a8d239dc72ef610da81bd31b8b78a3ba8


[ROCm/clr commit: 3a84fcd13e]
2020-06-03 17:25:47 -04:00
Tao Sang a0506189a1 Fix TC linux build issue due to previous Numa patch
Change-Id: I6068edaf38cac6fad187c8429707afdb727e8d41


[ROCm/clr commit: fabfc42b68]
2020-06-03 16:42:53 -04:00
Aaron En Ye Shi b2f9e1c299 Add compiler-rt library for __fp16 and _Float16
Similar to HCC, link with compiler-rt to support __fp16 and _Float16 type conversions in ONNX models. This should resolve SWDEV-238491.

Change-Id: Iad8dcff568831719f501f562a04023326ae8036c


[ROCm/clr commit: d93134e727]
2020-06-03 18:53:14 +00:00
Siu Chi Chan 85d781ba65 update device library path
fix device lib directory

add missing --hip-link switch for link phase

Change-Id: I4b2eeb32648ca3cec72ec1f4e3381ce1fc0a90a5


[ROCm/clr commit: c414c70e8f]
2020-06-03 14:44:23 -04:00
Vlad Sytchenko 1f915dddd2 Disable oclruntime OCLPerfCounters test
For some reason the test is causing latest rocr to crash. Disabling for now to investigate.

Change-Id: I78996241e6756c36af4b7f5fcb34e915bf33573e


[ROCm/clr commit: ce2c28c745]
2020-06-03 13:57:40 -04:00
Vlad Sytchenko 30621ae614 Add cmake targets to run ocltst test modules
Tests are now excluded from the main build, however ocltst can still be built by running `cmake --build . --target ocltst`.

Test modules can be run by invoking the test_${module_name} target, for example `cmake --build . --target test_oclruntime`.

Change-Id: I6f40d3bd318e821e4fbf35ccfa395dc7036673cb


[ROCm/clr commit: 8790099ba9]
2020-06-03 13:55:28 -04:00
kjayapra-amd 4afb215e53 FEAT-30761 - Adding gfx1031 to known targets in hipcc on amd-npi-next branch
Change-Id: I0f7fb414d53bd83087681ddb4e6a86802ba3c3ba


[ROCm/clr commit: 426d1d2c28]
2020-06-03 12:54:51 -04:00
kjayapra-amd a9ead10354 SWDEV-234295 - Dont clear device programs during amd::program::build()
Change-Id: I87bc7e2c830edee783ee490bbb087492467f2704


[ROCm/clr commit: e9bd41bf1a]
2020-06-03 12:18:25 -04:00
jujiang 0a5bd447d0 Merge updated HIP documents from amd-master-next to npi-next
Change-Id: Id511f398590a20ddc1ae03818099cdc55c507fdc


[ROCm/clr commit: 5f951fb21c]
2020-06-03 11:41:11 -04:00
Chauncey Hui 41d93c5cad SWDEV-2 - Change OpenCL version number from 3153 to 3154
[ROCm/clr commit: 298dd2ff3f]
2020-06-03 03:00:03 -04:00
Jatin 216873e9c8 Adding changes for hipExtLaunchKernel for rocCLR
Change-Id: Iba52bc3bde7c37f3fb375a55ba0947e87b3cdc9b


[ROCm/clr commit: 126573df4c]
2020-06-02 14:16:41 -04:00
Vlad Sytchenko fbc4d1b788 Only build oclgl tests if OpenGL is installed on the system
Change-Id: I226f2e09c98a970ce8dce0b6f670ca13d868aeb6


[ROCm/clr commit: 876cf62e0e]
2020-06-02 13:31:29 -04:00
Jason Tang 428cf966e7 Use ROCMSetupVersion only when ROCM is found
Change-Id: I2d76762aaa6c89b2ba956dcb62b3f79f6208a365


[ROCm/clr commit: 1171ec72be]
2020-06-02 10:40:25 -04:00
Matt Arsenault ff922a013e Use standard cmake option for USE_COMGR_LIBRARY
Change-Id: Id94d88a33772d9c9ab28f9a82c6f761d9c867476


[ROCm/clr commit: 0c539737cf]
2020-06-02 10:32:45 -04:00
Jenkins eb774da975 Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: I6f11cdf974f5e77b9f5210ac4da1eca08a655ab7


[ROCm/clr commit: 3bf16f4093]
2020-06-02 09:22:34 +00:00
Chauncey Hui bc71aa08e3 SWDEV-2 - Change OpenCL version number from 3152 to 3153
[ROCm/clr commit: 3eda2acdf8]
2020-06-02 03:00:03 -04:00
Rahul Garg 247e111c91 Use right perl-which rpm package
Change-Id: I22106a7d1b4b50c99f945bc6416ff3bd8486d15c


[ROCm/clr commit: db471e5ed9]
2020-06-02 02:17:54 -04:00
Tao Sang 6041b06b61 Support Numa-aware cpu selection
Select cpu in terms of the smallest Numa distance for a GPU device.
This will improve performance of hipMemcpy in the mode of
hipMemcpyHostToDevice or hipMemcpyDeviceToHost for small buffer.
`

Change-Id: I2860f1f83b79be0dff7bf5e64cf68ab4448db0a1


[ROCm/clr commit: aedb9590be]
2020-06-01 21:01:24 -04:00
Alex Xie 3167f3c725 ROCMOPS-924 centos-6.10 support for opencl_on_rocclr build
Fix a build error in centos 6.10. When linking, ld cannot find function
clock_getres. This function is from librt (for glibc version before 2.17).

Change-Id: I698f768d0618a054d5d0fc73b9f1916a7ce542fb


[ROCm/clr commit: 9a8bd9e68b]
2020-06-01 17:47:03 -04:00
Jason Tang 70404ac7d7 SWDEV-204566 - Use ROCMSetupVersion to set package version
Change-Id: I29b9f748291b3802de65c9f29f791050853c2d12


[ROCm/clr commit: 4dcfe78e56]
2020-06-01 16:39:35 -04:00
Aaron En Ye Shi d2bcb05dfb HIP-Clang Temporarily include HIP_HCC_FLAGS for PyT
Change-Id: I0f5895fba69f5bf0c6cc13e9402bdc44726dcc5a


[ROCm/clr commit: a436ab865a]
2020-06-01 15:28:04 -04:00
Vlad Sytchenko 627061d190 Add ocltst build files
Change-Id: I8fcff320efb677a5efa5ee48efe1a6bbb259539f


[ROCm/clr commit: 15b318b444]
2020-06-01 14:12:51 -04:00
Vlad Sytchenko 18ce996fe2 Initial source drop of ocltst
This only adds source files for ocltst and the following test modules - oclruntime, oclperf, oclgl, ocldx. There's no build files for now.

Change-Id: I0f8d9d074c45d82e92f7d30bf22753102f272f4f


[ROCm/clr commit: 75e6add24d]
2020-06-01 13:51:51 -04:00
Aryan Salmanpour e4052cd66b Add support for missig hipStreamGetPriority API
Change-Id: I2be4b055e5f977eb6ecad0b1f5f9535e72345fe7


[ROCm/clr commit: bf11ffd175]
2020-06-01 13:33:14 -04:00
agodavar a3feb53a30 hipMemset dont enqueue command if size bytes is 0
Change-Id: I63bf896f9f23edf254acdf7a8c11c92f8b5ac039


[ROCm/clr commit: 3375920638]
2020-05-30 10:33:44 -04:00
Chauncey Hui 109e92580e SWDEV-2 - Change OpenCL version number from 3151 to 3152
[ROCm/clr commit: ffe6516bb7]
2020-05-30 03:00:03 -04:00
Alex Xie 9f1374f442 Add document README.md
Change-Id: Ib186c1b55663e397b562ec53fca2d476de0c96b3


[ROCm/clr commit: 9e4d81fcb6]
2020-05-30 01:26:03 -04:00
Payam Ghafari a0fad24cf0 Revert "adding HIP_ENABLE_LAZY_KERNEL_LOADING flag"
This reverts commit 5540e98745.

Reason for revert: HIP_ENABLE_LAZY_KERNEL_LOADING is needed before the runtime is initialized, so this utility cannot be used

Change-Id: I49f8ddb98c9a85b9a77b8fd4b236d06b6b2b0f32


[ROCm/clr commit: ac8d1ba687]
2020-05-29 21:26:25 -04:00
Rahul Garg 3e397c620a Add libfile-which-perl dependency SWDEV-237642
Change-Id: I0799fdcbc58a35c957a3bc69a8a1c6a013a3f57c


[ROCm/clr commit: 27e306686c]
2020-05-29 20:04:23 -04:00
Matt Arsenault 4eacd3d38c Don't include llvm directories
There aren't any llvm includes here.

Change-Id: Ifce797c50bde772845923b1054fadd4173b3119a


[ROCm/clr commit: 4d1cbcba4e]
2020-05-29 15:36:26 -04:00
Alex Xie a5f661537b Add more information into Readme file
Change-Id: Id3e484877eaf8123ad6c767caa5f3546c02f5d98


[ROCm/clr commit: f887aaa9d2]
2020-05-29 13:33:29 -04:00
German Andryeyev 88c3f77bed Avoid lock for last queued command
Use atomics for last queued command update

Change-Id: I759e9d78ea72f23c0d45dbede6250b231e122276


[ROCm/clr commit: dc4e09a63a]
2020-05-29 11:06:55 -04:00
kjayapra-amd 776af02dfe SWDEV-229840 - fixing return HIP_RETURN instances in hip.
Change-Id: I48763d7268bf5649bf2242c962c185f5f4af159c


[ROCm/clr commit: ab17b43d45]
2020-05-29 09:43:58 -04:00
Chauncey Hui 25f93bc284 SWDEV-2 - Change OpenCL version number from 3150 to 3151
[ROCm/clr commit: a811cfc567]
2020-05-29 03:00:03 -04:00
Aryan Salmanpour 5aec64346f [dtest] add a multi stream test for (SWDEV-237846)
Change-Id: I4a1d764df75af7019d0f38313e5e0a6a224818f8


[ROCm/clr commit: 200ab30084]
2020-05-28 23:36:10 -04:00
jujiang 4fad481033 Update document for hip_faq.md, hip_porting_guide.md and hip_terms2.md
Change-Id: I2c019f802ad70ed43f1608cfd3c9067f1573741e


[ROCm/clr commit: 017e3b87b3]
2020-05-28 17:51:58 -04:00
Christophe Paquot c5e4607065 Revert "Call notifyCmdQueue when building the event wait list"
This reverts commit df67d8971a.

Reason for revert: better fix in ROCclr

Change-Id: I9707e69adf42a662c08fe9b3ec7458655d838bdd


[ROCm/clr commit: dfec136725]
2020-05-28 17:01:10 -04:00
kjayapra-amd b91ab37e8d SWDEV-233927 - Crash if binary for current device is not found.
Change-Id: I57281ae6c09110f39155664fca5a83ea57bb62b4


[ROCm/clr commit: f2899243f3]
2020-05-28 16:18:27 -04:00
Christophe Paquot 992fbe8215 Use a dedicated lock for last queued command set/get
Change-Id: If3d2144841c7863cf7afe2ca85aea62e0a3a33c7


[ROCm/clr commit: 0782acabb5]
2020-05-28 12:49:39 -07:00
Joseph Greathouse 9b1faa7db0 Fix a build error on signed/unsigned comparison
Change-Id: Ic79eb4c3ec5c6fd36cea7c4810d990619f08b9e1


[ROCm/clr commit: 766e708535]
2020-05-28 14:27:16 -05:00
kjayapra-amd 640559bdcb SWDEV-236465 - Return error code as soon as global creation fails.
Change-Id: I790b8b4fdd6ab8818bc5b6b9a79e6900b840372d


[ROCm/clr commit: 55cdef8e45]
2020-05-28 13:28:23 -04:00
Joseph Greathouse db6de71b54 Fix occupancy calculation functions in ROCclr path
The hipOccupancyMaxPotentialBlockSize API is meant to return the
number of threads for the highest-occupancy workgroup, and the number
of those workgroups. It was previously calculating the number of
maximum-sized workgroups that would fit on a single CU. This is
a mixture of the API we wanted (to calculate max potential block size)
and the MaxBlocksPerMultiprocessor function.

This patch fixes it up so that the internal occupancy calculation
function works for two uses: the traditional function that calculates
the maximum blocks per multiprocessor when a user passes in a fixed
block size (used for hipMaxBlocksPerMultiprocessor style functions)
and a function that calculates the size of a block that would lead
to maximum occupancy, and how many blocks of that size would be
needed to fill the whole GPU (for hipOccupancyMaxPotentialBlockSize
style functions).

This also updates the occupancy calculation function to prepare for
gfx10, which does not have SGPR-based occupancy limits.

Change-Id: Ie007b3f9d5ebc4e166b50a3a051498af35650f35


[ROCm/clr commit: 90453b68d3]
2020-05-28 10:22:10 -05:00