Commit Graph

274 Commits

Author SHA1 Message Date
Anusha Godavarthy Surya c35ba37287 SWDEV-240806 - Initial commit for hipGraph and stream capture infrastructure
On StreamBegincapture captures the parameters passed to APIs and respective node will be created and added to graph
All parameters are passed to STREAM_CAPTURE macro, it checks if stream in capture mode and redirects the call to the capture function and returns
Updated hipStream and hipEvent with capture parameters
Added handling for hipStreamBeginCapture & hipStreamEndCapture

Change-Id: Ic8926a7b4336c2cc81f0b3a9a224aa392c474134
2021-05-07 17:38:16 -04:00
Maneesh Gupta 2b04d249fc SWDEV-252801 - Fail if launch params exceeds launch_bounds
Change-Id: I90c8d0f1897ca63f00c3eec7c99d649a5c43416d
2021-05-06 22:38:50 -07:00
German Andryeyev 192c47e251 SWDEV-272496 - disable direct dispatch by default
Change-Id: I706387355add75852c570be2656131ef99e8958c
2021-05-06 16:17:26 -04:00
Vladislav Sytchenko 9e545007bc SWDEV-273235 - Allow explicitly disabling LF support
Currently LiquidFlash cannot be supported from Github Enterprise,
hence we need to be able to build with out it.

Allow this by setting -DWITH_LIQUID_FLASH=0.

Change-Id: If59afe45c02a1623639360dbcc3927360f16ebd3
2021-05-06 13:05:12 -04:00
Christophe Paquot 74a75f88d0 SWDEV-270599 - Refactored the way we get time from start/stop events in all cases
Change-Id: Id3f9bcad45d643e493daf9d5f47b3a032a427177
2021-05-03 13:16:36 -07:00
kjayapra-amd 9c07201c6b SWDEV-245533 - Implementing Mipmap array APIs
Change-Id: I222c8d0fcbd50cdefd702462e689463bb36366d2
2021-04-30 16:33:43 -04:00
agodavar ace2cf2840 SWDEV-283897 - SWDEV-283901 - Fix directed and performance test failure
Change-Id: Ia0e9ab5d172802403af7bf6568f985b82e799baf
2021-04-30 17:56:44 +00:00
Tao Sang a95ff95bf7 SWDEV-283515 - Fix crashing in kernel launch on MGPUS
Fix wrong mixing of current device and stream device in
ihipModuleLaunchKernel() and hipLaunchCooperativeKernel().

Fix missing hipSetDevice() in hipMemcpyWithStream* tests.

Change-Id: I09333bb40d239bb42c832df5ea16d17eeaeff5e7
2021-04-29 14:46:47 -04:00
Anton Gorenko 6b14050424 SWDEV-272536 - (PR-2229) Fix conversion of texture addressing mode
hipAddressModeClamp corresponds to CL_ADDRESS_CLAMP_TO_EDGE.
This change fixes incorrect sampling near texture edges.

https://github.com/ROCm-Developer-Tools/HIP/pull/2229

Change-Id: Ia2af9f3cb582a74af7b1f65bad1ed0310eab2628
2021-04-29 12:19:15 -04:00
Satyanvesh Dittakavi 2122a32034 SWDEV-283213 - Fix hipMemset2D, 3D failures in Debug mode
If the width is 0, hipMemset2D or 3D APIs should return success
doing nothing
Change-Id: I97f8825d090a73ee63145e52d2b6d2cc0eddade3

Change-Id: I9d62fee70929ad0c79b947aa4cbbc8ab898fb64a
2021-04-28 18:53:53 -04:00
Rahul Garg 429b4ffd1f SWDEV-266973 - Add missing HIP_RETURN
Change-Id: Ib569a8cb030179b71406d47fd08c7e1e7ab6eb7c
2021-04-27 19:55:28 -04:00
German Andryeyev a18c778a83 SWDEV-244287 - Keep direct dispatch for Linux only
Change-Id: I09333bb40d239cb42c732df5ea16d17eeaeff5e6
2021-04-26 14:10:57 -04:00
German Andryeyev cba1544a8d SWDEV-244287 - enable direct dispatch by default
Change-Id: If506566624a218a2dd443b794c5c400bd0b9ebf7
2021-04-24 02:33:46 -04:00
Rahul Garg f2c96993e1 SWDEV-229520 - Reenable hipEventIpc test
Change-Id: Ib40fb07a07cc447182e23664573c5e37a1194a32
2021-04-21 13:55:15 -04:00
Anusha GodavarthySurya d86b4696ca SWDEV-240806 - [hip-graph] hip_memory and hip_kernel separate command creation from enqueue
hipMemcpy1D all variants, hipMemcpy3D, hipMemset, hipMemset3D and hipLaunchKernel

Change-Id: Ieeb767cf87aa0546bc3b3d5d2e01ab618e0d285c
2021-04-20 11:04:42 -04:00
German Andryeyev 9fc0bddbf0 SWDEV-278896 - Notify GPU about possible wait
Early notification allows CPU command state to be processed earlier.
Otherwise state update will be delayed until the actual possible
wait.

Change-Id: I0e9d6c2ad88e3723eab2f6dc9a20f288f6c1ca0c
2021-04-19 13:00:16 -04:00
Sarbojit Sarkar 6b8ca9a503 SWDEV-261977 - Updated API to return runtime version
Change-Id: Id2373843c854c83ba06854dd05c61755d0264d8f
2021-04-15 07:17:36 -04:00
Satyanvesh Dittakavi 68161ff0dd SWDEV-279486 - Fix hipMemcpyPeer/hipMemcpy APIs
Addresses the scenarios when the size passed is more than
the allocated size and when the deviceid is invalid
Change-Id: I6c9b62639096f655ffb61976905b1ce8c5f51ee7

Change-Id: I8a0d660924a8e2300c517aba6f9088626b8f6ef5
2021-04-09 02:53:15 -04:00
Sarbojit Sarkar 492ccc3281 SWDEV-260454 - Fix for idenfying bad streams
Change-Id: I122ff6f47535c3c76ab56ba49ab1450ef886b15f
2021-04-07 12:13:30 -04:00
Sarbojit Sarkar 3d7ecb6fea SWDEV-276319 - Added null checks
Change-Id: Ib22a333f0f599c8f0efca34f2a287bc4b118d743
2021-04-01 05:11:16 -04:00
Sarbojit Sarkar c6aac041e1 SWDEV-254441 - Fixed review comments
Change-Id: Ica13f23638be04216d152821127b2b7316f96af0
2021-04-01 00:21:19 -04:00
pghafari a1b321bba4 SWDEV-245532 - HIP - Vulkan interop
Change-Id: Iba1ef8112e318b4f099da5a4a4602e0dae7de9e3
2021-03-31 10:23:31 -04:00
Anusha GodavarthySurya 45ccc14d55 SWDEV-278873 - hipStreamCreate handle invalid flag value
Change-Id: I05c0e0b76f7b09947e48d5b9f225af305bade27f
2021-03-31 07:59:41 -04:00
Satyanvesh Dittakavi 39f4d0d244 SWDEV-277152 - Add hipMemcpy2DToArrayAsync API in headers
Also, address few scenarios for hipMemcpy2DToArray/Async to return
proper error types

Change-Id: Idbadf666a5e7bebc0f3ea8b7048b79208e04cf6b
2021-03-27 13:50:38 -04:00
Maneesh Gupta b2cb34f519 SWDEV-187253 - Print warning if launch_params > bounds
Change-Id: I138546bf816887576e797105f97ce37245911045
2021-03-24 22:29:19 -07:00
Anusha GodavarthySurya 7535ce6498 SWDEV-269085 - Fix compilation error with clang
Change-Id: Iab5902c9a2702456fbe433fdefc40541c48acb71
2021-03-22 03:02:50 -07:00
Saleel Kudchadker c8b9257c0b SWDEV-277847 - Move event lock_ to the beginning
For addMarker, assume T1 comes in first and enqueues a command C1.
Before T1 grabs the event_::lock_ it gets preempted. At this time,
T2 comes in, enqueues C2 and grabs the lock_ and updates event_. Now T1
wakes up and updates a older command C1 for the event.

Change-Id: Ia423782b23026302c40976385623cfdede32d70b
2021-03-19 15:28:08 -07:00
Tao Sang ca0cc36ef4 SWDEV-273138 - Update canUseStreamWaitValue retrieving
Remove canUseStreamWaitValue from hipDeviceProp_t.
Update canUseStreamWaitValue retrieving in hipDeviceGetAttribute().

Change-Id: I275bd42d8b03e141caaf9f1bc6b714e51ca72dfb
2021-03-18 22:42:35 -04:00
German Andryeyev 7600326eb2 SWDEV-277543 - fix destruction of the stream object
Change-Id: If2f532e66099805a7f05181e63f5454893a1a288
2021-03-18 13:24:46 -04:00
Ravi C Akkenapally 475d928be8 SWDEV-276827 - Stream Operations: match API with CUDA
Change-Id: Ia79a950561e97df3b2229f76f5512dede2babf98
2021-03-18 07:52:29 -07:00
Sarbojit Sarkar 4ba39503bf SWDEV-276319 - Fix for -ve cases
Change-Id: Ie6157e3cdbd1f959c8ea502b48286bdf102b8a0f
2021-03-18 00:21:43 -04:00
Tao Sang 38b0c952a6 SWDEV-273943 - Enable runtimeApi.event dtest
Add device_id_ in hip::event to match cuda behaviour in
hipEventQuery() and hipEventRecord().
Enable hipEventElapsedTime test on AMD platform.
Workarround sporadic crash of hipEventIpc test due to
some bug of event ipc.
Add missing hipEventDestroy() in some event tests.
Fix some logic code errors.
Fix typo in comment.

Change-Id: I9ec74c475161b3e31df48d193449023e921f2924
2021-03-16 17:12:08 -04:00
Vladislav Sytchenko e967adbdaf SWDEV-275317 - Correctly pass HIP image width to ROCclr APIs in AtoD/DtoA copies
HIP assumes that image width is in bytes, but OCL/ROCclr assumes that
it's in pixels. AtoD/DtoA need to account for this.

Change-Id: I275bd41d8b03e141caaf951bc6b714e51ca72dfc
2021-03-15 21:09:58 -04:00
Payam f17adc439c SWDEV-182753 - Throw error if launch params>bounds
Change-Id: I5f9931efac37e3149894ca116a1b0c2dcc3e5bc5
2021-03-12 19:17:08 -05:00
Rahul Garg f265af744c SWDEV-270599 - hipExtLaunchKernelGGL Event Timing Incorrect Between Two Launches
Change-Id: I599a51720f297209072c6be8fffe2aa61e1a071e
2021-03-09 12:18:39 -05:00
Satyanvesh Dittakavi 0303084b0e SWDEV-275317 - Fix hipMemcpy2DFromArray to return proper error types
Change-Id: Id722865d81460bfd2fa6ad7a198b6e3c2a08265a
2021-03-09 05:22:23 -05:00
German Andryeyev 84f8785288 SWDEV-272496 - enqueue a marker for callbacks always
The current implementation in ROCclr for callback is
based on OCL specification. If in HIP the same command
could get multiple callbacks, then ROCclr will process them in
a reverse order. Unique Markers for each callback will make
sure it won't happen.
Add a dependency wait for callbacks, since HSA signal callback
doesn't guarantee the order.

Change-Id: I9d514734e258312fe9a74d48132361eb17c52d67
2021-03-08 14:19:53 -05:00
Sarbojit Sarkar 0b3b9810c4 SWDEV-254329 - Profiler ON/OFF fix
Change-Id: I996d185d2079ce68234109564a529a187ba4f04b
2021-03-08 01:27:46 -05:00
Arya.Rafii 24837c1afc SWDEV-269246 - Implementation of hipDrvMemcpy2DUnaligned
Change-Id: I86fdd3b930cbd74c45cd31944f0ea52c0ff65a59
2021-03-04 14:38:06 -05:00
Arya.Rafii 6f1a09b47f SWDEV-269246 - Added missing exports for hipArrayDestroy
Change-Id: I730814720bb618e895efbe2f412e437110bed8bc
2021-03-04 14:29:16 -05:00
kjayapra-amd b4492a3de3 SWDEV-259566 - Adding support to retrieve handle for offsetted pointer.
Change-Id: I5da5ab6a24c6df915950637feb486b8c288e60e0
2021-03-04 12:28:56 -05:00
German Andryeyev ffc89dff8a SWDEV-272496 - Delay enqueue until callback setup
With direct dispatch enqueue occurs before callback update and
it can't be tracked in the device backend

Change-Id: Ie8793e3ddb68cc5bb36348f7a8dcdbdc87a2487c
2021-03-03 13:14:28 -05:00
Ravi C Akkenapally e89b228eac SWDEV-179105 - Stream Operations: Add swqupport for Wait and Write
Change-Id: I9d6d0665d12b62fe705ce1569a0e8264a4f23ab7
2021-03-02 12:15:46 -08:00
Tao Sang b504a9bfae SWDEV-270973 - Add missing copyright headers
Change-Id: I6bb27650f74372dae6e29c79fd6bb2022cc062fe
2021-03-01 19:46:24 -05:00
Jatin Chaudhary 6288e68175 SWDEV-272361 - Dont call memcpy2d if width is 0 or height or depth is 0
Change-Id: I22324a536d2a5e68b9fc3e5ee4ad821b49021a17
2021-03-01 14:34:58 -05:00
cjatin 23f33d5f20 SWDEV-271274 - Changing DevLogPrintf to LogPrintf for cases where error condition is being returned
Change-Id: I153d071f7859e9412ea0c69f53c53d190453d73d
2021-03-01 14:33:46 -05:00
Ashutosh Mishra abff21c4fc SWDEV-271126 - Memory obtained from getDeviceMEmory can be NULL
which can cause segmentation faults. Hence checking for its sanity

Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: I78b4d029f0926a1369a8ebbeb4aef951a8f1f1d7
2021-02-26 23:29:53 -05:00
Payam c77caa3fbf SWDEV-273405 - updated roctracer path to use env var
Change-Id: I9ec74c475161a3e310f57d193449023e921f2922
2021-02-26 14:51:26 -05:00
cjatin b74de31f2a SWDEV-273859 - Add --hip-version to comgr call
Change-Id: Iae6c1a5e958a73f5d9849c13c8b49eede914e25e
2021-02-24 23:41:34 -05:00
Arya.Rafii 76abab2f24 SWDEV-269246 - Fixed null-case logic for hipCtxPopCurrent
Change-Id: Ic173980caccde8afee85a75c55a5d536f421549e
2021-02-24 13:20:24 -05:00