Commit Graph

781 Commits

Author SHA1 Message Date
coleramos425 782ea3099b Wrap text displayed in 'Top Dispatch' table for neatness
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: c6cfa9cc26]
2024-05-28 15:34:00 -05:00
Nicholas Curtis 8bd72673e8 Add fix for case where we pass a single 'nan' value to to_avg
This is triggered by doing e.g., analyze -p <whatever> -k <kernel> -n per_kernel -b 17 18
Manifests as e.g.:

```
  ERROR [analysis] 'float' object has no attribute 'empty'
```

because of:

https://github.com/ROCm/omniperf/blob/f3a0360a5640e4539fac534f73876f51ddd268d0/src/utils/parser.py#L135

Instead, we first check whether numpy thinks the whole array is nan's, and bail early if so

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: 047d7771f3]
2024-05-28 15:34:00 -05:00
Nicholas Curtis f7da503e6f handle unspecified case
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: 1f584c1612]
2024-05-28 15:34:00 -05:00
Nick Curtis 562e36a5c3 fix formatting
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com>


[ROCm/rocprofiler-compute commit: 5579beeed5]
2024-05-28 15:34:00 -05:00
Nick Curtis fbb384bd2f Add ability to overide arch when name missing in rocminfo
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com>


[ROCm/rocprofiler-compute commit: 989dd3b7ae]
2024-05-28 15:34:00 -05:00
coleramos425 219914fa9e Format CMake and Python
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 1f370c9fe7]
2024-05-10 09:07:40 -06:00
coleramos425 e6b2b03f32 Add support for --quiet flag to roofline
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: dba868973b]
2024-05-10 09:07:40 -06:00
coleramos425 1517617004 Add docs for --quiet mode and update README
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 3ab51735b5]
2024-05-10 09:07:40 -06:00
coleramos425 156305f391 Update docs for new Grafana reorg
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 8bca70a6ef]
2024-05-10 09:07:40 -06:00
coleramos425 5fd6022d9a Update from https://github.com/ROCm/mibench/commit/b704bd3ec439f8cbece6713852fcafc855c5b07e
[ROCm/rocprofiler-compute commit: 519bcb9b3e]
2024-05-10 09:07:40 -06:00
Karl W. Schulz f3a0360a56 Adding a top-level runtime python dependency checker. Goal is to
provide a kinder error message in the case where python dependencies
are not available locally. This is motivated for future execution by
users who are running from rocm-based binary packaging instead of using
normal cmake build system which would have verified the dependencies.

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: d1ee2ec870]
2024-05-03 15:26:27 -05:00
coleramos425 9a0d5f0663 Replace deprecated roofline warning with logging helper function
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 7d34e80567]
2024-04-25 18:43:20 +00:00
coleramos425 efcf9001d7 Add TCC_TOO_MANY_EA_WRREQS_STALL to gfx940 input configs (#349)
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 0fc620ce79]
2024-04-25 18:22:00 +00:00
Karl W Schulz 2653dc850b additional mod needed to support roofline binaries potentially
executing from two different locations

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: b5011ff0ae]
2024-04-22 09:00:18 -05:00
Karl W Schulz ab7db47eb6 update logic to detect roofline binaries in two alternate paths
depending on whether user is running within local clone or from form
install.

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 093a4511ee]
2024-04-21 14:53:14 -05:00
Karl W Schulz c7d3c861be update logic to detect VERSION file to accommodate rocm packaging;
check two locations to cover case where user is running within local
git clone directly or alternatively, from package install.

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 3c562588ff]
2024-04-21 14:53:14 -05:00
Karl W Schulz a99b74810c fix execution error when OMNIPERF_COLOR env is set; update coloring to
support four modes:

(0) - no coloring and no loglevel delimiters
(1) - colored loglevel delimiters
(2) - non-colored loglevel delimiters
(3) - fully colored messages for all levels besides INFO

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 65967658e9]
2024-04-04 14:44:51 -05:00
coleramos425 b6e857a4ee Define a README for /src subdir
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 9403dce667]
2024-04-01 14:30:21 -05:00
coleramos425 fc315248c7 Reorganizing docs runner and setting archive subdir for old docs
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: aac471c0fa]
2024-04-01 14:30:21 -05:00
coleramos425 6287e6dad3 Remove hardcoded URLs from docs in favor of relative links
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 9c93449cc7]
2024-04-01 14:30:21 -05:00
coleramos425 55ebe7059c Move dispatch id patch to proper util func in utils. Enable in rocprofv2 post-processing
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: e0556f32ab]
2024-04-01 14:30:21 -05:00
Nick Curtis 22b596dc32 implement rocprofv2 workaround for dispatch ids (#336)
* implement rocprofv2 workaround for dispatch ids

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

* formatting

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

---------

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>

[ROCm/rocprofiler-compute commit: a1017b68e9]
2024-04-01 14:30:21 -05:00
coleramos425 22e5069fc5 Adding documentation for global command line options
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 1a3bdad90a]
2024-04-01 14:30:21 -05:00
colramos-amd 5d15f4d6fa Restore OMNIPERF_COLOR global to disable default log coloring
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 6cc8f0154f]
2024-04-01 14:30:21 -05:00
colramos-amd 091e796643 Extending log coloring to message text. Enable by default.
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: b1d0b3905c]
2024-04-01 14:30:21 -05:00
colramos-amd dc13c30d74 Remove superfluous logging statement
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 78c48eaed5]
2024-04-01 14:30:21 -05:00
colramos-amd e170da2c39 Throw more helpful warning on missing csv in analyze mode (#313)
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: f47b8d2547]
2024-04-01 14:30:21 -05:00
coleramos425 e1470d7a38 Register TRACE loglevel ahead of parse_args to avoid error in --specs printout
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 706afa7f37]
2024-04-01 14:30:21 -05:00
Cole Ramos fa02efc962 Revert #333 deterministic ordering (#337)
* Revert "formatting"

This reverts commit e387561791898467371b6219921f10447d3486b3.

* Revert "Implement deterministic ordering of perfmon"

This reverts commit 2a24600a37c8002838145962a957cea447555b0c.

[ROCm/rocprofiler-compute commit: f7394bf272]
2024-04-01 14:30:21 -05:00
Nicholas Curtis ed86d5c64c formatting
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: f6f6165379]
2024-04-01 14:30:21 -05:00
Nicholas Curtis 3ff4117c4e Implement deterministic ordering of perfmon
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>


[ROCm/rocprofiler-compute commit: 97af96e435]
2024-04-01 14:30:21 -05:00
colramos-amd e55b9b1d34 Adding redirect to help button in standalone GUI
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 3928f36d5e]
2024-04-01 14:30:21 -05:00
colramos-amd fad337db06 Removing unused modules
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 33e763178e]
2024-04-01 14:30:21 -05:00
colramos-amd 8a9123d722 Documentation enhancements and removing watermark
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 3d8b748924]
2024-04-01 14:30:21 -05:00
colramos-amd 4a1293b5d7 Adding comments to roofline and changing output file name for specificity
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 73ac6c9561]
2024-04-01 14:30:21 -05:00
colramos-amd da0986846e Implementing docs feedback with typos and minor enhancements
Co-authored-by: Jose Santos <josantos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: cf36fb7fbf]
2024-04-01 14:30:21 -05:00
colramos-amd 033c4e8fc5 Correct typo in Mi100 metric defs for missing SQ_INSTS_VMEM
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 6cfdca93b9]
2024-04-01 14:30:21 -05:00
colramos-amd 2c8f4de5e4 Responding to first round of Ben R.'s docs feedback.\n\nThis round includes fixes for comments up to the 'Performance Model' section. I will need to work with our documentation group to respond to those higher level comments.
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 20670da2b7]
2024-04-01 14:30:21 -05:00
colramos-amd 58d876a2c2 Add timestamp override to rocprofv2 and format Python
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: dfdd8dd21d]
2024-04-01 14:30:21 -05:00
colramos-amd a83ea5d582 Create general_options() func to reduce code in parser
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 482fd6f2ca]
2024-04-01 14:30:21 -05:00
Nick Curtis c693890216 Fix for #300 (#331)
On some versions of numpy/pandas, applying a str map to an empty series doesn't change the type.
As a result, when adding a float to a string, sometimes numpy dies with a uadd error.
We fix this by explicitly casting to a str first

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>

[ROCm/rocprofiler-compute commit: d72ef52208]
2024-04-01 14:30:21 -05:00
David Galiffi e64e8b5604 Updated links in documentation. (#329)
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: ddb5c0ccc9]
2024-04-01 14:30:21 -05:00
David Galiffi 376a86d2d0 Updated links in documentation. (#328)
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: f5712875aa]
2024-03-21 10:14:37 -05:00
colramos-amd 8943f686f5 Fixing visualization for Compute Pipeline SOL. Need to consider 'Pct of Peak' rather than 'Avg'
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 62221383a7]
2024-03-18 14:28:14 -05:00
Karl W Schulz fbb88baa20 apply formatter
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 4fc30eb5c4]
2024-03-15 16:40:13 -05:00
Karl W. Schulz 70fa822698 update doc watermark for release candidate
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 03ddba538d]
2024-03-15 16:31:42 -05:00
Karl W Schulz 19a9e0431c apply formatter
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: f4070e3654]
2024-03-15 14:04:49 -05:00
colramos-amd 104bf46b4b Update docs for MI300 support
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: b436415784]
2024-03-15 12:48:00 -05:00
colramos-amd fa0cc81720 Update roofline distro_map for Ubuntu22.04 (#319)
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 2dcad38028]
2024-03-15 12:47:30 -05:00
Karl W Schulz a8dcdec00f tweak logger formatter to suppor OMNIPERF_COLOR=2 which includes the
loglevel name in output, but without color

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 69de978d35]
2024-03-15 09:31:22 -05:00