Commit Graph

4193 Commits

Author SHA1 Message Date
mhbliao a45de95113 Fix mathlib and app builds with hip-clang. (#1665) 2019-11-18 08:18:20 -08:00
Rahul Garg ff31f734fe Fix gcc build on NVCC path (#1661)
* Fix gcc build on NVCC path

* Fix CI build errors

* [dtest] Fix texture and surface obj2D tests
2019-11-18 12:19:22 +05:30
Nick Curtis cae9b13020 fix complex conjugate for double-complex (#1659)
The sign in the y component returned from hipConj incorrect for double-complex. Fix to match as in hipConjf above.
2019-11-18 12:19:12 +05:30
Sarbojit2019 7985ad218f Added null check in hipEventSynchronize (#1627)
* Added missing null check in hipEventSynchronize
* Minor correction in the Event API description
2019-11-18 12:18:55 +05:30
jiabaxie 7bbd420068 Updated hipEnvVarDriver to work with Windows (#1614)
* Updated hipEnvVarDriver to work with Windows

* Cleaned up a bit of code

* Fixed a part where putenv was used for both win and linux

* Defines moved to test_common.h and cleaned up code

* Cleaned up some macro defines and used const char instead

* Got rid of some excess commenting

* directory paths are unconditional

* Cleaned some duplicate code, and variables are now declared and defined together
2019-11-18 12:18:29 +05:30
kjayapra-amd 99da905509 [dtests] Fixing compilation error in saxpy.cpp (#1608) 2019-11-18 12:18:11 +05:30
Alex Voicu 355d0bdf95 Add support for extended launch syntax. (#1530)
* Add support for extended launch syntax.

* Add unit test.

* Fix typo

* hipExtLaunchKernelGGL lives in hip_ext.h

Change-Id: Ice32dab0d43475fda65c6a910c11416871a8f2ff

* [dtest] remove redundant include from hipModuleGetGlobal dtest
2019-11-16 22:24:07 -08:00
Maneesh Gupta 4d0a234183 [ci] Fix failures on nvcc path (#1654)
Change-Id: I97f6b51314e14965618ab510bf57a2b034183e78
2019-11-15 07:58:40 +05:30
Maneesh Gupta 5a03482690 [packaging] Conform to debian package naming rules (#1647)
* [packaging] Conform to debian package naming rules

* Add hip_hcc metapackage for backward compatibility
2019-11-14 11:40:34 +05:30
Evgeny Mankov cf79be0f64 Merge pull request #1651 from emankov/hipify
[HIPIFY][doc] A few words about LLVM's FileCheck in README.md
2019-11-12 16:06:25 +03:00
Evgeny Mankov bb6f1648ec [HIPIFY][doc] A few words about LLVM's FileCheck in README.md 2019-11-12 16:04:28 +03:00
Maneesh Gupta 0a2682625f Bump version to 3.0 (#1648)
Change-Id: Id1e6eb222080a339af938212e74a52c39c305eab
2019-11-10 20:23:58 -08:00
Rahul Garg 4c73950e31 Merge pull request #1643 from mhbliao/hliao/master/remove.redundant.decl
Remove redundant declarations.
2019-11-07 11:16:40 -08:00
Michael LIAO d28ad401c9 Remove redundant declarations.
- The revised `hip/hip_ext.h` have that declarations.
2019-11-07 10:11:22 -05:00
Evgeny Mankov 806ae1f43e Merge pull request #1642 from emankov/hipify
[HIPIFY] Clang style formatting
2019-11-07 12:49:52 +03:00
Evgeny Mankov 7f143585f6 [HIPIFY] Clang style formatting 2019-11-07 12:48:05 +03:00
Evgeny Mankov 367261ea0e Merge pull request #1641 from emankov/hipify
[HIPIFY][fix] Abandon canCompileHostAndDeviceInOneJob check for --cuda-compile-host-device option
2019-11-07 11:35:15 +03:00
Evgeny Mankov 4d2424ad36 [HIPIFY][fix] Delete canCompileHostAndDeviceInOneJob declaration as well 2019-11-07 11:32:53 +03:00
Evgeny Mankov 21c3d25403 [HIPIFY][fix] Abandon canCompileHostAndDeviceInOneJob check for --cuda-compile-host-device option
[Reason] It turned out that it is not so: 2 jobs are always
2019-11-07 11:30:40 +03:00
Evgeny Mankov 6f4ada4196 Merge pull request #1640 from emankov/hipify
[HIPIFY] Reorder options propagation to clang
2019-11-07 11:23:38 +03:00
Evgeny Mankov f18e63b8a9 [HIPIFY] Reorder options propagation to clang
[Reason] Leave overriding opportunity for -D, -std=c++XX, etc.
2019-11-07 11:21:06 +03:00
Jeff Daily 854147e911 General hipMemset improvements (#1495)
* hipMemset et al can use HSA API directly for synchronous cases

* lock and flush stream in hipMemset, hold lock until complete

* move hipMemset async check to front of conditional

* use hsa_amd_memory_fill for additional sync memset cases

code cleanup/review for all memset calls

* Fix inversion of execution mutating value.

* ihipMemsetSync fall back to kernel if HSA memset fails

* Never fallback, never surrender.

* Allow NULL stream.

* Optimise memset kernel. Remove deadwood.

* Update hip_memory.cpp

* Clean up stream logic in sync memset

* Revert "Clean up stream logic in sync memset"

This reverts commit 6117dedf673367f44cc704192573a117a3d92477.
2019-11-07 13:19:54 +05:30
Alex Voicu d38cc8efba Remove native vector support from the GCC case, since it never worked (#1637) 2019-11-07 13:19:14 +05:30
Sarbojit2019 97fca3439d [HIP] Fixed hipStreamAddCallback [SWDEV#165185] (#1425)
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior
2019-11-07 13:18:12 +05:30
ansurya dc8f556460 Fixed texture 2D mapping for pitched arrays & 3D Texture read (#1415)
Texture 2D image mapping for pitched arrays:
github issue: Texture Object's Buffer seems to be Misaligned #886
JIRA ticket: SWDEV-199313

SWDEV-151670 : Fixed issue with 3D texture with 4 components
SWDEV-151671 : Issue with 2D layered texture with 4 components
2019-11-07 13:17:46 +05:30
Rahul Garg dfee3ae279 Rename hip/hip_hcc.h to hip/hip_ext.h (#1341)
* Rename hip/hip_hcc.h to hip/hip_ext.h

* Deprecate hip_hcc.h
2019-11-07 13:17:10 +05:30
Rahul Garg d8e9a09064 Merge pull request #1630 from ROCm-Developer-Tools/hotfix_volatile_accessors
__half2 should walk like CUDA and talk like CUDA
2019-11-06 10:25:03 -08:00
Rahul Garg 5af7ca4445 Merge pull request #1620 from jeffdaily/hipEventRecord_patch
fix race condition in hipEventRecord
2019-11-06 10:23:24 -08:00
Evgeny Mankov c0f9c854a6 Merge pull request #1636 from emankov/hipify-clang
[HIPIFY][Win][fix] canCompileHostAndDeviceInOneJob is true only for LLVM >= 10
2019-11-06 19:27:40 +03:00
Evgeny Mankov 97a0670d29 [HIPIFY][Win][fix] canCompileHostAndDeviceInOneJob is true only for LLVM >= 10 2019-11-06 19:25:42 +03:00
Evgeny Mankov d9016ab9b7 Merge pull request #1635 from emankov/hipify-clang
[HIPIFY][doc] Update README.md
2019-11-06 19:20:02 +03:00
Evgeny Mankov 3f737625ee [HIPIFY][doc] Update README.md
+ Supported versions, testing
2019-11-06 19:18:13 +03:00
Jeff Daily b2af1820f5 hipEventRecord only needs one lock; remove locked_eventIsReady 2019-11-06 15:56:32 +00:00
Jeff Daily 444122dfb9 remove ihipEvent_t::refreshEventStatus(), new hipEventElapsedTime
This fixes possible races in hipEventElapsedTime.
2019-11-06 15:46:46 +00:00
Evgeny Mankov 2777b24abb Merge pull request #1634 from emankov/hipify-clang
[HIPIFY][format] Apply clang style formatting in LLVMCompat
2019-11-06 14:46:45 +03:00
Evgeny Mankov 4cad5fab78 [HIPIFY][format] Apply clang style formatting in LLVMCompat 2019-11-06 14:43:22 +03:00
Evgeny Mankov d0c5ab0e00 Merge pull request #1633 from emankov/hipify-clang
[HIPIFY] Add a compatibility for CharSourceRange if LLVM < 7
2019-11-06 14:32:47 +03:00
Evgeny Mankov 3dcae8760d [HIPIFY] Add a compatibility for CharSourceRange if LLVM < 7 2019-11-06 14:30:39 +03:00
Alex Voicu 1df423165b Remove leftover noise. 2019-11-06 02:46:21 +02:00
Alex Voicu 55fd1363e2 __half2 should walk like CUDA and talk like CUDA 2019-11-06 02:43:04 +02:00
Rahul Garg 6833886449 Merge pull request #1626 from mhbliao/hliao/master/fix.windows.build
Use portable macro for deprecation message.
2019-11-05 10:08:43 -08:00
Evgeny Mankov 7b1ca3dd91 Merge pull request #1595 from emankov/cmake
[HIP][cmake] Simplify `UNIX` related code (the beginning)
2019-11-05 20:30:55 +03:00
Michael LIAO 7ca43b98d1 Use portable macro for deprecation message. 2019-11-05 11:51:00 -05:00
Evgeny Mankov cf5d1caab3 Merge pull request #1624 from emankov/hipify
[HIPIFY][#1409] Fix for kernel launch macro expansion
2019-11-05 14:04:51 +03:00
Evgeny Mankov a1c380f38d [HIPIFY][#1409] Fix for kernel launch macro expansion
+ Add a corresponding test kernel_launch_01.cu
+ Add isBefore() check to avoid crash on Replacement with negative length

TODO:
+ Compatibility with former LLVM versions
+ More complicated kernel launch tests
2019-11-05 14:00:13 +03:00
Rahul Garg 8b3fce8069 Deprecate HIP Markers (#1622)
* Deprecate HIP markers

* Deprecate profiler start/stop
2019-11-05 12:32:59 +05:30
Aryan Salmanpour 7a3d592ed0 [hip][tests] Add two more workgroup sizes for testing hipLaunchCooperativeKernel (#1613) 2019-11-05 12:32:46 +05:30
Jeff Daily 6c3479a155 fix race condition in hipEventRecord 2019-11-04 17:45:11 +00:00
Rahul Garg 3b8a5cff2f Merge pull request #1618 from ROCm-Developer-Tools/hotfix_volatile_accessors
Separate volatile for clarity. Handle assignment.
2019-11-02 13:50:59 -07:00
Alex Voicu ed0d6ec51e Separate volatile for clarity. Handle assignment. 2019-11-02 22:02:08 +02:00