Commit Graph

12348 Commits

Author SHA1 Message Date
Julia Jiang a4cccd3b0e SWDEV-390597 - NoGpuTst test of Catch2 fails with docker
Change-Id: Ibf65e0ec57d47357e0afd119200622e223850b1e
2023-06-26 10:21:57 -04:00
taosang2 d9955b6707 SWDEV-407139 - Update __hipMapVector
Update __hipMapVector for C++11

Change-Id: I6179d9f3b2ddf4e42b9a6f7f3912322cfca02cfe
2023-06-25 23:15:21 -04:00
taosang2 e9e69f4c07 SWDEV-368553 - Fix C build failure
Change-Id: I56d760fa6cf8544100e3bcf3d35129bd16d8a42f
2023-06-23 18:47:53 -04:00
ajay d6946ffcbc SWDEV-406687 - combining rocblitcl and palblitcl blit kernel defs
Change-Id: Ia312d73584a03491e8d574f424295b64df6de174
2023-06-23 18:38:36 -04:00
Matt Arsenault e9750de215 SWDEV-1 - Fix -Wfinal-dtor-non-final-class
rocclr/platform/external_memory.hpp:93:30: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
   93 |     virtual ~ExternalImage() final {}

Change-Id: I56d760fa6c08544100e3bc03d35129bd16d8a428
2023-06-23 09:06:56 -04:00
Matt Arsenault 98e0607f0e SWDEV-1 - Fix -Winconsistent-missing-override
Change-Id: Ie69f234c755b112b7fe8ef7d00b8720bc178044c
2023-06-23 09:04:28 -04:00
Ioannis Assiouras 4add0e6563 SWDEV-405182 - Revert min alignment for abstract parameters stack to 16 bytes
Change-Id: I9e6ace281468e8ef11b011c58f5971ce8907f3c6
2023-06-23 04:39:51 -04:00
Rahul Garg 53ad3c6e5d SWDEV-389099 - Add initial CHANGELOG
Change-Id: I9091860684345a647ebe7167eb22a3aaf8df69a6
2023-06-23 02:35:12 -04:00
sdashmiz 2cdaf7e80f SWDEV-405485 - move the param validation
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ic3a27c47a88954da866a91494bcfb8721f33ad2b
2023-06-22 23:33:48 -04:00
Alex Xie cfc10d0e1e SWDEV-382072 - One more case that needs workaround
Change-Id: Ief81dd898e4d59ba858f38a843d79be45b5ea944
2023-06-22 19:00:34 -04:00
taosang2 f03c11491b SWDEV-368553 – Add missing mipmap Apis
Add missing mipmap Apis’ implementation.
Fix some bugs of mimpmap apis.
Use hipmipmappedArray to differentiate cuda
and driver apis on Nvidia.
Change-Id: I6079d9f3b2ddf4e42b9a6f7f3902322cfca02cfd
2023-06-22 17:24:21 -04:00
Alex Xie b961d4a970 SWDEV-382072 - [Naiv 10]EncodeSDK H264 test fails
let ROCr and addrlib decided whether a pitch is supported.
Then, check if we uses workaround.

Also improve image performance for Navi 1x in some cases.

Change-Id: If8bda46648b23c1dcfa26608ca3bb9cd89fef430
2023-06-22 10:40:31 -04:00
pghafari 9e08ecdd16 SWDEV-406821 - use int32 for grid y,z till rocm 6
Change-Id: If9eee4dd5553cc81e283cb2211cc69884808d5c1
2023-06-22 09:42:00 -04:00
Ioannis Assiouras 0af9788e32 SWDEV-406894 - Fix segfault when access HIPRTC_JIT_LOG_VERBOSE from options buffer
Change-Id: I24143dfb726d9a71fdb17b03d5b5dd910b54f5bb
2023-06-22 00:53:29 -04:00
Sourabh Betigeri 422d3ea035 SWDEV-402274 - Adds CG API group_dim() in class thread_block
Change-Id: I1c2569fffbc6fc730df9ba80786459c71140d327
2023-06-21 20:10:19 -04:00
German 9aa6f25f1c SWDEV-311270 - Clean-up IPC path in ROCclr
- Make IPC interfaces generic between devices and rely on the IPC buffer
for attach/detach logic

Change-Id: Id3c18d122030329b7ee532bbb6317de9dd6a0bbe
2023-06-20 15:18:21 -04:00
Saleel Kudchadker b2240bcda5 SWDEV-301667 - Better log
Change-Id: I3b5b3593cb0144e56a4ddea2fa29028544a73203
2023-06-20 14:26:44 -04:00
Sourabh Betigeri 0330801846 SWDEV-406750 - Fix to avoid a warning when compiling HIP runtime
Change-Id: If1d848d334bc0121a96655781fc60b0321213398
2023-06-20 12:16:16 -04:00
Konstantin Zhuravlyov 5914ac3c6e SWDEV-325538 - Enable code object v5 by default
Change-Id: I8c2bd415461403366de6e8b9157dd2fa6dc0c2a6
2023-06-20 11:08:50 -04:00
German f13988b88b SWDEV-404940 - Pass -cl-uniform-work-group-size to clang
Change-Id: I460dd848d439204e60f618669aef86f77e094c1a
2023-06-19 19:44:29 -04:00
Jeremy Newton 03bfa61684 Install .hipVersion into datadir for linux
Starting with LLVM 16, we can put .hipVersion in datadir for better
Linux FHS compliance:
https://github.com/llvm/llvm-project/commit/082593ff7aff68060bd66dccfa43493d07d9c255

For Windows, we can keep it status quo.

Change-Id: Id15ed0dac346fabec21ee060e7576ce085b1af70
2023-06-19 11:41:46 -04:00
Saleel Kudchadker 4510caed26 SWDEV-384557 - Include query under env var
Change-Id: Ibe0335168f9ad0cb72abb2ed69a5e40d33ce7c1c
2023-06-16 15:09:46 -07:00
ajay 169d17f47f SWDEV-404940 - __amd_rocclr_initHeap in pal.
Avoid Seg fault on Windows

Change-Id: I3901c003dd33222ec9e2600c519d8503f5e81c01
2023-06-16 11:48:42 -04:00
Jatin Chaudhary be02e1e524 SWDEV-399522 - Fix the issue #2 raised on github clr repo. Adds signed long long atomics
Change-Id: I09c386d45e219e472d2da1449f678b9d17fe3e2e
2023-06-16 08:53:45 -04:00
Jaydeep Patel a6e72de83d SWDEV-403768 - Check mem type is managed and result mem addresses are not null.
Change-Id: Ib40c468a981e0dd42b2da65aeb7543b11af4bc90
2023-06-16 08:49:21 -04:00
Jaydeep Patel 0a20da39cd SWDEV-403770 - Add validations.
Change-Id: If36202ba9777d2a0d6f8ee92982dbff92bafe81a
2023-06-16 02:37:25 -04:00
sdashmiz 38a67df312 SWDEV-403638 - Fix warnings
- disable deprecated function use warning
- disalbe size_t to .type' warning
- disable conversion from 'type1' to 'type2' warning

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I64161fd37cf56de3d132102103267ae8da40193a
2023-06-15 12:17:22 -04:00
sdashmiz cc85289739 SWDEV-403063 - Clean up hip graph
- Replace dynamic allocation with embedded struct in hip graph

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Idfe3f7393fa50d6e510d4c88f779408f96d3accb
2023-06-15 12:17:09 -04:00
German 1a0c3e4dc4 SWDEV-311270 - Add IPC support for memory pools
Initial implementation for hipMemPoolExportToShareableHandle,
hipMemPoolImportFromShareableHandle,
hipMemPoolExportPointer and hipMemPoolImportPointer

Change-Id: I0ebdc48e9163b394ded560adca6c38bbc5aee7d1
2023-06-15 11:36:52 -04:00
Jaydeep Patel ec75a3e60e SWDEV-403766 - Release mem obj while device reset.
Change-Id: I8a93061c9c4ed692bf7ba1b872af370f79a13a5d
2023-06-15 09:52:50 -04:00
Jatin Chaudhary f7f70a0880 SWDEV-400136 - change make_complex function name to make_hipComplex
Change-Id: Ia276610286df80ec35fe11f303eb9919eeda87dd
2023-06-15 09:02:38 -04:00
Saleel Kudchadker 8d193c32bb SWDEV-384557 - Use toggle for SDMA query
- Use HIP_USE_SDMA_QUERY env var toggle for new API use. Env var is 0 by
default

Change-Id: If725a0c41e15f78a1a6c3f47942954fe9240b4db
2023-06-15 01:02:24 -04:00
Jacob Lambert 8047d8e3e8 Revert "SWDEV-371628 - Shift device lib linking into clang driver"
This reverts commit a4c5c44008.

Reason for revert: Performance regressions and failures observed. Need to investigate those and before re-applying patch

Change-Id: I42ba0605797f9bdcfb5d5102927dd01405cf05e3
2023-06-15 00:56:08 -04:00
Jason Tang a4bba6d705 SWDEV-404928 - Remove rocm-opencl depends of rocm-ocl-icd
Will replace rocm-ocl-icd with packaging of khronos opencl-icd-loader

Change-Id: I26da58e80fd1426b9908d0b524f93b17ab27626d
2023-06-14 14:35:57 -04:00
Ioannis Assiouras d2e36bc047 SWDEV-386069 - Added nvidia and AMD config.cmake files as part of the dev package
Change-Id: I3c9a65b287822d91407996ca59ac90051b749923
2023-06-07 04:55:52 -04:00
Jaydeep Patel 2c9c58e7bb SWDEV-403995 - uniform_work_group_size is interger type is 1 for true and 0 for false. Lighting kernel's init sets uniform work group flag and hence not need to set it from options.
Change-Id: Ife45c1e3ccef03d16d7e07c3e0714fd8fd388fd3
2023-06-06 23:05:25 -04:00
Rahul Garg 17c052ca9a SWDEV-379678 - Take hipcc/hipconfig from hipcc
Change-Id: I53a6e5108e142860747186c0e7ed4fc2cb384a69
2023-06-06 17:21:59 -04:00
jatang a456182888 SWDEV-373396 - OCLCreateBuffer: make the CPU checkResult() 4 times faster
Change-Id: If20cd6b509896a748f74ab5296cb85f2c4a9f04c
2023-06-06 17:15:34 -04:00
Ioannis Assiouras 4f5dfa77bd SWDEV-401852 - Do not define hipCreateChannelDesc for long types in LP64
Change-Id: I56881a229ea666269d575c6bdfde5081562ec009
2023-06-06 14:28:15 -04:00
Jaydeep Patel 9daf8e3177 SWDEV-404118 - Change to uint.
Change-Id: Ib9ced171a4330e868a584bfb86d7ee5418e784ed
2023-06-06 13:17:56 -04:00
Ajay 16c6b365c2 SWDEV-400515 - populate __HIP_NO_IMAGE_SUPPORT flag
MI300 does not support image APIs.
Apps to use __HIP_NO_IMAGE_SUPPORT instead of arch

Change-Id: I91178bfd27ea7b7188e7a958a876c0264f4469aa
2023-06-06 12:11:41 -04:00
German c0e9734c35 SWDEV-403871 - Add MS platform recognition
Change-Id: Ie01e876f9322e35f4430352d1e4328f613133ee5
2023-06-06 11:57:07 -04:00
Maneesh Gupta 68238c99d2 SWDEV-397358 - Revert "Return hipErrorNotSupported for unsupported APIs"
This reverts commit c6647487e0.

Change-Id: Idb18e1ce6bcfc1da144fabf1ba01329f4f6604a5
(cherry picked from commit 8d1b76f4c6dc44bd05f6b6117d5354c54bee5c0b)
2023-06-05 04:55:33 -04:00
Satyanvesh Dittakavi 287f607d2b SWDEV-395996 - Add double precision constants to math constants header
Fixes a typo and adds missing constants matching cuda

Change-Id: Iebf47d107af361cbd356c2a3b9cd6ef121d01363
2023-06-05 03:31:27 -04:00
Jaydeep Patel 0064fac887 SWDEV-403762 - Fill pciBusId even if len <=12.
Change-Id: Iaf1b3314f4ae5597d42d54eb4c977667ecbb9cfb
2023-06-02 10:47:21 +00:00
Ranjith Ramakrishnan f788150132 SWDEV-366831 - Compile time flag to switch between #warning and #error message
Using backward compatibility paths will provide #warning message be default.
Compile time option added to enable/disable the #error message.
Updated the backward compatibility message

Change-Id: I3bab00df26145991b32176d2d76977c2e953bf5f
2023-06-01 04:22:19 -04:00
Anusha GodavarthySurya 2f83719d12 SWDEV-399098 - Change hip_init lock to use std::call_once
Updating hip_init lock to use std::call_once fixed Performance
drops in TF benchmarks for FP16

Change-Id: Ib1125ac66806b232057ba183e296ea4d0642d08d
2023-06-01 02:04:29 -04:00
Jacob Lambert 443f912c7f SWDEV-375055 - Re-enable Comgr unbundler
With recent upstream changes (D145770), we can now use the
Comgr unbundler without requiring an env field in the supplied
targetID. For users, this is consistent with previous legacy
unbundler behavior.

Change-Id: I5f085b0fa1ad352bbbb282b75367c206b75f279f
2023-05-31 16:14:08 -04:00
Jacob Lambert 1171518b97 SWDEV-380857 - Remove space in "Linker Program" used to set Comgr object name
Not a required change, but it does make dealing with temporary files generated
by Comgr easier.

Change-Id: I9c43138dd2a6c4fea965b57fbce7a087ab2bbd28
2023-05-30 13:47:26 -04:00
Jaydeep Patel d576356505 SWDEV-401847 - Update atomicMin/Max for float and double.
Change-Id: Ib5be459b8a24f0739e299ed12c9f877f8baa02b1
2023-05-29 14:27:16 -04:00