SrirakshaNag
b96eccf9d7
Adding SQ_WAVES_sum to derived counters.xml ( #394 )
...
* Adding SQ_WAVES_sum to derived counters.xml
* Update test check for derived counters
---------
Co-authored-by: Benjamin Welton <bewelton@amd.com >
[ROCm/rocprofiler-sdk commit: f84c2f4386 ]
2024-01-23 12:39:47 -08:00
Gopesh Bhardwaj
4b2161cafa
pandas installation should be a warning ( #402 )
...
* pandas installion should be a warning
* Removing pandas check
[ROCm/rocprofiler-sdk commit: 66b411d328 ]
2024-01-23 13:41:44 -06:00
Jonathan R. Madsen
37d7930a60
Tools update ( #397 )
...
* Srnagara/tool counters collect (#331 )
* Adding counter collection capability to tools
* Adding counter collection feature to tools
* Adding counter collection capability to tools
* Fixing merge down issues
* Small tool fixes for build + prevent profile realloc
* Reproducing the counter name query issue in buffered callback
* Minor fix for init order + sample that directly uses sdk-tool for debug purposes
* Adding a temporary fix to print the counter names
* Fixing the output file name and reverting the changes of caching the profile config
* Fixing SGPR_Count value
* cleaning up debug prints
* Adding header to counter collection file
* Adding kernel filtering support
* Remove threading
* Cleaning up the code
* Removing redundant prints
* Revert "Remove threading"
This reverts commit 05c58fb9de826e92cf8d2e3d1c31d5578525dcb4.
* Revert "Cleaning up the code"
This reverts commit 1d964882bf2396dee8ad020cbb6c83b36e0674e9.
* Changing the tools code to align with init-order fix
* cmake formatting (cmake-format) (#335 )
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
* source formatting (clang-format v11) (#336 )
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
* Adding support for async memory copy
* source formatting (clang-format v11) (#391 )
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
* Fixing header typo
* Fixing tool_fini
* Replaceing the direction and kind fields values with description
* Update lib/rocprofiler-sdk-tool/helper.cpp
- Remove use of VLA
* Update lib/rocprofiler-sdk-tool/tool.cpp
- Formatting
* Migrate common/config.* to rocprofiler-sdk-tool
* Update lib/rocprofiler-sdk-tool/tool.cpp
- fix clang-tidy issues
* source formatting (clang-format v11) (#392 )
Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com >
* Update lib/common/mpl.hpp
- is_string_type / is_string_type_impl for deducing if type is a string type
* Update include/rocprofiler-sdk/fwd.h
- ROCPROFILER_BUFFER_TRACING_MEMORY_COPY_NONE starts at zero
* Update lib/rocprofiler-sdk/hsa/async_copy.*
- functions for operation ids and names
* Update lib/rocprofiler-sdk/buffer_tracing.cpp
- support iterating and getting names for ROCPROFILER_BUFFER_TRACING_MEMORY_COPY
* Update lib/rocprofiler-sdk-tool/config.*
- env ROCPROFILER_ prefix -> ROCPROF_ prefix
- add support for memory copy tracing, counter collection, etc.
* Update lib/rocprofiler-sdk-tool/helper.*
- removed TracerFlushRecord
- removed cxa_demangle (use one in common library)
- removed GetCounterNames (handled in config)
- removed GetKernelNames (handled in config)
* Add lib/rocprofiler-sdk-tool/output_file.*
- separate out get_output_stream function and output_file struct from tool.cpp
* Add lib/rocprofiler-sdk-tool/csv.hpp
- write_csv_entry automatically quotes strings
- csv_encoder struct enforces correct number of columns
* Update lib/rocprofiler-sdk-tool/CMakeLists.txt
- add new files
* Update lib/rocprofiler-sdk-tool/tool.cpp
- update construction of output_file class
- add kernel_symbol_data for serializing kernel trace data
- use config instead of env lookups
- optimize counter collection profile config lookup/creation
* Update bin/rocprofv3
- rocprofv3 --help exits with 0 (as it should)
- command-line arg for memory copy tracing
- command-line arg for mangled kernels
- command-line arg for truncated kernels
- env ROCPROFILER_ prefix -> env ROCPROF_ prefix
* Update tests/async-copy-tracing/validate.py
- update test_async_copy_direction to new enum values
* Update tests/kernel-tracing/validate.py
- update test_async_copy_direction to new enum values
* Update tests/tools/json-tool.cpp
- add ROCPROFILER_BUFFER_TRACING_MEMORY_COPY to supported buffer_name_info
* Update samples/counter_collection/{CMakeLists.txt,main.cpp}
- remove counter-collection-sdk-tool
* Update .github/workflows/docs.yml
- fix paths triggering running the workflow
---------
Co-authored-by: Benjamin Welton <bewelton@amd.com >
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com >
* adding counter collection support
* Adding counter collection test
* changing directory structure of counter collection tests
* Fixing test path for rocprofv3
* Adding hsa-tracing basic test
* cmake formatting (cmake-format) (#362 )
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com >
* counter collection tests drop2
* fixing hsa-trace test for rocprofv3 path
* python formatting (black) (#371 )
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com >
* both counter colleciton and tracing should work together
* Fixing rocprofv3 path
* Attempt to fix Segfault with AddressSanitizer
* fixing sanitizer segfault
* Update rocprofv3
* Update lib/rocprofiler-sdk-tool/README.md
- update env variables
* Update lib/rocprofiler-sdk/buffer_tracing.cpp
- return ROCPROFILER_STATUS_BUFFER_NOT_FOUND if buffer tracing service is configured with invalid buffer
* Update lib/rocprofiler-sdk-tool/tool.cpp
- designated hsa API trace buffer
* Update tests/hsa-tracing/CMakeLists.txt
- Fix environment
* Update rocprofv3
- do not override HSA_TOOLS_LIB
- support ROCPROF_PRELOAD
- LD_PRELOAD librocprofiler-sdk.so
* Restructure tests directory
- move all rocprofv3 integration tests into subfolder
* Update cmake/Templates/rocprofiler-sdk/config.cmake.in
- create rocprofiler-sdk::rocprofv3 cmake target
* Update tests/rocprofv3/hsa-tracing
- improve validate.py
- convert input to dict via csv.DictReader
* Update tests/apps/CMakeLists.txt
- fix build rpath for simple-transpose
* Update cmake/rocprofiler_memcheck.cmake
- prefer libtsan.so.0
* Update tests/rocprofv3/hsa-tracing
- move to tests/rocprofv3/tracing
- include kernel tracing and memory copy tracing
* Update lib/rocprofiler-sdk-tool/tool.cpp
- normalize "_ID" vs. "_Id" in CSV column names (use "_Id")
* Update lib/rocprofiler-sdk/buffer.{hpp,cpp}
- change signature of buffer::get_buffers()
- buffer::get_buffers() uses static_object
* Update lib/rocprofiler-sdk/context/context.cpp
- update usage of buffer::get_buffers()
- now returns pointer
* Update lib/rocprofiler-sdk/tests/buffer.cpp
- update to change for signature of buffer::get_buffers()
* Update tests/rocprofv3/tracing/CMakeLists.txt
- use %argt% with -d argument
* Update lib/rocprofiler-sdk-tool/tool.cpp
- use atexit for finalization
* Update tests/rocprofv3/tracing/CMakeLists.txt
- tweaked name of tests
* Update lib/rocprofiler-sdk/hsa/async_copy.*
- async_copy_fini + reference counting signals
* Update lib/rocprofiler-sdk/registration.cpp
- invoke hsa::async_copy_fini() to prevent data race on signals
---------
Co-authored-by: SrirakshaNag <104580803+SrirakshaNag@users.noreply.github.com >
Co-authored-by: Benjamin Welton <bewelton@amd.com >
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
Co-authored-by: gobhardw <gopesh.bhardwaj@amd.com >
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 1f4cf1aa39 ]
2024-01-22 19:06:25 -06:00
Jonathan R. Madsen
9e2726b408
Update cmake/rocprofiler_config_nolink_target.cmake ( #395 )
...
- skip getting target properties if not a cmake target
[ROCm/rocprofiler-sdk commit: bd80fa168e ]
2024-01-22 00:55:03 -06:00
Jonathan R. Madsen
93f2a75c3b
ROCTx Library Tracing ( #390 )
...
* Update include/rocprofiler-sdk/marker/*
- Update rocprofiler_marker_api_args_t for all API functions
- Add ROCPROFILER_MARKER_API_ID_roctxGetThreadId to rocprofiler_marker_api_id_t
* Update include/rocprofiler-sdk/marker/api_args.h
- fix include
* Update lib/common/mpl.hpp
- is_pair
- is_type_complete_v
* Update include/rocprofiler-sdk/marker/*
- fix rocprofiler_marker_api_retval_t
- add roctxGetThreadId to rocprofiler_marker_api_args_t
- fix type in enum: HsaDevice -> HsaAgent
- add table_api_id.h
* Update include/rocprofiler-sdk/marker.h
- include marker/table_api_id.h
* Update include/rocprofiler-sdk/buffer_tracing.h
- Buffer marker tracer records have begin and end timestamp
* Add lib/rocprofiler-sdk/marker
- tracing implementation for marker (roctx) library
* Update include/rocprofiler-sdk/{buffer_tracing,marker/table_api_id}.h
- rocprofiler_buffer_tracing_marker_record_t -> rocprofiler_buffer_tracing_marker_api_record_t
* Update lib/rocprofiler-sdk/buffer_tracing.cpp
- support for ROCPROFILER_BUFFER_TRACING_MARKER_API
* Update lib/rocprofiler-sdk/callback_tracing.cpp
- support for ROCPROFILER_CALLBACK_TRACING_MARKER_API
* Update lib/rocprofiler-sdk/intercept_table.cpp
- template instantiation for notify_runtime_api_registration
* Update lib/rocprofiler-sdk/registration.cpp
- enable roctx in rocprofiler_set_api_table
* Update lib/rocprofiler-sdk/marker/marker.cpp
- rocprofiler_buffer_tracing_marker_record_t -> rocprofiler_buffer_tracing_marker_api_record_t
* Update lib/rocprofiler/tests for roctx testing
- add roctx.cpp
- unit tests for roctx callback and buffer tracing
- support marker API in get_{buffer,callback}_tracing_names()
* Update lib/common/logging.cpp
- logging initialized message mentions env variable
* Update lib/common/mpl.hpp
- NOLINT for misc-definitions-in-headers
* Update lib/rocprofiler-sdk/tests/CMakeLists.txt
- include LD_LIBRARY_PATH in rocprofiler-lib-tests-shared tests
* Update lib/rocprofiler-sdk/registration.cpp
- client_library_vec_t is now vector of option<client_library>
- enables resetting the client_library after finalization
- removed acquiring registration lock when invoke_client_finalizers called via atexit
- this was causing some lock-order-inversion warnings (potential deadlock)
* Update lib/rocprofiler-sdk/agent.cpp
- model name for agent supports spaces
* Update tests/common/serialization.hpp
- add serialization support for marker tracing data structures
* Update tests/apps
- Add ROCTx markers into reproducible-runtime and transpose
* Update tests/tools/json-tools.cpp
- add marker tracing support
- remove strdup (no longer necessary)
* Update tests/kernel-tracing/validate.py
- validate marker API tracing data
* Update tests/async-copy-tracing/validate.py
- validate marker API tracing data
* Update cmake for load path resolution during testing
* Update tests/async-copy-tracing/CMakeLists.txt
- fix test LD_LIBRARY_PATH
* Update cmake/Templates/rocprofiler-sdk-roctx/config.cmake.in
- fix constructing rocprofiler-sdk-roctx::rocprofiler-sdk-roctx
[ROCm/rocprofiler-sdk commit: 21dd088c8e ]
2024-01-18 09:48:06 -06:00
Gopesh Bhardwaj
3e038d871c
cloning doxygen-awesome-css to external ( #389 )
...
[ROCm/rocprofiler-sdk commit: b55cea0e98 ]
2024-01-17 02:44:52 -06:00
Jonathan R. Madsen
e8c7e6bfba
ROCTx Library ( #360 )
...
* Initial implementation of roctx library
* Update include/roctx/CMakeLists.txt
- fix installation
* Update cmake/rocprofiler_config_packaging.cmake
- add rocprofiler-sdk-roctx installer
* Update include/roctx/CMakeLists.txt
- include api_trace.h in installation
* Update include/roctx/api_trace.h
- add ROCTX_API_TABLE_VERSION_MAJOR define
- add ROCTX_API_TABLE_VERSION_STEP define
* Update lib/roctx/roctx.cpp
- static asserts for table size and struct member offsets
* Update external/CMakeLists.txt
- move BUILD_SHARED_LIBS to top
- disable libunwind for glog
* Update lib/roctx/CMakeLists.txt
- Update {BUILD,INSTALL}_RPATH
* Relocate include/roctx to include/rocprofiler-sdk/roctx
* Relocate lib/roctx to lib/rocprofiler-sdk-roctx
- change the name of the library from libroctx to librocprofiler-sdk-roctx
* Move lib/plugins to lib/rocprofiler-sdk-tool/plugins
- also change install export group
* Update lib/rocprofiler-sdk/CMakeLists.txt
- change rocprofiler-shared-library EXPORT group (rocprofiler-sdk-library-targets -> rocprofiler-sdk-targets)
* Update cmake/rocprofiler_utilities.cmake
- change install EXPORT group
- rocprofiler-sdk-library-targets -> rocprofiler-sdk-targets
* Update CMakeLists.txt
- set PACKAGE_NAME at high level
- include(rocprofiler_config_install_roctx)
* Update cmake/rocprofiler_config_install* and cmake/Templates/*.cmake.in
- added rocprofiler_config_install_roctx.cmake for installing roctx as a package
- reorganization of existing cmake/Templates/*-config.cmake.in files
- created new config.cmake.in and build-config.cmake.in for rocprofiler-sdk-roctx
* Relocate include/rocprofiler-sdk/roctx to include/rocprofiler-sdk-roctx
* Update rocprofiler_config_install_roctx.cmake
* Update lib/rocprofiler-sdk-roctx/roctx.cpp
- update include paths
* Update lib/rocprofiler-sdk-roctx/CMakeLists.txt
- change target name to have rocprofiler-sdk- prefix
- interface target_include_directories
- define export symbol
* source formatting (clang-format v11) (#361 )
Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com >
* Update include/rocprofiler-sdk/fwd.h
- fix doxygen markup for ROCPROFILER_STATUS_ERROR_CONTEXT_ERROR
* Update modulefile and setup-env.sh
* Update cmake/Templates/rocprofiler-sdk/config.cmake.in
- fix inclusion of rocprofiler-sdk-targets.cmake
* Update include/rocprofiler-sdk-roctx
- add types.h for typedefs
- add doxygen comments for roctx.h
- add roctxGetThreadId function
- roctxProfilerStart and roctxProfilerStop accept thread ID param
* Update lib/rocprofiler-sdk-roctx/roctx.cpp
- hsa_agent_t* -> hsa_agent_s*
* Update lib/rocprofiler-sdk-roctx/roctx.cpp
- support for roctxGetThreadId
- update signatures of roctxProfilerPause and roctxProfilerResume
* Update lib/rocprofiler-sdk-roctx/roctx.cpp
- Initialize logging with ROCTX_LOG_LEVEL
* Update include/rocprofiler-sdk-roctx/roctx.h
- remove ROCTX_NONNULL for ihipStream_t parameter in roctxNameHipStream because default stream is a nullptr
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
[ROCm/rocprofiler-sdk commit: 1edd4891b2 ]
2024-01-17 01:27:41 -06:00
Jonathan R. Madsen
12bc6c93d7
Cleanup + logging env variable ( #387 )
...
* [CP] Update tests/common/serialization.hpp
- remove duplication in rocprofiler_callback_tracing_code_object_load_data_t
* [CP] Update lib/rocprofiler-sdk/tests
- create common.hpp
- update registration.cpp to use common.hpp
* [CP] Add lib/common/logging.{hpp,cpp}
- generic init_logging function
* [CP] Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- remove excess logging
* [CP] Update lib/rocprofiler-sdk/registration.cpp
- use common::init_logging(...)
- enforce ROCPROFILER_REGISTER_FORCE_LOAD in rocprofiler_force_configure
- logging updates in rocprofiler_set_api_table
* Update include/rocprofiler-sdk/buffer_tracing.h
- rocprofiler_buffer_tracing_marker_record_t -> rocprofiler_buffer_tracing_marker_api_record_t
* Update lib/common/utility.hpp
- remove active_capacity_gate
* Update lib/rocprofiler-sdk/tests/common.hpp
- fix get_{callback,buffer}_tracing_names()
* Update lib/rocprofiler-sdk/counters/xml/{basic,derived}_counters.xml
- add entries for gfx1102
[ROCm/rocprofiler-sdk commit: dc8b8aa448 ]
2024-01-17 00:28:20 -06:00
Benjamin Welton
871048b7b9
Add check to ensure metrics are valid on GPU Arch ( #384 )
...
* Add check to ensure metrics are valid on GPU Arch
Ensure requested metrics are valid on the GPU arch. If not valid,
error is returned during profile config init.
* source formatting (clang-format v11) (#385 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
* Update metrics.cpp
* source formatting (clang-format v11) (#386 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
* Update metrics.cpp
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 0952308c4a ]
2024-01-16 21:47:45 -06:00
Benjamin Welton
099db3bab7
Drop signal limiter ( #382 )
...
* Drop signal limiter
* source formatting (clang-format v11) (#383 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: e0fd4c1716 ]
2024-01-16 19:43:24 -06:00
Jonathan R. Madsen
3c47bc534a
Update tests/apps/* to support multigpu in single process ( #374 )
...
- CPU threads will spread out across multiple devices
[ROCm/rocprofiler-sdk commit: a24b08c2db ]
2024-01-14 21:54:13 -06:00
Jonathan R. Madsen
c4a749d99e
Remove directly linking to HIP and HSA runtimes ( #373 )
...
- librocprofiler-sdk.so no longer directly links to HIP runtime library (libamdhip64.so)
- librocprofiler-sdk.so no longer directly links to HSA runtime library (libhsa-runtime64.so)
- librocprofiler-sdk.so does directly link to AQL profile library (libhsa-amd-aqlprofile64.so) so HSA runtime library is still in DT_NEEDED
- This needs to be fixed eventually so rocprofiler-sdk library can be independent of HSA and HIP runtimes
[ROCm/rocprofiler-sdk commit: 57113e98c9 ]
2024-01-14 19:05:10 -06:00
Jonathan R. Madsen
b3afc6c1ea
Support documentation build + install + packaging ( #369 )
...
* Support documentation build + install + packaging
* Fix NUM_ROCPROFILER_PACKAGING_COMPONENTS check
[ROCm/rocprofiler-sdk commit: 84499b17c6 ]
2024-01-14 08:10:14 -06:00
Benjamin Welton
60f2d204d2
Tests for agent and aql packet generation ( #365 )
...
* Tests for agent and aql packet generation
Test for agent and fixing test problems with aql packet that caused test
to not run.
* cmake formatting (cmake-format) (#366 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
* source formatting (clang-format v11) (#367 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
* Minor tweak
* source formatting (clang-format v11) (#368 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
* Add gfx900 to basic_counters
* Update samples/counter_collection/client.cpp
- fix data race by flushing buffer during tool_fini
* Fix data race for output stream destruction
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
[ROCm/rocprofiler-sdk commit: 802e79b113 ]
2024-01-14 04:46:27 -06:00
Benjamin Welton
cf296be224
Fix init order for getMetricIdMap ( #341 )
...
* Fix init order for getMetricIdMap
Ensure that getMetricIdMap() stays valid until the destruction
of the counting service. Adds a test to ensure that this behavior
is maintained (this test fails without this change).
* source formatting (clang-format v11) (#343 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
* cmake formatting (cmake-format) (#342 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
* Remove threading
* Update usage of rocprofiler::counters::get{Metric,MetricId}Map()
- uses common::static_object
* Update counter init_order testing
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
[ROCm/rocprofiler-sdk commit: ef71cc38c1 ]
2024-01-11 23:35:12 -08:00
SrirakshaNag
9e7041dba9
Fixing bugs in tracing tool output ( #349 )
...
* Fixing bugs in tracing tool output
* source formatting (clang-format v11) (#350 )
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
* correcting the formatting to match csv format
* source formatting (clang-format v11) (#353 )
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 78dd471110 ]
2024-01-10 09:43:28 -06:00
Gopesh Bhardwaj
19ec457fef
shellcheck and minor bug fix ( #347 )
...
* shellcheck and minor bug fix
* source formatting (clang-format v11) (#348 )
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 00fc6c7178 ]
2024-01-09 14:35:13 -06:00
Gopesh Bhardwaj
480c9f6662
Fixes bug when nested directories are created; eg: out/pmc_1 ( #345 )
...
* Fixes bug when nested directories are created; eg: out/pmc_1
* source formatting (clang-format v11) (#346 )
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 55918b5c1f ]
2024-01-09 12:19:00 -06:00
Jonathan R. Madsen
5e0a39e5d5
Async memory copy tracing ( #317 )
...
* Update samples/api_buffered_tracing/client.cpp
- support ROCPROFILER_BUFFER_TRACING_MEMORY_COPY
* Update include/rocprofiler-sdk/{buffer_tracing,fwd}.h
- update rocprofiler_buffer_tracing_memory_copy_record_t
- add ROCPROFILER_BUFFER_TRACING_MEMORY_COPY_HOST_TO_HOST to rocprofiler_memory_copy_operation_t
* Update lib/rocprofiler-sdk/context/context.*
- get_registered_contexts functions (local copy)
* Update tests/apps/reproducible-runtime/reproducible-runtime.cpp
- include some memory allocations and memory copies for better testing
* Update tests/common/serialization.hpp
- update serialization save function for rocprofiler_buffer_tracing_memory_copy_record_t
* Update lib/rocprofiler-sdk/hsa/hsa.*
- remove stale set_callback / activity_functor_t code
- forward decl hsa_api_meta
- template struct hsa_api_func for getting function return type and args
* Update tests/kernel-tracing/validate.py
- enforce memory_copies data size
- test timestamps in memory copies data
- improve internal and external correlation id validation
* Update lib/rocprofiler-sdk/hsa/defines.hpp
- HSA_API_META_DEFINITION macro
* Update lib/rocprofiler/hsa/rocprofiler-sdk/hsa/hsa.def.cpp
- HSA_API_META_DEFINITION specializations for async copy functions
* Add lib/rocprofiler-sdk/hsa/async_copy.{hpp,cpp}
- implements buffer memory tracing
* Update lib/rocprofiler-sdk/registration.cpp
- invoke rocprofiler::hsa::async_copy_init
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- logging improvements
- improve hsa <-> rocp agent mapping
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- load original signal in async signal handler before store_screlease
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- use store_relaxed instead of store_screlease
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- logging
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- logging
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- misc changes
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- misc changes
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- misc changes
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- return function pointer instead of lambda
* Update reproducible-runtime.cpp
- device sync
* Update tests/apps/reproducible-runtime/reproducible-runtime.cpp
- use *Async variants of hipMalloc and hipMemcpy
* Update lib/rocprofiler-sdk/hsa/async_copy.cpp
- populate async data properly
* Update tests/kernel-tracing/validate.py
- verification of async copy direction
* Update tests/apps/reproducible-runtime/reproducible-runtime.cpp
- temporarily disable async memcpy functions
* Create tests/tools
- directory containing tool libraries used for collecting data in integration tests
* Update tests/kernel-tracing
- remove kernel-tracing-test-tool library (now rocprofiler-sdk-json-tool)
- update cmake, validate.py, conftest.py accordingly
* Add tests/async-copy-tracing
- integration test validating async copy tracing in transpose example
* Update tests/CMakeLists.txt
- updates for restructuring
* Revert tests/apps/reproducible-runtime
- restore code to semi-original state (no memory copying)
* Update tests/async-copy-tracing/validate.py
- fix comment in test_async_copy_direction
* Fix building tests against installation
[ROCm/rocprofiler-sdk commit: 936816f762 ]
2024-01-09 11:34:46 -06:00
Benjamin Welton
2f08904cd8
Build fixes for clang 10 ( #339 )
...
* Build fixes for clang 10
fixes build warnings in clang10
* source formatting (clang-format v11) (#340 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 0dd0cad2e4 ]
2024-01-05 15:20:11 -08:00
Jonathan R. Madsen
2ccb156030
Contexts update + buffer flushing + cleanup ( #338 )
...
* Update lib/rocprofiler-sdk/context/context.*
- get_registered_contexts functions (local copy)
* Update lib/rocprofiler-sdk/hsa/{queue,queue_controller}.cpp
- remove ROCPROFILER_BUFFER_TRACING_MEMORY_COPY code
* Update tests/kernel-tracing/kernel-tracing.cpp
- move stop() and flush() in tool_fini to before reporting of sizes of data collected
* Update lib/rocprofiler-sdk/hsa/hsa.*
- remove stale set_callback / activity_functor_t code
* Update lib/rocprofiler-sdk/buffer.cpp
- full wait instead of returning busy when buffer is busy
- use task_group::join instead of task_group::wait to fully wait for tasks to finish (bug fix)
* Update lib/rocprofiler-sdk/agent.cpp
- support agent mapping for CPU agents
* Remove direct access to vector of registered contexts
[ROCm/rocprofiler-sdk commit: 199f0b5421 ]
2024-01-03 04:26:46 -06:00
Jonathan R. Madsen
56fea9f08b
Code Coverage Reporting ( #334 )
...
* Update lib/rocprofiler-sdk/counters/{tests,parser/tests}/CMakeLists.txt
- use rocprofiler-static-library instead of rocprofiler-object-library
* Update scripts/run-ci.py
- support gcovr and pycobertura
* Update CI workflow for code coverage
- load/save cache for XML code coverage (via gcovr)
- generate and write code coverage comment
- archive code coverage HTML report
- fix name for sanitizer jobs
* Update CI workflow
- tweaks to env for PATH and LD_LIBRARY_PATH
* Add scripts/upload-image-to-github.py
- script for saving images to orphan branches to be used in markdown links
* Update CI workflow
- fix upload artifact conflict
- use upload-image-to-github.py
* Update CI workflow
- install extra packages for wkhtmltopdf/wkhtmltoimage
* Update CI workflow (code coverage)
- install more recent git
- tweak package installs for wkhtmltopdf/wkhtmltoimage
* Update CI workflow (code coverage)
- remove duplicate --cap-add=SYS_PTRACE
* Update CI and upload-image-to-github.py
- print versions
* Update upload-image-to-github.py
- check exit code of some subprocesses
* Update CI workflow
- fix GITHUB_PATH ordering
- fix LD_LIBRARY_PATH
* Update CI workflow
- fix code coverage cache keys (use SHAs)
- copy .codecov to .codecov.ref if a cached .codecov exists
* Update upload-image-to-github.py
- Update git pull/push commands
* Update upload-image-to-github.py
- git fetch before pulling
- git pull before committing
* Update upload-image-to-github.py
- git fetch after committing
- git pull after committing
* Update CI workflow
- list files before cat
* Update upload-image-to-github.py
- output messages
* Update CI workflow and upload-image-to-github.py
- fix output directory path for script to work with CI workflow
* Update CI workflow
- finishing touches/fixes on the code coverage comment generation
* Reproducible filenames
* Update CI workflow
- fix archive of code coverage data
* Fix relative path of reproducible file loc
* Update upload-image-to-github.py
- change update method
* rocprofiler-v2-internal -> rocprofiler-sdk-internal
[ROCm/rocprofiler-sdk commit: c5e45803e9 ]
2024-01-02 19:22:43 -06:00
Giovanni Lenzi Baraldi
32127d2f76
Gbaraldi/navi3fix ( #318 )
...
* Adding Navi3x gate fixes
* Making reproducible runtime more reproducible
* source formatting (clang-format v11) (#319 )
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
* Update lib/common/utility.hpp
- revert
* Update lib/common/environment.{hpp,cpp}
- support get_env for various integral types
* Update lib/rocprofiler-sdk/hsa/queue.cpp
- query ROCPROFILER_GATE_CAPACITY in ctor of active_capacity_gate
* Update tests/apps/reproducible-runtime
- fix help message
- misc float vs. double changes
- update output messages
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
[ROCm/rocprofiler-sdk commit: 3d539c1677 ]
2024-01-02 16:12:02 -03:00
dependabot[bot]
8d1fc8d773
Bump actions/upload-pages-artifact from 2 to 3 ( #327 )
...
[ROCm/rocprofiler-sdk commit: 3eac7ce2e8 ]
2023-12-30 04:48:49 +00:00
dependabot[bot]
416acd877f
Bump actions/deploy-pages from 3 to 4 ( #326 )
...
[ROCm/rocprofiler-sdk commit: 567bdf746e ]
2023-12-30 03:46:44 +00:00
dependabot[bot]
aed4c54adc
Bump actions/upload-artifact from 3 to 4 ( #311 )
...
[ROCm/rocprofiler-sdk commit: eed68cf748 ]
2023-12-19 20:47:52 +00:00
Jonathan R. Madsen
1e675fceb5
Improve static singleton memory safety ( #316 )
...
* Update GitHub links
* Update samples/api_buffered_tracing/client.cpp
- check if initialized before forcing initialization
* Add lib/common/static_object.*
- template class for creating a static allocation in the binary which has all the properties of a heap allocated singleton but does not trigger leak sanitizers
* Update include/rocprofiler-sdk/internal_threading.h
- document return values
* Update lib/rocprofiler-sdk/internal_threading.cpp
- return codes from rocprofiler_create_callback_thread and rocprofiler_assign_callback_thread
- use common::static_object for thread-pool object
* Update lib/rocprofiler-sdk/agent.cpp
- use common::static_object to store array of strings and their hashes
* Update lib/rocprofiler-sdk/hsa/code_object.cpp
- use common::static_object to store array of strings and their hashes to ensure strings exist until termination
* Update lib/rocprofiler-sdk/registration.cpp
- use common::static_object to store status and client libraries
- update return values for rocprofiler_set_api_table
* Update lib/rocprofiler-sdk/hsa/hsa.cpp
- check registration::get_fini_status() in hsa_api_impl::functor<Idx>(args...)
* Update lib/rocprofiler-sdk/context/context.cpp
- using common::static_object for correlation id map
[ROCm/rocprofiler-sdk commit: 6b374b8e68 ]
2023-12-19 13:47:21 -06:00
Giovanni Lenzi Baraldi
946407623f
Fixed pcs doorbell_id so it matches the trap handler ( #309 )
...
* Fixed pcs doorbell_id so it matches the trap handler
* source formatting (clang-format v11) (#310 )
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
* Changed trap_handler correlation_id to a struct and added comments
* Fixed one of the comments
* source formatting (clang-format v11) (#312 )
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
* Changing correlation_in to please the linter
* source formatting (clang-format v11) (#313 )
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 5761b5fb60 ]
2023-12-18 11:50:06 -03:00
Jonathan R. Madsen
309a8e069b
Update packaging ( #306 )
...
* Restructured tests
- support standalone compilation
- move tests/kernel-tracing/serialization.hpp to tests/common/serialization.hpp
- created tests/common library
- handle cloning of cereal library in standalone build
* Update install and packaging
* Update cmake/rocprofiler_config_packaging.cmake
- condense core, samples, development, and tools install components into single rocprofiler-sdk package
- keep tests install component in separate rocprofiler-sdk-tests package
* Update CI workflow to test install and packaging
* Update CI workflow
- install newer cmake for packaging checks
* Update cmake/rocprofiler_config_packaging.cmake
- disable auto-generation of shared-lib deps and provides for tests package
* Update CI workflow
- add sbin to PATH for dpkg install
* Update CI workflow
- remove using github.workspace when installing packages
* Update CI workflow
- hack to fix ordering of dpkg install
* Update CI workflow
- whitespace cleanup
[ROCm/rocprofiler-sdk commit: 8ed68ce4f3 ]
2023-12-15 14:39:13 -06:00
Jonathan R. Madsen
633a80ec1b
Fix rocprof and rocprofiler-sdk-tool ( #304 )
...
* Fix rocprof and rocprofiler-sdk-tool
- removed redundant options for rocprofv3
- fixed extension of CSV files
- fixed memory error (segfault) when tracing kernels
- fixed constructor of output_file
- using string after move
- output_file writes csv header
- implemented tool_fini
- flush buffer and stop context
* Minor updates to rocprofv3
* Update source/bin/CMakeLists.txt
- fix rocprof configure output location
[ROCm/rocprofiler-sdk commit: 7d117870d8 ]
2023-12-15 12:44:50 -06:00
Jonathan R. Madsen
b50cf816a1
Update lib/rocprofiler-sdk/hsa/types.hpp ( #305 )
...
- remove static asserts on the HSA table step versions
- ifdef/else the amd_ext size based on HSA_AMD_EXT_API_TABLE_STEP_VERSION
[ROCm/rocprofiler-sdk commit: f96ab90067 ]
2023-12-15 11:01:55 -06:00
dependabot[bot]
3441eafb8d
Bump actions/deploy-pages from 2 to 3 ( #285 )
...
Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages ) from 2 to 3.
- [Release notes](https://github.com/actions/deploy-pages/releases )
- [Commits](https://github.com/actions/deploy-pages/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: actions/deploy-pages
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[ROCm/rocprofiler-sdk commit: 9f821652bd ]
2023-12-12 13:44:53 -06:00
dependabot[bot]
f5a87cc919
Bump actions/setup-python from 4 to 5 ( #284 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[ROCm/rocprofiler-sdk commit: 93e3ca7660 ]
2023-12-12 13:44:37 -06:00
dependabot[bot]
067a4b8604
Bump actions/configure-pages from 3 to 4 ( #283 )
...
Bumps [actions/configure-pages](https://github.com/actions/configure-pages ) from 3 to 4.
- [Release notes](https://github.com/actions/configure-pages/releases )
- [Commits](https://github.com/actions/configure-pages/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/configure-pages
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
[ROCm/rocprofiler-sdk commit: a6754ceac7 ]
2023-12-12 13:44:17 -06:00
Vladimir Indic
43d5712dcb
AmdExtTable updated ( #292 )
...
* AmdExtTable updated
* hsa_amd_agent_set_async_scratch_limit introduced
* source formatting (clang-format v11) (#294 )
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 0666f6a197 ]
2023-12-12 10:36:38 -06:00
Benjamin Welton
cad071f395
Added kernel id to enqueue callback for kernel dispatch ( #276 )
...
Adds kernel id as parameter to rocprofiler_profile_counting_dispatch_callback_t.
Small cleanup of code in core.cpp.
[ROCm/rocprofiler-sdk commit: d2a6eec1bf ]
2023-12-11 09:13:48 -08:00
Vladimir Indic
2271ed7730
pcs parser: includes fixed, GLOB removed ( #286 )
...
* pcs parser: includes fixed, GLOB removed
* source formatting (clang-format v11) (#287 )
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com >
* cmake formatting (cmake-format) (#288 )
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 200be03bb4 ]
2023-12-08 17:36:32 +01:00
Benjamin Welton
c19e054225
Fix clock check for reproducible runtime ( #281 )
...
* Fix clock check for reproducible runtime
* source formatting (clang-format v11) (#282 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: efbb154515 ]
2023-12-08 01:25:23 -08:00
Giovanni Lenzi Baraldi
c1c939deaf
Gbaraldi/pcparser2 ( #266 )
...
* Rollback PCparser. Separated GFX9 and ID tests. Fixed flags for GFX9 tests.
* Removing C++ header from rocr.h. Fixing CMakeLists.
* Moved PCS benchmark to separate unit.
* Fixed workgrouP naming
* Adding inline on header functions
* Fixing pull conflicts.
* source formatting (clang-format v11) (#268 )
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
* cmake formatting (cmake-format) (#267 )
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
* Removed leftover rocprofiler folder for pcparser
* Adding <array> header on translation.hpp
* Fixing PCS test names.
* Chaging parser tests failure to the status_t value
* Renaming pcs_parser tests
* Removing benchmark test
* Adding const to a few variables
* source formatting (clang-format v11) (#269 )
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ApoKalipse-V <ApoKalipse-V@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: cce7fda5fb ]
2023-12-07 19:42:56 -03:00
Benjamin Welton
28272d4cc9
Align calculation of cu_per_engine with compute_unit/shader_engs ( #278 )
...
* Align calculation of cu_per_engine with compute_unit/shader_engs
* source formatting (clang-format v11) (#279 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
* Update agent.cpp
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 35928e6008 ]
2023-12-06 17:39:43 -06:00
Benjamin Welton
ee77f548f7
Reduce max memory usage of buffer-parallel test ( #280 )
...
[ROCm/rocprofiler-sdk commit: 7ab334b432 ]
2023-12-06 14:00:22 -08:00
Benjamin Welton
b98dc4453c
Reduce gate capacity further for NAVI3 cards ( #277 )
...
[ROCm/rocprofiler-sdk commit: b19b4eddc7 ]
2023-12-06 07:55:21 -08:00
Gopesh Bhardwaj
4e9dc3417f
Getting Started docs for samples and tools ( #261 )
...
* getting started for amples and tools
* Adding getting started to documentation
* Addressing review comments
* minor update
* renaming rocprofv2 to rocprofv3 in doc
* Apply suggestions from code review
---------
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 5c42d7d82a ]
2023-12-04 16:22:18 -06:00
Jonathan R. Madsen
7ff6b6db7b
Update documentation ( #275 )
...
- finished most of the TODOs
[ROCm/rocprofiler-sdk commit: 1c02e7a92a ]
2023-12-04 13:43:22 -06:00
Benjamin Welton
4114b975d5
Documentation Update For Counters ( #246 )
...
* Documentation Update
* Minor fixes
* source formatting (clang-format v11) (#265 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 022d7abc29 ]
2023-11-30 14:58:54 -08:00
Jonathan R. Madsen
fafab6b713
Use -sdk suffix and reset VERSION to 0.0.0 ( #263 )
...
* Fix find_package(rocprofiler) in build tree
* Move include/rocprofiler to include/rocprofiler-sdk
* Update include/CMakeLists.txt
- add_subdirectory(rocprofiler-sdk)
* Move lib/rocprofiler to lib/rocprofiler-sdk
* Move lib/rocprofiler-tool to lib/rocprofiler-sdk-tool
* Update lib/CMakeLists.txt
- add_subdirectory(rocprofiler-sdk)
- add_subdirectory(rocprofiler-sdk-tool)
* Update lib/rocprofiler-sdk/CMakeLists.txt
* Rename rocprofiler-tool to rocprofiler-sdk-tool
* Replace include rocprofiler/ with include rocprofiler-sdk/
* Replace include lib/rocprofiler/ with include lib/rocprofiler-sdk/
* Set VERSION to 0.0.0 and finish install to rocprofiler-sdk
* More fixes for rocprofiler -> rocprofiler-sdk
- fix issue with rocprofiler-sdk-config.cmake.in
- fix counters xml install path
* Fix documentation generation
* Create rocprofiler_LIB_ROCPROFILER_SDK_DIR for build tree
* cmake formatting (cmake-format) (#264 )
Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
[ROCm/rocprofiler-sdk commit: 9a0c84efa6 ]
2023-11-29 20:43:18 -06:00
Ammar ELWazir
898cef06f5
Misc updates for distribution ( #233 )
...
* Adding tools support
* cmake formatting (cmake-format) (#227 )
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
* Checking to do rebase
* Adding rocprofv2 script
* cmake formatting (cmake-format) (#229 )
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com >
* Fixing build for the tool
* Removing the requirement for rocm_version
* Update rocprofiler_utilities.cmake
* C++ filesystem fixes
- added source/lib/common/filesystem.hpp
- support older compilers which have <experimental/filesystem> and do not have <filesystem>
- added samples/common/filesystem.hpp
- samples now depend on "common" library which provides the correct filesystem header
- renamed rocprofiler-stdcxxfs interface target to rocprofiler-cxx-filesystem
- support old LLVM in addition to GNU
- fix bin/rocprof/rocprof.cpp
- was using VLA
* Fix rocprofiler-drm include directories
- OpenSUSE only has include/libdrm/drm.h (no include/drm/drm.h)
* Tools fixes
* Fix for the tools
* Fix rocprofv2 script
* Fixing Filesystem Issues
* source formatting (clang-format v11) (#234 )
Co-authored-by: ammarwa <ammarwa@users.noreply.github.com >
* Vlaindic/pc sampling api update (#235 )
* pcs: updating PC sampling API
* source formatting (clang-format v11) (#232 )
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com >
---------
Co-authored-by: vlaindic <vladimir.indic@amd.com >
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com >
* Vlaindic/pc sampling api update for ammar branch (#244 )
*Updating the documentation inside pc_sampling.h
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com >
* pcs: use @p in front of params
* pcs: documenting struct fields updated
* Fixing PC Sampling Documentation issues
* Fixing PC Sampling Documentation
* Relocated tools directory to source/lib/rocprofiler-tool
* Fixes/updates to rocprofiler-tool
- updated CMake
- Fixed miscellaneous issues in the code (VLAs, etc.)
- Updated rocprofv2 to reflect some minor env variables changes in rocprofiler-tool
- Fixed clang-tidy warnings
* Update lib/rocprofiler-tool/CMakeLists.txt
- link to atomic library
* Add $ORIGIN/.. RUNPATH to rocprofiler-tool
* Adding readme file for tools
* Renaming the tools readme file
* Update ReadMe.md
* Update ReadMe.md
* Documentation updates
- overview and explanation of design and concepts
* Fix lib/rocprofiler-tool/README.md
- delete ReadMe.md
* Hacks for build
* Update Filesystem
* cmake formatting (cmake-format) (#248 )
Co-authored-by: ammarwa <ammarwa@users.noreply.github.com >
* source formatting (clang-format v11) (#249 )
Co-authored-by: ammarwa <ammarwa@users.noreply.github.com >
* source formatting (clang-format v11) (#250 )
Co-authored-by: ammarwa <ammarwa@users.noreply.github.com >
* Addressing review comments on the tool readme file
* Revert "Hacks for build"
This reverts commit d6688cb3d1226c46fc97e37ced889a5b0d180940.
* Fixes for GCC 7.5 compiler in OpenSUSE 15.4
* Update lib/rocprofiler-tool/CMakeLists.txt
- link to AQL profile library
* Fix lib/rocprofiler-tool/README.md
- fix markdown
* Fix lib/rocprofiler-tool
- fix usage of hsa_ven_amd_loader_query_host_address
* Fix unused variable warnings
- byproduct of variables only used in assert statements
* Update docs
- update about.md
- more "Important Changes" section here
- update tool_library_overview.md
- extend "Tool Library Design" section
- write "Tool Initialization" section
- write "Tool Finalization" section
* Add ghc::filesystem submodule
* Implement usage of ghc::filesystem
* Add ROCPROFILER_BUILD_GHC_FS option
- option to use external/filesystem (ghc)
* Update samples/counter-collection
- compile flags
- common library
- fixes for warnings
* Update tests/kernel-tracing/CMakeLists.txt
- change install location of kernel-tracing-test-tool and install rpath
* Update samples/common/CMakeLists.txt
- compile features requiring C++17
* Update lib/rocprofiler-tool/tool.cpp
- remove include <filesystem>
- comment out unused variable
- remove unused functions
- move some functions into anonymous namespace
---------
Co-authored-by: Sriraksha Nagaraj <Sriraksha.Nagaraj@amd.com >
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: SrirakshaNag <SrirakshaNag@users.noreply.github.com >
Co-authored-by: gobhardw <gopesh.bhardwaj@amd.com >
Co-authored-by: bgopesh <bgopesh@users.noreply.github.com >
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com >
Co-authored-by: ammarwa <ammarwa@users.noreply.github.com >
Co-authored-by: vlaindic <vladimir.indic@amd.com >
Co-authored-by: vlaindic <vlaindic@users.noreply.github.com >
Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com >
Co-authored-by: Benjamin Welton <bewelton@amd.com >
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: fe5d074375 ]
2023-11-28 10:04:37 -06:00
Jonathan R. Madsen
032fbe843c
Install samples ( #252 )
...
- install samples into <prefix>/share/rocprofiler
- update samples for testing
[ROCm/rocprofiler-sdk commit: 41d06ae9c3 ]
2023-11-21 11:35:39 -06:00
pbhandar-amd
785d5e3a00
Use Vega20 runners for CI while MI200 runners are unstable ( #230 )
...
* Run jobs on vega20 instead of mi200 as per ammar's instructions. mi200 is too unstable for CI/CD
* Remove the options --memory=128g --cpus=32 from docker execution for job vega20-ubuntu
* Fix tab
* Fix tab again
* Forgot to switch code-coverage job to vega20
* Fix workflow file syntax error
* Fix workflow file syntax error
* Remove flags --memory and --cpus
* Remove flags --device=/dev/dri and device: entries
* Update .github/workflows/continuous_integration.yml
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com >
* Apply suggestions from code review
---------
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: 98459b579e ]
2023-11-20 15:04:48 -06:00
Benjamin Welton
7b71c18cef
Rename functioanl counter client, fix crash if no counters present on system ( #242 )
...
* Rename functioanl counter client, fix crash if no counters
Lack of counters for an agent should not crash this sample.
* source formatting (clang-format v11) (#243 )
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <bwelton@users.noreply.github.com >
[ROCm/rocprofiler-sdk commit: d40fc59703 ]
2023-11-17 17:15:39 -06:00