b996310710
Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
...
[ROCm/hip commit: faa546d194
2017-11-29 01:37:52 +00:00
dd8a589893
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
...
[ROCm/hip commit: 89e9399427
2017-11-29 00:17:44 +00:00
8fcd85757a
Remove leftover agent allocated globals.
...
[ROCm/hip commit: 5aeb5dcd6f
2017-11-28 19:56:04 +00:00
9668003fe3
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
...
[ROCm/hip commit: 6e4ca3fbb4
2017-11-28 19:45:47 +00:00
aef26d3477
Re-sync with upstream and re-factor platform global management for texture references.
...
[ROCm/hip commit: 02c2bfc7ef
2017-11-28 19:15:29 +00:00
11f7d895f4
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
[ROCm/hip commit: dc67ca3feb
2017-11-28 17:29:11 +00:00
3b25286003
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
[ROCm/hip commit: 265c3b224e
2017-11-28 17:23:43 +00:00
c2a5825c3c
This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands.
...
[ROCm/hip commit: a6ccaf3d57
2017-11-28 17:23:06 +00:00
23cc46786a
This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.
...
[ROCm/hip commit: a401ce6e5d
2017-11-28 17:23:06 +00:00
97f96255bc
Add hipify mappings for all CUDA headers that have HIP equivalents
...
I'm particularly running into issues with `device_types.h` in real
CUDA code...
[ROCm/hip commit: 9d47a4d980
2017-11-28 17:23:06 +00:00
d31ef2b462
Merge pull request #256 from gargrahul/texture_driver_api_support
...
Texture driver APIs support
[ROCm/hip commit: 0da0426f94
2017-11-27 13:52:39 -06:00
0d2f61daae
Added note in Release notes for texture driver APIs
...
[ROCm/hip commit: a139b533bb
2017-11-27 22:06:50 +05:30
499e247586
Merge pull request #262 from ChrisKitching/frontendaction
...
[HIPIFY] Mostly fix preprocessor-or-template induced issues
[ROCm/hip commit: aa05b3d84e
2017-11-27 17:30:11 +03:00
da1e6b14f5
Porting guides update for texture APIs usage
...
[ROCm/hip commit: 04bc5a1d1f
2017-11-24 12:00:55 +05:30
9e0e43bfd8
Merge pull request #273 from mangupta/swdev-129574
...
Fix float2int rounding functions
[ROCm/hip commit: 814548407d
2017-11-23 12:04:36 -06:00
2e043b7c0e
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
[ROCm/hip commit: 4c96882366
2017-11-23 09:57:24 +05:30
acc05cdff7
Remove leftover comment.
...
[ROCm/hip commit: 08f252e4bf
2017-11-22 19:37:03 +00:00
52b93658a9
Merge pull request #263 from ChrisKitching/headers
...
[HIPIFY] Add hipify mappings for all CUDA headers that have HIP equivalents
[ROCm/hip commit: 4e92a034d0
2017-11-22 21:24:21 +03:00
d8db534805
Modify the set component of the memcpy test (unclear why there is a memset component to begin with).
...
[ROCm/hip commit: 4131b47134
2017-11-21 17:52:01 +00:00
13879387e5
Fixed review comments
...
[ROCm/hip commit: 56862b1c35
2017-11-21 21:19:06 +05:30
d71132de7c
This corrects how addresses are formed for symbols which reside in shared objects. For this case, the .value component of an ELF symbol holds the offset from the base VA where the shared object was loaded. Thus, to correctly obtain the VA of the object refered by the symbol, we must add the offset to the VA where the shared object is loaded. We were already doing this correctly for symbols denoting functions, but we were incorrect for those denoting objects.
...
[ROCm/hip commit: 5e16ee0d1f
2017-11-21 13:15:13 +00:00
03552f2e94
Changed function hipMemcpy_2D to hipMemcpyParam2D
...
[ROCm/hip commit: 9866fa250d
2017-11-21 12:36:24 +05:30
45ff3c31c4
Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch.
...
[ROCm/hip commit: 9d088d2283
2017-11-21 02:40:34 +00:00
e8ca14848e
Clean-up some remaining noise in program_state.cpp.
...
[ROCm/hip commit: 1824fb7698
2017-11-20 22:41:46 +00:00
69f8043d12
Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
...
[ROCm/hip commit: 7d5a45ac1a
2017-11-20 16:33:52 +00:00
3c936777aa
Re-sync with upstream.
...
[ROCm/hip commit: c5f2b22d0d
2017-11-20 15:34:50 +00:00
6e332812fc
Merge pull request #264 from pzins/missing_end_marker
...
Fix missing MARKER_END
[ROCm/hip commit: e8ede28ec4
2017-11-20 06:08:01 -06:00
97ee22c3f5
-Moved coGlobals in hipModule class (takes care of multi module case)
...
-Used mutex scope for updating coGlobals
[ROCm/hip commit: f97c5f9a64
2017-11-20 16:23:18 +05:30
d807f528e6
Merge pull request #266 from gargrahul/fix_half2_gfx900
...
Fixed half2 issue on gfx900
[ROCm/hip commit: db378fbc9e
2017-11-20 07:28:41 +05:30
2bb78b3a69
Merge pull request #265 from phani544/nvccTests
...
[nvccTests]Enabled inline_asm_vadd on nvcc
[ROCm/hip commit: 1174534e85
2017-11-20 07:28:29 +05:30
1ec5bab716
Fix test on cuda
...
[ROCm/hip commit: 59956a57ca
2017-11-19 15:31:02 -06:00
64a169fd5c
Merge branch 'feature_natural_indexing' of https://github.com/AlexVlx/HIP
...
[ROCm/hip commit: 5a7a28ad29
2017-11-19 15:25:17 -06:00
dde41ae0aa
Temporarily disable P2P on nvidia (fails on dual GPU)
...
[ROCm/hip commit: e0c3f684ae
2017-11-19 15:21:37 -06:00
62f20c6dc8
Update hipModuleGetTexRef API
...
[ROCm/hip commit: c7d60a7a75
2017-11-19 22:10:46 +05:30
962bf7bfda
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
...
[ROCm/hip commit: cffd0e14eb
2017-11-19 01:54:12 +00:00
6206ac6138
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
[ROCm/hip commit: f93859cdc2
2017-11-16 23:20:15 +00:00
5de28551c1
Fixed test case for GFX900
...
[ROCm/hip commit: 9af0f9cbc1
2017-11-16 09:34:52 +05:30
d0ee6e00fe
Fixed half2 issue on gfx900
...
[ROCm/hip commit: fef496d4f1
2017-11-15 18:52:59 +05:30
e5aae56998
Removed redundant desc variable
...
[ROCm/hip commit: ae1eb7a03a
2017-11-15 18:28:27 +05:30
58b37dce5f
-Fixed texture driver API sample
...
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs
[ROCm/hip commit: 4b19c2aa0c
2017-11-15 18:23:28 +05:30
65a8021933
[nvccTests]Enabled inline_asm_vadd on nvcc
...
[ROCm/hip commit: 18f6e31d1d
2017-11-14 16:37:59 +05:30
0263292087
Texture code reorganized
...
[ROCm/hip commit: 63680edd30
2017-11-14 11:09:35 +05:30
d917c6b546
Fix missing MARKER_END
...
Logging status of hipCtxSynchronize was missing
Test if hip profiling is active for MARKER_END in ihipPostLaunchKernel
Add MARKER_END after the completion of a kernel launched through
the "grid launch"
[ROCm/hip commit: 6baaed8e48
2017-11-13 16:13:19 -05:00
9ef5b7a506
Add an explicit check for proper rewriting of CUDA includes
...
[ROCm/hip commit: ab3debb2f9
2017-11-13 21:02:42 +00:00
6e5f80b345
Add a preprocessor conditional to one of the tests
...
Hurrah, we can cope with ifdefs now (except for kernel launches)
[ROCm/hip commit: 2344ca89f3
2017-11-13 20:58:55 +00:00
096136750c
Use proper clang diagnostics for printing warnings
...
Much pretty. Very wow
This gives users all the usual power when it comes to manipulating
clang diagnostics. People can pass -Werror can have hipify fail if
it doesn't completely translate a file, for example. Much nicer
than reinventing the wheel.
[ROCm/hip commit: 6b767a59ba
2017-11-13 20:58:55 +00:00
78cf713140
Use a custom FrontendAction to simplify identifier translation
...
Most of what hipify does is really just replacing CUDA idenitifers
with HIP ones. CUDA function calls, preprocessor macro calls,
enum references, types, etc.
This is problematic: calls/types/enum-refs require name resolution
for the AST matcher to work. This fails in the presence of code
deleted by the preprocessor, and in two-pass template compilation.
Instead, we can simply hook the lexer and have it rewrite the
identifiers for us.
This approach means identifier transformations will work correctly
regardless of where they appear (and we get to delete lots of code)
- Fixes #260
- Helps a bit with #207 - it will still fail to translate kernel
calls in preprocessor-ignored code, but everything except kerel
launches should translate correctly now, even in
preprocessor-deleted code.
[ROCm/hip commit: 24cdc5e1d3
2017-11-13 20:58:54 +00:00
c2d54f0154
Add hipify mappings for all CUDA headers that have HIP equivalents
...
I'm particularly running into issues with `device_types.h` in real
CUDA code...
[ROCm/hip commit: 23b5d26582
2017-11-13 17:20:07 +00:00
1451d8fc89
Add a test that exposes #260
...
[ROCm/hip commit: 9165df3848
2017-11-13 16:18:15 +00:00
b13465cfdd
Add a couple of missing CHECK directives to concurrentKernels.cu
...
[ROCm/hip commit: 4ab091ce1e
2017-11-13 16:17:19 +00:00
Alex Voicu
Maneesh Gupta
Chris Kitching
Ben Sander
Rahul Garg
Evgeny Mankov
Phaneendr-kumar Lanka
Pierre