Commit graph

12221 Commits

Autor SHA1 Nachricht Datum
Shilei Tian ce4e3ebe04 Revert "SWDEV-459556 - Revert "SWDEV-442724 - Remove uses of -amdgpu-early-inline-all to enable function calls""
This reverts commit e5b6537315ce9b2688ee0269ba0828a703c3e2c9.

The regressions (SWDEV-459556 and SWDEV-460260)  caused by the original patch
has been resolved.

Change-Id: I32344492b4ff88bd7e91ea47983ac15636dc77c1


[ROCm/clr commit: b0930263e5]
2024-05-28 06:31:10 +00:00
Jatin Chaudhary 026346a6c7 SWDEV-462027 - bfloat162 struct members are public
bfloat16 member is protected, bfloat162 members are public

Change-Id: Ice090401553b9526cb34d003b3996b85d538bc4e


[ROCm/clr commit: 2b290953b0]
2024-05-28 06:31:10 +00:00
Payam Ghafari f8d4cca28b SWDEV-447691 - added error reporting on semaphore
Change-Id: Id903806d122c0594d6549d5e8b7201512eff9850


[ROCm/clr commit: f268b48a2d]
2024-05-28 06:31:10 +00:00
Anusha GodavarthySurya 3b85ba70df SWDEV-461072 - Extend AQL Optimization for child graph nodes
Change-Id: I6baf906add7240b29ea653020a9a0b56206ee2a7


[ROCm/clr commit: 243dad92c9]
2024-05-28 06:31:10 +00:00
sdashmiz 2889266aeb SWDEV-429053 - Add check for StreamLegacy
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I402185a3b81935aaa1c8c4963407b8de21c72d8a


[ROCm/clr commit: 627ccfa502]
2024-05-28 06:31:10 +00:00
Brian Sumner 3f5cf1ce8b Include pointer value in error message
Change-Id: I4bb3281f73de89a9ad0541d88061b995cb919731


[ROCm/clr commit: 4f7830c998]
2024-05-28 06:31:10 +00:00
Vladana Stojiljkovic c05056e695 SWDEV-452364 - Check if no GPUs are available when hsa_init fails
* When no GPUs are available, hsa_init fails with HSA_STATUS_ERROR_OUT_OF_RESOURCES, and device and runtime initialization fails. In order for NoGpu tests to pass, true needs to be returned which will cause HIP_INIT_API to return proper error hipErrorNoDevice instead of hipErrorInvalidDevice.

Change-Id: I982d4416c92ed1b36893354d8b10d73df34f2478


[ROCm/clr commit: fdaa7141af]
2024-05-28 06:31:10 +00:00
Vladana Stojiljkovic bf817aeaa3 SWDEV-454681 - Add nullptr check for memsetParams in hipDrvGraphAddMemsetNode
Change-Id: Ife8784b23179c5613c29cde27dd2975cb729aaae


[ROCm/clr commit: d543ab6a0b]
2024-05-28 06:31:10 +00:00
Saleel Kudchadker 2969f2476b SWDEV-301667 - Better log
- Print kernelname for graph launches, its hard to correlate packets
otherwise
- Print correlation_id if any

Change-Id: Ib8db7a00e4e7c98f570e71029e61d86f5dccc2ed


[ROCm/clr commit: 72d23a02c5]
2024-05-28 06:31:10 +00:00
Saleel Kudchadker efc2de44f0 SWDEV-451594 - Fix HDP reg readback
Change-Id: I478a968330f85c3b60ff39fb40bf3cd91acd610e


[ROCm/clr commit: 1ba74c3ce3]
2024-05-28 06:31:10 +00:00
Ranjith Ramakrishnan 98fd53c2ef SWDEV-442738 - Static package generation for hip
Generate static package by combining binary and dev components.
Binary and dev component dependencies are added to the static package dependencies
Package name will have suffix static-dev/devel

Change-Id: I7eb187ceaf2af7dfaf6ff9f56de20dac72881a12


[ROCm/clr commit: 2ce57184d3]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras b8af347e8e SWDEV-445072 - Disable rocprofiler register for static libs
Change-Id: I38f4cc31ea196156aad65ca743787b27c02823ac


[ROCm/clr commit: 7d901666b8]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras 60ba0874fa SWDEV-460925 - Do awaitCompletion before releasing the lastEnqueueCommand
Change-Id: I210399dd1bced13c0923fdb1c215e044920c5a4b


[ROCm/clr commit: d6eaf49033]
2024-05-28 06:31:10 +00:00
Saleel Kudchadker cb67c6d949 SWDEV-461717 - Increase CB alignment and size
- Gfx12 TCC cacheline size is 256B, Increase to have alignment
compatible. Eventually this needs to be replaced with what the query
returns.

Change-Id: I545929446c4faa3f26872a6290b3a89657888596


[ROCm/clr commit: bb01b4c3b4]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras c36eeeb0ec SWDEV-455444 - Add the hiprtc sources to hiprtc library for static builds
Change-Id: Ic17f22831376be37fe998aa1ec9a754738c9a147


[ROCm/clr commit: 6c8ca0b3aa]
2024-05-28 06:31:10 +00:00
Tao Sang 5bf67d7da7 Revert "SWDEV-433371 - use comgr to unbundle code objects"
This reverts commit c0ee0ffa1c.

Reason for revert: <INSERT REASONING HERE>
New comgr unbundling action leads to perf drop for uncompressed code object.   Will create a new patch to use old path for uncompressed , new unbundling api for compressed . 

Change-Id: I41ef53b71fc9f7aaa8cf231d4d70945f1117db52


[ROCm/clr commit: a1350fe8c1]
2024-05-28 06:31:10 +00:00
German Andryeyev ad24101e5e SWDEV-451594 - Correct preMI100 detection
Change-Id: I4f1570a64cebf1ff73b4d189c17b7d7db095009c


[ROCm/clr commit: a4dbc97bd7]
2024-05-28 06:31:10 +00:00
Ioannis Assiouras a81f82931b SWDEV-449620 - Added hipExternalMemoryGetMappedMipmappedArray in the dispatch table
Change-Id: I79952f131dea1949296685ee92cae05a4f9aec30


[ROCm/clr commit: 7b46701142]
2024-05-28 06:31:10 +00:00
kjayapra-amd 27bc1632f1 SWDEV-417091 - Disable GWS Init for PAL/Windows side.
Change-Id: Ib6295f063daa835c1f33f21f50c083241a9026ff


[ROCm/clr commit: 931431fc38]
2024-05-28 06:31:10 +00:00
Ajay 31748d52c7 SWDEV-460151 - enable gfx12 code in runtime
Change-Id: I2d6fbf350c7cc2e1e4a698f0bad4ce8d512c4368


[ROCm/clr commit: d754ab4e30]
2024-05-28 06:30:26 +00:00
Saleel Kudchadker 0b3e421451 SWDEV-301667 - Refactor graph code
- Remove Last graph node optimization and instead submit a barrier NOP
packet always. This simplifies the code.

Change-Id: Ied443173ba47a08b6df148ac7e3ead712acda11c


[ROCm/clr commit: badf2b0880]
2024-05-28 06:28:17 +00:00
Satyanvesh Dittakavi ecca4d8188 SWDEV-457755 - Add TS only for kernel packets in the Accumulate command
Change-Id: I1b2f01c5763761808f49802fa117abc6306a22aa


[ROCm/clr commit: 3d540ec113]
2024-05-28 06:28:17 +00:00
shadi 19ce99d104 SWDEV-421027 - Add more Graph APIs
Signed-off-by: shadi <shadi.dashmiz@amd.com>
Change-Id: I0a1fc284e48317a49ca88d4ed4e3a10e752efd58


[ROCm/clr commit: e705e5e0d9]
2024-05-28 06:28:17 +00:00
kjayapra-amd 4ebecc5b98 SWDEV-459325 - Remove hiprtc sources from libhipamd64 compilation.
Change-Id: Ic70206c5936fb36a23c122e67110b91ae7e95e09


[ROCm/clr commit: 31935b1d39]
2024-05-28 06:28:17 +00:00
kjayapra-amd 0f6b315ca7 SWDEV-445072 - Fixing error on static library for hip package.
Change-Id: I96d2b9000e290739870e201b599bdef8859b971a


[ROCm/clr commit: 2cfc42368e]
2024-05-28 06:28:17 +00:00
kjayapra-amd a95e9e7679 SWDEV-445072 - Enable RTC outside of BUILD_SHARED_LIBS variable.
Change-Id: Iab9f1cb2bdf24163979e2b646bdbed3f1508b221


[ROCm/clr commit: b9c65fb7ff]
2024-05-28 06:28:17 +00:00
Anusha GodavarthySurya 085703c225 SWDEV-460770 - Handle Graph Exec release
Handle GraphExec instance is destroyed before async launch completes
GraphExec instance is destroyed after async launch completes
GraphExec instance is destroyed without a launch

Change-Id: I45a7c82295fea916c7559bd8f796df710513aea1


[ROCm/clr commit: bf4d10ff61]
2024-05-28 06:28:17 +00:00
Saleel Kudchadker 3a67addd48 SWDEV-459778 - Remove CPU wait for profiler
- No cpu wait is needed when profiler is attached, Doing this changes
the application profile when roctracer is attached.

Change-Id: I2b9cfc48d697cf5ed54bb6a240d8c12bdb079171


[ROCm/clr commit: 51e4368723]
2024-05-28 06:28:17 +00:00
Anusha GodavarthySurya 9818ad44a2 SWDEV-453739 - Added definition for undeclared methods
Change-Id: I3f10e0a3fb4bbaf9d873a6a988847f05ac43a312


[ROCm/clr commit: 45dccd6eab]
2024-05-28 06:28:17 +00:00
Anusha GodavarthySurya ece7fa9f76 SWDEV-454247 - Fix graph multi threading issue
Change-Id: I565889da6f7091030b7f6a2d6234b82c389358e3


[ROCm/clr commit: de95625f09]
2024-05-28 06:28:17 +00:00
Saleel Kudchadker 76f0560319 SWDEV-460080 - Do not wait for host side command complete
- awaitCompletion would wait for host side command compelete(aka
cpuWait). The correct way is to check the completion signal and if not
dispatch a marker that has a signal.

Change-Id: I0f4f23c7ea68c329bf1d5f05e9735f631e5e3808


[ROCm/clr commit: 2d7912dc01]
2024-05-28 06:28:17 +00:00
kjayapra-amd 4b186faf31 SWDEV-459254 - Change return type to support values > 128.
Change-Id: Ib4c9a3718c4cb26b24503fe4d9af3e63e151e843


[ROCm/clr commit: c7461436d6]
2024-05-28 06:28:17 +00:00
kjayapra-amd 04ed74552f SWDEV-459254 - Overwrite cacheline size to 256 for gfx12, as it is used for kernarg alignment.
Change-Id: Ia6acf312ee84f6dde1c830fc21f10d3a8a9de5ee


[ROCm/clr commit: dd1dd86fd7]
2024-05-28 06:28:17 +00:00
Ioannis Assiouras 6a0f554fa6 SWDEV-451594 - Fallback to host kernel args on older devices
On gfx8, gfx9 devices before MI100 and gfx10.0 or gfx10.1
none of the memory ordering workarounds for device kernel arguments
can be applied. Use host kernel arguments on these devices.

Change-Id: I9be6fbfe4b3986eb7d9f83998334df5f03fd4124


[ROCm/clr commit: 2b746de6de]
2024-05-28 06:28:17 +00:00
Ioannis Assiouras f1aae6b5bf SWDEV-460581 - Fixed memory leak in hipIpcCloseMemHandle
hsa_amd_ipc_memory_detach is called with an invalid mapped pointer.
Changed to pass the svm pointer of the owner memory instead.

Change-Id: I8203c6e2d718efb8ca3b028309bc78caff8d4c7d


[ROCm/clr commit: 5bb30d7718]
2024-05-28 06:28:17 +00:00
Rakesh Roy 0b5525cb38 SWDEV-459556 - Revert "SWDEV-442724 - Remove uses of -amdgpu-early-inline-all to enable function calls"
This reverts commit d90a0d9c57.

Change-Id: I885b9e5910d90fd871ab48f7ee95796b6cd01297


[ROCm/clr commit: 87619af175]
2024-05-28 06:28:17 +00:00
German Andryeyev 68344576d3 SWDEV-460242 - Add system memory suballocator
Switch commands creation to the new suballocator to avoid
frequent expensive OS calls

Change-Id: I3597c811820e577c15708bad8b8a41aa53acc400


[ROCm/clr commit: 5b0bfdcbad]
2024-05-28 06:28:17 +00:00
kjayapra-amd 3ca0dbc4d7 SWDEV-460151 - Enabling gfx12 in HIP runtime.
Change-Id: I374ea7c3119b0c61f9846a862c4a448ddb179748


[ROCm/clr commit: f5d0ee650b]
2024-05-28 06:28:07 +00:00
Alex Xie 0812cc34a6 SWDEV-451945 - Remove ShouldLoadPlatform function
Change-Id: Iabb4071bb77201576bc2c0488a04f4fa188815df


[ROCm/clr commit: 2eb30376ba]
2024-05-06 10:42:59 -04:00
Saleel Kudchadker 588e870000 SWDEV-301667 - Pass reference to kernel name
Change-Id: I21abe109ddfabfe7640bf78a96c81a1317d31952


[ROCm/clr commit: 4a9d24a211]
2024-05-05 16:38:20 -04:00
kjayapra-amd 7c56ed2526 SWDEV-460091 - Handle cases where inline variables are included in multiple translation unit.
Change-Id: I92179ad198abbdaf5aec9c3c4ba76eeb6b0cc761


[ROCm/clr commit: 68ddd8f3a0]
2024-05-03 15:52:28 -04:00
Maneesh Gupta f30be8996b SWDEV-433371 - Build needs comgr >= 2.8
Unbundle compressed code objects needs comgr 2.8 or higher

Change-Id: I23942d2038e19b02c3ea5d3c9c1fe5367db87136


[ROCm/clr commit: 1bd8b4eaf5]
2024-05-03 09:34:49 +00:00
Ioannis Assiouras a21913a0bd SWDEV-451594 - Change device kernel args to use HDP flush by default
The Readback and Avoid HDP Flush memory ordering workaround is
used as a fallback solution only when HDP flush register is invalid

Change-Id: Ic284eba1f95ed22b0270d3abeb904fb902015b1a


[ROCm/clr commit: 6cb7b6ec6b]
2024-05-02 19:35:13 +00:00
taosang2 c0ee0ffa1c SWDEV-433371 - use comgr to unbundle code objects
1.Make runtime use comgr to unbundle code objects
2.Support compressed/uncompressed modes
3.Remove HIP_USE_RUNTIME_UNBUNDLER and
  HIPRTC_USE_RUNTIME_UNBUNDLER to simplify logics
4.Add comgr wrapper for
  amd_comgr_action_info_set_bundle_entry_ids()

Change-Id: Ic41b1ad1b64cca1e31986437983a5146d52a7329


[ROCm/clr commit: e53df57ffe]
2024-05-01 16:09:12 -04:00
Julia Jiang d5b57de7e5 SWDEV-449327 - Adding CONTRIBUTING.md in clr repos
Change-Id: I3601373f680aa4bff0075f4b3b9e885e54b4600d


[ROCm/clr commit: 996c16ad0a]
2024-05-01 11:48:29 -04:00
Rahul Manocha 35ab01f7de [SWDEV-442583] - Fix hipLaunchCooperativeKernel API error codes
Change-Id: Id3cb4b58b9efd3aceec4377d4d1d3a053c50333e


[ROCm/clr commit: 59051ed3af]
2024-05-01 11:36:59 -04:00
Julia Jiang 1e22a14b1b SWDEV-455586 - create ocltst ASAN test instrumented pkg
Change-Id: I820cacd75a36363d1387e2e881c96937281bc265


[ROCm/clr commit: feaef7f54e]
2024-04-30 17:50:15 -04:00
Saleel Kudchadker 0cf1f056a7 SWDEV 301667 - Fix Debug dot print for graphs
- Fix possible buffer overflow for long kernel names

Change-Id: I3c51669de7ff242d03f9210ee045b6d5e7ac274a


[ROCm/clr commit: f1ef05b121]
2024-04-30 12:26:10 -04:00
Saleel Kudchadker 40bd47ba42 SWDEV-301667 - Add LOG_TS mask
- Add LOG_TS mask for printing signal times
- Read raw ticks from signals

Change-Id: Ibdd0bf06c790729f6c65083a4784c97a3c3219e0


[ROCm/clr commit: 948ca5a931]
2024-04-30 12:24:48 -04:00
Jaydeep Patel ab70925687 SWDEV-456279 - Adding new hip flag to access contiguous memory and pass the flag to HSA API.
Change-Id: I1bafeaa3096395c729723af958d609bc41e7845c


[ROCm/clr commit: 1d48f2a1ab]
2024-04-30 05:25:38 -04:00