Commit Graph

257 Commits

Author SHA1 Message Date
Satyanvesh Dittakavi 68161ff0dd SWDEV-279486 - Fix hipMemcpyPeer/hipMemcpy APIs
Addresses the scenarios when the size passed is more than
the allocated size and when the deviceid is invalid
Change-Id: I6c9b62639096f655ffb61976905b1ce8c5f51ee7

Change-Id: I8a0d660924a8e2300c517aba6f9088626b8f6ef5
2021-04-09 02:53:15 -04:00
Sarbojit Sarkar 492ccc3281 SWDEV-260454 - Fix for idenfying bad streams
Change-Id: I122ff6f47535c3c76ab56ba49ab1450ef886b15f
2021-04-07 12:13:30 -04:00
Sarbojit Sarkar 3d7ecb6fea SWDEV-276319 - Added null checks
Change-Id: Ib22a333f0f599c8f0efca34f2a287bc4b118d743
2021-04-01 05:11:16 -04:00
Sarbojit Sarkar c6aac041e1 SWDEV-254441 - Fixed review comments
Change-Id: Ica13f23638be04216d152821127b2b7316f96af0
2021-04-01 00:21:19 -04:00
pghafari a1b321bba4 SWDEV-245532 - HIP - Vulkan interop
Change-Id: Iba1ef8112e318b4f099da5a4a4602e0dae7de9e3
2021-03-31 10:23:31 -04:00
Anusha GodavarthySurya 45ccc14d55 SWDEV-278873 - hipStreamCreate handle invalid flag value
Change-Id: I05c0e0b76f7b09947e48d5b9f225af305bade27f
2021-03-31 07:59:41 -04:00
Satyanvesh Dittakavi 39f4d0d244 SWDEV-277152 - Add hipMemcpy2DToArrayAsync API in headers
Also, address few scenarios for hipMemcpy2DToArray/Async to return
proper error types

Change-Id: Idbadf666a5e7bebc0f3ea8b7048b79208e04cf6b
2021-03-27 13:50:38 -04:00
Maneesh Gupta b2cb34f519 SWDEV-187253 - Print warning if launch_params > bounds
Change-Id: I138546bf816887576e797105f97ce37245911045
2021-03-24 22:29:19 -07:00
Anusha GodavarthySurya 7535ce6498 SWDEV-269085 - Fix compilation error with clang
Change-Id: Iab5902c9a2702456fbe433fdefc40541c48acb71
2021-03-22 03:02:50 -07:00
Saleel Kudchadker c8b9257c0b SWDEV-277847 - Move event lock_ to the beginning
For addMarker, assume T1 comes in first and enqueues a command C1.
Before T1 grabs the event_::lock_ it gets preempted. At this time,
T2 comes in, enqueues C2 and grabs the lock_ and updates event_. Now T1
wakes up and updates a older command C1 for the event.

Change-Id: Ia423782b23026302c40976385623cfdede32d70b
2021-03-19 15:28:08 -07:00
Tao Sang ca0cc36ef4 SWDEV-273138 - Update canUseStreamWaitValue retrieving
Remove canUseStreamWaitValue from hipDeviceProp_t.
Update canUseStreamWaitValue retrieving in hipDeviceGetAttribute().

Change-Id: I275bd42d8b03e141caaf9f1bc6b714e51ca72dfb
2021-03-18 22:42:35 -04:00
German Andryeyev 7600326eb2 SWDEV-277543 - fix destruction of the stream object
Change-Id: If2f532e66099805a7f05181e63f5454893a1a288
2021-03-18 13:24:46 -04:00
Ravi C Akkenapally 475d928be8 SWDEV-276827 - Stream Operations: match API with CUDA
Change-Id: Ia79a950561e97df3b2229f76f5512dede2babf98
2021-03-18 07:52:29 -07:00
Sarbojit Sarkar 4ba39503bf SWDEV-276319 - Fix for -ve cases
Change-Id: Ie6157e3cdbd1f959c8ea502b48286bdf102b8a0f
2021-03-18 00:21:43 -04:00
Tao Sang 38b0c952a6 SWDEV-273943 - Enable runtimeApi.event dtest
Add device_id_ in hip::event to match cuda behaviour in
hipEventQuery() and hipEventRecord().
Enable hipEventElapsedTime test on AMD platform.
Workarround sporadic crash of hipEventIpc test due to
some bug of event ipc.
Add missing hipEventDestroy() in some event tests.
Fix some logic code errors.
Fix typo in comment.

Change-Id: I9ec74c475161b3e31df48d193449023e921f2924
2021-03-16 17:12:08 -04:00
Vladislav Sytchenko e967adbdaf SWDEV-275317 - Correctly pass HIP image width to ROCclr APIs in AtoD/DtoA copies
HIP assumes that image width is in bytes, but OCL/ROCclr assumes that
it's in pixels. AtoD/DtoA need to account for this.

Change-Id: I275bd41d8b03e141caaf951bc6b714e51ca72dfc
2021-03-15 21:09:58 -04:00
Payam f17adc439c SWDEV-182753 - Throw error if launch params>bounds
Change-Id: I5f9931efac37e3149894ca116a1b0c2dcc3e5bc5
2021-03-12 19:17:08 -05:00
Rahul Garg f265af744c SWDEV-270599 - hipExtLaunchKernelGGL Event Timing Incorrect Between Two Launches
Change-Id: I599a51720f297209072c6be8fffe2aa61e1a071e
2021-03-09 12:18:39 -05:00
Satyanvesh Dittakavi 0303084b0e SWDEV-275317 - Fix hipMemcpy2DFromArray to return proper error types
Change-Id: Id722865d81460bfd2fa6ad7a198b6e3c2a08265a
2021-03-09 05:22:23 -05:00
German Andryeyev 84f8785288 SWDEV-272496 - enqueue a marker for callbacks always
The current implementation in ROCclr for callback is
based on OCL specification. If in HIP the same command
could get multiple callbacks, then ROCclr will process them in
a reverse order. Unique Markers for each callback will make
sure it won't happen.
Add a dependency wait for callbacks, since HSA signal callback
doesn't guarantee the order.

Change-Id: I9d514734e258312fe9a74d48132361eb17c52d67
2021-03-08 14:19:53 -05:00
Sarbojit Sarkar 0b3b9810c4 SWDEV-254329 - Profiler ON/OFF fix
Change-Id: I996d185d2079ce68234109564a529a187ba4f04b
2021-03-08 01:27:46 -05:00
Arya.Rafii 24837c1afc SWDEV-269246 - Implementation of hipDrvMemcpy2DUnaligned
Change-Id: I86fdd3b930cbd74c45cd31944f0ea52c0ff65a59
2021-03-04 14:38:06 -05:00
Arya.Rafii 6f1a09b47f SWDEV-269246 - Added missing exports for hipArrayDestroy
Change-Id: I730814720bb618e895efbe2f412e437110bed8bc
2021-03-04 14:29:16 -05:00
kjayapra-amd b4492a3de3 SWDEV-259566 - Adding support to retrieve handle for offsetted pointer.
Change-Id: I5da5ab6a24c6df915950637feb486b8c288e60e0
2021-03-04 12:28:56 -05:00
German Andryeyev ffc89dff8a SWDEV-272496 - Delay enqueue until callback setup
With direct dispatch enqueue occurs before callback update and
it can't be tracked in the device backend

Change-Id: Ie8793e3ddb68cc5bb36348f7a8dcdbdc87a2487c
2021-03-03 13:14:28 -05:00
Ravi C Akkenapally e89b228eac SWDEV-179105 - Stream Operations: Add swqupport for Wait and Write
Change-Id: I9d6d0665d12b62fe705ce1569a0e8264a4f23ab7
2021-03-02 12:15:46 -08:00
Tao Sang b504a9bfae SWDEV-270973 - Add missing copyright headers
Change-Id: I6bb27650f74372dae6e29c79fd6bb2022cc062fe
2021-03-01 19:46:24 -05:00
Jatin Chaudhary 6288e68175 SWDEV-272361 - Dont call memcpy2d if width is 0 or height or depth is 0
Change-Id: I22324a536d2a5e68b9fc3e5ee4ad821b49021a17
2021-03-01 14:34:58 -05:00
cjatin 23f33d5f20 SWDEV-271274 - Changing DevLogPrintf to LogPrintf for cases where error condition is being returned
Change-Id: I153d071f7859e9412ea0c69f53c53d190453d73d
2021-03-01 14:33:46 -05:00
Ashutosh Mishra abff21c4fc SWDEV-271126 - Memory obtained from getDeviceMEmory can be NULL
which can cause segmentation faults. Hence checking for its sanity

Signed-off-by: Ashutosh Mishra <ashutosh.mishra@amd.com>
Change-Id: I78b4d029f0926a1369a8ebbeb4aef951a8f1f1d7
2021-02-26 23:29:53 -05:00
Payam c77caa3fbf SWDEV-273405 - updated roctracer path to use env var
Change-Id: I9ec74c475161a3e310f57d193449023e921f2922
2021-02-26 14:51:26 -05:00
cjatin b74de31f2a SWDEV-273859 - Add --hip-version to comgr call
Change-Id: Iae6c1a5e958a73f5d9849c13c8b49eede914e25e
2021-02-24 23:41:34 -05:00
Arya.Rafii 76abab2f24 SWDEV-269246 - Fixed null-case logic for hipCtxPopCurrent
Change-Id: Ic173980caccde8afee85a75c55a5d536f421549e
2021-02-24 13:20:24 -05:00
kjayapra-amd 848b7e3ec0 SWDEV-274058 - Porting HIP, ROCclr gfx90a changes to mainline.
Change-Id: I02f53d4c7897d26243620cfc961fa9bd984cede4
2021-02-24 09:55:43 -05:00
German Andryeyev 56154e33dc SWDEV-272496 - Add marker if notification was the last command.
If MT is enabled, then a new callback can be received before the previous
command is processed, causing a conflict of 2 callbacks.

Change-Id: I5ff8f231208e8d62824d590d3c8e791e8e36affb
2021-02-23 13:12:06 -05:00
Vladislav Sytchenko fa169b129b SWDEV-255979 - Fix Windows build
Change-Id: I1f1375911d90ded9043a4716e7d09a3ca6a33c23
2021-02-19 11:31:52 -05:00
agodavar 995e6336c6 SWDEV-255979 - Added support of __managed__ static variable
Change-Id: I9d5cbbecc8c19ec38a95c94ab4130465ba76c102
2021-02-17 13:01:29 -05:00
Satyanvesh Dittakavi 0d7cd231e8 SWDEV-272543 - Fix hipDeviceGetP2PAttribute when both devices are same
Change-Id: I3db17a962807565ea134e3cbcefa66d373e2d363
2021-02-17 12:41:59 -05:00
Rahul Garg 72e7826adf SWDEV-271182 - Fix HdpMemFlushCntl and HdpMemFlushCntl
Change-Id: I33e5a677c6c6e1d83e6343f8e3690d7b34fe2af5
2021-02-12 14:38:56 -05:00
Sarbojit Sarkar 5e7ee214ec SWDEV-270630 - Added missing nullcheck
Change-Id: I7caf26c59c4660e26b4159da35731c2ce1600819
2021-02-12 13:29:30 -05:00
Sarbojit Sarkar 751578a37e SWDEV-271496 - Added missing params check
Change-Id: I17bbf5ed445826e7380df22fa5c6ec1675e208d6
2021-02-12 13:28:12 -05:00
Vladislav Sytchenko eb00f70bf3 SWDEV-252745 - Guard PCH code behind __HIP_ENABLE_PCH macro
Change-Id: I12425b9d44b3d92f9cacceb797a5d09d99e4156b
2021-02-10 09:23:41 -08:00
Zack Galbreath 8c90ab196b SWDEV-264220 - Provide CMake hip language configuration information
This provides the required information for CMake to bootstrap
HIP language and runtime support. In particular this file
is consumed by CMake during HIP compiler detection to
determine the required flags needed for compilation and
linking.

Initial design was discussed in #2158

Add copyright / license header

Change-Id: I10acb860bf6291b2deb6b678e6e916faa7c82c2a
2021-02-10 08:26:35 -05:00
cjatin 4681e124f6 SWDEV-252745 - Adding rtc options transformer
Change-Id: Ib250689906a35f81255398e53da979774361dbfa
2021-02-09 13:35:30 -05:00
agodavar c149c88fa1 SWDEV-271096 - Handle depth zero in hipMalloc3D
Change-Id: I0ef0cc825e20b3480e9e5476e09dde5f73cdd3ea
2021-02-09 08:39:44 -05:00
Jatin Chaudhary 1770e8a160 SWDEV-271274 - Remove hip init call from hipUnregisterBinary, this call ends up initializing rocclr and hsa even when there is no hip call in the entire file
Change-Id: I20c1d3079c6032d79c5b892d5616921f7aeb4fe2
2021-02-09 07:59:32 -05:00
agodavar e236ae7ea5 SWDEV-269085 - Add support for build with ADDRESS_SANITIZER
Change-Id: I102cbe197727ec059d3dc9fae3a41bb559b0dff1
2021-01-29 01:54:43 -05:00
Vladislav Sytchenko ff4b9ab9bc SWDEV-1 - Fix Windows build
Change-Id: I20c727a8718941694da6dc024efdfd1eb6af828b
2021-01-28 10:22:25 -05:00
agodavar 464cad2751 SWDEV-269400 - handle nullptr in hipFuncGetAttributes and blockSizeLimit<0 in hipModuleOccupancyMaxPotentialBlockSize
Change-Id: Ia1c6e5713f40876b4a9c7a1c56b7b3a589c4497a
2021-01-27 23:41:31 -05:00
agodavar aac12d1bd9 SWDEV-268552 - HIP sample segfaults during hipModuleLoad, fix mmap bug
Change-Id: I51c6061e7ac6b2524586d96fdd69b9f084b1906a
2021-01-27 23:39:50 -05:00