System clock timestamps should only come from a single source:
util::timestamp_ns(). Externally, this function is exposed as
roctracer_get_timestamp() (used by the tracer tool).
Removed the now unused HSA Runtime Utilities which were never part
of the ROCtracer API.
Change-Id: I044b7f4da60fd8fdb771b0c877622a3143f0e815
[ROCm/roctracer commit: f8462b8637]
hsa_rsrc_factory was only used to enumerate the agents types and pools.
The pools don't seem to be used by bin/mem_manager.py, so I only
ported the agent enumeration using hsa_iterate_agents.
Change-Id: Idd586aa13db303cf92962a6392771b7bf38b758f
[ROCm/roctracer commit: 6d6017249a]
Compilers doesn't see assert as a usage of the variables, I added [[maybe_unused]] to the variables that are used only in assert to make sure that the compiler is skipping them in the check. Note: [[maybe_unused]] is introduced in C++17
Change-Id: I96bb53cb2ab55ee7120681c2d279271c0075095d
[ROCm/roctracer commit: 78869032ad]
The else part was not used as it was only using the hipApiString to format the data to string
Change-Id: I376721c478cffba0890436ca8895dfe2a7641570
[ROCm/roctracer commit: 5e012541c5]
1) The Entry's state was published after making the record avaiable,
so a thread flushing the records could see an unitialized record.
2) data_ and write_pointer_ could become out of sync. write_pointer_
could be indexing into another buffer than what data_ was pointing
to.
3) GetEntry could get a nullptr free_buffer_ because multiple threads
could acquire the work_mutex_ before the work_thread_ could wake up,
or between allocate_worker's loop iterations.
Change-Id: I6f0a015557888eeeaa75a8bce7fde8de276d11dd
[ROCm/roctracer commit: 046df32729]
A trace buffer is used to efficiently store synchronous event records
so that they can be processed later, possibly in a different thread,
when the buffer is flushed. This helps reduce the latency added by
tracing API calls.
The API does not need to use trace buffers as synchronous events are
directly reported to the client with callbacks, and asynchronous events
(activities) are saved in memory pools.
The implentation of HSA asynchronous memory copy activities was using
a trace buffer shared with the tracer tool to write the records to a
file (async_copy_trace.txt), instead of using a memory pool and
reporting the activity to the client.
Removed the asynchronous memory copies trace buffer, and updated
hsa_async_copy_handler to use the pool specified when the activity
was enabled.
Updated the tracer tool to read HSA_OP_ID_COPY records out of the
default memory pool and write them to async_copy_trace.txt.
Move trace_buffer.h to test/tool as tracer_tool.cpp is now the only
file using it.
Change-Id: Ida95aba2eaf3c3f2a979ed6c2b060374017b7424
[ROCm/roctracer commit: 61f35b0204]
This test stresses the concurrent writing of trace buffer records while
frequently allocating new storage to hold the records.
Due to race conditions, this test fails with the current trace buffer
implementation.
Change-Id: I0b77c64005e776319bf21f1ee1e6d7c99ddccfff
[ROCm/roctracer commit: 200e27f12d]
Replace EXC_ABORT() checks with assertions.
Rewrite the exception class to use std::runtime_error (as it
already handles the std::string/char* message argument).
Change-Id: I48e31924f3aea1328e6562ab6bb06ec373fd5d5e
[ROCm/roctracer commit: 5963363484]
There's a typo in RegisterApiCallback, roctx::cb_table.Get should be
roctx::cb_table.Set.
Change-Id: I47ec8ac666f783ff4e03f35d13e375e645899900
[ROCm/roctracer commit: 0d7d56eea5]
The proxy queue implements packet interception to enable timestamps
collection. As it is, the roctracer is not intercepting packets, and
instead relies on the rocprofiler tool to collect the timestamps for
kernel dispatches.
This is an issue as the roctracer API does not implement HSA_OPS
activities for kernel dispatches. This will be addressed in a future
commit.
Change-Id: Ib6a778a513410bec4579f223a9d9e9fd9b6054df
[ROCm/roctracer commit: 6b06322578]
Building with -DLIBRARY_TYPE=STATIC fails with 3 undefined symbols.
Add weak symbols to satisfy the linker (mirror what is done for the
other Loader symbols).
Change-Id: I8a2878def21d5f500b0764ceacb4e5255e1111c5
[ROCm/roctracer commit: b352eedac6]
Backward comaptibility for components that search for contents in roctracer.h
Improvements: Removed redundant code for setting and unsetting variables
Added header template file in source code instead of generating it on build time
Change-Id: I96aeb7f2a6d53d45eb5aeb5300024cd22dad1324
[ROCm/roctracer commit: 8ca752ce2c]
Removing DEBUG_TRACES and the unnecessary use of roctracer_op_string, made the MS app reporting 78 to 81 stable samples per second, depending on the type of the trace, while the main app without rocprof reports 100 to 106. More detailed numbers will be posted in the ticket.
Change-Id: Ifbc529278cea54dd23e6086aa9b9ea2df952d5dd
[ROCm/roctracer commit: e4569c41fe]
Before this change, when a producer was blocked by a flush operation,
no other producer could write to the memory pool. This change allows
other producer threads to continue to write by releasing the producer
lock before waiting on the consumer condition variable.
Change-Id: Idc1c07173d2edb18fbe1a61961f10c02e7ca8c20
[ROCm/roctracer commit: dc8717a6b5]
HCC_EXC_RAISING and HIP_EXC_RAISING don't add much value, so to
simplify, only keep EXC_RAISING and EXC_ABORT.
Change-Id: Ifdc54981bb682fe68b418cdc95ecebe668e3dcf6
[ROCm/roctracer commit: 121a84b449]
The HCC runtime is no longer used, so move all the remaining
activities in the HipApi loader and remove the HccLoader.
Change-Id: I845c04ca275a474526840315bae0ad1a4ce02257
[ROCm/roctracer commit: 85552ea3a0]
roctracer_hip.h now contains the definitions for the HCC_OPS domain.
Change-Id: I132c993110254050aaa68828f3ca80f368ad24bc
[ROCm/roctracer commit: d3b166cf01]
It only defines one class (hip_act_cb_tracker_t) that is only used
by roctracer.cpp.
Change-Id: I375a25bd363770d70a7b3b713223484a498cc3d1
[ROCm/roctracer commit: c009df3327]
Use the standard concurrent support library (std::thread, std::mutex,
st::condition_variable) instead of pthread.
Fix a mismatched memory allocation/deallocation when a custom allocator
is provided. The MemoryPool destructor was always using the default
allocator (using malloc/realloc/free) even if the pool memory was
allocated with the custom allocator.
Fix various thread safety issues and inefficiencies (spin loops).
Change-Id: I97592caa947f63463041bf43e00af9ebb5ff5886
[ROCm/roctracer commit: 9d728f74a1]
Move roctracer_cb_table.h to the src/core directory, as it should not
be exposed as a public header, and rename it callback_table.h
Change-Id: Ib448cbd32a275df0268d53bd8d1da0bdc9201470
[ROCm/roctracer commit: cd62d841fa]
This reverts commit 35ea06abd0.
Reason for revert: Merged by mistake
Change-Id: I8c39c823d92cc20a238ca6120dde4b2fa9121e85
[ROCm/roctracer commit: 57add1a6fa]
Removing DEBUG_TRACES and the unnecessary use of roctracer_op_string, made the MS app reporting 78 to 81 stable samples per second, depending on the type of the trace, while the main app without rocprof reports 100 to 106. More detailed numbers will be posted in the ticket.
Change-Id: Ida25d3bfc72047afaa27326d697be76d97564334
[ROCm/roctracer commit: e7327aaac7]
Exchanging the git clone of the hsa-class to a local downloaded version pushed to the roctracer repo
Change-Id: Id45a38b2d355102c2e0dee1e4bfde50398369047
[ROCm/roctracer commit: 7ee4f87b73]
Include the upgrade operation check in the prerm script
in package.
Signed-off-by: Saravanan Solaiyappan <saravanan.solaiyappan@amd.com>
Change-Id: I1504ce96a27d21d9c3d9bafc0dea8055398adc99
[ROCm/roctracer commit: bfea525ff3]
Changing pthread_yield() to sched_yield() as pthread_yield() is deprecated in CentOS 9
Change-Id: I2961b61374e36995d0835f0e65b26c35f5eb8715
[ROCm/roctracer commit: 43a36f8dd5]
Removing the RPATH skip & Removing the install path that was defined CMakelist
Change-Id: Icf374b9548fc7b24e99a1b5ab9720ce6d775abf8
[ROCm/roctracer commit: 8098ec6acf]
To fix the issue we modified CMakeLists.txt as described in Sparry Icarus comment
Change-Id: Ie9ca16cfcfb7b7a9a858f0fb1f5071923c787313
[ROCm/roctracer commit: 554011e767]
Making the new License file, Adding support in the CMakeLists.txt
Change-Id: I43862b8b7f3025ae6200aeb442ea70c7993a7349
[ROCm/roctracer commit: b721e3209e]
Laurent Morichetti
Ammar ELWazir
Tony Tye
Ranjith Ramakrishnan
Saravanan Solaiyappan
Saurabh Verma
Kiumars Sabeti