Commit Graph

13474 Commits

Author SHA1 Message Date
Yaxun (Sam) Liu 4c4fff6b51 Fix test hipDynamicShared
This test does not work if block size is greater than wave size
since it relies on lock-step execution of the kernel in the block.
If there are more than waves in the block, the threads in the block
miss synchronization since one wave may finish before another wave.

Due to this bug, the test fails on GFX10 wave32 mode.

This patch fixes that so that it works for block size greater than
wave size.

Change-Id: Ie0097066081df36cb6fe025a71d0ee5a83ec00a2
2020-10-14 10:15:44 -04:00
Jason Tang c5184d61b4 SWDEV-252150 - No need to send a Marker if the event is completed in Event::notifyCmdQueue()
Change-Id: Iaa1c550ce0849c12298a24812604345dbf877a5e
2020-10-14 09:29:24 -04:00
Jason Tang b38317cb3c Add COMGR_DYN_DLL to device/rocm/CMakeLists.txt
Now rocm/rocdevice.cpp also includes comgrctx.hpp, and we don't want to statically link against comgr when buidling shared libs.

Change-Id: Ic330bd860559b3e07b776c951afe6126b0f43f7d
2020-10-14 09:28:37 -04:00
Sarbojit Sarkar 40f27ec83a SWDEV-255975: fix for gcc + hip_fp16.h compilation error
Change-Id: Ia152bad4af71a5b53a16e2f9fd9aeeacc61b39ac
2020-10-14 06:57:25 -04:00
Sarbojit Sarkar 3b8b31a61c Added sample with __gfx*__ macro used
Change-Id: I80a474947ea1b755082dad5329d1aff3ee78840c
2020-10-14 06:56:39 -04:00
Chauncey Hui a00981128a SWDEV-2 - Change OpenCL version number from 3212 to 3213 2020-10-14 03:00:02 -04:00
agodavar 4018464960 SWDEV-249870: Short-Term solution for Pre-Compiled Headers for Online Compilation - Fix static build
Change-Id: Ib608e73dbffa2d803599cba5ba842cd5a2a2ba9d
2020-10-14 00:37:46 -04:00
German Andryeyev 15ba5611ba Report managed memory capabilities
Change-Id: I241a42e26ee49fb47dcb3ba87c4bd8fb691dffdf
2020-10-13 16:09:43 -04:00
Rahul Garg 85715bc20f Clean up unused options
Fixes SWDEV-253092

Change-Id: Ic820c4d7bec1130978b47094f3ad9764e40e6a1f
2020-10-13 12:19:20 -04:00
Aryan Salmanpour 89964dbbd4 Fix a seg fault when unallocated mem handle passed to hipIpcOpenMemHandle API
also validate the flag argument passed to hipIpcOpenMemHandle API and return
error if it is not equal to "hipIpcMemLazyEnablePeerAccess" (defined to 0)
and it is the only supported flag currenlty for this API.

SWDEV-253462

Change-Id: Ie1c8b79c680a29dc72bf262cf53ae5e011fb1247
2020-10-13 11:14:41 -04:00
Lakhan singh Thakur 04b773471b [dtest] Adding Test case for hipFuncSetSharedMemConfig() and hipFuncSetAttribute()
SWDEV-251504 - QA task for validation

Change-Id: I11ed98f648352cb32161c41290516c77231236bc
2020-10-13 11:11:00 -04:00
Rupam Chetia 4f48154f46 [dtest] hipModuleLoad and related API tests
APIs: hipModuleLoad, hipModuleLoadData and hipModuleLoadDataEx,
      hipModuleGetGlobal(), hipModuleGetFunction
Functional and negative tests
Repeated call to ModuleLoadXX/ModuleUnloadXX
Few tests are disabled now, will be enabled when functional

SWDEV-238517 for enhancing hip unit tests

Change-Id: I65c12027e32db80213468fdee1c5cc1aa3e60bfd
2020-10-13 11:10:11 -04:00
Julia Jiang c144b57d54 SWDEV-249487-remove two HCC related APIs
Change-Id: Icf90ece0808643e0c5f0cc00b6644d5171b553d8
2020-10-13 11:08:37 -04:00
Vladislav Sytchenko 26d1b28b16 [PAL] Allow overriding reported asic revision
This is helpfull to do when debugging issues on lowend asics. Navi14 can be emulated as Navi10. So can Navi22 be emulated as Navi21.

Change-Id: I693ffd45a5b03657822afdc872781901bc69b65c
2020-10-13 09:36:15 -04:00
agodavar 92f1ce41dc SWDEV-254185 : hiprtc headers - handle empty headerIncludeNames
Change-Id: Ie06278c18b62cef1bdfbb8ac82728ed5667b2047
2020-10-13 09:23:43 -04:00
German Andryeyev c05de4f2f9 Add ROCr queries for HMM support
Change-Id: I2b5508bf0faf8f48dd7348d6a5202fb28de09876
2020-10-13 09:12:00 -04:00
agodavar e65bbb0329 SWDEV-255853: CUDA device P2P attributes
Change-Id: I7deffd04101b565f68a72a179f9faeaa22cab97d
2020-10-13 05:32:29 -04:00
agodavar fae443cb36 SWDEV-254909:Support for missing texture/array cuda driver types
Change-Id: I9c769f6335ec3e7feacaa8929719c666bff91934
2020-10-13 05:30:31 -04:00
Chauncey Hui 2a5f1ccadf SWDEV-2 - Change OpenCL version number from 3211 to 3212 2020-10-13 03:00:03 -04:00
Freddy Paul 5a46d80682 HIP:Break dependency to rocm-dev package
Check for rocm_agent_enumerator instead of rocminfo or
.info/version.

Change-Id: I1718bd4f70b3e527ea3afe19c1a685ab7ed70808
2020-10-12 17:53:53 -04:00
agodavar 7d67573a4f SWDEV-254185 - Added support to pass include headers to hipRTC
Change-Id: Ia19e6806a476d3c6ecd3e9a89c3ed72953a4900c
2020-10-12 06:04:14 -04:00
agodavar ac72e50adc SWDEV-254185 - Added support to pass include headers to hipRTC
Change-Id: Ic7f2957b04e518c57e2fd3fc9d839de07232405e
2020-10-12 03:46:04 -04:00
Tao Sang 0d1cf31eb1 Revert "Make directed_test support static libs"
This reverts commit 36c5679efc.

Reason for revert: <INSERT REASONING HERE>

Change-Id: Ib2d1084ea21461f70f96f95c6025a08f88288357
2020-10-12 00:01:13 -04:00
Chauncey Hui 2810b8f367 SWDEV-2 - Change OpenCL version number from 3210 to 3211 2020-10-10 03:00:03 -04:00
Sameer Sahasrabuddhe 160dfb5a1f Do not inline the body of __assert_fail()
The device side assertion calls printf to write out a message. In the
device compiler, printf is expanded into a series of hostcalls that
transmit the printf payload to the host. This expansion increases the
length of the kernel, resulting in sub-optimal compilation. The
solution is to ensure that the assert() implementation is not inlined
into the kernel.

Change-Id: Ia3a075461a755cf007218f262b0863e1926c76aa
2020-10-10 01:03:04 -04:00
Yaxun (Sam) Liu 147f064d31 Disable wave64 support on GFX10 for HIP
Change-Id: Ie3d4fe91516167ea26ce704689b6b6f1951a7521
2020-10-09 17:02:56 -04:00
Vladislav Sytchenko fd09a7a23c [PAL] Skip extra calls to MakeResident
With the PAL_ALWAYS_RESIDENT flag memory objects are resident at allocation time, no need to make them resident again before submit.

Also we should never evict anything with this setting, or we'll generate a VM fault.

Change-Id: Ieacc6af88ab4e09c20efd94100e148b2502e1d70
2020-10-09 14:13:32 -04:00
Tao Sang 36c5679efc Make directed_test support static libs
1.Make directed_test apps linked against static libs
of hip, rocclr, rocr, roct and amd_comgr.
2.Remove custom_target amdhip64_static_combiner.
3.Support EXCLUDE_HIP_LIB_TYPE <static|shared>.
4.Simplify argument list parsing.
5.Fix hip_pch.o missing issue in samples' build.
6.Fix some original small bugs.

Change-Id: I30f5e65367613152ce86b80b13e1c9f2a28da803
2020-10-08 22:46:58 -04:00
Jason Tang f2c2fd3d09 Add hipStreamSynchronize to hipModuleLoadDataMultThreadOnMultGPU test
hipStreamDestroy() by definition doesn't guarantee waiting for all stream operations.

Change-Id: Ibfd21c48d71741ebcbcb9898c8b5ac235bdc570b
2020-10-08 11:06:39 -04:00
Payam 95bef523fe Cleaning lintian warning SWDEV-247996 Part1
Change-Id: Ie024912b65125c3e14ecc278ac12e07912df6354
2020-10-08 05:44:58 -04:00
German Andryeyev 4ee6d78763 Use more managed memory interfaces
Add extra API calls for managed memory: hipMemAdvise, hipMemPrefetchAsync,
hipMemRangeGetAttribute

Change-Id: Ifb09744acdf7582d278453707373c89c30e3ed03
2020-10-07 16:45:25 -04:00
sumanthtg 00d46218b7 [dtest] Tests for atomicAdd/atomicAddnoRet
Positive and negative test cases for atomicAdd and
AtomicAddnoRet device functions

SWDEV-238517 for enhancing hip unit tests

Change-Id: Id20ba2550d20f224004f105cdcd087002cb80e56
2020-10-07 13:20:12 -04:00
sumanthtg 4eb65d58dd [dtest] Additional tests for hipOccupancyMax APIs
Additional tests for following APIs
- hipOccupancyMaxActiveBlocksPerMultiprocessor
- hipOccupancyMaxPotentialBlockSize

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ib9441c1366f46a082e10eb1a572bc7d8ebe1ee37
2020-10-07 13:19:06 -04:00
Chauncey Hui 099dbb7f13 SWDEV-2 - Change OpenCL version number from 3209 to 3210 2020-10-07 03:00:03 -04:00
Sourabh Betigeri acdc435e77 SWDEV-247768: Added new perf test - SampleRate
Change-Id: I3aee07dff3759a0ac56a1afb384168bb94394187
2020-10-06 12:46:13 -04:00
Sarbojit Sarkar a3b44b5f75 [perf]hipMalloc perf optimization
Change-Id: I9cd1d29205cb0c9938d26bb8e336fc9fe8a262ed
2020-10-06 12:22:57 -04:00
Vladislav Sytchenko 8034467ec3 Change __HIP_ENABLE_PCH to be an option
Currently all the logic checks if __HIP_ENABLE_PCH is set, so setting it
to OFF will still enable PCH.

Switching __HIP_ENABLE_PCH to be a CMake option will enable correct
build behaviour.

Change-Id: I77a663589ffb5f2595c6ad3d144eb9466adcf250
2020-10-06 11:17:47 -04:00
Jason Tang bad12583b0 SWDEV-255321 - Support target names from Target ID feature
Change-Id: I45e5314dff2ee65dd402c38744279bf67501304d
2020-10-06 09:00:54 -04:00
kjayapra-amd 40322a9f1c SWDEV-254363 - Checks to make sure kernel is launched on the same device as it was launched.
Change-Id: I2f273a70b1a5fc0e9fc9c6144eabd32466ff4e59
2020-10-06 08:38:09 -04:00
German Andryeyev d9397590de Add option to skip AQL barrier
The change reuses HSA signals for dispatches as a wait signal.
Skipping the barrier requires to  disable L2 cache for sysmem
allocations and extra tracking for HDP access with the large bar.
ROC_BARRIER_SYNC=0 activates the new logic. Barrier sync is
still used by default.
ROC_ACTIVE_WAIT=1 enables unconditional active wait in ROCr.
The change also consolidated ROCr wait logic under single function.

Change-Id: I6bd1be30aa88258da1b1f9de319ef5a45852afd8
2020-10-06 08:37:12 -04:00
Rahul Garg 2a5d39cd3b Remove libhip_hcc references
These were added in commit 2cce9170c3.

Change-Id: I5815c90bb83ac74730f6bce114eb353f54b86670
2020-10-06 04:29:35 -04:00
Sarbojit Sarkar 4a025e1a87 [perf]hipMalloc performance optimization
Change-Id: I6e8a918cc1c4cafad197b09e10755cd180e11ead
2020-10-06 03:19:41 -04:00
Sarbojit Sarkar 8ab8fac173 SWDEV-253548 : clean up gfx-arch macros
Change-Id: I8deb2ea44f556260bb78d24f68b04b0c730ed4d8
2020-10-06 03:17:09 -04:00
Chauncey Hui c7f03dae75 SWDEV-2 - Change OpenCL version number from 3208 to 3209 2020-10-06 03:00:02 -04:00
Sarbojit Sarkar 3f0e33adb5 SWDEV:253548 : remove gfx-arch macros
Change-Id: I1ef0b4e080c15a9c6228f48ecd6a65b134d0a72d
2020-10-06 01:15:58 -04:00
Yaxun (Sam) Liu 71586b02e3 Fix warpSize for gfx10
Change-Id: I8029ebeb91db1efa8e166ad349aaae6364e8069d
2020-10-05 20:45:07 -04:00
Rahul Garg 9f81811fd2 Bump version to 3.10
Change-Id: I7410996510fa24d2db0a4ecb2a2642e2e95058cf
2020-10-05 20:26:38 -04:00
Vladislav Sytchenko d5aa0f607d Revert "Revert "Merge branch 'amd-master-next' into amd-npi-next""
This reverts commit 9142674ef0.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I92ceb171e31026ed1864704cef2fc1497b883ef9
2020-10-05 13:20:58 -04:00
Vladislav Sytchenko 9142674ef0 Revert "Merge branch 'amd-master-next' into amd-npi-next"
This reverts commit d7c02619d6.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I53322718dadde2c98f96140b8e260ec7ee9ef721
2020-10-05 13:02:39 -04:00
German Andryeyev ef5d9bd562 Fix error codes in HMM interfaces
Change-Id: I16490c575f2840b1116a4135431a611cf812f3a4
2020-10-05 12:54:16 -04:00