Commit Graph

796 Commits

Author SHA1 Message Date
German Andryeyev 116c9fd6c1 SWDEV-409815 - Fix image view cache issue
Make sure parent_ field is cleared for the internal image views.
The internal image views don't require dependencies tracking.
The issue appeard only when Navi10 pitch workaround was enabled.

Change-Id: I376d212750085a9391f8c32fc2979dcb5d93c89c


[ROCm/clr commit: 6b89980fb2]
2023-07-11 11:22:29 -04:00
Alex Xie a7418845f8 SWDEV-409299 - Vega clinfo is not working
Change-Id: Ia48bc6f130bd102dff210b105de6f9c02ebbe012


[ROCm/clr commit: 7912f3af89]
2023-07-10 09:53:50 -04:00
German b55398774b SWDEV-408650 - Report CL_DEVICE_HALF_FP_CONFIG query
If cl_khr_fp16 extension is enabled, then OCL runtime should report CL_DEVICE_HALF_FP_CONFIG.

Change-Id: I7c4ac48387f80bc704a475c57e5b52a462090d1b


[ROCm/clr commit: ad2c1e899a]
2023-07-06 11:58:16 -04:00
kjayapra-amd 03504e2f6c FEAT-47686 - Changes to support new uncached memory segment in ROCr.
Change-Id: I0ba8769d6737cdf1cc8a8644b2e82109f584a430


[ROCm/clr commit: aca7d9e14a]
2023-07-05 20:47:51 -04:00
Jaydeep Patel 6fa299f3a3 Revert "SWDEV-403995 - uniform_work_group_size is interger type is 1 for true and 0 for false. Lighting kernel's init sets uniform work group flag and hence not need to set it from options."
This reverts commit 063b3d4e51.

Change-Id: I077135a726320eb109888f0e7442120dc852ad3e


[ROCm/clr commit: 90f53925a3]
2023-07-05 04:41:40 +00:00
Rakesh Roy f887f2fc6f SWDEV-405329 - Fix cuMask issue for WGP mode
- Enable CUs adjacent pairwise for WGP mode
- In HostQueue::terminate() do not segfault if virtual device hasn't been created

Change-Id: I94402ff333308af5824878086cc238b3993d534d


[ROCm/clr commit: 8c1232124e]
2023-06-30 01:09:01 -04:00
Saleel Kudchadker 47894de700 SWDEV-384557 - Rename env var
- Rename HIP_USE_SDMA_QUERY to DEBUG_CLR_USE_SDMA_QUERY as this is
supposed to be a temporary env var for debug purposes only.

Change-Id: If6ebd52ab87624375a3df24ceccdcc05c60a65af


[ROCm/clr commit: 770b2a4711]
2023-06-29 13:54:55 -04:00
kjayapra-amd 4ad93e01f7 SWDEV-408213 - Move the init_heap blit kernel inside linear blit kernel grouping.
Change-Id: Id540018d4cceab5f01f614f7d49ef42505e69039


[ROCm/clr commit: a034995f81]
2023-06-29 10:36:53 -04:00
German Andryeyev 1de5c73c38 SWDEV-396088 - Add image view cache
Blit manager requires an image view to reduce the amount
of copy kernels. Creation/destruction of a view in ROCr is
an expensive operation. Thus, runtime can cache views for fast access.

Change-Id: Ia67d775b481cc8326d91215ca22d4a73c1dddb59


[ROCm/clr commit: d29755452b]
2023-06-28 09:44:05 -04:00
Saleel Kudchadker 9cb5f95a56 SWDEV-408180 - Remove largeBar memcpy
- Remove large bar memcpy path. Since we end up waiting for a barrier,
its defeating the true intent of the copy, Also memcpy over PCIE\XGMI is
introducing variability in perf for HPC apps like GROMACS

Change-Id: I3b5c9d9ce93333959c39023bf4f703e2ccb6e3af


[ROCm/clr commit: 0a3d4bd4d4]
2023-06-27 18:15:26 -04:00
Saleel Kudchadker 97fea3890c SWDEV-301667 - Enable SDMA profiling only when queue profiling
Change-Id: I9a62a2fbaefd54638c35f4b8fce2e9ea2da7af19


[ROCm/clr commit: bceec9d9a2]
2023-06-26 16:10:34 -04:00
ajay a8d5879f26 SWDEV-406687 - combining rocblitcl and palblitcl blit kernel defs
Change-Id: Ia312d73584a03491e8d574f424295b64df6de174


[ROCm/clr commit: d6946ffcbc]
2023-06-23 18:38:36 -04:00
Matt Arsenault 4af8b4ef0f SWDEV-1 - Fix -Winconsistent-missing-override
Change-Id: Ie69f234c755b112b7fe8ef7d00b8720bc178044c


[ROCm/clr commit: 98e0607f0e]
2023-06-23 09:04:28 -04:00
Alex Xie 867d1fc66f SWDEV-382072 - One more case that needs workaround
Change-Id: Ief81dd898e4d59ba858f38a843d79be45b5ea944


[ROCm/clr commit: cfc10d0e1e]
2023-06-22 19:00:34 -04:00
Alex Xie c14a017d77 SWDEV-382072 - [Naiv 10]EncodeSDK H264 test fails
let ROCr and addrlib decided whether a pitch is supported.
Then, check if we uses workaround.

Also improve image performance for Navi 1x in some cases.

Change-Id: If8bda46648b23c1dcfa26608ca3bb9cd89fef430


[ROCm/clr commit: b961d4a970]
2023-06-22 10:40:31 -04:00
German c8e65415ea SWDEV-311270 - Clean-up IPC path in ROCclr
- Make IPC interfaces generic between devices and rely on the IPC buffer
for attach/detach logic

Change-Id: Id3c18d122030329b7ee532bbb6317de9dd6a0bbe


[ROCm/clr commit: 9aa6f25f1c]
2023-06-20 15:18:21 -04:00
Saleel Kudchadker 60b9dc4a45 SWDEV-301667 - Better log
Change-Id: I3b5b3593cb0144e56a4ddea2fa29028544a73203


[ROCm/clr commit: b2240bcda5]
2023-06-20 14:26:44 -04:00
Sourabh Betigeri 395c4f1b40 SWDEV-406750 - Fix to avoid a warning when compiling HIP runtime
Change-Id: If1d848d334bc0121a96655781fc60b0321213398


[ROCm/clr commit: 0330801846]
2023-06-20 12:16:16 -04:00
Saleel Kudchadker 2e67d925a1 SWDEV-384557 - Include query under env var
Change-Id: Ibe0335168f9ad0cb72abb2ed69a5e40d33ce7c1c


[ROCm/clr commit: 4510caed26]
2023-06-16 15:09:46 -07:00
ajay c4e5952687 SWDEV-404940 - __amd_rocclr_initHeap in pal.
Avoid Seg fault on Windows

Change-Id: I3901c003dd33222ec9e2600c519d8503f5e81c01


[ROCm/clr commit: 169d17f47f]
2023-06-16 11:48:42 -04:00
sdashmiz 2216908962 SWDEV-403638 - Fix warnings
- disable deprecated function use warning
- disalbe size_t to .type' warning
- disable conversion from 'type1' to 'type2' warning

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I64161fd37cf56de3d132102103267ae8da40193a


[ROCm/clr commit: 38a67df312]
2023-06-15 12:17:22 -04:00
German af5944dc71 SWDEV-311270 - Add IPC support for memory pools
Initial implementation for hipMemPoolExportToShareableHandle,
hipMemPoolImportFromShareableHandle,
hipMemPoolExportPointer and hipMemPoolImportPointer

Change-Id: I0ebdc48e9163b394ded560adca6c38bbc5aee7d1


[ROCm/clr commit: 1a0c3e4dc4]
2023-06-15 11:36:52 -04:00
Jaydeep Patel d6086f9d69 SWDEV-403766 - Release mem obj while device reset.
Change-Id: I8a93061c9c4ed692bf7ba1b872af370f79a13a5d


[ROCm/clr commit: ec75a3e60e]
2023-06-15 09:52:50 -04:00
Saleel Kudchadker 87652b6c93 SWDEV-384557 - Use toggle for SDMA query
- Use HIP_USE_SDMA_QUERY env var toggle for new API use. Env var is 0 by
default

Change-Id: If725a0c41e15f78a1a6c3f47942954fe9240b4db


[ROCm/clr commit: 8d193c32bb]
2023-06-15 01:02:24 -04:00
Jacob Lambert 52eaffa1a4 Revert "SWDEV-371628 - Shift device lib linking into clang driver"
This reverts commit 2e664d2492.

Reason for revert: Performance regressions and failures observed. Need to investigate those and before re-applying patch

Change-Id: I42ba0605797f9bdcfb5d5102927dd01405cf05e3


[ROCm/clr commit: 8047d8e3e8]
2023-06-15 00:56:08 -04:00
Jaydeep Patel 063b3d4e51 SWDEV-403995 - uniform_work_group_size is interger type is 1 for true and 0 for false. Lighting kernel's init sets uniform work group flag and hence not need to set it from options.
Change-Id: Ife45c1e3ccef03d16d7e07c3e0714fd8fd388fd3


[ROCm/clr commit: 2c9c58e7bb]
2023-06-06 23:05:25 -04:00
Vikram 5ba0fb5802 SWDEV-354050 - Runtime support for HIP non hostcall printf
Relates to https://reviews.llvm.org/D150427,

Each printf call populates buffer with following data
1. Control DWord - contains info regarding stream, format string constness and size of data frame
   (see http://gerrit-git.amd.com/c/lightning/ec/device-libs/+/857722 for more info)
2. Hash of the format string (if constant) else the format string itself
3. Printf arguments (each aligned to 8 byte boundary)

Change-Id: I7e320deb343921b4b4cfaf08a2be2883e0bc1f65


[ROCm/clr commit: 7b6a8f1702]
2023-05-26 01:55:20 -04:00
Saleel Kudchadker a5715294fb SWDEV-301667 - Add a flag for gpuvm kernargs
HIP_FORCE_DEV_KERNARG=1 will create a device allocation for kernel arg
segment. Flag is 0 by default.

Change-Id: Iaaf5a149f3be8596568878d5d272268baf067c60


[ROCm/clr commit: 5436d362b1]
2023-05-22 11:23:48 -04:00
Saleel Kudchadker 9394aa2671 SWDEV-384557 - Do not fall back to compute
- Use regular copy API if we exhaust free SDMA engines and not fall back
to compute copy. Falling to compute is affecting performance for
numerous apps that are GPU bound

Change-Id: I75c767eff0b9f5ada324301c5c327fe2c23a9806


[ROCm/clr commit: 60d9a4ebab]
2023-05-22 11:23:23 -04:00
Alex Voicu e266f8834b SWDEV-301667 - Kernelarg gpuvm
Add aligned, nontemporal `memcpy` for kernarg.

Change-Id: I5d8ac76904feaf793b45ec2ea5fbd1069be20068


[ROCm/clr commit: 06df9e2efd]
2023-05-22 11:21:14 -04:00
Jacob Lambert 2e664d2492 SWDEV-371628 - Shift device lib linking into clang driver
Previously, we used the following approach and Comgr actions
for device lib linking:

    AMD_COMGR_COMPILE_SOURCE_TO_BC (compile with clang driver)
    AMD_COMGR_ADD_DEVICE_LIBRARIES (link in device libs with
      llvm-link API)

However, the clang driver can link in device libraries as part
of compilation, assuming a --rocm-path is set. In this context,
this is accomplished by using the following Comgr action instead:

  AMD_COMGR_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC (compile and
    link in device libs with clang driver)

Change-Id: I661465865365afecc44aa15d4df91bfab361af8d


[ROCm/clr commit: a4c5c44008]
2023-05-17 17:40:56 -04:00
Ioannis Assiouras ad30c947bf SWDEV-400119 - Return error from globalFreeMemory() if HSA available memory query fails
Change-Id: I33c069fa1e0d31891f64dc8167a24ef9d7ed1426


[ROCm/clr commit: a07e38be2f]
2023-05-15 11:54:25 +01:00
Saleel Kudchadker 0141e6809f SWDEV-398151 - Partly relax static engine allocation
Change-Id: I4903b51a34b597a2e84d771b52cf629f877dba05


[ROCm/clr commit: 0b475284e9]
2023-05-11 00:52:18 -04:00
Jaydeep Patel cb3642e26e SWDEV-398047 - Disable arena for XNACK.
Change-Id: If6c98490bd5b8146a357f45ed132f687def0877f


[ROCm/clr commit: ffa1deef27]
2023-05-10 23:28:05 -04:00
taosang2 8d054fa50e SWDEV-366528 – Fix image memory format updating issue
Add dstMemory format updating.
Separate format updating for srcMemory and dstMemory.

Change-Id: I1692b92d417bbd742d562679f218ebf8ca532e92


[ROCm/clr commit: 7624a48de9]
2023-05-08 21:43:42 -04:00
Jaydeep Patel 34f9de0f7e SWDEV-397168 - Enable dynamic call stack size for PAL.
Change-Id: I8be51ffb48e6a742117491a4bf6f12f152e4a0b3


[ROCm/clr commit: 0eb96cbc59]
2023-05-07 23:26:28 -04:00
German 8d97827417 SWDEV-353281 - VM support in mempool for graphs
The change enables VM support in graphs on Windows. That allows
to avoid caching of all allocations at the cost of map/unmap
overhead during memory create/destroy.

Change-Id: I792be00fba099e5e5d3cd44a963e1dfd6976a86d


[ROCm/clr commit: 04b696abee]
2023-05-05 15:31:26 -04:00
kjayapra-amd 23584feba4 SWDEV-393910 - Port gfx94x changes to mainline.
Change-Id: Ibf727223bbe5230b132b47c39e0fc1d87cbd3b9c


[ROCm/clr commit: f14e8a2dba]
2023-05-05 15:16:23 -04:00
Sourabh Betigeri d7275cb51c SWDEV-393362 - Move setData() from profilingEnd() to profilingBegin() to eliminate a possible data race
- Introduce a state variable to indicate if HwProfiling is enabled to
eliminate a possible data race of vector<> signals_.

Change-Id: Id504cc76d7fa9f7e6455587dd232b60ccbbb735b


[ROCm/clr commit: afa28cdf44]
2023-05-04 17:19:25 -04:00
Jaydeep Patel 23af1d59d3 SWDEV-392870 - Enable p2p support for image using PAL.
Change-Id: I3acbbc01ee11e488e93204814361b8c3431bca4f


[ROCm/clr commit: 82e4859e03]
2023-05-03 00:34:08 -04:00
Jatin Chaudhary 639656a09e SWDEV-376453 - Changes to fix crash seen with HIP and recent compiler change with -O0
Change-Id: I37de83b7449461ce2378741e97ff8fb8da736523


[ROCm/clr commit: c585aefdb7]
2023-05-02 17:46:38 -04:00
Saleel Kudchadker 44512e3228 SWDEV-301667 - Cleanup log
Change-Id: I9719ec8b19406a062727937471e7a845a522a0be


[ROCm/clr commit: 538d453b86]
2023-05-01 11:07:55 -07:00
Saleel Kudchadker a210535169 SWDEV-392427 - Invalidate Barrier Value AQL header
Change-Id: Id8e04ffe44da58641361468957d397af128443bb


[ROCm/clr commit: 9775c38725]
2023-05-01 14:06:05 -04:00
victzhan 2278d7e0ad SWDEV-345751 - fix misinitialize arraySlice in partialMemCopyTo()
Change-Id: I622c368957b1bd39e973f9afa4ee01593dd9e8ac


[ROCm/clr commit: d9c00767dc]
2023-05-01 13:07:44 -04:00
German 5af1af9c57 SWDEV-353281 - Move VirtualMem map update to memobj
- The implementation in mempool graphs requires refcounting VA object.
That requires release() to update the map only on the actual destruction.
- Add GPU event tracking for paging operation. Otherwise, runtime
may not always flush IB.

Change-Id: Idf99ffb894321a38e04b490116a7ca435635918d


[ROCm/clr commit: 7ef2da5aba]
2023-04-28 17:22:11 -04:00
German Andryeyev b2525dfb82 SWDEV-381627 - Move cl_vk_amd.hpp into rocclr
Rename VK interop to ExternalMemory object, since it should handle
DX interops also

Change-Id: I536ec46d3e53ece35234a2e29030393ad411b96d


[ROCm/clr commit: 3e5803c4c0]
2023-04-26 15:25:01 -04:00
Jacob Lambert eda5e6731e SWDEV-1 - Add missing newlines to debug log output
Change-Id: I6c98d482079c34931cdc0615075eba34f87241f3


[ROCm/clr commit: 2a9d8b5862]
2023-04-25 13:10:57 -04:00
pghafari 0ddd82a5f7 SWDEV-367145 - adding support for timeline semaphore
Change-Id: I654359b48abe8bbaac2def5118d3ad0bb05d9492


[ROCm/clr commit: afa15ddb89]
2023-04-25 10:02:43 -04:00
Saleel Kudchadker 8ae30e036d SWDEV-384557 - Fix engine status query
- Maintain a map of SDMA engine# to stream allocated following a greedy
approach
- Anything past that will query SDMA engine status always and go with a
SDMA or Blit copy path

Change-Id: Ibfaed7f951ab84d80cb0430596a4d11b5aec9202


[ROCm/clr commit: 5865c642d4]
2023-04-21 00:57:26 -04:00
pghafari 82219d2fb1 SWDEV-366992 - adding handle type for vk interop
Change-Id: I79ee0d89b948c21b96709e9e607abe7901621a97


[ROCm/clr commit: 78de2ae692]
2023-04-18 16:59:25 -04:00