Граф коммитов

12611 Коммитов

Автор SHA1 Сообщение Дата
Ioannis Assiouras 1868de1f7d SWDEV-436236 - Fixed integer division to float result in Heap::FindMemory
Change-Id: Ic72cfdbe1f62fabd3e25d33bfa540d82a02480d0


[ROCm/clr commit: 2ede1c9adb]
2023-12-06 12:41:00 -05:00
Ioannis Assiouras 5a141cbda4 SWDEV-433821 - Make hipStreamWaitEvent flags a default argument
Change-Id: I0192c1c5f69a1bbcc3f9919f76c947dc40737cb8


[ROCm/clr commit: a562194562]
2023-12-06 12:37:35 -05:00
Jatin Chaudhary 07237ed91d SWDEV-435702 - the functions in bf16 header need to be static
If the compiler decides not to inline these functions, we might break ODR (one definition rule) due to this file being included in multiple files and being linked together

Change-Id: Iacbfdabb53f5b4e5db8c690b23f3730ec9af16c0


[ROCm/clr commit: 77c581a3eb]
2023-12-06 03:59:54 -05:00
Satyanvesh Dittakavi 70ee947527 Revert "SWDEV-419480 - HIPRTC implementation of standard headers shouldn't be in std namespace"
This reverts commit 239fdc3bfd.

Reason for revert: This is considered a breaking change and requires
multiple apps to change their behavior. This will be reintroduced in later releases.

Change-Id: I3481627115af1872785585a155cc6a0ecfbe1372


[ROCm/clr commit: 7febad13be]
2023-12-06 03:11:59 -05:00
Anusha GodavarthySurya 183bc0a591 SWDEV-351966 - Remove hipRegisterTracerCallback from dispatch table
Change-Id: Ib343e2c8414a98c0cee6c60fb74a47bb859d8f45


[ROCm/clr commit: d347f1d67d]
2023-12-06 01:23:33 -05:00
Rahul Garg 8a0d73882a SWDEV-427855 - hipamd change for profiler and TF fix
This reverts commit e1889b77b4.

Change-Id: Id69e47a1afd336ae1edb9c8e173be27e7b9dcc8d


[ROCm/clr commit: afc28b091e]
2023-12-05 20:33:48 -05:00
Ioannis Assiouras 4a96c2fe15 SWDEV-435715 - Acquire the streamSetLock prior to iterating the set in WaitActiveStreams
Change-Id: I0a9721dcde1a3716192d532e290d8a7afc8ac9fc


[ROCm/clr commit: 3c6505c2d5]
2023-12-05 04:12:24 -05:00
Satyanvesh Dittakavi 85e9925335 Revert "SWDEV-431175 - Remove datatypes from HIPRTC"
This reverts commit 6035b47801.

Reason for revert: This is considered a breaking change and requires
multiple apps to change their behavior. This will be reintroduced in later releases.

Change-Id: I0354ce4e0f5e6c402499a7a8c2aaf43bf5b1bfc7


[ROCm/clr commit: 270c6d48f1]
2023-12-05 02:32:38 -05:00
Jaydeep Patel 0d74d8b187 SWDEV-430911 - Force SDMA only if explicitly specified & pick appropriate engine.
Change-Id: Ib34fa6b2782f74b753899fa8fddff646dc60c8ce


[ROCm/clr commit: 3daf8b334a]
2023-12-04 21:58:47 -05:00
Ioannis Assiouras 73c249bb59 SWDEV-435168 - Added virtual destructor in StreamCallback
Change-Id: I548f34e4f4208658a5a6c35927fc424415186354


[ROCm/clr commit: 8a53c97fd1]
2023-12-04 17:32:45 -05:00
German a414a5c7a3 SWDEV-435015 - Disable sysmem allocation in abstraction layer
Change-Id: Idefdabd2997d618b962c42545ae67768c628c5d6


[ROCm/clr commit: 01217d0383]
2023-12-04 11:40:28 -05:00
Jatin Chaudhary c9b5c5c657 SWDEV-431399 - add const cast to pointer before casting it to function type.
C++ does not allow const qualifier on function type, even if we add it it will get ignored and clang will fail with failed cast from const void* to func*. const_cast here is necessary to make it work.

Change-Id: I72cec8d9e715bdf9e163cb9b08393dd733dafaf2


[ROCm/clr commit: 5b5213adf5]
2023-12-04 04:34:57 -05:00
Ioannis Assiouras ab411c8f34 SWDEV-434702 - get the nullstream in constant time in iHipWaitActiveStreams
Change-Id: Ib92cc4d2ca1b725cf30b24cdd711c873fd513d95


[ROCm/clr commit: 8bdda90071]
2023-12-03 19:05:18 -05:00
German Andryeyev d60fabacbe SWDEV-434298 - Add destination offset
The end pointer in copy buffer requires destination offset

Change-Id: I01f2967144f741761fd2ce3244fd8d04564d986f


[ROCm/clr commit: 44761fe89b]
2023-11-29 16:33:29 -05:00
Satyanvesh Dittakavi 66b4a403a6 SWDEV-434362 - Replace __HIP_CLANG_ONLY__ as it is not supported on HIPRTC
__HIP_CLANG_ONLY__ is not recognized in HIPRTC, due to which some
math functions like amd_mixed_dot were not included in hiprtc builtins.

Change-Id: I1fe41e1ddc8911f6a5b5b1405dd4730d0170a4f7


[ROCm/clr commit: f0010f4fdb]
2023-11-29 04:22:19 -05:00
German Andryeyev eec1e978f0 SWDEV-434298 - Change copy buffer kernel
The new copy kernel can limit the number of launched workgoups.
It can copy in chunks of 16 bytes or 4 bytes.
Workgoup size is increased to 512 or 1024

Change-Id: Ic3fefa2d5bda6afebd1acc4d41ad310b138af6df


[ROCm/clr commit: ed4e1fec98]
2023-11-28 16:56:30 -05:00
AravindanC 50dab3bf30 SWDEV-354543 - Update File permissions for opencl sdk
Change-Id: I0a0f28a969d130ac003110b9abd4b768bc20be69


[ROCm/clr commit: 24fced96b3]
2023-11-28 13:06:00 -05:00
Satyanvesh Dittakavi 6035b47801 SWDEV-431175 - Remove datatypes from HIPRTC
Defining int64_t, uint64_t, int32_t, uint32_t in HIPRTC
seem to result in conflicts with some apps as they use
their own definitions for these types. NVRTC also doesn't
define these. Hence remove them to match the behavior.

Change-Id: I77ef70e846950698cb00375f5d0501b907f01fe3


[ROCm/clr commit: 629e279f72]
2023-11-28 11:32:12 -05:00
taosang2 cc6e0c2a32 SWDEV-431104 - Query atomics attribute in Win
Make hipDeviceAttributeHostNativeAtomicSupported return
right value in Windows

Change-Id: I149a8629769cd0d5848ffefb24f1752678a685b8


[ROCm/clr commit: 1faf1a4cb9]
2023-11-24 09:16:41 -05:00
Jaydeep Patel 7933b88d7c SWDEV-431879 - Introduce IsHandlerPending back.
It seems that due to removal of vdev()->isHandlerPending(),
Marker queued to ensure finish is not enqueued and that cause
hung at waiting event for kernel enqueue command.

Change-Id: I364abb2dcb4897b11a7eb61b5d85013b69292792


[ROCm/clr commit: eecbc2e436]
2023-11-23 08:45:19 -05:00
Anusha GodavarthySurya 3bdedf0cc7 SWDEV-351966 - Dispatch table for hip runtime
Change-Id: Ie4a44fa8cf1ff9c152146070bbbf6b0636d4e325


[ROCm/clr commit: 5e21f0c6bd]
2023-11-22 01:11:19 -05:00
Alex Xie cea00f53fb SWDEV-423536 - [ROCM QA] Observed 1 test failed
Change-Id: Icb41f1031ec40e0df5df7a6d21ffd6602b665a09


[ROCm/clr commit: ae8d3a6a4e]
2023-11-20 11:57:29 -05:00
Ioannis Assiouras 4593cb2ef8 SWDEV-433069 - Fixed hip mempool impl SetAttribute switch-case
Change-Id: I0b1b8414db09051125dae4ea98f70827f10c4b98


[ROCm/clr commit: 3e6b4a528d]
2023-11-17 17:51:39 -05:00
German Andryeyev e390ec044f SWDEV-432174 - Change the fillBuffer kernel
- Add the new fillBuffer kernel, which allows to launch a limited
number of workgroups for memory fill operation
- Switch fill memory to 16 bytes write by default
- Allow to limit the workgroups with DEBUG_CLR_LIMIT_BLIT_WG

Change-Id: Ibad1822f2d42b2fc71bcfc1917c31409c0623e8e


[ROCm/clr commit: f1dc81f427]
2023-11-16 14:25:55 -04:00
Rahul Garg e1889b77b4 SWDEV-427855 - Revert "SWDEV-427855 - hipamd change for profiler and TF fix"
This reverts commit 7478e90727.

Reason for revert: <Need rocprofiler changes to avoid PSDB failures>

Change-Id: I856b7ea30744f1b7bb099b6adbce2155201be539


[ROCm/clr commit: 57cb840058]
2023-11-16 00:20:54 -05:00
jiabaxie 7478e90727 SWDEV-427855 - hipamd change for profiler and TF fix
Change-Id: If32eb0ee152f3f46741a8277689363181c8753e8


[ROCm/clr commit: 3b9963c499]
2023-11-15 23:36:52 -05:00
Jaydeep Patel 7fc7ba2288 SWDEV-432530 - Change to --hip-path.
Change-Id: I6fb2fd9111750f4fe5a56be440841ec32c0aa53c


[ROCm/clr commit: 067e2a355f]
2023-11-15 23:22:44 -05:00
Saleel Kudchadker cb9a715e04 SWDEV-422207 - Report kernel names for activity profiling
- Report kernel names for optimized graph path
- Refactor code so that we store profiling info in Accumulate command

Change-Id: Ib97735a0239aeb9fc3a50a4bb7126dd0bcadc8af


[ROCm/clr commit: b056686607]
2023-11-15 14:38:07 -05:00
Saleel Kudchadker 153bb15f46 SWDEV-301667 - Support device kernel args for PCIE
Change-Id: I5e51602bea5a68734227fd62e11ab68eb1ad81c1


[ROCm/clr commit: 5c591b5877]
2023-11-15 14:37:41 -05:00
Jatin Chaudhary d3bcc29cd6 SWDEV-422808 - Add entries for missing hipDataType
Change-Id: I6c41f8497564e1d718a3b5bc09c45ec4b53fd25f


[ROCm/clr commit: 7e59460ba0]
2023-11-15 11:15:13 -05:00
Joseph Greathouse 79b9dedbb4 SWDEV-431560 - use XCC_ID in __smid() for gfx941 and gfx942
__smid() needs to use both HW_ID and XCC_ID for gfx940, gfx941, and
gfx942. Previously, we only did this for gfx940 and thus XCC_ID
was incorrectly not passed back on the other two architectures.

Change-Id: I9fb13b6cef3280e15463443a180174629d03f8b2


[ROCm/clr commit: a0f29b454c]
2023-11-15 10:10:47 -05:00
Jatin Chaudhary c2f944f899 SWDEV-432339 - consider HIPCC_VERBOSE output while parsing hipcc output for compiler rt
Change-Id: I146e188c4d47bede25a479933fa41e4c64ce89eb


[ROCm/clr commit: 515d07cb3a]
2023-11-15 04:01:08 -05:00
Jatin Chaudhary 2361cc0dab SWDEV-431399 - fix first set of memory leaks in clr, found in rtc tests
change constexpr variable names to match the C++ style we follow.

Change-Id: Ibc59a65d8ff2ca765da7bf5e653c0650fb3714c4


[ROCm/clr commit: ce27581465]
2023-11-14 20:39:45 -05:00
Ioannis Assiouras 803ef23320 SWDEV-432329 - Remove outdated install instructions from hipamd/rocclr subdirs
Change-Id: Ie6793e0a12689aed201d6f6278b8484d707ebdec


[ROCm/clr commit: f6e0f2613c]
2023-11-14 18:55:10 -05:00
Saleel Kudchadker f3c28c6d5c SWDEV-301667 - StreamwaitEvent may not flush caches
Change-Id: I8d648f96273b36d4930216ffa05bf1adb3c408da


[ROCm/clr commit: 514b7fc470]
2023-11-14 15:59:08 -05:00
Vikram eef9872d9b SWDEV-423946 - Make hash string to int conversion platform independent
The "long" type size seems to be platform dependent, causing hash value
overflow on implementations where "long" is 4 bytes. This addresses the
scenario.

Change-Id: I4e3c0df457e35b139dcc496d832210ba2cb849ba


[ROCm/clr commit: 1f8ead914a]
2023-11-14 12:01:44 -05:00
Tao Sang 8f417d910b SWDEV-432180 - Support hipArraySurfaceLoadStore
Make hipExternalMemoryGetMappedMipmappedArray() accept
hipArraySurfaceLoadStore.
Make hipCreateSurfaceObject() check hipArraySurfaceLoadStore
flag. If flag is hipArrayDefault, hipCreateSurfaceObject() will
also pass to prevent failure of catch2/swissknife tests.

Change-Id: Ifb7db2db14e0c2208a9661cfa33887ec61ab26a5


[ROCm/clr commit: 1c442658ca]
2023-11-14 10:17:07 -05:00
Ioannis Assiouras 8f679127a3 SWDEV-428244 - Fixed the computation of the start address of KernelParameters.values_
For avx build, the start address of values_ buffer in KernelParameters is not
correct as it is computed based on 16-byte alignment.

Change-Id: I3b28ae02d2c9c0517d4a348d95ae8c6721bec83d


[ROCm/clr commit: c4f773db0b]
2023-11-14 05:52:01 -05:00
Satyanvesh Dittakavi cf708607da SWDEV-431466 - Fix rocPRIM build failure
Do not populate AMDGPU_TARGETS when there is no device
detected by amdgpu-arch on the machine

Change-Id: I87fd7081f9e0b72f057aab2eb639808d2f89cfb1


[ROCm/clr commit: e36020f339]
2023-11-14 00:23:49 -05:00
Saleel Kudchadker be743bcd59 SWDEV-422207 - Optimize graph end detection
- Do not use extra barrier to detect graph end. If its a kernel node we
can use a completion signal for the last packet. Saves roughly 6us for
Phantom testcase per graph launch.

Change-Id: I5e0c2479d9964fbeda86ed97533f6718f49a7f91


[ROCm/clr commit: c3bd229f4f]
2023-11-10 11:57:02 -05:00
Saleel Kudchadker 85b95f0a45 SWDEV-301667 - Add error logging
Change-Id: I814399dc0e7083bb7fb0ed8bf46dd96bdf664965


[ROCm/clr commit: f06368fd04]
2023-11-10 11:55:54 -05:00
Satyanvesh Dittakavi 2119d83bfb SWDEV-430963 - Address MIGraphX failures due to unsafe buffer access usage
Compiler seem to be stricter in compiler staging builds related to
safe buffer programming when compared to other component staging builds.
This seem to result in additional errors when -Werror is enabled
in MIGraphX tests.

Removes all the clang pragmas to ignore several type of warnings in all
the headers and adds a single pragma which ignores all warnings using
#pragma clang diagnostic ignored "-Weverything" in hiprtc builtins.

Change-Id: I95f302bb285b2451b19dd5dfdb7df29164b0f750


[ROCm/clr commit: b5d286a6d3]
2023-11-09 04:39:49 -04:00
Saleel Kudchadker bd6a5c399e SWDEV-422207 - Workaround HDP register query bug
Change-Id: Ib886a3166b555fbd6b8e5a249f993f47afd00166


[ROCm/clr commit: 9fdee05aee]
2023-11-08 12:12:15 -05:00
German 32e02383ba SWDEV-430256 - Expose HIP_FORCE_DEV_KERNARG under PAL
Add support of HIP_FORCE_DEV_KERNARG under PAL.
Fix persistent memory detection for a resource view.

Change-Id: Ifb7db2db14e0c2205a9661cfa53887ec61ab26a4


[ROCm/clr commit: 5f297d75d9]
2023-11-08 10:01:22 -05:00
Jaydeep Patel 367d211aa2 SWDEV-430966 - Size to unmap should be same as mapped memory size.
Change-Id: Id59990c655e7bb4bb980efe587275296103e1e73


[ROCm/clr commit: 2415701080]
2023-11-07 23:38:06 -05:00
Jaydeep Patel 86902b4d96 SWDEV-425248 - numerous bug fixes.
Set flag with hipCtxCreate so that get flags works.
Validate hipHostGetDevicePointer for flags!=0.
Validate mem cpy kind and accommodate new type hipMemcpyDeviceToDeviceNoCU.
Match error code for hipGetChannelDesc.

Change-Id: If09a635ac01bc53f1fe2b7df3f3f9c1b0d69a0ab


[ROCm/clr commit: 8e8fb993de]
2023-11-07 22:49:20 -05:00
Saleel Kudchadker 19ea94729c SWDEV-422207 - Report TS for Accumulate command
Change-Id: Iba193a6068c1a2d25c2136643faee2c1e2591a07


[ROCm/clr commit: f5c6fc4dfa]
2023-11-07 18:19:40 +00:00
Jatin Chaudhary 85cfa10a3f SWDEV-367537 - fix style inconsistencies seen in some operators
Change-Id: Ib94a26b931b2aa0237335f07f8557a4830c80f23


[ROCm/clr commit: 794ca0522f]
2023-11-07 10:37:02 -05:00
Alex Xie 4c860f41fd SWDEV-430062 - Support GPU_MAX_HEAP_SIZE flag in ROCm
Change-Id: Ibfe82b3524e09c61879b988f23512f394d725024


[ROCm/clr commit: 4fb9f03f9e]
2023-11-07 10:07:24 -05:00
Ioannis Assiouras 9d1a39bba2 SWDEV-430116 - Fix segfault in Heap::EraseAllocaton
Change-Id: I8c49af081079307118562485cb0d5b3e8a9d906a


[ROCm/clr commit: bc2a4f8450]
2023-11-07 09:49:35 -05:00