Satyanvesh Dittakavi
522ae8ead4
SWDEV-483241 - Add a compile option to avoid including default hiprtc header
...
Change-Id: Ic23b41395588e6183abac36cb7543da02b0aba29
2024-10-07 07:56:29 -04:00
Saleel Kudchadker
e36666e536
SWDEV-301667 - Enable ROCr logging
...
- Use AMD_LOG_LEVEL=5 to dump AQL packets in ROCr
Change-Id: I2c044a5304c4eaf3d3af20e62d1f54c98d4fbaa4
2024-10-04 19:22:12 -04:00
Saleel Kudchadker
d3d0ca5fc6
SWDEV-478065 - Revert "SWDEV-478065 - Embed host thread in shared_ptr"
...
This reverts commit 4b03017e8a .
Reason for revert: This blocks multithreaded callbacks
Change-Id: I9944417e4fb63c9eea2b286c828c7dfa621c4fe8
2024-10-04 19:19:28 -04:00
Branislav Brzak
d29ebea7ac
SWDEV-476542 - Unable to link to hipGraphExecGetFlags
...
Change-Id: I572baaeee31c6a73e533f9ef956bf111e9d2e688
2024-10-04 13:39:06 -04:00
Saleel Kudchadker
35e03ea0d0
SWDEV-301667 - Logging upgrades
...
- Use AMD_LOG_LEVEL_SIZE in MBs to set log file size truncation, by default its 2048 MB
Change-Id: Ia2f87e8c6b94148e30edfb602b279f93630817c3
2024-10-04 13:26:25 -04:00
Jaydeep Patel
292842ad28
SWDEV-471422 - Free memory being double deducted on APUs due to system_total_alloced var holds local memory.
...
Change-Id: I3fbbc8f8aaa156881ff95cad6a4f82fd3df651d1
2024-10-04 04:49:20 -04:00
pghafari
b07178618c
SWDEV-467263 - Allow hipMalloc to use sys memory
...
PAL supports allocating from system memory once device memory is used up
or allocation is larger than the device memory.
Change-Id: Iccd3377e95a6cc6d23e45d4738a17af8b9ee32d7
2024-10-03 11:14:08 -04:00
Ioannis Assiouras
07bcc283f9
SWDEV-488851 - Correctly remove the queue from the active set on windows
...
Change-Id: I4d21743ecf7a44636121f85566f898e62ff61e97
2024-10-02 12:06:59 +01:00
Satyanvesh Dittakavi
ade1954015
SWDEV-478708 - Remove forced wait of 10us in hipEventQuery
...
Change-Id: I868aae14311c3cdfc09aa03252ac324c4b79b864
2024-10-01 06:27:42 -04:00
Rahul Manocha
9da90fe848
SWDEV-487903 - Fix for Empty Kernel Segfault in PAL
...
Change-Id: Ia1c19cf4ea24188cdb2d374b07f975f794e02dba
2024-09-30 13:00:15 -04:00
Jaydeep Patel
614b00c20b
SWDEV-487905 - Managed vars are registered in __hipRegisterManagedVar however not freed.
...
Change-Id: Ic5a72ac4d64a9f7f5a3a7a88e1ed813e6dcc1f57
2024-09-30 11:54:31 -04:00
Julia Jiang
17c8b9f855
SWDEV-412099 - Fix CTS clFillImage sub-tests failures
...
Change-Id: I082476837c539e6ccf93cba6b1e97aae2509e65c
2024-09-30 11:13:52 -04:00
Branislav Brzak
939c788779
SWDEV-478034 - Unable to link to hipGraphExecNodeSetParams
...
Change-Id: I0b6b8d1a4281ecda3c1789d8829ade9771aed741
2024-09-30 02:13:43 -04:00
Anusha GodavarthySurya
742b0210d3
SWDEV-477324 - Capture Memcpy1D pinned H2D D2H
...
Change-Id: I1f4744f20a9caeed005ec68da44e5fde737e09f7
2024-09-30 01:01:30 -04:00
Vladana Stojiljkovic
da5f1a6146
SWDEV-482086 - Fix hipGraphInstantiate leak
...
* In a scenario where kernel is launched with hipExtLaunchKernelGGL and stop event is used, hipGraphInstantiate leaks. Since stop event is used, profiling is enabled and Timestamp (ReferencedCountedObject) is created, but it doesn't get released.
* The idea behind this solution is that profiling should be disabled when command is captured, hence the timestamp should not be created. Because information about capturing isn't available when kernel command is created, packet capturing state is used to determine whether to create a timestamp or not.
Change-Id: Ia23adac4592ded4fb5e236acf99e12e729f63692
2024-09-29 11:36:53 -04:00
Jaydeep Patel
d6193a2f23
SWDEV-483436 - User spt stream as def with -fgpu-default-stream=per-thread for hipMemsetAsync.
...
Change-Id: Ia85c2b4c40fc9250754d3b64fb9fd1c615362572
2024-09-29 01:42:33 -04:00
Rahul Manocha
0d20383ef9
[SWDEV-467733] - Add Param checking for SetCacheConfig APIs
...
Change-Id: I9e777fa0fae6791ebab539e49346e6956a6ff196
2024-09-27 11:32:58 -04:00
Jonathan R. Madsen
07c9c7fe56
Fix HIP API trace versioning
...
Change-Id: I33f2be4668c96e2225d4ca9a253e61ec2dc65102
2024-09-25 10:32:14 -04:00
Ajay
7a288ea8bf
SWDEV-486816 - RenderOpDispatch usage in pal client
...
Change-Id: I11cae3e625b287b998c9500c547efdacf1034a2b
2024-09-24 14:28:16 -04:00
pghafari
0a918c8f96
SWDEV-479260,SWDEV-483599 - Check griddim Y,Z <= 65536
...
Gfx12 has 16 bits for grid dim Y/Z. Detect gfxIp and return error if dim y/z > 16 bits
Change-Id: I43dd14affc9e4073d0b1232e7523967f0180fa31
2024-09-23 11:36:13 -04:00
Jatin Chaudhary
f8beeede22
SWDEV-466747 - call device sync once while unregistering
...
Basically embed hipDeviceSync in std::call_once.
Change-Id: I29ca926d61ed80e21acba5c388a8256d913487e4
2024-09-23 08:00:10 -04:00
German Andryeyev
29cc678d8d
SWDEV-483586 - Unblock staging H2D transfers
...
Although unpinned copies require synchronizations
in HIP, runtime can avoid syncs for H2D copies with
a staging buffer
Change-Id: If2203c6bc0cbd89742823688dc8e89e9acd873b2
2024-09-21 10:25:27 -04:00
Maneesh Gupta
2d1c6ee23e
SWDEV-485179 - Revert "SWDEV-459254 - Overwrite cacheline size to 256 for gfx12, as it is used for kernarg alignment."
...
This reverts commit 1f63650bf96e01e48f879aa58b80e2130dd4a567.
Reason for revert: <INSERT REASONING HERE>
Change-Id: I6d7ed87c09d9b77116548dce1f30ac4711c2c09d
2024-09-20 11:33:34 -04:00
Anusha GodavarthySurya
870842201d
SWDEV-485904 - Fix virtual,physical mem obj leaks
...
Change-Id: Ie0456b5dcfec206ae54a6aabfc2a15a620cac693
2024-09-19 23:04:20 -04:00
Saleel Kudchadker
8c84a20b01
SWDEV-301667 - Improve logging
...
Change-Id: I3fa06791b7ac73d84b8a9586e6b3435fa8858d25
2024-09-19 15:09:03 -04:00
kjayapra-amd
12a39fbf22
SWDEV-480772 - Remove name variable from amd::Monitor class.
...
Change-Id: Ie2a4fa44f485786227230f8a892e090e718aa30e
2024-09-19 11:55:01 -04:00
Marko Arandjelovic
cfdc9dfc36
Revert "SWDEV-441296 - Allign hipTexObjectCreate error handling to CUDA"
...
This reverts commit 7d3c0c5e10 .
Changing the error code is considered as a breaking change,
so it should be done in major releases only.
The other reason for reverting the commit is that this change itself
is incorrect. Cuda behaves in the same way as hip when
pResDesc or pTexDesc are nullptr.
Change-Id: I3abee6b79279b81ab01c7f8466c7f8e3776c4109
2024-09-18 16:38:16 -04:00
Rahul Manocha
4d1ded9eaf
SWDEV-479575 - Add marker to parent graph dependencies in childgraph node
...
1) Child Graph nodes need to have parent graph dependencies in waitlist.
2) Marker is placed on base stream with parent graph waitlist
Change-Id: Iec65a0171ea387be05b0733abcc708fb630e4be4
2024-09-18 15:12:50 -04:00
pghafari
365ffd4805
SWDEV-444447 - Fix regression for verbose printing for AMD_LOG_LEVEL=4
...
Change-Id: Id245caef711b7ccdf4e999e934993beb43d7c3d5
2024-09-18 13:08:10 -04:00
Rahul Manocha
07261002b1
SWDEV-439234 - Fix for Segfault in ValidateMemAccess
...
Change-Id: I251d277eb5af16ba5c0de85ffd142a5f64fa469d
2024-09-18 10:52:32 -04:00
Daniel Livingston
e550032d25
SWDEV-77148 - Add UberTrace support to PAL device
...
This PR adds UberTrace-based tracing support to ROCclr's PAL device class.
Legacy RGP-based tracing is still available and is the default.
If UberTrace support is enabled tool-side, this new code path will activate.
Change-Id: I268b2dcef70e850a50e2caef8355f38bf51d4641
2024-09-17 16:06:37 -04:00
Satyanvesh Dittakavi
8ee065c5bd
SWDEV-478776 - Fix segfault with streamsync using hipStreamLegacy
...
Change-Id: Ifb412d0bcfa33bc1130b47b757ee276ca9bc1c3a
2024-09-17 15:02:18 -04:00
Jatin Chaudhary
4b03017e8a
SWDEV-478065 - Embed host thread in shared_ptr
...
This shows up in some valgrind runs. Make sure the resources are
released.
Change-Id: I34c25c00370a221585895655744831215136d5f4
2024-09-17 09:53:51 -04:00
Jaydeep Patel
2494992695
SWDEV-478049 - Clear packets list as it is being added back later during submitKernelInternal while setting params for graph node.
...
Change-Id: I7451ffda93d94eeda5e1be05bb87558ae86d2a19
2024-09-16 23:10:32 -04:00
Ioannis Assiouras
bcc545e6b8
SWDEV-476929 - Introduce an activeQueues set
...
The new set tracks only the queues that have a command
submitted to them. This allows for fast iteration
in waitActiveStreams.
Change-Id: I2c832eefa01280d9a87a5f57874d36d2e9441de7
2024-09-16 15:53:49 -04:00
kjayapra-amd
d81c5d3d7f
SWDEV-484188 - Change few std::array style globals to C style to avoid optimization on Static Libs.
...
Change-Id: Iab6d3c040b8d088013daa08093898be99dd3a971
2024-09-16 09:46:56 -04:00
kjayapra-amd
4ecd77df5e
SWDEV-484188 - Moving std::maps into struct const and into amd::Kernel class.
...
Change-Id: Ie4d5a64511412fdb498b045aaffb52c3a1286de6
2024-09-15 09:14:51 -04:00
Ranjith Ramakrishnan
4d0b815d06
SWDEV-437189 - Provide option to enable/disable CPACK_SET_DESTDIR
...
The variable is already set as cache, so that user can override.
But the hard coded setting is preventing override. Removed the same
Change-Id: I2aecc18ce4f1d1b523ba267ef1c8ef4ea1168d9c
2024-09-13 15:49:53 -04:00
Rahul Manocha
eb1089593e
SWDEV-480536 - Disable cpu wait in device synchronize
...
1) currently cpu wait is set to true, which makes the host wait for last
command in queue to finish even if the kernel execution has already
finished causing delay in device sync call.
2) device sync only needs to await completion when hw event
is not ready.
Change-Id: I91e3e89d39a1193ae06abac822cea8ae651493a5
2024-09-13 15:31:32 -04:00
Ajay
c9955a1cea
SWDEV-465215 - hipFuncSetAttribute hipFuncGetAttributes fixes
...
Change-Id: I2151e4470d63918ff6b809a8fdeaae5bea5cc899
2024-09-13 14:05:25 -04:00
Saleel Kudchadker
9de6d4d46c
SWDEV-478624 - Use readback workaround to ensure kernel arg coherence
...
Use env var DEBUG_CLR_KERNARG_HDP_FLUSH_WA=1 to fall back to HDP flush
workaround. The default is 0
Change-Id: I7bdb9be61da60c30d15ac9991b7cd27351e1831c
2024-09-11 14:53:15 -04:00
Ajay
5a810f789a
SWDEV-471863 - avoid copy of invisibleHeap
...
Change-Id: Ieb0aa22ac6d0d01cb9ca7fbf1305df03a1ab3cdf
2024-09-11 13:24:31 -04:00
Jaydeep Patel
9c90bc43a5
SWDEV-475938 - Update dynamic stack in submit kernel internal.
...
Change-Id: I816bf9cfe8aaac5486ff3b719dbdc4f4d6134e01
2024-09-11 00:59:45 -04:00
Chong Li
e6a5c81221
SWDEV-478929 - Benchmark ReallyQuickPureX Failed
...
Ensure the member function Alloc() and Free() of command_pool_ will not be
accessed after command_pool_ be destructed.
Signed-off-by: Chong Li <chongli2@amd.com >
Change-Id: Ic2d36423302518a030bd61fa399290ebe2ed8194
2024-09-10 22:08:18 -04:00
Saleel Kudchadker
abc80fcc2f
SWDEV-301667 - Improve kernel logging
...
Change-Id: I4b2b1950e3ab7124fd41af9a92a677c48d6da5eb
2024-09-10 13:43:58 -04:00
Saleel Kudchadker
62a7fed90d
SWDEV-481974 - Clear dependent signal bit for barrier value
...
Change-Id: I3ffda051fa8538970fbb1964beb1f538fce0782c
2024-09-10 13:43:04 -04:00
Ioannis Assiouras
0b8bc6682f
SWDEV-482553 - Removed setting of BUILD_SHARED_LIBS from hip-config.cmake
...
Change-Id: I84eb33939d47dde1dd389741c431ee0e5955973b
2024-09-09 13:27:53 +01:00
kjayapra-amd
6211037f63
SWDEV-439234 - Access check before memcpy and kernel operations.
...
Change-Id: I7057125c03460db205409e19980145298c190fe2
2024-09-06 14:30:00 -04:00
Julia Jiang
bb03ef11a3
SWDEV481762 - Updated definition of 'DEPRECATED' in header file
...
Change-Id: I88986b8e1815f3d816595f3eb2da8a6c1c1c2993
Jenifer helped make a combined PSDB build, together with the change in hip repos
https://gerrit-git.amd.com/c/compute/ec/hip/+/1114046
Combined PSDB verification passed.
http://rocm-ci.amd.com/job/compute-psdb-staging-hip/17293/
2024-09-05 15:41:04 -04:00
victzhan
8be00b6602
SWDEV-477218 - Implement hipDeviceGetTexture1DLinearMaxWidth
...
Change-Id: I8103f710abeb869f5f84be61c57a30b24356def6
2024-09-05 15:09:38 -04:00