Commit Graph

1162 Commits

Author SHA1 Message Date
Tao Sang eb5fed63c1 Temporarily comment out Hcc-specific APIs for CLang compiler
Temporarily comment out Hcc-specific template functions
hipExtLaunchKernelGGL and hipOccupancyMaxPotentialBlockSize for CLang
compiler so that all test cases under hip/samples can be built
successfully for Clang + Hip/Hcc runtime.

Change-Id: Iafc761257be4a7b34eafa6759a01f369570cd6ce


[ROCm/hip commit: b3f445c0f5]
2020-02-16 22:26:47 -05:00
Maneesh Gupta 7753b3e827 Revert "Match Occupancy APIs syntax with CUDA (#1625)" (#1857)
Reverting this for now till we figure out how to avoid the build
breakage.

This reverts commit e38db9fb6f.

[ROCm/hip commit: f8e1c01900]
2020-02-10 10:45:28 +05:30
Alex Voicu 5d5344eea1 (Maybe) Match alignment between Clang and GCC. (#1789)
Should fix #1740 and the related internal bug.

[ROCm/hip commit: dd34ea95d6]
2020-02-10 10:44:49 +05:30
vsytch e5243c1834 Device texture functions should not normalize the sampled pixel (#1826)
* Device texture functions should not normalize the sampled pixel. This is already done by HW.
* Add support to use h/w capability for normalized float data convertion for driver API's

Co-authored-by: ansurya <50609411+ansurya@users.noreply.github.com>


[ROCm/hip commit: ef514eef71]
2020-02-05 20:56:17 +05:30
satyanveshd e38db9fb6f Match Occupancy APIs syntax with CUDA (#1625)
* Match Occupancy APIs syntax with CUDA and fix tests using these APIs


[ROCm/hip commit: fa98798b63]
2020-01-29 13:05:53 -08:00
vsytch 1af35a6044 Add missing texturePitchAlignment member to the hipDeviceProp_t struct. (#1802)
* Add missing texturePitchAlignment member to the hipDeviceProp_t struct.

* Add missing hipDeviceAttributeTexturePitchAlignment enumerator to the hipDeviceAttribute_t enum.

* Initialize texturePitchAlignment to 256. This works for gfx9+, but is technically overaligned in most cases for pre-gfx9.

* Add the texturePitchAlignment property to the NVCC path.


[ROCm/hip commit: f72a669487]
2020-01-27 16:37:00 -08:00
vsytch 95ee059bbb Update the HIP_TRSF_* flags to match their Cuda equivalents. (#1801)
[ROCm/hip commit: 9cfada0f9d]
2020-01-24 11:41:15 -08:00
mshivama c630cb57b2 SWDEV-220503: this_grid().thread_rank() gives incorrect result (#1808)
* fix a minor bug while computing this.grid()::thread_rank()

[ROCm/hip commit: bed8f1c1b8]
2020-01-24 16:23:28 +05:30
kpyzhov dabbde21c6 Don't use accelerated vector element access for hip-clang. (#1796)
[ROCm/hip commit: 566adc4594]
2020-01-15 18:17:08 -08:00
kpyzhov 4c457c2bb5 Add missing constructors for Scalar_accessor class. (#1792)
[ROCm/hip commit: fae85cf6d2]
2020-01-14 11:30:21 -08:00
Evgeny Mankov 3d22f829f5 [HIP] Unify hipError_t (Step 3): Sync nvcc path (#1778)
* [HIP] Unify hipError_t (Step 3): Sync nvcc path

* [HIP][fix] Add CUDA 10.x support to nvcc path


[ROCm/hip commit: a005a8550d]
2020-01-10 13:47:18 +05:30
Maneesh Gupta 6ebf5ca991 Revert PRs that break ROCm builds (#1781)
Fixes SWDEV-218626 and SWDEV-218629

Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692)"
   This reverts commit b7803eb0c6.
- Revert "Fix rocFFT build failure (#1777)"
   This reverts commit 9c8c3df294.

[ROCm/hip commit: 00bd5d1cec]
2020-01-08 15:11:58 +05:30
ansurya 9c8c3df294 Fix rocFFT build failure (#1777)
Fixes SWDEV-217761

[ROCm/hip commit: 753277422a]
2020-01-07 08:12:37 +05:30
Rahul Garg 327a45b18b Add hipBindTexture2D on NVCC path (#1773)
[ROCm/hip commit: a5d7e7d8d3]
2020-01-06 12:33:50 +05:30
Rahul Garg 86dbb13897 Fix hipcc warning related to hipVersion (#1767)
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.

[ROCm/hip commit: f3cafd5855]
2020-01-06 12:33:23 +05:30
Evgeny Mankov 6ac4d18753 Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/hip commit: 0dadb23327]
2019-12-30 19:21:09 +03:00
Sarbojit2019 6d2ec032fe Change to generate hipVersion.h (#1726)
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.

[ROCm/hip commit: aa4aea0754]
2019-12-30 12:44:24 +05:30
Aryan Salmanpour ffea90f865 [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.

[ROCm/hip commit: 6968aeb841]
2019-12-30 12:42:17 +05:30
Evgeny Mankov abef353b5b [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/hip commit: 4921678b6c]
2019-12-23 17:01:35 +03:00
Yaxun (Sam) Liu d10837db9d Add macro __HIP_ENABLE_CUDA_WRAPPER_FOR_OPENMP__ (#1761)
This is to allow force enable cuda wrapper for OpenMP for flexibility

[ROCm/hip commit: 3c90d57072]
2019-12-23 19:24:54 +05:30
saleelk bb7fa73dcc Fix the return type of demangle function so that its compatible across ABIs (#1744)
[ROCm/hip commit: 080b0b9a68]
2019-12-23 19:11:40 +05:30
Alex Voicu 1f5ecc0f6a Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/hip commit: 75a11330aa]
2019-12-23 19:11:24 +05:30
Maneesh Gupta 91f82210fb replace array designator C99 (#1694)
* replace array designator C99

* Update texture_functions.h

Highlight valid and invalid values in texFormatToSize

Co-authored-by: Maneesh Gupta <maneesh.gupta@amd.com>


[ROCm/hip commit: 7d6634ce9d]
2019-12-23 19:10:24 +05:30
Alex Voicu b7803eb0c6 static inline in a header, just like excess sugar in a diet, causes bloat (#1692)
[ROCm/hip commit: be70b9f7e7]
2019-12-23 19:09:38 +05:30
Evgeny Mankov 97535f3e97 [HIP] Fix typo
[ROCm/hip commit: 9544682e2c]
2019-12-23 12:06:44 +03:00
Evgeny Mankov 30ae3942dc [HIP] Unify hipError_t (Step 2)
Step 2. Make a few hipError codes deprecated
Update hipify-clang, hipify-perl, docs and samples accordingly


[ROCm/hip commit: dbad4d9b7f]
2019-12-22 02:05:31 +03:00
Maneesh Gupta ddc169cf4e Update texture_functions.h
Highlight valid and invalid values in texFormatToSize

[ROCm/hip commit: d92169c05a]
2019-12-21 12:25:36 +05:30
Sarbojit2019 ef3ee5908f Fix for windows dtest build failure (#1742)
[ROCm/hip commit: e2fc00da65]
2019-12-19 13:10:43 -08:00
mhbliao ded857e2b9 [hip] Add macro guarding the enum conversion for scalar accessor. (#1748)
- That's a high overhead part, which needs enabling ONLY if necessary.

[ROCm/hip commit: 99a3b66110]
2019-12-19 10:08:37 -08:00
Evgeny Mankov ca99107c7b [HIP] Unify hipError_t (Step 1)
Step 1. Set the same values for RT error codes as for analogous Driver's

[Reason] RT's and Driver's error codes unification in CUDA 10.2


[ROCm/hip commit: d8737ba50c]
2019-12-13 19:40:16 +03:00
mhbliao e1f55b0cee Only add hipExtLaunchMultiKernelMultiDevice for non-HCC compilers. (#1729)
[ROCm/hip commit: 444c931641]
2019-12-10 10:32:25 -08:00
jglaser 65f80f80a1 fix linking of vector types with gcc (#1690)
* fix linking of vector types when linking hipcc objects with gcc

* use __atribute__((vector_size)) with both clang and gcc

and reinstate nonaligned n=3 vector type

* use implicit conversion to value and ext_vector_type when available

* Alternate formulation for GCC compatibility

* Built-in arrays don't mix well with placement new

* Fix typo

* Add conversions to enum

* Fix Scalar_accessor assignment.

* Update hip_vector_types.h

* stir up the underlying_type hideous mess

This fixes the HIP build issue "error: only enumeration types have underlying types".


[ROCm/hip commit: 00d735cdc9]
2019-12-10 09:40:15 +05:30
mhbliao 7703031d33 Fix hipExtLaunchMultiKernelMultiDevice refactoring. (#1714)
- Use the correct condition for HIP VDI runtime.

[ROCm/hip commit: e9da934ac6]
2019-12-06 09:49:17 -08:00
Rahul Garg ebdd811632 Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.

[ROCm/hip commit: e53fc316f1]
2019-12-06 09:51:53 +05:30
Aryan Salmanpour abe7531676 [hip] refactoring hipExtLaunchMultiKernelMultiDevice API (#1698)
[Background] it was found that if lazy linking used for a library that calls hipExtLaunchMultiKernelMultiDevice API then this API can get the wrong program_state object for looking up device kernels leading to a "No device code available" error in this API.

To fix this issue, the API was refactored to be inline and get and pass the correct program_state to an internal hip API to request a multi-device kernel launch.

[ROCm/hip commit: 68cc787781]
2019-12-04 11:50:51 +05:30
Maneesh Gupta 4e564f783e Revert changes for atomic FADD support when address is in LDS (#1701)
This reverts PR #1591 and follow-on PR #1695

[ROCm/hip commit: 32442c6506]
2019-11-29 11:58:12 +05:30
Alex Voicu dc9bc8ee86 Uniform is_shared query. (#1695)
[ROCm/hip commit: b6514fffb9]
2019-11-28 13:39:05 +05:30
Anusha Godavarthy Surya 023ee64ecf replace array designator C99
[ROCm/hip commit: edf29b8673]
2019-11-25 16:51:49 +05:30
Alex Voicu f220a7592e Unary operators were too restrictive in the type of their argument. (#1683)
[ROCm/hip commit: aaf31b6b96]
2019-11-22 07:54:53 +05:30
ansurya 92837d4b4d Fix rocBLAS compilation failure (#1677)
SWDEV-212749:
o Recent changes to “add support for extended launch” require hip_runtime.h to be include in hip_ext.h
o Order in which external applications include hip_hcc.h/hip_runtime.h causes compilation failure

[ROCm/hip commit: e60dec51da]
2019-11-22 07:54:17 +05:30
Alex Voicu fd08d068c7 Use native support for atomic FADD when address is in LDS (#1591)
[ROCm/hip commit: d597e7ca20]
2019-11-22 07:53:48 +05:30
satyanveshd 3848cd97ea fixed directed tests fail when hcc bumped to 3.0 (#1678)
Handled the HCC version check appropriately as few of the directed tests (SWDEV-212161) were failing when hcc was bumped to 3.0.

[ROCm/hip commit: 6b06911ef1]
2019-11-20 21:37:52 +05:30
Alex Voicu 1baa84eae4 General sync memcpy improvements. Add hipMemcpyWithStream (#1673)
* General sync memcpy improvements. Add `hipMemcpyWithStream`

* Update hip_memory.cpp


[ROCm/hip commit: 5a1f823739]
2019-11-20 21:36:37 +05:30
Rahul Garg 7e75cf12df Update error codes for hipGetDevice for doxygen and move up null check (#1668)
* [docs] Update error codes for hipGetDevice

* Move up out ptr check


[ROCm/hip commit: b3161e9fa0]
2019-11-20 21:35:27 +05:30
Paul Fultz II 27112bbdf0 Fix helper header when using c++17 (#1666)
This will fix issue #1621. It also adds tests for is_callable with c++11, c++14, and c++17.

The fallback implementation was completely broken so I rewrote it so it pass the tests as well. This should be used instead of PR #1631.

[ROCm/hip commit: 8519a1411c]
2019-11-20 21:33:42 +05:30
Alex Voicu 4ec70a7e03 Extend vector type capabilities and add tests to reflect it. (#1656)
[ROCm/hip commit: b5b3d1bbaa]
2019-11-20 21:32:32 +05:30
mhbliao 97646b52f1 Fix mathlib and app builds with hip-clang. (#1665)
[ROCm/hip commit: ebe0c56f4f]
2019-11-18 08:18:20 -08:00
Rahul Garg ecdba45d29 Fix gcc build on NVCC path (#1661)
* Fix gcc build on NVCC path

* Fix CI build errors

* [dtest] Fix texture and surface obj2D tests


[ROCm/hip commit: e39d7497ec]
2019-11-18 12:19:22 +05:30
Nick Curtis 05ef9bd386 fix complex conjugate for double-complex (#1659)
The sign in the y component returned from hipConj incorrect for double-complex. Fix to match as in hipConjf above.

[ROCm/hip commit: 3f2316086f]
2019-11-18 12:19:12 +05:30
Sarbojit2019 a4f2c7717f Added null check in hipEventSynchronize (#1627)
* Added missing null check in hipEventSynchronize
* Minor correction in the Event API description


[ROCm/hip commit: b865a50e44]
2019-11-18 12:18:55 +05:30