Commit graph

2795 Commits

Autor SHA1 Nachricht Datum
Yaxun Sam Liu 69bbf45b44 Fix declaration conflict when hip/math_functions.h is included first
This fixes build failure in TensorFlow 1.8 for HCC
2018-08-07 15:44:59 -04:00
Maneesh Gupta ac18a3b701 Merge pull request #588 from Jorghi12/patch-10
Fixing a HIP bug that causes DEBUG symbols to be dropped.
2018-08-03 08:48:56 +05:30
Maneesh Gupta b485957858 Merge pull request #603 from b-sumner/master
Drop use of NVCC_COMPAT since it is always set
2018-08-03 08:45:18 +05:30
Maneesh Gupta ad44a77ed4 Merge pull request #601 from sarunyap/fix-shareWithAll-mem-dev-mapping
Remove device mapping from shareWithAll memory
2018-08-03 08:45:04 +05:30
Maneesh Gupta 0354367a07 Merge pull request #610 from aaronenyeshi/enable-hcc-module-launch
Enable hipHccModuleLaunchKernel on HIP-Clang
2018-08-02 08:08:46 +05:30
Maneesh Gupta 4544e681ac Merge pull request #600 from ROCm-Developer-Tools/enable-texture-functions
Enable HIP texture functions with HIP vector types
2018-08-02 08:01:00 +05:30
Maneesh Gupta 1692af19cc Merge pull request #593 from mangupta/patch2-removerdynamic
[FindHIP] Remove rdynamic from CMAKE_SHARED_LIBRARY_LINK_HIP_FLAGS
2018-08-02 07:58:34 +05:30
Maneesh Gupta 2960739c43 Merge pull request #514 from luckynikki/GETandALGN
[GETandALGN]: Get channel and alignment details
2018-08-02 07:57:50 +05:30
Evgeny Mankov a244ddd659 Merge pull request #612 from emankov/docs
[HIPIFY][docs] Formatting
2018-08-01 17:30:35 +03:00
Evgeny Mankov 55ee734b22 [HIPIFY][docs] Formatting 2018-08-01 17:29:00 +03:00
Evgeny Mankov 58d9df900c Merge pull request #609 from emankov/master
[HIPIFY][FFT] Add cuFFT support
2018-08-01 17:11:19 +03:00
lthakur b7a4b2c300 Added offset value verification.
Added offset value verification.
2018-08-01 10:41:30 +05:30
Aaron Enye Shi 0ad36dfa58 Enable hipHccModuleLaunchKernel on HIP-Clang 2018-07-31 20:38:20 +00:00
Evgeny Mankov c57bfd50e3 [HIPIFY][FFT] Add cuFFT support
+ Add API_FFT support (data types and functions)
+ Add CUFFT_API_supported_by_HIP.md
+ Add simple_cufft.cu test
+ Update README.md
2018-07-31 22:25:48 +03:00
Aaron Enye Shi e42af991d1 Protect macro TYPEDEF_VECTOR_VALUE_TYPE and prefix __hip_ for vector_value_types 2018-07-30 20:41:24 +00:00
Aaron Enye Shi ff1e49d191 Ensure correct vector value type used in texture
Implement the vector value types in terms of SCALAR_TYPE##SIZE_vector_value_type for float, int, uint and sizes 2, 3, 4, 8, and 16.
2018-07-30 19:43:12 +00:00
Sarunya Pumma 84aadb9274 Remove device mapping from shareWithAll memory
When shareWithAll memory (e.g., host memory) is allocated, set appId
in hc::AmPointerInfo to -1 to indicate that this memory is not mapped
to any device.  Peer checking in ihipStream_t::canSeeMemory is not
necessary if memory is shared with all devices.  Thus, it is skipped.

Note that earlier host memory is always mapped to device 0 and HIP
always performs peer checking for all kinds of hipMemcpy.  Since the
peer checking process requires context locking, hipMemcpy from/to host
memory always grabs device 0's context lock.  Therefore, if there is
another thread holding the context lock of device 0 (e.g.,
hipDeviceSynchronize on device 0), hipMemcpy will have to wait for the
lock until it can actually perform memcpy.  This can significantly
deteriorate execution performance.

Signed-off-by: Sarunya Pumma <sarunya.pumma@amd.com>
2018-07-28 23:15:16 -07:00
Evgeny Mankov f2e1b9d220 Merge pull request #607 from emankov/hipBLAS
[HIPIFY][BLAS] cuBLAS support revise
2018-07-28 21:11:03 +03:00
Evgeny Mankov e00cfefd4f [HIPIFY][BLAS] cuBLAS support revise
+ doc for CUBLAS API supported by HIP
+ 3 tests: 0 & 1 based indexing, sgemm matmul
2018-07-28 21:00:44 +03:00
Brian Sumner 8d80abb30f Drop use of NVCC_COMPAT since it is always set 2018-07-27 09:29:29 -07:00
Maneesh Gupta 17f612def1 Merge pull request #596 from mangupta/patch5-fixhiplaunchparm
[tests] Fixed hipLaunchParm test on nvcc path
2018-07-26 06:17:50 +05:30
Maneesh Gupta 86188f04c8 Merge pull request #595 from mangupta/patch4-fixhipStdComplex
[tests] Fixed build & disabled run of hipStdComplex on nvcc path
2018-07-26 06:17:04 +05:30
Maneesh Gupta ec6995485c Merge pull request #592 from mangupta/patch1-initialize-cudapath
[hipcc] Initialize CUDA_PATH before printing
2018-07-26 06:16:31 +05:30
Maneesh Gupta ddcb85a77b Merge pull request #590 from ROCm-Developer-Tools/fix-ballot-anyall-return
Fix return EXIT_FAILURE if ballot or anyall fails
2018-07-26 06:16:23 +05:30
Aaron Enye Shi bf6fdca1e8 Enable HIP texture functions with HIP vector types
Include texture_functions.h on HIP-Clang path. Use HIP vector types instead of hc::short_vectors for texture_functions, and remove HCC headers.
2018-07-25 19:52:19 +00:00
Maneesh Gupta 51307ac705 [tests] Fixed hipLaunchParm test on nvcc path
- Uses c++11 features. Added it to nvcc options
- Arguments for some kernels exceeded 4096 bytes which is the limit
  imposed by nvcc. Reduced BLOCK_DIM_SIZE to 512 to handle this
- Fixed compilation issues on nvcc path

Change-Id: I14f6b28afcb7c6b24a085fd707b2104e2ed64627
2018-07-25 15:41:04 +05:30
Maneesh Gupta 843020bfe6 [tests] Fixed build & disabled run of hipStdComplex on nvcc path
Change-Id: I885e96902faa065f6559183f33b6a7aa1f37e393
2018-07-25 15:39:45 +05:30
Maneesh Gupta 7a5987e289 [FindHIP] Remove rdynamic from CMAKE_SHARED_LIBRARY_LINK_HIP_FLAGS
CMAKE_SHARED_LIBRARY_LINK_CXX_FLAGS contains -rdynamic which does not go
well with nvcc

Change-Id: I10e6d21553de0e43c6a7ae5fb3ec2418087959ff
2018-07-25 15:32:14 +05:30
Maneesh Gupta 2027675b3f [hipcc] Initialize CUDA_PATH before printing
Change-Id: Ifd448b628fa4a7055f4a439ed2c817c5f11f9bef
2018-07-25 15:29:57 +05:30
Maneesh Gupta 8c195a3588 Merge pull request #589 from gargrahul/set_offset_gettexalignoffset
Set offset in hipGetTextureAlignmentOffset
2018-07-25 12:13:31 +05:30
Aaron Enye Shi 8ab8a37812 Fix return EXIT_FAILURE if ballot or anyall fails 2018-07-24 20:39:48 +00:00
Rahul Garg f17c897751 Null check before setting offset 2018-07-24 12:25:40 +05:30
Rahul Garg 0ec64e8b24 Set offset in hipGetTextureAlignmentOffset 2018-07-24 10:11:26 +05:30
Maneesh Gupta cab5e80b22 Merge pull request #582 from ROCm-Developer-Tools/set-vdi-path
Let hipcc use proper include and lib path for HIP/VDI
2018-07-24 07:32:54 +05:30
Maneesh Gupta bb02937dd5 Merge pull request #580 from ROCm-Developer-Tools/document-fatbin
Document hip-clang fatbinary format and initialization function
2018-07-24 07:31:19 +05:30
Maneesh Gupta 25ba9f6f94 Fix typo 2018-07-24 07:30:05 +05:30
Jorghi12 25c780c89e Fixing a HIP bug that causes DEBUG symbols to be dropped.
I've noticed that in the generated makefiles, we'd have 

if(NOT build_configuration)
    set(build_configuration Debug)
endif()

However, only definitions with all capitals are provided. 

e.g.

set(HIP_HCC_FLAGS_DEBUG -g)

This is because of lines 442 to 448. We capitalize the configuration ${config_upper}.

This PR fixes this bug.
2018-07-23 18:16:00 -04:00
Yaxun Sam Liu 555c2f9c08 Fix warnings about unused command line option --hip-link
and set search path for libhip_hcc.so
2018-07-23 14:55:07 -04:00
Yaxun Sam Liu 674b45902d Document hip-clang fatbinary format and initialization function
This is for documenting the change in hip-clang: https://reviews.llvm.org/D49083
2018-07-23 09:28:40 -04:00
Yaxun Sam Liu 6053c71323 Fix hipcc for -M for hip-clang 2018-07-23 09:26:42 -04:00
Yaxun Sam Liu 4627aa0085 Let hipcc use proper include and lib path for HIP/VDI
Add support of environment variable HIP_VDI_HOME.

By setting environment variable HIP_VDI_HOME to the distribution directory of HIP/VDI, hipcc
will choose proper include and lib path for hip-clang.
2018-07-23 09:26:42 -04:00
Evgeny Mankov a5afadec7e Merge pull request #583 from emankov/cuDNN
[HIPIFY][DNN] cuDNN support revise
2018-07-23 14:13:54 +03:00
Maneesh Gupta e2615335c0 Merge pull request #568 from Srinivasuluch/sprint2_9tests
Adding a few more struct scenarions and a ResultValidation()
2018-07-23 14:44:06 +05:30
Maneesh Gupta 00c1542487 Merge pull request #558 from Jorghi12/patch-8
Fix the FindHIP.cmake script.
2018-07-23 11:48:42 +05:30
saleelk e8a5ad629f Fix hipHostRegister mem leak and copy kind in hipMemcpyAsync (#587) 2018-07-23 11:04:14 +05:30
Maneesh Gupta 4637e11a24 Fix typo in FindHIP.cmake 2018-07-23 10:39:45 +05:30
Maneesh Gupta 137d7f559f Merge pull request #559 from rpathani/master
Adding functor unit tests
2018-07-23 10:15:16 +05:30
Maneesh Gupta 123af1a9c6 Merge pull request #584 from ROCm-Developer-Tools/fix-vector-explicit-cast
Fix explicit cast required
2018-07-23 10:13:05 +05:30
Maneesh Gupta 4d6a3f3eba Merge pull request #581 from ROCm-Developer-Tools/fix-warning-math-decl
[HIPClang] Switch ordering on math functions
2018-07-23 10:12:01 +05:30
Maneesh Gupta c53d0f967e Merge pull request #554 from gargrahul/cleanup_hipmemset3d_test
Cleaned up hipMemset3D test
2018-07-23 10:11:49 +05:30