Commit Graph

5467 Commits

Author SHA1 Message Date
agodavar a6c83e443c SWDEV-239297:hipMemset fix, getMemoryObject with unaligned ptr
Change-Id: I37b8139c5099d37b42f34d728a3d694fdf9cb55d


[ROCm/hip commit: 93da1b1f11]
2020-06-23 08:56:09 -04:00
German Andryeyev f490ef4c87 Disable flush on marker
Change-Id: I04d0fd995fb4b29a6bc372e1543902a053017d6a


[ROCm/hip commit: 44c1df802e]
2020-06-22 13:27:39 -04:00
Tao Sang 9c6dbda74b Fix static lib crashing issue
Initialize HIP_ENABLE_DEFERRED_LOADING = 1

Change-Id: I432ccf1926b953c4391fdd086cde7da2380962bb


[ROCm/hip commit: 0eebbb4f87]
2020-06-22 13:24:40 -04:00
Michael LIAO 49dfc5b2bd [hip] Disable assert workaround for HCC on HIP-Clang.
- HIP-Clang follows the standard assert definition by providing
  `__assert_fail`.  But, `assert` macro is added as an HCC-specific
  workaround due to the missing implementation. Only enable that on the
  HCC compilation to avoid unexpected behaviors on HIP-Clang
  compilation.

Change-Id: I1c9a707baff9b85c30faef58c52ebfe07e3fc3fc


[ROCm/hip commit: cea6b99a28]
2020-06-22 10:33:56 -04:00
Ronak Chauhan b2edee4693 Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

Change-Id: Id76e2bf91acd5d68f56a24fc39f219f2eeb06d33


[ROCm/hip commit: 961717879d]
2020-06-22 04:35:29 -04:00
Tao Sang c2a9bed3d7 Support numa policy set by user
Add hipHostMallocNumaUser flag to hipHostMalloc() in order to support
numa policy set by user.

Change-Id: I6d70ed539a5f97f27187f2242b68849c0e27e4d6


[ROCm/hip commit: 63051ca2e1]
2020-06-19 21:23:58 -04:00
Vlad Sytchenko 2780b86df2 Correct texture element size calculations
hipChannelFormatDesc contains size of each channel in bits. There's 8 bits per byte, not 4, so we should divide by 8.

Change-Id: I38ae2d28ad54740823c98908ca2afecad0ba0183


[ROCm/hip commit: e9033edc10]
2020-06-19 11:39:03 -04:00
Yaxun (Sam) Liu 7f26819b2f Fix missing ldexp(float,int)
Change-Id: I2c1553407dfc26948d3ab7aa532eef42a0f6b204


[ROCm/hip commit: b907505d55]
2020-06-18 15:16:59 -04:00
rohit pathania 670a34e8e2 [ dtest ] Added different test scenario with hipMemcpyWithStream
- Test with one, two streams
- Test Multi-gpu (one stream per gpu)
- Test D-D (on same device/different devices).  Can discover issues
  when devices are on same or different root complexes.
- Test H-D/Default

SWDEV-238517 for enhancing hip unit tests

Change-Id: I8031a7eebe2f9c8c0e0996e2c7accb09ac0b96d4


[ROCm/hip commit: d701632e01]
2020-06-18 10:31:01 -04:00
Vlad Sytchenko 9a8ba0d8e4 Support creating textures from user ptr with offset
Change-Id: Ied0af9a842fc6ef067e068a9d89dde63ff5dfce1


[ROCm/hip commit: 205e4c1c5f]
2020-06-17 14:10:14 -04:00
Vlad Sytchenko 3af20b1bbb Fix -Wsign-compare warnings
Change-Id: I874dc007ac657c25a72c6752c1a2da74c028a822


[ROCm/hip commit: a6aef2a36a]
2020-06-17 11:20:45 -04:00
Jason Tang 671b994ff8 Add asicRevision
Change-Id: I59f3ad20b9bdadf77bd1e0725f7a401d7ad423a3


[ROCm/hip commit: 38cd2b96c7]
2020-06-16 17:54:20 -04:00
Tao Sang a41347a1db Make hipHostMalloc() respect hipSetDevice()
Change-Id: I2410240f91b108c24597ee0fa7cf31e7b1f3ac5d


[ROCm/hip commit: 7682ec6a7b]
2020-06-15 23:20:09 -04:00
kjayapra-amd 78474d9ef8 SWDEV-240589 - Remove guarantee @ __hipRegisterFunction flow for now.
Change-Id: Ic51e2a1f951ac7745c2bbd11cfd2b92521c6966a


[ROCm/hip commit: 45e0847319]
2020-06-15 22:32:24 -04:00
Vlad Sytchenko 59be70d914 Enable the use of some warnings when building HIP-ROCclr
Similar to http://gerrit-git.amd.com/c/compute/ec/vdi/+/375385, except no -Wno-strict-aliasing.

With this change only two warnings show up during the build - -Wsign-compare and -Wmisleading-indentation.

Change-Id: Iffa436c65ab6312aeaa6def71ee6af38ed1b4a4e


[ROCm/hip commit: f3480e019e]
2020-06-15 20:33:30 -04:00
German Andryeyev 61c65cf0b7 Initial support for HIP managed memory
- Call the new ROCclr interfaces for HMM

Change-Id: I2cd1bf438f712a9e9e328340e7d0c025257ca6c1


[ROCm/hip commit: f4211c3905]
2020-06-15 18:10:41 -04:00
Aryan Salmanpour 969f1651fb expose five missing memcpy hip APIs
exposing the following hip APIs which have been previously implemented:

hipMemcpy2DFromArray
hipMemcpy2DFromArrayAsync
hipMemcpyAtoH
hipMemcpyHtoA
hipMemcpyParam2DAsync

Change-Id: I3f8635bd4265d2bf5aa2084f4eabb51f74fb18ba


[ROCm/hip commit: 17102ff3a1]
2020-06-15 12:30:31 -04:00
kjayapra-amd 10919eb6a9 SWDEV-236178 - Store texture reference metadata for dynamically loaded modules.
Change-Id: I99ecc80da7e29c691341a01a09e4532972f1e3e5


[ROCm/hip commit: 173bb2af6e]
2020-06-11 22:34:50 -04:00
kjayapra-amd f2c6f3bf63 SWDEV-236178 - Remove __hip_pinned_shadow reference from dtests and add hipModuleUnload for all corresponding hipModuleLoad calls.
Change-Id: I405789b430ffbb8fccda1cebdb5d18e83a85c926


[ROCm/hip commit: 0dd6123998]
2020-06-11 22:34:36 -04:00
Rahul Garg 44930cfb52 Addback __mbcnt_lo and __mbcnt_hi
Change-Id: Ic3facba2e2245461515799f6a17842da0f5d9933


[ROCm/hip commit: 00301b1665]
2020-06-11 21:21:36 -04:00
Vlad Sytchenko 6556412a83 Revert "Let hipcc not pass -mllvm option to HIP-Clang on Windows"
This reverts commit 9683880363.

Change-Id: If29906b9c63f03d6e51144f510d3a956d90935e8


[ROCm/hip commit: 01372e2cd4]
2020-06-11 16:36:48 -04:00
kjayapra-amd 37508980de SWDEV-236178 - Reorganizing Platform/Modules code for easy access.
Change-Id: Ie8920260ffc4ff01e44b48af8cec9ea5aed1aa9b


[ROCm/hip commit: 20f05c4228]
2020-06-11 10:11:20 -04:00
Siu Chi Chan ee30f289b4 fix uninitialized value in hipcc
Change-Id: I90b070c491f0efc328fcf97de0e111658ec772de


[ROCm/hip commit: 85e3b37052]
2020-06-10 16:07:51 -04:00
jujiang 572efac7a5 Fix for SWDEV-239415 to handle hipGetDevice properly while no GPU present
Change-Id: I252cbbf9a89fc76fe1be1fbb8f45778e96c70fb2


[ROCm/hip commit: c54590ebbd]
2020-06-10 14:18:56 -04:00
kjayapra-amd 707ec427bc SWDEV-231701 - Remove amd::memory->svm_ptr from MemObj, instead of the ptr to the object.
Change-Id: I5aab450a2320cfa5417c284e2a8454102df6f99d


[ROCm/hip commit: 2f8e180f01]
2020-06-10 11:49:02 -04:00
Dittakavi Satyanvesh 7b1ff8fe8b SWDEV-236670 Address Eigen unit test failure by adding __host__ attribute to half2 functions
Change-Id: Ifdc852c30a1b3704871e0ee58cb7a55d3d37fc6e


[ROCm/hip commit: 6ed1868203]
2020-06-10 03:01:42 -04:00
Christophe Paquot 5a8857b3e9 Do not deferred stream creation now that we multiplex HW queues
SWDEV-239856

Change-Id: I156650faf832f86891f00ee167269509edd844ec


[ROCm/hip commit: c8f9afa9da]
2020-06-09 19:16:25 -04:00
Yaxun (Sam) Liu 0a8e0c9147 Fix include path and wrapper header
Currently std::complex and some other std functions require uses to
include hip_runtime.h before any other headers to work, which is not
reliable.

changes are made in clang to fix this issue:
https://reviews.llvm.org/D81176

which requires hipcc and HIP headers to make corresponding changes.

This patch will make sure the clang change will not break
HIP/ROCclr during this transition.

After the transition is done, we can remove explicitly setting
include path for HIP-Clang and HIP header in hipcc and hip config
cmake files and rely on clang driver to set it automatically.

Change-Id: I5d226861c2560ffa6c5ab17343a43cc378048061


[ROCm/hip commit: 087c579625]
2020-06-09 17:37:20 -04:00
jujiang a7bcb71345 To fix a format in hip_porting_guide.md
Change-Id: I5faa4ec9b3d17625b7cb5cea86b9f44766b1cfa9


[ROCm/hip commit: 0d006bf79d]
2020-06-09 13:14:52 -04:00
Rahul Garg 6d110befe1 Bump version to 3.6
Change-Id: I739a7bd03a4ed102bbc7c2f60d108e20132f5423


[ROCm/hip commit: 96a2834595]
2020-06-09 11:22:20 -04:00
Saleel Kudchadker 75f05a8b01 Modify HIP_RETURN to print useful details
Change-Id: I23892c2d9a738b0298cdf24106d688a792937c73


[ROCm/hip commit: 2e8c1e9f24]
2020-06-06 02:05:21 -04:00
kjayapra-amd 81e6261ff8 SWDEV-239327 - Remove amd_mem_obj during unregistervar
Change-Id: I2130eaa21369b9634a9459680061138c61eaaaa4


[ROCm/hip commit: 421bc7dfcb]
2020-06-05 23:24:38 -04:00
kjayapra-amd a3f6bf1161 SWDEV-235295 - Move addDeviceProgram() to lazy loading
Change-Id: I8fe07e370e58844496e18c858bb528393556854f


[ROCm/hip commit: 348066d21f]
2020-06-05 18:03:32 -04:00
Jason Tang 67baf4f506 SWDEV-227909 - Add gcnArchName
Change-Id: Iea6d16b5d693dd0d900fa424d7a321c39315430e


[ROCm/hip commit: 1c0d737e1f]
2020-06-05 15:33:55 -04:00
kjayapra-amd 0bdff1ff07 SWDEV-234295 - Pass flag to ROCclr to not clear device programs during program::build()
Change-Id: I50b9fa1a96da6895f73fdf4a7c0d3f096b1188da


[ROCm/hip commit: 8941d19fe8]
2020-06-05 09:53:11 -04:00
rohit pathania 791e62287c [ dtest ] hipModuleLaunchKernel multiThreaded n multiGPU scenarios
1.Added hipModuleLaunchKernel multithreaded multi GPU scenario.
2.removed hipCtxCreate API from earlier test as it is deprecated.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Id102d80887b6ff61a59938dbeb9fa2a26a3275b2


[ROCm/hip commit: cc6a87e9e3]
2020-06-05 09:40:58 -04:00
Lakhan Singh Thakur 55f368c3a0 [dtest] merge 'Adding the two test cases to cover scenarios observed in SWDEV-181598.'
SWDEV-238517 for enhancing hip unit tests

Change-Id: Ie61145b46c89b2e970af0ab11e22b6f6286ec90f


[ROCm/hip commit: fb77b2497c]
2020-06-05 09:10:23 -04:00
Aryan Salmanpour 1cdccedef9 Add support for setting hip stream priority
this change follows CUDA convention where lower number is greater priority

Change-Id: I72596a36449e818cbd8c175bf8519c51f46b1610


[ROCm/hip commit: 1bb86658cc]
2020-06-04 22:50:30 -04:00
Payam dac652e8df Observed softhang while running hipStreamAddCallbackCatch SWDEV-236746
Workaround hipStream deadlock issue as the same lock was used twice SWDEV-236746

Change-Id: Icc60104ce6edf4cfd2a3a889bab78a6caadd50b7


[ROCm/hip commit: a524f13c97]
2020-06-04 14:11:22 -04:00
Aaron En Ye Shi 9aa9282f89 Add gfx908 to hip-config.cmake
Support gfx908 as part of the default AMDGPU_TARGETS. MIGraphX requires this change.

Change-Id: I692f87f27829778e04f59c9ca655c6e8cbc00abc


[ROCm/hip commit: dc2caed525]
2020-06-04 11:00:09 -04:00
Siu Chi Chan b8db8cac9b add constexpr constructor for vector types
Change-Id: I45bb0537d6a24ee50b548c2fd8b4f20518764813


[ROCm/hip commit: 784ca6f43c]
2020-06-04 01:57:03 -04:00
Evgeny 037da0c744 adding hipGetStreamDeviceId() profiling API
Change-Id: I5ccf88ddac123260d7c17defefcf20ff3b2504e2


[ROCm/hip commit: cad3f805c0]
2020-06-03 18:57:49 -04:00
Aaron En Ye Shi 9dabdf86fe Add compiler-rt library for __fp16 and _Float16
Similar to HCC, link with compiler-rt to support __fp16 and _Float16 type conversions in ONNX models. This should resolve SWDEV-238491.

Change-Id: Iad8dcff568831719f501f562a04023326ae8036c


[ROCm/hip commit: 56392b4f8a]
2020-06-03 18:53:14 +00:00
Siu Chi Chan 20abb9dcc7 update device library path
fix device lib directory

add missing --hip-link switch for link phase

Change-Id: I4b2eeb32648ca3cec72ec1f4e3381ce1fc0a90a5


[ROCm/hip commit: f20748854e]
2020-06-03 14:44:23 -04:00
Jatin 7b52f0a1ea Adding changes for hipExtLaunchKernel for rocCLR
Change-Id: Iba52bc3bde7c37f3fb375a55ba0947e87b3cdc9b


[ROCm/hip commit: 2d517fdcc6]
2020-06-02 14:16:41 -04:00
Rahul Garg 1be23e215c Use right perl-which rpm package
Change-Id: I22106a7d1b4b50c99f945bc6416ff3bd8486d15c


[ROCm/hip commit: 88720e2e77]
2020-06-02 02:17:54 -04:00
Aaron En Ye Shi 5ef8eb7375 HIP-Clang Temporarily include HIP_HCC_FLAGS for PyT
Change-Id: I0f5895fba69f5bf0c6cc13e9402bdc44726dcc5a


[ROCm/hip commit: 13ac055fc2]
2020-06-01 15:28:04 -04:00
Aryan Salmanpour dee385497d Add support for missig hipStreamGetPriority API
Change-Id: I2be4b055e5f977eb6ecad0b1f5f9535e72345fe7


[ROCm/hip commit: 4a1536701f]
2020-06-01 13:33:14 -04:00
agodavar 76cb1b1644 hipMemset dont enqueue command if size bytes is 0
Change-Id: I63bf896f9f23edf254acdf7a8c11c92f8b5ac039


[ROCm/hip commit: 39ee03f64c]
2020-05-30 10:33:44 -04:00
Rahul Garg e97fb496f0 Add libfile-which-perl dependency SWDEV-237642
Change-Id: I0799fdcbc58a35c957a3bc69a8a1c6a013a3f57c


[ROCm/hip commit: 7259b70f60]
2020-05-29 20:04:23 -04:00