Commit Graph

5593 Commits

Author SHA1 Message Date
Tao Sang 3fdd346cf2 SWDEV-417727 - Fix hipSignalExternalSemaphoresAsync()
This reverts commit cab71e6e00.

Implement the right way to make ExternalSemaphores be signalled
only after prior works on the stream have been finished.

Change-Id: I9d5974e05d5f229170b928db4566c14e40e3cbaa


[ROCm/clr commit: d433df4761]
2023-08-23 22:31:27 -04:00
taosang2 cab71e6e00 SWDEV-417727 - Fix hipSignalExternalSemaphoresAsync()
Let ExternalSemaphores be signalled only after prior works on the
stream have been finished.

Change-Id: I856917db905f68f55fdf484f5267f7fe8ea3117f


[ROCm/clr commit: 44a3935cda]
2023-08-23 14:58:37 -04:00
German 85d075fa82 SWDEV-404889 - Inital change for debugger support
- Program unique AQL index for debugger. The logic manages AQL array of packets per HW queue.
- Provide debug state to PAL

Change-Id: I38fa1f5435fa711fd1d44dc391f2e61eb2a25efa


[ROCm/clr commit: d97cc0abbd]
2023-08-23 13:21:58 -04:00
kjayapra-amd b432ced424 SWDEV-408473 - Add wait time of 10 us if the waiting signal copy was < 24K.
Change-Id: I438ec9eb07e5034042a4a9a5e6e51d74daba2c83


[ROCm/clr commit: 6f5277c701]
2023-08-23 10:46:33 -04:00
Juan Manuel MARTINEZ CAAMAÑO 0cf78a6dfa Revert "SWDEV-410182: Do not force wave64 for geekbench"
This patch did not consider the dicussions in SWDEV-270908

> "we found that in GeekBench5, forcing Wave64 instead of the default
> Wave32 compute policy yields big gains in every subtest except one"

This reverts commit 10e2958197.

Change-Id: Ice1728585b9d1b2c1b36a06cfa0b8c47cb2bfa49


[ROCm/clr commit: 06dcaae619]
2023-08-21 03:29:32 -04:00
Jaydeep Patel dcaa21376f SWDEV-417691 - Error handling for MemoryMap OS calls.
Change-Id: I0a823289b274e118c8440f2d372a5216bf4ba6aa


[ROCm/clr commit: 7a10423a44]
2023-08-21 00:01:06 -04:00
German 6a7f06fd9b SWDEV-415115 - Fix memory commit in SVM on large bar systems
Skip memory commit for linux only.

Change-Id: I6304607f7c5516c76e59afa6da57de5b088f6a8c


[ROCm/clr commit: 9bd592e2ff]
2023-08-18 11:25:28 -04:00
Todd tiantuo Li 262839abea SWDEV-403758 - support new ASIC Revisions for Hawk Point1 and Hawk Point2
Change-Id: Ib8383b16e85abaa0bbf481c1aac71a11cd5b9218


[ROCm/clr commit: b4933f1d00]
2023-08-18 10:32:09 -04:00
victzhan 779e5c3a22 SWDEV-274425 - fix bad assignment of imageOffset.y and imageOffset.z to PAL
Change-Id: I6adce05928f6ff61aad845f289687d9bc0d17476


[ROCm/clr commit: b14bd96d3c]
2023-08-18 00:17:31 -04:00
victzhan 4312ca9e32 SWDEV-416580 - Add condition when memory has direct access, only use host fill if image is small
Change-Id: I3509c4aa21f6413adad3b46273ec650f5c577ddd


[ROCm/clr commit: cb426df1bd]
2023-08-17 17:23:49 -04:00
Ajay 17813d3e3c SWDEV-414828 - set AMD_DK_ROOT variable to env DK_ROOT
this ensures python to be picked from DK

Change-Id: Idd006b7a2bb819c6aa747136aa55cfc28737a5a9


[ROCm/clr commit: 0d3a5c4c81]
2023-08-17 12:21:16 -04:00
Jaydeep Patel 86bac29b0a SWDEV-412393 - Force alloc memory to avoid another hsa image creation.
Change-Id: Ia3cd99eb736231e6dfe013ebae6c41fd4cc657bc


[ROCm/clr commit: 289535e805]
2023-08-17 05:18:43 +00:00
Juan Manuel MARTINEZ CAAMAÑO 10e2958197 SWDEV-410182: Do not force wave64 for geekbench
Change-Id: I505af6b0ca70e54a963abe9b097b91eea94d3268


[ROCm/clr commit: d6dc82b220]
2023-08-16 10:22:52 -04:00
Alex Xie 278c65ae86 SWDEV-416457 - clr to handle metadata ActualAccQual
Change-Id: I4e4c52093ed0f65830dbba19266872d3405c4916


[ROCm/clr commit: dc401c520b]
2023-08-15 13:47:34 -04:00
victzhan 8a7a86847f SWDEV-274425 - fix bad initialization of array slice index for 1d image array in partialMemCopyTo()
Change-Id: Id9a0c55d4296de8cd89f1870b2c8028ce6cf601b


[ROCm/clr commit: 4fb24c48b0]
2023-08-15 12:55:10 -04:00
victzhan 2fab383d94 SWDEV-385303 - remove bad row pitch assignment
Change-Id: If959be2fa51035c54c3b08e74711077ad52ac4c8


[ROCm/clr commit: 7e3d8243b7]
2023-08-14 15:21:56 -04:00
Saleel Kudchadker 28fa32a405 SWDEV-384557 - Reset mask at in the constructor
Change-Id: I15dafd281213c03590bcae4bf4544e33c4a7e277


[ROCm/clr commit: 8a538b5639]
2023-08-11 17:22:27 -04:00
German e425f6cacc SWDEV-416527 - Disable PAL platform destruction until a proper fix in PAL
Change-Id: I465aa15959187eb27354caa9b8308f1266be46ed


[ROCm/clr commit: 618cc4d9ee]
2023-08-11 10:51:37 -04:00
Ioannis Assiouras 275ef916cd SWDEV-415160 - Added fix in kernel argument logging
Change-Id: Ic54d51264602c7bf0c91b5273f9519da3fbb1062


[ROCm/clr commit: 63af50b6e0]
2023-08-03 21:39:41 +01:00
Saleel Kudchadker 520b17fb07 SWDEV-384557 - Enable SDMA query
Change-Id: Ibb0a8d131f799985a4d4adbf753261e58c04157f


[ROCm/clr commit: aa6eb555e2]
2023-08-01 18:41:23 -04:00
Jaydeep Patel 1d785911ed SWDEV-408283 - Sync scratchRegs_, privateMemSize_ and workitemPrivateSegmentSize.
Change-Id: I623a7140810ff9867f8816bf4c8621a1fe921744


[ROCm/clr commit: ff1a999f66]
2023-07-27 00:31:54 -04:00
Anusha GodavarthySurya e6bdfcccf7 SWDEV-392732 - CP processes until doorbell ring
Change-Id: I3a0974435d3f95a40cea6ed326f744bcab5b4c0f


[ROCm/clr commit: 0711320cb4]
2023-07-25 13:10:31 -04:00
German Andryeyev e62940f7df SWDEV-409815 - Fix image view cache issue
Add a view bit to avoid original resource destruction when parent
dependency doesn't exist with the image view cache

Change-Id: I8277afd575af8f29951c5d1a9f7d94d784251657


[ROCm/clr commit: b49e8e78e1]
2023-07-25 12:30:04 -04:00
Lang Yu 11873d4eff SWDEV-396372 - Add support for gfx1150 and gfx1151
Change-Id: If97710f18fbb61bead5cfe92ce11e11b4895b029
Signed-off-by: Lang Yu <Lang.Yu@amd.com>


[ROCm/clr commit: c674d94a12]
2023-07-24 20:11:03 -04:00
Ioannis Assiouras 62b3d8f59b SWDEV-412496 - treat USE_PROF_API to always be true
Change-Id: I77cfac409215a33d11228a0f2da9ffba63c3d73a


[ROCm/clr commit: cb7776ef07]
2023-07-21 04:42:57 -04:00
Saleel Kudchadker 96e25898c8 SWDEV-301667 - Disable HostBlit copy for HIP
Change-Id: I46333ff42e8c1d402ece97e3ead7b539a27c3f82


[ROCm/clr commit: 5447cf8872]
2023-07-17 17:49:11 -04:00
Todd tiantuo Li cd9fa7af05 SWDEV-333557 - add PAL_HIP_IPC_FLAG for PAL HIP device allocations
Change-Id: I9017f4e3b03d4817bf233c788e30775fb2297589


[ROCm/clr commit: 04b9ab49eb]
2023-07-17 08:10:25 -04:00
Anusha GodavarthySurya 57467ef2c7 SWDEV-392732 - Initial commit for graph doorbell optimization(AQL Buffering)
Change-Id: I451725006c54c249dc530c55d2af2a31594bf49b


[ROCm/clr commit: b0e6f99ad7]
2023-07-16 07:56:00 -04:00
kjayapra-amd 8f7eeb8a74 SWDEV-408891 - Only register the host pointer to the current device.
Change-Id: If5397f148638e3b7d542b9e6fb8ac749a602b35e


[ROCm/clr commit: 8c7f59663f]
2023-07-12 21:44:52 -04:00
Todd tiantuo Li 677c88a9a6 SWDEV-333557 - 1.Add support for IPC memory to enable hipIpcGetMemHandle() and hipIpcOpenMemHandle() in PAL path. Set interprocess flag for device allocations in HIP PAL. 2.Fix PAL IPC path with ResourceCache and SubAllocation 3.Minor fixes for IpcBuffer constructor and IpcAttach 4.Remove redundant checks that may go wrong
Change-Id: Ie9d99847c7c2c7b3b2aaefaaf60d23bf71b68635


[ROCm/clr commit: 8434feed16]
2023-07-12 17:49:32 -04:00
German Andryeyev 116c9fd6c1 SWDEV-409815 - Fix image view cache issue
Make sure parent_ field is cleared for the internal image views.
The internal image views don't require dependencies tracking.
The issue appeard only when Navi10 pitch workaround was enabled.

Change-Id: I376d212750085a9391f8c32fc2979dcb5d93c89c


[ROCm/clr commit: 6b89980fb2]
2023-07-11 11:22:29 -04:00
Alex Xie a7418845f8 SWDEV-409299 - Vega clinfo is not working
Change-Id: Ia48bc6f130bd102dff210b105de6f9c02ebbe012


[ROCm/clr commit: 7912f3af89]
2023-07-10 09:53:50 -04:00
German b55398774b SWDEV-408650 - Report CL_DEVICE_HALF_FP_CONFIG query
If cl_khr_fp16 extension is enabled, then OCL runtime should report CL_DEVICE_HALF_FP_CONFIG.

Change-Id: I7c4ac48387f80bc704a475c57e5b52a462090d1b


[ROCm/clr commit: ad2c1e899a]
2023-07-06 11:58:16 -04:00
Maneesh Gupta 247c8ca332 SWDEV-1 - Bump min required ROCr version
ROCr version needs to be > 1.11 due to 03504e2f6c

Change-Id: I836dd5dc4ad5626120661ba19bad2e36dccbe36c


[ROCm/clr commit: 96fb1ac289]
2023-07-06 05:17:52 +00:00
kjayapra-amd 03504e2f6c FEAT-47686 - Changes to support new uncached memory segment in ROCr.
Change-Id: I0ba8769d6737cdf1cc8a8644b2e82109f584a430


[ROCm/clr commit: aca7d9e14a]
2023-07-05 20:47:51 -04:00
Jaydeep Patel 6fa299f3a3 Revert "SWDEV-403995 - uniform_work_group_size is interger type is 1 for true and 0 for false. Lighting kernel's init sets uniform work group flag and hence not need to set it from options."
This reverts commit 063b3d4e51.

Change-Id: I077135a726320eb109888f0e7442120dc852ad3e


[ROCm/clr commit: 90f53925a3]
2023-07-05 04:41:40 +00:00
Rakesh Roy f887f2fc6f SWDEV-405329 - Fix cuMask issue for WGP mode
- Enable CUs adjacent pairwise for WGP mode
- In HostQueue::terminate() do not segfault if virtual device hasn't been created

Change-Id: I94402ff333308af5824878086cc238b3993d534d


[ROCm/clr commit: 8c1232124e]
2023-06-30 01:09:01 -04:00
Saleel Kudchadker 47894de700 SWDEV-384557 - Rename env var
- Rename HIP_USE_SDMA_QUERY to DEBUG_CLR_USE_SDMA_QUERY as this is
supposed to be a temporary env var for debug purposes only.

Change-Id: If6ebd52ab87624375a3df24ceccdcc05c60a65af


[ROCm/clr commit: 770b2a4711]
2023-06-29 13:54:55 -04:00
kjayapra-amd 4ad93e01f7 SWDEV-408213 - Move the init_heap blit kernel inside linear blit kernel grouping.
Change-Id: Id540018d4cceab5f01f614f7d49ef42505e69039


[ROCm/clr commit: a034995f81]
2023-06-29 10:36:53 -04:00
German Andryeyev 1de5c73c38 SWDEV-396088 - Add image view cache
Blit manager requires an image view to reduce the amount
of copy kernels. Creation/destruction of a view in ROCr is
an expensive operation. Thus, runtime can cache views for fast access.

Change-Id: Ia67d775b481cc8326d91215ca22d4a73c1dddb59


[ROCm/clr commit: d29755452b]
2023-06-28 09:44:05 -04:00
Saleel Kudchadker 9cb5f95a56 SWDEV-408180 - Remove largeBar memcpy
- Remove large bar memcpy path. Since we end up waiting for a barrier,
its defeating the true intent of the copy, Also memcpy over PCIE\XGMI is
introducing variability in perf for HPC apps like GROMACS

Change-Id: I3b5c9d9ce93333959c39023bf4f703e2ccb6e3af


[ROCm/clr commit: 0a3d4bd4d4]
2023-06-27 18:15:26 -04:00
Saleel Kudchadker 97fea3890c SWDEV-301667 - Enable SDMA profiling only when queue profiling
Change-Id: I9a62a2fbaefd54638c35f4b8fce2e9ea2da7af19


[ROCm/clr commit: bceec9d9a2]
2023-06-26 16:10:34 -04:00
ajay a8d5879f26 SWDEV-406687 - combining rocblitcl and palblitcl blit kernel defs
Change-Id: Ia312d73584a03491e8d574f424295b64df6de174


[ROCm/clr commit: d6946ffcbc]
2023-06-23 18:38:36 -04:00
Matt Arsenault eed1597e39 SWDEV-1 - Fix -Wfinal-dtor-non-final-class
rocclr/platform/external_memory.hpp:93:30: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class]
   93 |     virtual ~ExternalImage() final {}

Change-Id: I56d760fa6c08544100e3bc03d35129bd16d8a428


[ROCm/clr commit: e9750de215]
2023-06-23 09:06:56 -04:00
Matt Arsenault 4af8b4ef0f SWDEV-1 - Fix -Winconsistent-missing-override
Change-Id: Ie69f234c755b112b7fe8ef7d00b8720bc178044c


[ROCm/clr commit: 98e0607f0e]
2023-06-23 09:04:28 -04:00
Ioannis Assiouras 320d7c1d9a SWDEV-405182 - Revert min alignment for abstract parameters stack to 16 bytes
Change-Id: I9e6ace281468e8ef11b011c58f5971ce8907f3c6


[ROCm/clr commit: 4add0e6563]
2023-06-23 04:39:51 -04:00
Alex Xie 867d1fc66f SWDEV-382072 - One more case that needs workaround
Change-Id: Ief81dd898e4d59ba858f38a843d79be45b5ea944


[ROCm/clr commit: cfc10d0e1e]
2023-06-22 19:00:34 -04:00
taosang2 9aa3a87b66 SWDEV-368553 – Add missing mipmap Apis
Add missing mipmap Apis’ implementation.
Fix some bugs of mimpmap apis.
Use hipmipmappedArray to differentiate cuda
and driver apis on Nvidia.
Change-Id: I6079d9f3b2ddf4e42b9a6f7f3902322cfca02cfd


[ROCm/clr commit: f03c11491b]
2023-06-22 17:24:21 -04:00
Alex Xie c14a017d77 SWDEV-382072 - [Naiv 10]EncodeSDK H264 test fails
let ROCr and addrlib decided whether a pitch is supported.
Then, check if we uses workaround.

Also improve image performance for Navi 1x in some cases.

Change-Id: If8bda46648b23c1dcfa26608ca3bb9cd89fef430


[ROCm/clr commit: b961d4a970]
2023-06-22 10:40:31 -04:00
German c8e65415ea SWDEV-311270 - Clean-up IPC path in ROCclr
- Make IPC interfaces generic between devices and rely on the IPC buffer
for attach/detach logic

Change-Id: Id3c18d122030329b7ee532bbb6317de9dd6a0bbe


[ROCm/clr commit: 9aa6f25f1c]
2023-06-20 15:18:21 -04:00