SWDEV-155434 - Add SQTT instrumentation tokens for OpenCL dispatches for RGP support
- Switch to the workgroup size report for the dispatch info.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#118 edit
[ROCm/clr commit: 19968ab78a]
SWDEV-2 - Change OpenCL version number from 2706 to 2707.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2454 edit
[ROCm/clr commit: 37677e98a5]
SWDEV-145570 - [HIP] refactor hipMemcpy* functions to correctly handle copies using prepinned memory
The current implementation of hipMemcpy functions picks the copy type based on a flag that the user passes. However, one can use the hipMemcpyHostToDevice/hipMemcpyDeviceToHost flag in a combination with prepinned memory. By using the WriteMemoryCommand/ReadMemoyCommand in this case, we will pin the same host memory twice. This is fine on PAL/Linux, since pinning the same VA range is a noop, but this will start failing once we switch to using device memory with HIP/VDI/HSA.
The solution is to ignore the hipMemcpyKind flag and let the runtime decide what kind of copy is best to do. Except for the case when hipMemcpyHostToHost is passed, since both host pointers may be prepinned.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15482/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#37 edit
[ROCm/clr commit: b02040e934]
SWDEV-2 - Change OpenCL version number from 2705 to 2706.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2453 edit
[ROCm/clr commit: ce73c861d6]
Implement the vector value types in terms of SCALAR_TYPE##SIZE_vector_value_type for float, int, uint and sizes 2, 3, 4, 8, and 16.
[ROCm/clr commit: ff1e49d191]
When shareWithAll memory (e.g., host memory) is allocated, set appId
in hc::AmPointerInfo to -1 to indicate that this memory is not mapped
to any device. Peer checking in ihipStream_t::canSeeMemory is not
necessary if memory is shared with all devices. Thus, it is skipped.
Note that earlier host memory is always mapped to device 0 and HIP
always performs peer checking for all kinds of hipMemcpy. Since the
peer checking process requires context locking, hipMemcpy from/to host
memory always grabs device 0's context lock. Therefore, if there is
another thread holding the context lock of device 0 (e.g.,
hipDeviceSynchronize on device 0), hipMemcpy will have to wait for the
lock until it can actually perform memcpy. This can significantly
deteriorate execution performance.
Signed-off-by: Sarunya Pumma <sarunya.pumma@amd.com>
[ROCm/clr commit: 84aadb9274]
SWDEV-2 - Change OpenCL version number from 2704 to 2705.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2452 edit
[ROCm/clr commit: 33c588c456]
SWDEV-2 - Change OpenCL version number from 2703 to 2704.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2451 edit
[ROCm/clr commit: 46a6b4b4d7]
SWDEV-132899 - [OCL][GFX10] removing gfx1001 (target for Navi10 Lite if xnack is enabled)
starting from gfx10, we will use the same target (e.g., gfx1000) no matter if xnack is enabled/disbaled and we pass "-xnack" option to Finalizer if xnack is enabled on the target
ReviewURLBoard = http://ocltc.amd.com/reviews/r/15492/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#37 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#99 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#64 edit
[ROCm/clr commit: 9ddfeef105]
SWDEV-2 - Change OpenCL version number from 2702 to 2703.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2450 edit
[ROCm/clr commit: f7701ab726]
SWDEV-1 - Also catch clGetPlatformIDs error, so clinfo won't get a page fault when no platform is found.
Instead clinfo now shows:
ERROR: clGetPlatformIDs(-1001)
Affected files ...
... //depot/stg/opencl/drivers/opencl/tools/clinfo/clinfo.cpp#5 edit
[ROCm/clr commit: adf6570955]
Include texture_functions.h on HIP-Clang path. Use HIP vector types instead of hc::short_vectors for texture_functions, and remove HCC headers.
[ROCm/clr commit: bf6fdca1e8]
- Uses c++11 features. Added it to nvcc options
- Arguments for some kernels exceeded 4096 bytes which is the limit
imposed by nvcc. Reduced BLOCK_DIM_SIZE to 512 to handle this
- Fixed compilation issues on nvcc path
Change-Id: I14f6b28afcb7c6b24a085fd707b2104e2ed64627
[ROCm/clr commit: 51307ac705]
CMAKE_SHARED_LIBRARY_LINK_CXX_FLAGS contains -rdynamic which does not go
well with nvcc
Change-Id: I10e6d21553de0e43c6a7ae5fb3ec2418087959ff
[ROCm/clr commit: 7a5987e289]
SWDEV-2 - Change OpenCL version number from 2701 to 2702.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2449 edit
[ROCm/clr commit: cfccbd91ab]
SWDEV-79445 - OCL generic changes and code clean-up
1. In SvmCopyMemoryCommand handle the case when both src and dst pointer don't belong to the SVM space.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15481/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#424 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#117 edit
[ROCm/clr commit: ebe91eeace]
SWDEV-2 - Change OpenCL version number from 2700 to 2701.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2448 edit
[ROCm/clr commit: f1157f1cfb]
SWDEV-79445 - OCL generic changes and code clean-up
- Reset memory dependency if runtime invalidated L1 for the profiling logic workaround. Profiling can be enabled for wave limiter, which could cause L1 invalidation twice.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#116 edit
[ROCm/clr commit: c84525aa73]
I've noticed that in the generated makefiles, we'd have
if(NOT build_configuration)
set(build_configuration Debug)
endif()
However, only definitions with all capitals are provided.
e.g.
set(HIP_HCC_FLAGS_DEBUG -g)
This is because of lines 442 to 448. We capitalize the configuration ${config_upper}.
This PR fixes this bug.
[ROCm/clr commit: 25c780c89e]
SWDEV-155860 - [OCL][LC] 62 Failures running on OCL/LC Windows drivers
- Conformance test basic->vload_private was failing due to alignment assert check on akc->workitem_private_segment_byte_size.
- Determined needed to add alignment, so added alignment into the header file, and removed assert check (as alignment was done afterwards).
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15451/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.cpp#57 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#18 edit
[ROCm/clr commit: 12a063779d]
Yaxun Sam Liu
foreman
Evgeny Mankov
lthakur
Aaron Enye Shi
Rahul Garg
Sarunya Pumma
Brian Sumner
Maneesh Gupta
Jorghi12