Maneesh Gupta
a3e7b7c18e
Merge pull request #613 from ROCm-Developer-Tools/hcc-compat
...
Add HCC compatibility mode for hip-clang
[ROCm/clr commit: a5f9ae90d2 ]
2018-08-10 09:32:31 +05:30
Maneesh Gupta
4e2e234a56
Merge pull request #617 from gargrahul/genco_remove_adipose_extn
...
Remove adipose extension from genco output
[ROCm/clr commit: 497610f96c ]
2018-08-10 09:31:44 +05:30
Maneesh Gupta
f74ececf41
Merge pull request #619 from ROCm-Developer-Tools/revert-pr457
...
Revert pr457
[ROCm/clr commit: 79e9a2dfa4 ]
2018-08-10 09:25:57 +05:30
sunway513
3621ec1971
resolve a segfault bug when env var not set; remove startup_kernel_loader class
...
[ROCm/clr commit: 7c467220a8 ]
2018-08-09 16:40:26 +00:00
Rahul Garg
1f0d24fa61
Clean up module api samples
...
[ROCm/clr commit: b6c5d7d71b ]
2018-08-08 22:28:13 +05:30
Evgeny Mankov
dac14d60b7
[HIPIFY][Complex] Add cuComplex support
...
+ Add API_COMPLEX support (data types and functions)
+ Add cuComplex_API_supported_by_HIP.md
+ Add cuComplex_Julia.cu test
+ Update README.md
[ROCm/clr commit: ce57b99f9d ]
2018-08-08 18:34:57 +03:00
Yaxun Sam Liu
d3295e61e2
Fix __HIP_ARCH_* not defined after including math_functions.h
...
hcc_detail/math_functions.h used to include hcc_detail/hip_runtime.h.
Removing it has caused regression in TensorFlow 1.8.
Put it back for backward compatibiliity.
[ROCm/clr commit: 87de95975a ]
2018-08-08 08:55:28 -04:00
Yaxun Sam Liu
6e153a743f
Fix __HIP_DEVICE_COMPILE__ not defined when hip/math_functions.h is included
...
This fixes build failure in TensorFlow 1.8 for HCC
[ROCm/clr commit: 058eb7535b ]
2018-08-07 17:14:39 -04:00
Yaxun Sam Liu
6df5aef807
Fix declaration conflict when hip/math_functions.h is included first
...
This fixes build failure in TensorFlow 1.8 for HCC
[ROCm/clr commit: 69bbf45b44 ]
2018-08-07 15:44:59 -04:00
foreman
ee0e1fafe2
P4 to Git Change 1590010 by skudchad@skudchad_test2_win_opencl on 2018/08/06 21:18:48
...
SWDEV-145570 - [HIP] - Fix some issues in hip runtime
- Set stream for event
- Free mem needs to be reported in bytes but runtime backends reports in Kb
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15586/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#40 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#15 edit
[ROCm/clr commit: b4ccaeffe1 ]
2018-08-06 21:24:14 -04:00
sunway513
e1d72394da
Add more check to ensure the startup loader only be enabled with the env var set to 1
...
[ROCm/clr commit: 7d776ae665 ]
2018-08-04 01:52:27 +00:00
sunway513
ef368c0f43
Add startup loader under HIP_STARTUP_LOADER env var, disable by default
...
[ROCm/clr commit: 9af862d364 ]
2018-08-04 01:48:06 +00:00
Wen-Heng (Jack) Chung
d7b2bab183
Revert "HIP program state re-initialization logic"
...
This reverts commit 865fe01b37 .
[ROCm/clr commit: 1fe7f1be91 ]
2018-08-03 17:03:04 -05:00
Wen-Heng (Jack) Chung
fbf97dddb5
Revert "Improve performance of re-initialization logic"
...
This reverts commit 1d1b402e5b .
[ROCm/clr commit: f6178c2159 ]
2018-08-03 17:02:58 -05:00
Wen-Heng (Jack) Chung
1494fc442f
Revert "Keep the map which tracks GPU kernel symbols to grow monotonically"
...
This reverts commit ca62af218c .
[ROCm/clr commit: 329f3b7a5e ]
2018-08-03 17:02:50 -05:00
foreman
4897c229a4
P4 to Git Change 1589138 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/03 01:04:05
...
SWDEV-145570 - [HIP] Added __gnu_h2f_ieee and __gnu_f2h_ieee
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#10 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#16 edit
[ROCm/clr commit: f4add6058a ]
2018-08-03 01:15:15 -04:00
Maneesh Gupta
34e14adae2
Merge pull request #588 from Jorghi12/patch-10
...
Fixing a HIP bug that causes DEBUG symbols to be dropped.
[ROCm/clr commit: ac18a3b701 ]
2018-08-03 08:48:56 +05:30
Maneesh Gupta
0f033ca572
Merge pull request #603 from b-sumner/master
...
Drop use of NVCC_COMPAT since it is always set
[ROCm/clr commit: b485957858 ]
2018-08-03 08:45:18 +05:30
Maneesh Gupta
044a73015e
Merge pull request #601 from sarunyap/fix-shareWithAll-mem-dev-mapping
...
Remove device mapping from shareWithAll memory
[ROCm/clr commit: ad44a77ed4 ]
2018-08-03 08:45:04 +05:30
foreman
8819b1de20
P4 to Git Change 1589087 by skudchad@skudchad_rocm on 2018/08/02 20:10:02
...
SWDEV-145570 - [HIP] - hipHccModuleLaunchKernel needs to be a c++ sym
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#9 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#14 edit
[ROCm/clr commit: 678764d113 ]
2018-08-02 20:20:23 -04:00
foreman
934eca953a
P4 to Git Change 1589062 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/02 18:34:20
...
SWDEV-145570 - [HIP] Fix a segfault exposed by rocBlas.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#39 edit
[ROCm/clr commit: 08a308dd59 ]
2018-08-02 18:52:37 -04:00
foreman
650747dfe6
P4 to Git Change 1589030 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/02 17:40:15
...
SWDEV-145570 - [HIP] Fixed the underline
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#15 edit
[ROCm/clr commit: 388d597321 ]
2018-08-02 18:00:05 -04:00
foreman
8ca0447f6e
P4 to Git Change 1588779 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/02 12:25:51
...
SWDEV-145570 - [HIP] Refactored some g_* stuff
Refactored g_functions into a platform state.
Added a _vars for registered variables.
Added an execution stack similar to Hcc-clang.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#14 edit
[ROCm/clr commit: 2ff260c727 ]
2018-08-02 12:33:55 -04:00
Rahul Garg
22d59ba040
Remove adipose extension from genco output
...
[ROCm/clr commit: e9d7584b02 ]
2018-08-02 15:16:36 +05:30
foreman
68f06e9f60
P4 to Git Change 1588556 by skudchad@skudchad_rocm on 2018/08/02 02:04:15
...
SWDEV-145570 - [HIP] - Release eStop if it not a nullptr.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#13 edit
[ROCm/clr commit: e638c1377f ]
2018-08-02 02:18:57 -04:00
foreman
a3fc17658c
P4 to Git Change 1588551 by skudchad@skudchad_rocm on 2018/08/02 01:55:45
...
SWDEV-145570 - [HIP] - Refactor ihipModuleLaunchKernel and add hipModuleLaunchKernelExt
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#8 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#12 edit
[ROCm/clr commit: 11a91fbe0b ]
2018-08-02 02:14:04 -04:00
Maneesh Gupta
1039c7952c
Merge pull request #610 from aaronenyeshi/enable-hcc-module-launch
...
Enable hipHccModuleLaunchKernel on HIP-Clang
[ROCm/clr commit: 0354367a07 ]
2018-08-02 08:08:46 +05:30
Maneesh Gupta
6de7fd4934
Merge pull request #600 from ROCm-Developer-Tools/enable-texture-functions
...
Enable HIP texture functions with HIP vector types
[ROCm/clr commit: 4544e681ac ]
2018-08-02 08:01:00 +05:30
Maneesh Gupta
f9dbc19d51
Merge pull request #593 from mangupta/patch2-removerdynamic
...
[FindHIP] Remove rdynamic from CMAKE_SHARED_LIBRARY_LINK_HIP_FLAGS
[ROCm/clr commit: 1692af19cc ]
2018-08-02 07:58:34 +05:30
Maneesh Gupta
c440c4d3e8
Merge pull request #514 from luckynikki/GETandALGN
...
[GETandALGN]: Get channel and alignment details
[ROCm/clr commit: 2960739c43 ]
2018-08-02 07:57:50 +05:30
Yaxun Sam Liu
b8bbc4f1fa
Let hipcc handle static library for hip-clang
...
[ROCm/clr commit: 2ba45a23b8 ]
2018-08-01 22:03:01 -04:00
Aaron Enye Shi
da60937c5d
Enable HIP_COMPILER to choose HIP-Clang lib links
...
[ROCm/clr commit: 7560956233 ]
2018-08-01 20:37:46 +00:00
Yaxun Sam Liu
b587661200
Add hc_get_workitem_absolute_id for hip-clang HCC compatibility mode
...
[ROCm/clr commit: 9c28758fa0 ]
2018-08-01 15:14:38 -04:00
Yaxun Sam Liu
2d74df6f34
Add HCC compatibility mode
...
[ROCm/clr commit: b91691966f ]
2018-08-01 15:14:38 -04:00
foreman
7664c89d3e
P4 to Git Change 1588185 by vsytchen@vsytchen-win10 on 2018/08/01 11:46:00
...
SWDEV-145570 - [HIP] Correctly handle calculating the offset when retrieving the amd::Memory object from a prepinned pointer
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15539/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#38 edit
[ROCm/clr commit: 85777ea939 ]
2018-08-01 12:08:35 -04:00
Evgeny Mankov
9ffec20ff2
[HIPIFY][docs] Formatting
...
[ROCm/clr commit: 55ee734b22 ]
2018-08-01 17:29:00 +03:00
lthakur
313cdfd494
Added offset value verification.
...
Added offset value verification.
[ROCm/clr commit: b7a4b2c300 ]
2018-08-01 10:41:30 +05:30
Aaron Enye Shi
83d293a2a4
Enable hipHccModuleLaunchKernel on HIP-Clang
...
[ROCm/clr commit: 0ad36dfa58 ]
2018-07-31 20:38:20 +00:00
Evgeny Mankov
66e24cb0d3
[HIPIFY][FFT] Add cuFFT support
...
+ Add API_FFT support (data types and functions)
+ Add CUFFT_API_supported_by_HIP.md
+ Add simple_cufft.cu test
+ Update README.md
[ROCm/clr commit: c57bfd50e3 ]
2018-07-31 22:25:48 +03:00
foreman
50b6d51a72
P4 to Git Change 1587799 by vsytchen@vsytchen-win10 on 2018/07/31 14:47:31
...
SWDEV-145570 - [HIP] refactor hipMemcpy* functions to correctly handle copies using prepinned memory
The current implementation of hipMemcpy functions picks the copy type based on a flag that the user passes. However, one can use the hipMemcpyHostToDevice/hipMemcpyDeviceToHost flag in a combination with prepinned memory. By using the WriteMemoryCommand/ReadMemoyCommand in this case, we will pin the same host memory twice. This is fine on PAL/Linux, since pinning the same VA range is a noop, but this will start failing once we switch to using device memory with HIP/VDI/HSA.
The solution is to ignore the hipMemcpyKind flag and let the runtime decide what kind of copy is best to do. Except for the case when hipMemcpyHostToHost is passed, since both host pointers may be prepinned.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15482/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#37 edit
[ROCm/clr commit: b02040e934 ]
2018-07-31 15:07:56 -04:00
Rahul Garg
17e35e382c
Added support for pinned 2D SDMA copy
...
[ROCm/clr commit: 5eb11b58f3 ]
2018-07-31 14:05:35 +05:30
Aaron Enye Shi
9512246b5c
Protect macro TYPEDEF_VECTOR_VALUE_TYPE and prefix __hip_ for vector_value_types
...
[ROCm/clr commit: e42af991d1 ]
2018-07-30 20:41:24 +00:00
Aaron Enye Shi
ad6066eebd
Ensure correct vector value type used in texture
...
Implement the vector value types in terms of SCALAR_TYPE##SIZE_vector_value_type for float, int, uint and sizes 2, 3, 4, 8, and 16.
[ROCm/clr commit: ff1e49d191 ]
2018-07-30 19:43:12 +00:00
Sarunya Pumma
57c15b815d
Remove device mapping from shareWithAll memory
...
When shareWithAll memory (e.g., host memory) is allocated, set appId
in hc::AmPointerInfo to -1 to indicate that this memory is not mapped
to any device. Peer checking in ihipStream_t::canSeeMemory is not
necessary if memory is shared with all devices. Thus, it is skipped.
Note that earlier host memory is always mapped to device 0 and HIP
always performs peer checking for all kinds of hipMemcpy. Since the
peer checking process requires context locking, hipMemcpy from/to host
memory always grabs device 0's context lock. Therefore, if there is
another thread holding the context lock of device 0 (e.g.,
hipDeviceSynchronize on device 0), hipMemcpy will have to wait for the
lock until it can actually perform memcpy. This can significantly
deteriorate execution performance.
Signed-off-by: Sarunya Pumma <sarunya.pumma@amd.com >
[ROCm/clr commit: 84aadb9274 ]
2018-07-28 23:15:16 -07:00
Evgeny Mankov
351f385ea9
[HIPIFY][BLAS] cuBLAS support revise
...
+ doc for CUBLAS API supported by HIP
+ 3 tests: 0 & 1 based indexing, sgemm matmul
[ROCm/clr commit: e00cfefd4f ]
2018-07-28 21:00:44 +03:00
Yaxun Sam Liu
d539617d9b
Do not use std::complex in test hipDeviceMalloc
...
[ROCm/clr commit: fc1ed91ddb ]
2018-07-27 17:07:00 -04:00
Yaxun Sam Liu
ea77788a5f
Fix thread index calculation in __hip_malloc
...
[ROCm/clr commit: f08f26942c ]
2018-07-27 16:24:51 -04:00
Yaxun Sam Liu
9a4744566f
Support malloc/free for hip-clang
...
[ROCm/clr commit: d17dc21c9c ]
2018-07-27 16:24:51 -04:00
Brian Sumner
beb7f13068
Drop use of NVCC_COMPAT since it is always set
...
[ROCm/clr commit: 8d80abb30f ]
2018-07-27 09:29:29 -07:00
Maneesh Gupta
56ebef737b
Merge pull request #596 from mangupta/patch5-fixhiplaunchparm
...
[tests] Fixed hipLaunchParm test on nvcc path
[ROCm/clr commit: 17f612def1 ]
2018-07-26 06:17:50 +05:30