SWDEV-2 - Change OpenCL version number from 2604 to 2605.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2352 edit
[ROCm/clr commit: 936cfbb4b9]
SWDEV-143465 - AMDIL - Compiler Lib - Mark as unsupported all CI+ targets
1. Mark all CI+ targets as unsupported for AMDIL target mappings.
2. Let aclGetTargetInfo, aclGetTargetInfoFromChipID, aclGetDeviceInfo to report unsupported chips.
3. Fix aclReadFromMem in order to early determination of the target of binary in memory and reporting ACL_INVALID_TARGET if target is invalid, or ACL_UNSUPPORTED if chip is unsupported.
4. Add utility inline functions IsValidTarget, IsChipSupported, make getTargetMapping inline too, as it is used in the first two.
5. Fix affected tests.
[Testing] http://ocltc.amd.com:8111/viewModification.html?modId=98724&personal=true&init=1&tab=vcsModificationBuilds (clean)
[Reviewed] by Stas (http://ocltc.amd.com/reviews/r/14277)
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/api/v0_8/acl.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/libUtils.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/libUtils.h#4 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings.h#22 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_amdil.h#23 edit
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/utils/v0_8/target_mappings_amdil64.h#22 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_amdil.h#49 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/target_mappings_amdil64.h#45 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/binary/BIF2xTo3x.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/binary/BIFBase.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/binary/BIFSymbol.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/tests/ocltst/module/complib/aclAPI.cpp#22 edit
[ROCm/clr commit: 354d0df8bd]
SWDEV-2 - Change OpenCL version number from 2603 to 2604.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2351 edit
[ROCm/clr commit: c9b33609c5]
SWDEV-2 - Change OpenCL version number from 2602 to 2603.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2350 edit
[ROCm/clr commit: 78450aa252]
SWDEV-2 - Change OpenCL version number from 2601 to 2602.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2349 edit
[ROCm/clr commit: a4b65e6c2c]
SWDEV-145716 - dGMA via OpenCL not working properly on AMD EPYC Ethanol platform with two WX9100/W9100s
- Add a stall and cache flushes before a barrier write in GSL and PAL
- Place temporary workarounds for CP prefetch of WRITE_DATA and the lack of SDMA marker in PAL
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuvirtual.cpp#414 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#76 edit
[ROCm/clr commit: 30eacbe243]
SWDEV-2 - Change OpenCL version number from 2600 to 2601.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2348 edit
[ROCm/clr commit: 8e57fbbf10]
SWDEV-129762 - Remove following macros that are passed through the command line to the lightning compiler:
-D__AMD__=1
-D__devicename=1
-D__devicename__=1
-DFP_FAST_FMA=1
-DFP_FAST_FMAF=1
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#54 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#79 edit
[ROCm/clr commit: 87f42bdb73]
SWDEV-2 - Change OpenCL version number from 2599 to 2600.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2347 edit
[ROCm/clr commit: cb3754fe12]
SWDEV-2 - Change OpenCL version number from 2598 to 2599.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2346 edit
[ROCm/clr commit: 900ba35d50]
SWDEV-2 - Change OpenCL version number from 2597 to 2598.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2345 edit
[ROCm/clr commit: f4ac96ebce]
SWDEV-79445 - OCL generic changes and code clean-up
- Remove debugger checks from the dispatch path. There are no plans to enable debugger in the near future.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#74 edit
[ROCm/clr commit: b561617774]
SWDEV-2 - Change OpenCL version number from 2596 to 2597.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2344 edit
[ROCm/clr commit: 674711913a]
SWDEV-145750 - SSG Player drop in performance observed when using the OCL Api in 18.10
- Keep persistent memory mapped all time for Linux and Win10
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#73 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#48 edit
[ROCm/clr commit: 9018bc85cc]
SWDEV-102733 - Update some CMakeLists.txt files:
- when setting CMAKE_CXX_FLAGS, append to it rather than overwriting it.
- some linker flags, -Wl,--unresolved-symbols=report-all being one of them, requires -shared-libasan if using -fsanitize=address.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/CMakeLists.txt#13 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/loaders/elf/utils/libelf/CMakeLists.txt#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/CMakeLists.txt#9 edit
... //depot/stg/opencl/drivers/opencl/tools/clinfo/CMakeLists.txt#5 edit
[ROCm/clr commit: a31d6b2e6d]
SWDEV-2 - Change OpenCL version number from 2595 to 2596.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2343 edit
[ROCm/clr commit: 7b2c30bd6d]
SWDEV-2 - Change OpenCL version number from 2594 to 2595.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2342 edit
[ROCm/clr commit: a6603eb87c]
SWDEV-132899 - [OCL][GFX10] OCLCreateImage[3] fails for the image type 1Darray
Issue: FillImage blit kernel is not working properly on gfx10 if the image type is 1Darray (i.e., it only fills the first slice/layer and ignores the rest of the layers when number of layers >1)
Root cause: gfx10 HW expects the number of layers in Z component
Fix: To fix this issue we swap the Y and Z components if the image type is 1Darray for gfx10+ in image blit kernels.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/14281/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palblit.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#42 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.hpp#14 edit
[ROCm/clr commit: e0f4740fc4]
SWDEV-2 - Change OpenCL version number from 2593 to 2594.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2341 edit
[ROCm/clr commit: 66208072a3]
SWDEV-2 - Change OpenCL version number from 2592 to 2593.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2340 edit
[ROCm/clr commit: ccb104e56b]
SWDEV-143465 - Revert of #1516121
[Reason]
A plenty of tests are failed.
After the changing stack logic a lot of tests should be fixed, a lot - to be removed from testing.
#1516121 will be submitted again after renewal/removal of all the failed tests.
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/backends/common/v0_8/if_acl.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#98 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#583 edit
[ROCm/clr commit: f63eb0e998]
SWDEV-2 - Change OpenCL version number from 2591 to 2592.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2339 edit
[ROCm/clr commit: 890b5a78cc]
SWDEV-143465 - Stop building static C++ kernels on CI+
Changed stack logic:
1. Stop supporting AMDIL on CI+ devices: "AMDIL doesn't support device ..." will be reported.
2. Stop handling OpenCL extension options in RT: if "-x spir" or "-x clc++" option is specified, it wouldn't force legacy AMDIL compiler anymore.
3. Start reporting error on "-legacy" option in HSAIL compiler. If we reach HSAIL compiler, then it means that there are conflicting options. Report them all, possible options are: -frontend=edg, -cl-std=CL2.0 (>= 2.0), -binary_is_spirv.
Already submitted changes in stack logic:
1. Start reporting error for SI devices on HSAIL path.
2. Start handling OpenCL extension options on HSAIL path: report error on "-x spir" or "-x clc++" options.
[Testing]
rga offline for all the targets supported by HSAIL and AMDIL (from Family_SI up to Family_VI):
tahiti, pitcairn, capeverde, spectre, spooky, kalindi, hawaii, oland, bonaire, hainan, carrizo, iceland, tonga, fiji, stoney, baffin, ellesmere.
[Reviewed] by German and Stas (http://ocltc.amd.com/reviews/r/14270)
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/legacy-lib/backends/common/v0_8/if_acl.cpp#9 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#97 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpudevice.cpp#582 edit
[ROCm/clr commit: 9a85405b0b]
SWDEV-2 - Change OpenCL version number from 2590 to 2591.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2338 edit
[ROCm/clr commit: 45f6857022]
SWDEV-143465 - Fix crashes while mixed work with hsail and amdil (legacy) paths
Redirect (where it is possible) ACL API calls from HSAIL lib to legacy AMDIL lib if target is AMDIL.
For those functions (aclCreateFromBinary, aclReadFromMem), where redirect is impossible, explicit loadLibrary for AMDIL lib and call of corresponding function from AMDIL lib is performed.
[Reviewed] by Stas (http://ocltc.amd.com/reviews/r/14238)
[Testing] rga offline for all the targets supported by HSAIL and AMDIL (from Family_SI up to Family_VI):
tahiti, pitcairn, capeverde, spectre, spooky, kalindi, hawaii, oland, bonaire, hainan, carrizo, iceland, tonga, fiji, stoney, baffin, ellesmere.
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/acl.cpp#45 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclValidation.cpp#8 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/api/v0_8/aclValidation.h#3 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.h#30 edit
[ROCm/clr commit: a9ac031e6e]
SWDEV-2 - Change OpenCL version number from 2589 to 2590.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2337 edit
[ROCm/clr commit: 8548f9262e]
SWDEV-2 - Change OpenCL version number from 2588 to 2589.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2336 edit
[ROCm/clr commit: 94025b9c3b]
SWDEV-2 - Change OpenCL version number from 2587 to 2588.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2335 edit
[ROCm/clr commit: 6aec0a3b37]
SWDEV-143465 - HSAIL - Add checks for OpenCL extension and device family
FAMILY_SI devices and OpenCL extensions clc++ and spir are not supported by HSAIL.
Affected only offline compilation via ACL API.
[Reviewed] by Stas, http://ocltc.amd.com/reviews/r/14240
[Testing] aoc2, rga
Affected files ...
... //depot/stg/opencl/drivers/opencl/compiler/lib/backends/common/v0_8/if_acl.cpp#96 edit
[ROCm/clr commit: d2d88e9da0]
SWDEV-2 - Change OpenCL version number from 2586 to 2587.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2334 edit
[ROCm/clr commit: 1c58eed229]
SWDEV-2 - Change OpenCL version number from 2585 to 2586.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2333 edit
[ROCm/clr commit: 42a53ca7c2]
SWDEV-2 - Change OpenCL version number from 2584 to 2585.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2332 edit
[ROCm/clr commit: e07fd7fc7a]
SWDEV-2 - Change OpenCL version number from 2583 to 2584.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2331 edit
[ROCm/clr commit: 8b14ef24c5]
SWDEV-2 - Change OpenCL version number from 2582 to 2583.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2330 edit
[ROCm/clr commit: 9bc6d88733]
SWDEV-144231 - [CQE OCL][DTB][Perf][DTB-BLOCKER] 10% Performance drop observed while running Subtests of IndigoBench due to faulty CL#1507569
-Wavelimiter has more negative impact than improvements in a few benchmarks.
- Reduce the number of adaptive samples during the search to 4 per each wave count.
- Add worstWave_ to skip sampling with low performance settings.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.hpp#7 edit
[ROCm/clr commit: 2e6d7d965a]
SWDEV-2 - Change OpenCL version number from 2581 to 2582.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2329 edit
[ROCm/clr commit: a7ca88a40e]
SWDEV-143822 - [CQE OCL][Vega10][OCLtst][DTB-Blocker][QR] 8 out of 50 failures are observed with OCLPerf 32bit test; due to Faulty CL# 1502648
- Limit the cache size to 1GB with 32 bit
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#41 edit
[ROCm/clr commit: a1433357fb]
SWDEV-2 - Change OpenCL version number from 2580 to 2581.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2328 edit
[ROCm/clr commit: c5b4ea25c5]
SWDEV-2 - Change OpenCL version number from 2579 to 2580.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2327 edit
[ROCm/clr commit: 0d9cdd5b8f]
SWDEV-142271 - Performance drop is observed in Ocean Surface Simulation of Compubenchcl in 17.50 when compared to 17.Q4.1
- Fix link error in Linux.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#72 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#40 edit
[ROCm/clr commit: 9ed39f6107]
SWDEV-143822 - [CQE OCL][Vega10][OCLtst][DTB-Blocker][QR] 8 out of 50 failures are observed with OCLPerf 32bit test; due to Faulty CL# 1502648
- Free resource cache if PAL failed memory allocation
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#47 edit
[ROCm/clr commit: 142e5908ee]
SWDEV-142271 - Performance drop is observed in Ocean Surface Simulation of Compubenchcl in 17.50 when compared to 17.Q4.1
- Fix compilation errors in Linux.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.cpp#6 edit
[ROCm/clr commit: d71a4dbb04]
SWDEV-2 - Change OpenCL version number from 2578 to 2579.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2326 edit
[ROCm/clr commit: a5c369a33a]
SWDEV-142271 - Performance drop is observed in Ocean Surface Simulation of Compubenchcl in 17.50 when compared to 17.Q4.1
- Fix compilation errors in Linux.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.hpp#6 edit
[ROCm/clr commit: 0558a4abb6]
SWDEV-142271 - Performance drop is observed in Ocean Surface Simulation of Compubenchcl in 17.50 when compared to 17.Q4.1
- Rewrite the adaptive mode for waveliimiter. Make sure the performance feedback corresponds to the right wave count. Add the new sampling logic to find the best number, based on average performance.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#295 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/gpu/gpuwavelimiter.hpp#10 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palkernel.hpp#15 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#71 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#39 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.cpp#4 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palwavelimiter.hpp#5 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#80 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.hpp#88 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#282 edit
[ROCm/clr commit: 1e90e581d6]
SWDEV-2 - Change OpenCL version number from 2577 to 2578.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2325 edit
[ROCm/clr commit: 111c3fc45c]
foreman