f60367f1c3
Improved version reporting in NCCL_DEBUG=VERSION ( #1232 )
...
* Improved version reporting in NCCL_DEBUG=VERSION.
Signed-off-by: rahulvaidya20 <ravaidya@amd.com >
* Version reporting changes
Signed-off-by: rahulvaidya20 <ravaidya@amd.com >
* Versioning changes: Initialized char arrays to null and fixed typo.
---------
Signed-off-by: rahulvaidya20 <ravaidya@amd.com >
[ROCm/rccl commit: c755b9cf93
2024-07-12 08:14:29 -05:00
942555fd21
gfx12 initial enablement ( #1219 )
...
[ROCm/rccl commit: 63e4d76e23
2024-07-10 13:32:09 -06:00
37bf54b8f8
Enable multi-threading for MSCCL ( #1203 )
...
MSCCL can now run in a multi-threaded configuration. To test in the unit tests, added the ENABLE_OPENMP compile definition flag and the --openmp-test-enable flag to the unit test build script. To activate, set the environment variables UT_MULTITHREADED=1 and UT_PROCESS_MASK=1. Set Jenkins to use this mode.
[ROCm/rccl commit: 0c36d571ea
2024-07-04 09:34:38 -06:00
b5bc883f61
Checking kernel header files only when missing sysfs entry ( #1239 )
...
[ROCm/rccl commit: 45f3fbc52f
2024-07-03 15:53:15 -07:00
8a7dd0e590
[GRAPH] Use channel shuffling only for IB systems ( #1228 )
...
* [GRAPH] Use channel shuffling only for IB systems
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
* [GRAPH] Define channels=48 for gfx94 RoCE systems
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
* [GRAPH] Increase channels for RoCE gfx94 systems
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
---------
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
[ROCm/rccl commit: 5be3b713ef
2024-07-02 12:20:40 -05:00
b3e9d2d61b
NPKit: separate time stamps for GPU access from different blocks ( #1229 )
...
To avoid races in memory access in GPU
[ROCm/rccl commit: 9d8f68b4ee
2024-06-28 08:00:22 -07:00
c24b1ff14f
graph: fix minNchannels for multi-node overwrite ( #1230 )
...
[ROCm/rccl commit: b09ea29d66
2024-06-26 16:56:10 -05:00
bb6fab3d8e
Revert "Changing channel stride for MI300X multinode ( #1196 )" ( #1224 )
...
This reverts channel stride change in commit
a009e43f3cad31d93f3d
2024-06-25 14:03:30 -07:00
de7ea612d7
Unit Tests for testing channels ( #1222 )
...
[ROCm/rccl commit: e170f41ddd
2024-06-25 10:10:10 -05:00
3c7bbd3243
Merge pull request #1223 from nusislam/minNchannels-multinode
...
graph: fix minNchannels for multi-node
[ROCm/rccl commit: 9f2514e5c8
2024-06-25 10:03:35 -05:00
2e6c26a36c
Fix DMABUF support ( #1218 )
...
* Fix DMABUF support
* Reduce log output by moving dmabuf allocation details to TRACE
* Enable peer memory GDR support if ib_umem_get_peer is in kernel
[ROCm/rccl commit: 5d7078e383
2024-06-25 08:00:15 -07:00
bf164da244
graph: fix minNchannels for multi-node
...
Multi-node rccl was not correctly setting the minNchannels value. This
PR fixes the bug.
[ROCm/rccl commit: 05df0f8cea
2024-06-24 16:42:44 -05:00
f7fb3392fb
fix initOnceFunc setting incorrect result code ( #1205 )
...
Addresses DMA-BUF support check unexpectedly failing
[ROCm/rccl commit: 435756af02
2024-06-07 16:47:19 -07:00
7c029672a8
Merge pull request #1200 from nusislam/multi-node-256-fix
...
graph: fix multi-node channel count
[ROCm/rccl commit: 9660e2e2dc
2024-06-07 14:34:20 -05:00
9b88e59ea4
Fix min_nchannels bug for gfx94* nranks=4 ( #1202 )
...
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
[ROCm/rccl commit: d9661c17e6
2024-06-07 14:31:28 -05:00
efe851cfff
Disabling NUMA maching for model 79 for some VM configs ( #1204 )
...
[ROCm/rccl commit: 9b94a1052f
2024-06-06 17:15:04 -06:00
3cbf67715f
graph: restrict maxChannels to 64 for multi-node and RCCL_ENABLE_INTRANET=1
...
[ROCm/rccl commit: 526cce9bf4
2024-06-06 10:58:41 -05:00
bf35178250
graph: fix multi-node minChannel count
...
[ROCm/rccl commit: 6ab20a7c6b
2024-06-06 10:56:39 -05:00
62cbb3bcdd
set MIN_NCHANNEL limit to 64 for multi-node
...
[ROCm/rccl commit: 9746d8ca3f
2024-06-03 13:05:05 -05:00
b34fd115a1
doubling debug buffer size with increased channels
...
[ROCm/rccl commit: 0634c5c8e1
2024-06-03 13:05:05 -05:00
48821ad0d7
set MAXCHANNELS to 128
...
[ROCm/rccl commit: ef442f8f92
2024-06-03 13:05:05 -05:00
2447161fb4
graph: restrict MAXCHANNELS for certain platforms
...
[ROCm/rccl commit: 9f654f6cf5
2024-06-03 13:05:01 -05:00
ed2f96bc6a
device: update the logic for channelId assignment
...
[ROCm/rccl commit: 48859a97b1
2024-06-03 13:03:18 -05:00
b0b2aa1166
add 256 channels support
...
[ROCm/rccl commit: 506f16c506
2024-06-03 13:03:18 -05:00
a009e43f3c
Changing channel stride for MI300X multinode ( #1196 )
...
* Shuffling MI300X multi-node channels
* Updating tree channel logic
[ROCm/rccl commit: 0948eecbba
2024-06-03 10:00:55 -06:00
4f56aa5f8c
Optimize NCHANNELS and MSCCL config for gfx942 80CUs ( #1195 )
...
* Optimize NCHANNELS and MSCCL config for gfx942 80CUs
Set appropriately for different NCCL_MIN_NCHANNELS and MSCCL config,
potentially improving communication perf on the MI300x 80CUs
* Delete tools/msccl-algorithms/allreduce_1step_mccl_8_2_16777216_LL.xml
* Change the factor of gfx94 and update msccl config
[ROCm/rccl commit: cab25f919e
2024-06-01 07:07:46 -07:00
8518ef4afb
[MSCCL]: Move scratch buffer debug msgs to TRACE ( #1189 )
...
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
[ROCm/rccl commit: 1249a6c3fd
2024-05-31 17:54:23 -05:00
b35e2b8c4b
Addressing possible out-of-bounds mem access during channel duplication ( #1193 )
...
[ROCm/rccl commit: 354e0b29a6
2024-05-30 14:02:14 -06:00
a724f1ebb7
Add ring simple chunk size tuning ( #1180 )
...
* Add ring simple chunk size tuning
* modifying the tuning table to improve the performance of broadcast for 8MB to 32MB for single-node MI300X after ring simple chunk size tuning
* modifying the tuning table to improve the performance of reduce for 1MB to 4MB for single-node MI300X after ring simple chunk size tuning
---------
Co-authored-by: PedramAlizadeh <pmohamma@amd.com >
[ROCm/rccl commit: 73221b4230
2024-05-29 07:59:47 -07:00
ae6c372406
Make WSL detection thread safe ( #1178 )
...
* Make WSL detection thread safe
* Change static to beginning
* Switch to use atomics
[ROCm/rccl commit: 8f099b1adb
2024-05-28 17:23:50 -07:00
7f4bec7682
Merge pull request #1175 from edgargabriel/topic/alt_rsmi
...
add alternative to rocm_smi_lib
[ROCm/rccl commit: a78c4f5e88
2024-05-28 09:36:55 -05:00
bc29c89d9d
Report error when collective is not enabled in build ( #1177 )
...
* Report error when collective is not enabled in build
* Fix typo
[ROCm/rccl commit: eeea3b693b
2024-05-16 10:11:12 -07:00
c31ac0d17b
add alternative to rocm_smi_lib
...
[ROCm/rccl commit: 9ad913bfa8
2024-05-14 13:51:41 -07:00
984f87a5d5
Support WSL2 ( #1173 )
...
[ROCm/rccl commit: ecafc1969c
2024-05-10 07:31:12 -07:00
42d9f2458a
Changing the failure print to reflect a bad installation of MSCCL ( #1160 )
...
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
[ROCm/rccl commit: 87d01e6bf5
2024-05-08 16:56:26 -05:00
dd5d66d01a
Use rocm-smi thread only mutex when available ( #1169 )
...
[ROCm/rccl commit: a64aab5f63
2024-05-08 14:32:24 -07:00
43d875b422
modifying the tuning table to improve the performance of broadcast for 1MB to 64MB for single-node MI300X ( #1172 )
...
[ROCm/rccl commit: 73acf3eeec
2024-05-08 15:49:33 -04:00
00c0f3d67f
Adding ASAN changes to address memory leak issue" ( #1170 )
...
Co-authored-by: akolliasAMD <akollias@amd.com >
[ROCm/rccl commit: 408278209d
2024-05-08 09:16:00 -05:00
63d8de3bd3
Add compiler warning for uninitialized variable and fix ( #1163 )
...
* Add compiler warning for uninitialized variable and fix
* Add -Wsometimes-uninitialized
* Convert warning to error
[ROCm/rccl commit: b18784d8b8
2024-05-08 07:00:25 -07:00
eab9978e48
Use normal permute path when one NIC per GPU ( #1171 )
...
[ROCm/rccl commit: f679db6ff6
2024-05-08 06:59:57 -07:00
0ff5fc0bad
npkit: add broadcast trace ( #1166 )
...
[ROCm/rccl commit: a0cef69110
2024-05-07 14:00:16 -07:00
dd8e937948
fix typo for DMABUF_ENABLE
...
[ROCm/rccl commit: 140b7dd40f
2024-05-06 13:27:50 -07:00
c782aba364
Bypass NVIDIA Ampere related tuning ( #1165 )
...
[ROCm/rccl commit: b513c3970a
2024-05-03 17:57:16 -07:00
7c811a7582
Fix ignore NUMA not being observed for NICs during model matching ( #1164 )
...
[ROCm/rccl commit: bb58b1c258
2024-05-03 16:42:07 -07:00
9638535690
Fix build error when roctracer-dev package is not installed ( #1161 )
...
[ROCm/rccl commit: 6f5a8ce1fb
2024-05-01 13:55:09 -07:00
3906e992f8
MSCCL: add support for out-of-place all reduce ( #1156 )
...
[ROCm/rccl commit: 4e1b8c1cbb
2024-04-28 19:49:09 -07:00
703014e960
Add back tree simple chunk size tuning ( #1157 )
...
[ROCm/rccl commit: cd6e840e0b
2024-04-28 19:48:53 -07:00
b99b89e7a2
[GRAPH] Reduce NCCL_TOPO_MAX_NODES to 64 ( #1153 )
...
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
[ROCm/rccl commit: b90436d292
2024-04-27 23:41:11 -05:00
afeaa17475
Merge pull request #1158 from AtlantaPepsi/NPKit_fix
...
Prevent segfault from npkit-enabled rccl build
[ROCm/rccl commit: cc39e91c6f
2024-04-26 12:44:04 -04:00
8cf28704ce
prevent segfault from npkit-enabled rccl build
...
Signed-off-by: AtlantaPepsi <timhu102@amd.com >
[ROCm/rccl commit: 67246649ac
2024-04-26 10:54:27 -05:00
Rahul Vaidya
akolliasAMD
corey-derochie-amd
Wenkai Du
Nilesh M Negi
Nusrat Islam
saurabhAMD
Paul Emberson
gilbertlee-amd
ClementLinCF
Edgar Gabriel
Edgar Gabriel
mberenjk
Pedram Alizadeh
paklui
Tim
AtlantaPepsi