Grafik Komit

1076 Melakukan

Penulis SHA1 Pesan Tanggal
Aryan Salmanpour df81136734 [HIP] add hip specific properties for cooperative kernel multi device
[ROCm/hip commit: 03797ae986]
2020-03-03 13:25:36 -05:00
Siu Chi Chan 7a908a9a70 improve code object loading error message (#1889)
[ROCm/hip commit: 57edf48191]
2020-02-28 16:47:40 +05:30
saleelk 3c66b171e1 Fix HIPRTC headers to export C style symbols (#1879)
[ROCm/hip commit: 3e1f41c165]
2020-02-28 16:47:29 +05:30
Rahul Garg c34c9a4b4d Remove deprecated HIP markers (#1876)
[ROCm/hip commit: 6c5fa32815]
2020-02-28 16:47:15 +05:30
Rahul Garg 5229ffff99 Add hipDrvOccupancyMaxActiveBlocksPerMultiprocessor[WithFlags] (#1854)
Equivalent to cuOccupancyMaxActiveBlocksPerMultiprocessor[WithFlags].

[ROCm/hip commit: edc97f3073]
2020-02-28 16:46:55 +05:30
Alex Voicu a5ad7bc67b Address post-staging issues in #1809 (#1894)
Fixes SWDEV-223910 and SWDEV-223663

[ROCm/hip commit: d830dad3be]
2020-02-27 16:21:12 +05:30
Alex Voicu 745a66c60e Tweak synchronous memcpy implementation (#1809)
The existing one can have issues on certain systems, therefore this limits use of direct memcpy via largeBAR to sizes where it is unequivocally better.

Also addresses SWDEV-220030 and SWDEV-222237.

[ROCm/hip commit: 9b4f39e1d8]
2020-02-18 20:50:27 +05:30
Rahul Garg f1746197c7 Fix hipMemcpy3D (#1798)
Fixes #1790 and #1791. hipMemcpy3D still requires further refactoring for different input and output combinations.

[ROCm/hip commit: 8c5e5e435b]
2020-02-17 19:35:35 +05:30
Maneesh Gupta e72b5a0187 Use deque instead of vector for code readers so that the iterators and references will be stable (#1851)
* Use deque instead of vector for code readers so that the iterators and references will be stable

* Fix compile error

* Assign the iterator

* Add multithreaded test

* Make threads a multiple of hardware concurrency

* Output on failure

* Add setDevice to try and initialize the context on cuda

* Create context for cuda

* Set context on each thread

* Reduce threads on cuda

* Skip test on cuda

* Try to initialize the primary context on cuda

* Push ctx to the stack as current

* Revert "Push ctx to the stack as current"

This reverts commit 0fb72d9e7f.

* Revert "Try to initialize the primary context on cuda"

This reverts commit 44e3908680.

* updated test for nvidia path

* Add c++11 option for nvcc

Co-authored-by: satyanveshd <53337087+satyanveshd@users.noreply.github.com>


[ROCm/hip commit: e7120dd876]
2020-02-15 09:51:24 +05:30
Jeff Daily a352a87a15 missing break statement in hipDeviceGetAttribute (#1865)
The break is missing for hipDeviceAttributeMaxTexture3DDepth.

[ROCm/hip commit: 03bb658721]
2020-02-13 14:22:56 +05:30
Sarbojit2019 624cba30a6 [hip] Fix for bug introduced in #1770 when blockSize is non-power of 2 (#1864)
Fixes SWDEV-222161

[ROCm/hip commit: 1109cbff83]
2020-02-13 14:22:46 +05:30
Sarbojit2019 603a254cc2 ihipEnablePeerAccess return error if peer is not accessible (#1858)
hipDeviceEnablePeerAccess returns success and adds peer into the list even if it is not accessible which creates problem in hipMalloc when it tries to share the ptr to peer device.
Proposed change is to check the access status before updating the peer list and update only when it can access the peer.

[ROCm/hip commit: fc5256fd28]
2020-02-13 14:22:11 +05:30
ansurya fb53186682 Reduce GPU copying based on arch it runs on (#1751)
Implements SWDEV-213230.

[ROCm/hip commit: 8c6934223b]
2020-02-13 14:21:51 +05:30
Aryan Salmanpour 964a272004 resolve merge conflict
[ROCm/hip commit: 874b201ee2]
2020-02-10 10:30:55 -05:00
Maneesh Gupta 7753b3e827 Revert "Match Occupancy APIs syntax with CUDA (#1625)" (#1857)
Reverting this for now till we figure out how to avoid the build
breakage.

This reverts commit e38db9fb6f.

[ROCm/hip commit: f8e1c01900]
2020-02-10 10:45:28 +05:30
Paul 70fa1572a2 Assign the iterator
[ROCm/hip commit: 85560d38b1]
2020-02-06 12:15:29 -06:00
Paul 7ee1ccfe24 Fix compile error
[ROCm/hip commit: f34f96350c]
2020-02-06 12:04:50 -06:00
Paul 41193acfdf Use deque instead of vector for code readers so that the iterators and references will be stable
[ROCm/hip commit: 08123cff0d]
2020-02-06 11:56:17 -06:00
vsytch e5243c1834 Device texture functions should not normalize the sampled pixel (#1826)
* Device texture functions should not normalize the sampled pixel. This is already done by HW.
* Add support to use h/w capability for normalized float data convertion for driver API's

Co-authored-by: ansurya <50609411+ansurya@users.noreply.github.com>


[ROCm/hip commit: ef514eef71]
2020-02-05 20:56:17 +05:30
saleelk 9d723d9c21 Implement __hipPushCallConfiguration/__hipPopCallConfiguration for hip_clang (#1845)
This is needed so that the right symbols are present if we want to use hip-clang with hip/hcc runtime

[ROCm/hip commit: 499938d974]
2020-02-04 19:37:57 +05:30
Siu Chi Chan ec45ec16e3 Fix C-style hipLaunchKernel (#1835)
* Fix bug in LaunchKernel test
Instead of passing the address of the gpu buffer, pass the address
of the pointer that holds the address of the gpu buffer

* Fix hipLaunchKernel's kernarg buffer construction.
The hipLaunchKernel implementation should rely on ihipModuleLaunchKernel
to construct the kernarg buffer correctly based on kernel metadata.

* Fix a bug in get_functions where the Kernel_descriptor wasn't constructed with the correct kernarg layout information.

* Fix a bug in kernarg layout parsing dealing with kernel without any arg

* teach ihipModuleLaunchKernel to handle kernel without any arg

* Add a more interesting test

[ROCm/hip commit: bff8e15e13]
2020-02-04 19:37:16 +05:30
Sarbojit2019 91d9cfd64d Added overflow check in kernel launch (#1770)
[ROCm/hip commit: 13316f724f]
2020-02-04 09:02:16 +05:30
Aryan Salmanpour 78a36b4fb8 [HIP][HIPIFY] Add some missing flags for cooperative launch and occupancy APIs
[ROCm/hip commit: 6e867eacb6]
2020-01-30 15:05:53 -05:00
Evgeny Mankov 49771fe59d Merge pull request #1700 from scchan/object_load_error_check
add error checking for code object loading

[ROCm/hip commit: 2735b9923f]
2020-01-30 21:31:03 +03:00
satyanveshd e38db9fb6f Match Occupancy APIs syntax with CUDA (#1625)
* Match Occupancy APIs syntax with CUDA and fix tests using these APIs


[ROCm/hip commit: fa98798b63]
2020-01-29 13:05:53 -08:00
vsytch 1af35a6044 Add missing texturePitchAlignment member to the hipDeviceProp_t struct. (#1802)
* Add missing texturePitchAlignment member to the hipDeviceProp_t struct.

* Add missing hipDeviceAttributeTexturePitchAlignment enumerator to the hipDeviceAttribute_t enum.

* Initialize texturePitchAlignment to 256. This works for gfx9+, but is technically overaligned in most cases for pre-gfx9.

* Add the texturePitchAlignment property to the NVCC path.


[ROCm/hip commit: f72a669487]
2020-01-27 16:37:00 -08:00
Siu Chi Chan af3e8f633a Fix associate code object symbols with host allocation bug (#1799)
The current implementation skips this procedure for a given device
object when a global symbol is found in the cache.  This is incorrect:

 - There could be other undefined globals that have not been previously
encountered further down the list
 - If a symbol is found in the cache, it doesn't need to be pinned again
but it still need to be defined for the current executable

Added special case for the printf buffer symbol (already pinned by HCC)

The bug was exposed by running printf on different GPUs.

[ROCm/hip commit: 6613a37b3b]
2020-01-24 16:22:49 +05:30
ansurya ac41b1d0e0 Fix texture tests, always pass row pitch to HSA API for linear layout images (#1785)
=> New ROCr calculates pitch as per HSA specification and addrlib is used to check whether HW can support that configuration. Hence few texture tests are failing with HSA_EXT_STATUS_ERROR_IMAGE_PITCH_UNSUPPORTED.

=> Determine pitch for linear images and always pass rowpitch to HSA API's.

[ROCm/hip commit: df20c17f12]
2020-01-16 08:54:30 +05:30
Jatin Chaudhary de58e1b43e Remove filesystem dependency in hipRTC (#1749)
Removing dependency on filesystem, so libstdc++fs is no longer required to link

[ROCm/hip commit: aadb62f2c9]
2020-01-10 13:47:54 +05:30
Maneesh Gupta 6ebf5ca991 Revert PRs that break ROCm builds (#1781)
Fixes SWDEV-218626 and SWDEV-218629

Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692)"
   This reverts commit b7803eb0c6.
- Revert "Fix rocFFT build failure (#1777)"
   This reverts commit 9c8c3df294.

[ROCm/hip commit: 00bd5d1cec]
2020-01-08 15:11:58 +05:30
Siu Chi Chan fcf07e0b04 Detect when an explicit printf buffer flush is required (#1766)
* Detect when an explicit printf buffer flush is required
in a device/stream synchronization function.

* hip_module.cpp: add missing hc_am.hpp header


[ROCm/hip commit: f4555c835a]
2020-01-07 09:06:38 -08:00
satyanveshd 33b5e15e9a hipMemcpy[To/From]Symbol(Async) fixes (#1774)
[ROCm/hip commit: 6b5ea15dfe]
2020-01-07 08:11:53 +05:30
Rahul Garg b6a3c3a95e Fix nested designator warnings (#1768)
[ROCm/hip commit: 785a4440c8]
2020-01-06 12:33:34 +05:30
Evgeny Mankov 6ac4d18753 Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/hip commit: 0dadb23327]
2019-12-30 19:21:09 +03:00
Aryan Salmanpour ffea90f865 [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.

[ROCm/hip commit: 6968aeb841]
2019-12-30 12:42:17 +05:30
ansurya 8f0daf4019 Fix texture 3D & 2D layered with N components (#1746)
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components

Fixed memcpy when memory is allocated with driver API's.

Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.

[ROCm/hip commit: 391e99cd12]
2019-12-30 12:41:42 +05:30
Evgeny Mankov abef353b5b [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/hip commit: 4921678b6c]
2019-12-23 17:01:35 +03:00
saleelk bb7fa73dcc Fix the return type of demangle function so that its compatible across ABIs (#1744)
[ROCm/hip commit: 080b0b9a68]
2019-12-23 19:11:40 +05:30
Alex Voicu 1f5ecc0f6a Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/hip commit: 75a11330aa]
2019-12-23 19:11:24 +05:30
Alex Voicu b7803eb0c6 static inline in a header, just like excess sugar in a diet, causes bloat (#1692)
[ROCm/hip commit: be70b9f7e7]
2019-12-23 19:09:38 +05:30
Rahul Garg ebdd811632 Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.

[ROCm/hip commit: e53fc316f1]
2019-12-06 09:51:53 +05:30
Rahul Garg fa87abd58a Fix hipMemcpyWithStream (#1707)
* Fix hipMemcpyWithStream
* Add a dtest for the same.


[ROCm/hip commit: 892d2a562e]
2019-12-04 11:56:23 +05:30
Aryan Salmanpour abe7531676 [hip] refactoring hipExtLaunchMultiKernelMultiDevice API (#1698)
[Background] it was found that if lazy linking used for a library that calls hipExtLaunchMultiKernelMultiDevice API then this API can get the wrong program_state object for looking up device kernels leading to a "No device code available" error in this API.

To fix this issue, the API was refactored to be inline and get and pass the correct program_state to an internal hip API to request a multi-device kernel launch.

[ROCm/hip commit: 68cc787781]
2019-12-04 11:50:51 +05:30
Siu Chi Chan 7aee8f9803 add error checking for code object loading
[ROCm/hip commit: 6ecd303d94]
2019-11-28 14:00:48 -05:00
Jeff Daily f1544b621d fix hipMempcy precondition, test for zero size first (#1697)
[ROCm/hip commit: 299bbe2325]
2019-11-25 19:03:03 -08:00
satyanveshd 3848cd97ea fixed directed tests fail when hcc bumped to 3.0 (#1678)
Handled the HCC version check appropriately as few of the directed tests (SWDEV-212161) were failing when hcc was bumped to 3.0.

[ROCm/hip commit: 6b06911ef1]
2019-11-20 21:37:52 +05:30
Alex Voicu 1baa84eae4 General sync memcpy improvements. Add hipMemcpyWithStream (#1673)
* General sync memcpy improvements. Add `hipMemcpyWithStream`

* Update hip_memory.cpp


[ROCm/hip commit: 5a1f823739]
2019-11-20 21:36:37 +05:30
Rahul Garg 7e75cf12df Update error codes for hipGetDevice for doxygen and move up null check (#1668)
* [docs] Update error codes for hipGetDevice

* Move up out ptr check


[ROCm/hip commit: b3161e9fa0]
2019-11-20 21:35:27 +05:30
Sarbojit2019 6679cd3998 Revert [HIP] Fixed hipStreamAddCallback (#1674)
This reverts commit fa1e44aa0e.
Addresses SWDEV#212675.

[ROCm/hip commit: 153a959280]
2019-11-20 11:55:46 +05:30
Jeff Daily 492248ef12 hipStreamSynchronize can skip marker if stream is empty (#1667)
[ROCm/hip commit: 3a7eb694f5]
2019-11-19 09:42:43 -08:00